Stop writing old on testwiki
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Mar 21 2024, 6:29 PM

Description

To ensure that nothing breaks when we stop writing log events to cu_changes, the first wiki we will do this on is testwiki. This also is necessary because failed login attempts and password reset requests when logged out will cause an exception when writing old (because of trying to create an actor ID for an IP address).

Acceptance criteria

Set $wgCheckUserEventTablesMigrationStage = SCHEMA_COMPAT_NEW; on testwiki

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	[CheckUser] Stop writing old for event table migration on testwiki	operations/mediawiki-config	master	+1 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Feature	Dreamy_Jazz	T311375 Instead of not showing any results on too many results show the results to the truncation point with a pager that allows generation of more results
Resolved	Feature	Dreamy_Jazz	T313446 Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder
Open		None	T364943 InvestigateBlock does not allow many custom options
			Restricted Task
			Restricted Task
Resolved		Ladsgroup	T370903 Remove cuc_actiontext, cuc_only_for_read_old, and cuc_private from cu_changes on WMF wikis
Open		None	T340995 Display client hint data in Special:Investigate
Resolved	Security	Dreamy_Jazz	T268147 CVE-2024-40611: Special:CheckUser shows deleted edits to non-admins
Resolved	Security	Zabe	T311337 CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension
Resolved	Security	Dreamy_Jazz	T316414 CVE-2022-39193: Special:Investigate can expose supressed information in check results
Resolved	Security	Dreamy_Jazz	T318166 CVE-2022-39193: CheckUser API can expose the suppressed performer
Resolved	Security	Dreamy_Jazz	T316360 Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it
			Restricted Task
Resolved	BUG REPORT	Dreamy_Jazz	T326866 CVE-2024-40596: Special:Investigate can expose suppressed information for log events
Resolved	BUG REPORT	Dreamy_Jazz	T326867 CVE-2024-40598: CheckUser API can expose suppressed information for log events
Resolved	BUG REPORT	Dreamy_Jazz	T326865 CVE-2024-40597: Special:CheckUser can expose suppressed information for log events
Resolved		Dreamy_Jazz	T253796 Make CheckUser record the log_id of logged actions
Resolved		None	T139810 RFC: Overhaul the CheckUser extension
Resolved		Dreamy_Jazz	T132892 CheckUser UI revamp
Resolved		Dreamy_Jazz	T69811 CheckUsers "Get users" design needs improvements
Resolved	Feature	Dreamy_Jazz	T24120 Enhance Blocking and tagging from checkuser interface: add dropdowns
Duplicate		None	T145340 Split CheckUser mass-block interface to separate special page
Resolved	Feature	Dreamy_Jazz	T316441 Enforce minimum length of the tag on the client side for the checkuser block form
Resolved	Feature	Dreamy_Jazz	T321427 Allow HTMLForm text based elements to specify a minimum length
Resolved	Feature	Dreamy_Jazz	T321439 Allow TextInputWidget to specify the "minlength" attribute
Resolved	Feature	Dreamy_Jazz	T316444 The CheckUser block form should explain why users were not blocked or tagged
Resolved	Feature	Dreamy_Jazz	T314700 Restore the bottom paging links on 'Get users'
Resolved	BUG REPORT	Dreamy_Jazz	T314217 Checkuserblock form is broken when paging links are shown on 'Get users'
Declined	Feature	None	T313451 Separate out when the blocks are made for IPs and users in Special:CheckUser 'get users' mode
Resolved	Feature	Dreamy_Jazz	T18306 Allow user to specify block settings from CU form
Resolved		Glaisher	T41213 Block interface after "Get users" check should allow talk page/send email blocking
Resolved	Feature	Dreamy_Jazz	T329493 Replace Special:CheckUser's 'get users' block form with a usage of Special:InvestigateBlock
Resolved		Dreamy_Jazz	T339914 Remove CheckUserEnableSpecialInvestigate config
Resolved	Feature	Dreamy_Jazz	T318458 Add dropdown options for the reason in Special:InvestigateBlock (like Special:Block has)
Resolved		Dreamy_Jazz	T362569 Test SpecialInvestigateBlock
Resolved		Dreamy_Jazz	T366265 Limit the number of blocks that can be performed in a single use of Special:InvestigateBlock to wgCheckUserMaxBlocks
Declined		None	T27053 Replace user / talk pages feature of "Get users" creates a user/talk page if it doesnt exist
Resolved	Feature	Dreamy_Jazz	T318459 Make a clearer visual distinction between the UA and IP list in 'get users'
Resolved		Glaisher	T49505 CheckUser results (userlinks) cannot be customized
Resolved		Niharika	T24119 Enhance Blocking and tagging from checkuser interface: add new page
Resolved		None	T14808 Blocking and tagging from checkuser interface
Resolved	Feature	Dreamy_Jazz	T16699 More versatile searching in CheckUser log
Declined		None	T15789 Restore the global CheckUser log
Resolved	Feature	Dreamy_Jazz	T309924 Add check links for both the target and performer in Special:CheckUserLog
Resolved	Feature	Dreamy_Jazz	T309925 Implement User:Amalthea/culoghelper.js into the CheckUser extension
Duplicate		None	T140345 Userlinks in CheckUser should be customizable
Resolved		Dreamy_Jazz	T21964 Provide a link to the user on account creation
Duplicate		None	T144099 Make CheckUser unit-testable
Resolved		Dreamy_Jazz	T309815 Use OOUI in Special:CheckUser
Resolved		Dreamy_Jazz	T310019 The Special:CheckUser block form should use OOUI
Resolved		Dreamy_Jazz	T266586 Use OOUI in SpecialCheckUserLog
			Restricted Task
Open	Feature	None	T26231 Allow CheckUsers to filter checks for account creations only
Resolved		Dreamy_Jazz	T139809 Bad output of AbuseFilter blocks in CU get edits
Resolved	BUG REPORT	Dreamy_Jazz	T41013 Incomplete i18n for log entries in CheckUser
Resolved	BUG REPORT	Dreamy_Jazz	T268156 Partial blocks from namespaces are displayed odd
Open		None	T311354 Make CheckUser results easier to parse by userscripts
Open	Feature	None	T311380 Make certain types of edits in 'Get edits' highlightable for ease of parsing the results
Declined	Feature	None	T54849 Checkuser option "get users" should point out when user password is changed
Open	Feature	None	T315488 Show failed login attempts in the results list for the user
			Restricted Task
Resolved		Dreamy_Jazz	T145265 Store check user data action text in structured format
Resolved		kostajh	T257893 [EPIC] Support User-Agent Client Hints header in CheckUser
Resolved		kostajh	T341094 Create client hint mapping rows for CheckUser-worthy events
Resolved		None	T248926 Performance review of checkuser database queries [NOT READY]
Resolved		tstarling	T342613 CompareService::getTotalEditsFromIp queries exceeding TransactionProfiler limits
Declined		None	T366783 Remove remaining code related to event tables migration
Resolved		Tchanders	T326393 IP Address Reveal on Log page
Declined	BUG REPORT	None	T28843 CheckUser results do not appear cleanly for AbuseFilter modifications
Open		None	T366719 Update AccountInfo InfoLookup::getUserInfo to read data from cu_log_event and cu_private_event
Open		None	T366739 Update ArticleFeedbackv5 rebuildCheckUser.php maintenance script for CheckUser extension database changes
Resolved		Dreamy_Jazz	T371099 No longer use removed cuc_actiontext column in analytics/refinery
Resolved	Feature	Dreamy_Jazz	T324907 Create separate tables for log events in CheckUser
Resolved		Dreamy_Jazz	T366507 Remove 'CheckUserInsertForRecentChange' hook
Resolved		Dreamy_Jazz	T357620 Hard deprecate the CheckUserInsertForRecentChange hook
Resolved		Dreamy_Jazz	T366782 Remove now unused columns from cu_changes
Resolved		Dreamy_Jazz	T366546 Remove wgCheckUserEventTablesMigrationStage and related migration code
Resolved		Dreamy_Jazz	T346022 Remove modifications of wgCheckUserLogAdditionalRights in code outside CheckUser
Resolved		Dreamy_Jazz	T366781 Run maintenance script to delete entries only for use when reading old on WMF wikis
Resolved		Dreamy_Jazz	T369539 Remove migration code from Hooks.php
Resolved		Dreamy_Jazz	T341830 Create maintenance script to delete entries only for read old
Duplicate		Dreamy_Jazz	T368419 Run deleteReadOldRowsInCuChanges.php on WMF wikis
Resolved		Dreamy_Jazz	T360685 Stop writing old for event table migration on WMF wikis
Resolved		Dreamy_Jazz	T360686 Stop writing old on testwiki
Resolved		Dreamy_Jazz	T366505 Stop writing old for event table migration in extension.json
Resolved		Dreamy_Jazz	T329189 Add read new support to Special:Investigate for event table migration
Resolved		Dreamy_Jazz	T329200 Enable read new support in Special:Investigate's 'Timeline' tab
Resolved		Dreamy_Jazz	T329201 Enable read new support in Special:Investigate's 'IPs & User agents' tab
Resolved		Dreamy_Jazz	T347102 Alias column names in Special:Investigate to not include the "cuc_" prefix
Resolved		Dreamy_Jazz	T362152 Improve test coverage on Special:Investigate code
Resolved	Security	Dreamy_Jazz	T338419 CVE-2024-40609: Wikimedia\RequestTimeout\RequestTimeoutException on Special:Investigate timeline mode
Declined		Dreamy_Jazz	T363376 Move code that groups and sorts the rows from the CheckUser result tables to the CheckUserLookupUtils service to reduce duplication
Resolved		Dreamy_Jazz	T341827 Add read new support to the CheckUser API
Resolved		Dreamy_Jazz	T354643 Queries to cu_log_event on large wikis are exceeding TransactionProfiler limits on Special:CheckUser
Resolved		Dreamy_Jazz	T360622 Use the CheckUserLookupUtils service in Special:CheckUser pager classes
Resolved		Dreamy_Jazz	T360962 Create ApiQueryCheckUserResponseFactory service
Resolved		Dreamy_Jazz	T360963 Implement response classes for the CheckUser API
Resolved		Dreamy_Jazz	T360961 Create ApiQueryCheckUserAbstractResponse
Resolved		Dreamy_Jazz	T360072 Alias select fields in ApiQueryCheckUser
Resolved		Dreamy_Jazz	T360106 Improve test coverage on ApiQueryCheckUser
Resolved		Dreamy_Jazz	T360453 Create the CheckUserLookupUtils service
Resolved	BUG REPORT	Dreamy_Jazz	T361722 'ipusers' does not handle 'cupe_actor' as NULL
Resolved		Dreamy_Jazz	T341829 Enable read new for the event table migration
Resolved		Dreamy_Jazz	T330158 Enable write new for the event table migration
Resolved		Dreamy_Jazz	T328874 Create temporary column in cu_changes to assist in migration to the new tables
Resolved		• Marostegui	T329203 Add new column cuc_only_for_read_old to cu_changes for migration purposes to wmf wikis
Resolved		Dreamy_Jazz	T341586 Allow write old and new for event table migration
Resolved	PRODUCTION ERROR	Dreamy_Jazz	T342902 Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cuc_only_for_read_old' in 'field list'Function: MediaWiki\CheckUser\Hooks::onAuthManagerLoginAuthenticateAuditQuery: INSERT INTO `cu_changes` (cuc_page_id,cuc_namespac
Resolved		• Marostegui	T343174 Add missing column cuc_only_for_read_old to testcommonswiki
Resolved		Ladsgroup	T326105 Create cu_log_event and cu_private_event on WMF wikis
Resolved		Dreamy_Jazz	T328992 Add read new support to Special:CheckUser for event table migration
Resolved		Dreamy_Jazz	T328995 Enable read new support in Special:CheckUser's 'Get edits' mode
Resolved	BUG REPORT	Dreamy_Jazz	T347773 Log action text shown when reading new does not respect the deleted status of the log
Resolved		Dreamy_Jazz	T328997 Enable read new support in Special:CheckUser's 'Get users' mode
Resolved		Dreamy_Jazz	T328998 Enable read new support in Special:CheckUser's 'Get IP Addresses' mode
Resolved		Dreamy_Jazz	T328988 Create a SelectQueryBuilder that allows selecting from all three tables
Resolved		Dreamy_Jazz	T342629 Investigate CheckUser currently saving failed login attempted to usernames which fail RIGOR_VALID
Resolved		Dreamy_Jazz	T341688 Create LogFormatter for cu_private_event log events
Resolved	BUG REPORT	Dreamy_Jazz	T347400 Read new cannot parse the log_params of global block log entries
Resolved	BUG REPORT	Dreamy_Jazz	T347669 moveLogEntriesFromCuChanges import inconsistencies

Event Timeline

Dreamy_Jazz created this task.Mar 21 2024, 6:29 PM

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)).

Dreamy_Jazz updated the task description. (Show Details)

Change #1013386 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] [CheckUser] Stop writing old for event table migration on testwiki

https://gerrit.wikimedia.org/r/1013386

gerritbot added a project: Patch-For-Review.Mar 21 2024, 6:34 PM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 21 2024, 6:35 PM

Dreamy_Jazz moved this task from In Progress to Ready on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 21 2024, 10:58 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Team, Trust and Safety Product Sprint; removed Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)).Apr 1 2024, 4:16 PM

Change #1038396 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Add UserMerge support for cu_log_event and cu_private_event

https://gerrit.wikimedia.org/r/1038396

Change #1038397 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Update comments to reflect event table migration

https://gerrit.wikimedia.org/r/1038397

Change #1038398 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Set event tables migration to SCHEMA_COMPAT_NEW in extension.json

https://gerrit.wikimedia.org/r/1038398

Change #1013386 merged by jenkins-bot:

[operations/mediawiki-config@master] [CheckUser] Stop writing old for event table migration on testwiki

https://gerrit.wikimedia.org/r/1013386

Mentioned in SAL (#wikimedia-operations) [2024-06-05T12:53:57Z] <dreamyjazz@deploy1002> Started scap: Backport for [[gerrit:1013386|[CheckUser] Stop writing old for event table migration on testwiki (T360686)]]

Mentioned in SAL (#wikimedia-operations) [2024-06-05T13:02:33Z] <dreamyjazz@deploy1002> dreamyjazz: Backport for [[gerrit:1013386|[CheckUser] Stop writing old for event table migration on testwiki (T360686)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-06-05T13:13:10Z] <dreamyjazz@deploy1002> Finished scap: Backport for [[gerrit:1013386|[CheckUser] Stop writing old for event table migration on testwiki (T360686)]] (duration: 19m 13s)