Making an image Frameless with out any wrap option deletes the content of the caption
Open, LowPublic8 Story Points

Description

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Add caption to it
4.Make it frameless and uncheck the wrap option

Observed Result;
The image moves to the left and loses all its content in the caption

Environment:Test2 and production (en.wiki)


Version: unspecified
Severity: normal

Details

Reference
bz66808
bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz66808.
Ryasmeen created this task.Jun 18 2014, 7:51 PM

The bit of this where the transaction is not undoable feels like a DM bug. Ed, could you look it it?

Actually, this is the issue of retaining the caption data in inline images that I discussed with Ed and later with Roan yesterday. Roan mentioned the work on sub-documents as a potential fix for that, and perhaps a mid-way solution involving similar work to what the MWReferenceNode is doing.

We need to make sure the caption information is kept to inline images and then also sent back to Parsoid through the data-mw field.

Currently captions on inline images are only made available as wikitext by Parsoid. In order to preserve these when converting between the block & inline that would need to change.

cscott added a subscriber: cscott.

A patch for T50958 on the Parsoid side is imminent, so perhaps it's time to wake up the VE side of this bug.

Jdforrester-WMF renamed this task from VisualEditor: Making an image Frameless with out any wrap option deletes the content of the caption to Making an image Frameless with out any wrap option deletes the content of the caption.Aug 25 2015, 7:33 PM
Jdforrester-WMF lowered the priority of this task from Normal to Low.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.

Change 239300 had a related patch set uploaded (by Alex Monk):
[WIP] Preserve captions even in inline images

https://gerrit.wikimedia.org/r/239300

Change 239300 abandoned by Alex Monk:
[WIP] Preserve captions even in inline images

https://gerrit.wikimedia.org/r/239300

Krenair removed Krenair as the assignee of this task.Sep 19 2015, 12:20 AM

@Krenair what made you abandon this task?

I don't know enough about how the VE DM works to deal with it.