Page MenuHomePhabricator

tstarling (Tim Starling)
UserAdministrator

Projects (22)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 8:27 PM (505 w, 15 h)
Roles
Administrator
Availability
Available
LDAP User
Tim Starling
MediaWiki User
Tim Starling (WMF) [ Global Accounts ]

Recent Activity

Today

tstarling created T368006: htmlCacheUpdate missed for new template pages due to backlink partition cache.
Thu, Jun 20, 1:24 AM · MediaWiki-Page-derived-data

Tue, Jun 18

tstarling moved T362133: Clean up block_target migration code from Ready for dev to Feedback and review on the Community-Tech (June 17-28 2024 Bat-Eared Fox) board.
Tue, Jun 18, 12:30 AM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, Community-Tech (June 17-28 2024 Bat-Eared Fox), Multiblocks, MediaWiki-Blocks

Wed, Jun 12

tstarling added a comment to T363228: WMF staff should be able to update the status of a wish.

There's no permissions in the gadget implementation. You can't restrict who gets to change a status.

Wed, Jun 12, 12:20 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), Community Wishlist Survey (Wish page)
tstarling added a comment to T361067: Rewrite Wishlist Survey bot.

Random tech debt thing -- we have a few terms for whatever the subpage name for a wish/focus area is. Is slug a good name and if so maybe the db and backend things could be renamed? Or vice versa :)

Wed, Jun 12, 12:17 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), Patch-For-Review, Community Wishlist Survey

Tue, Jun 11

tstarling moved T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work) from In development to Feedback and review on the Community-Tech (June 3-14 2024 Arctic Fox) board.
Tue, Jun 11, 11:27 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Patch-For-Review, MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T77151: Full Zoom Feature in Media Viewer.

@JScherer-WMF asked on Slack for image size statistics.

Tue, Jun 11, 2:37 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 6), Multimedia, MediaViewer

Sat, Jun 8

tstarling added a comment to T366824: Add a changelog and apply a custom version number to our patched bundled Lua binaries.

I wish I understood how coroutines were disabled, but searching the Scribunto codebase found only a couple of references to the word coroutine in the tests. Fiddling ignorantly with those tests didn't seem to provide any meaningful change.

Sat, Jun 8, 7:10 AM · SecTeam-Processed, Scribunto, Security, Security-Team

Thu, Jun 6

tstarling added a comment to T138933: Explore moving the Panoviewer gadget/Toolforge tool into production.

@tstarling I don't understand the gerritbot comment above. Would you be able to give an update on where this task is at?

Thu, Jun 6, 1:58 AM · Patch-For-Review, Thumbor, MediaViewer, Tools, Platform Team Legacy (Watching / External), Services (watching), Multimedia

Tue, Jun 4

tstarling added a comment to T363630: Score audio cannot be played if the page has other embedded media.

TMH should set its own class attributes on the server side and avoid mangling unrelated content. Per my commit message comments on cf8a4f2133cb, TMH is too broken to use with Score. Requiring every other extension to set a fake TMH attribute to trick TMH into not breaking it doesn't seem like a good solution.

Tue, Jun 4, 12:24 AM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), VideoJS player, MediaWiki-extensions-Score

Mon, Jun 3

tstarling updated the task description for T366433: CentralAuth tests broken unless you run them inside Quibble.
Mon, Jun 3, 12:37 AM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
tstarling created T366433: CentralAuth tests broken unless you run them inside Quibble.
Mon, Jun 3, 12:33 AM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth

Sun, Jun 2

Don-vip awarded T357251: [build-service,apt-buildpack] Add local Ubuntu mirror or package cache a Hungry Hippo token.
Sun, Jun 2, 12:43 PM · Toolforge

Fri, May 31

tstarling updated subscribers of T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work).

I just discovered T224245, which is a different approach to the same problem, already implemented.

Fri, May 31, 4:47 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Patch-For-Review, MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T201340: Local notification settings stuck at latest global preference.

Do we want to do the row cleanup as part of this ticket? If not, let's get another ticket in.

Fri, May 31, 2:29 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Community-Tech-Sprint, MediaWiki-Core-Preferences, Community-Tech, MediaWiki-extensions-GlobalPreferences

Wed, May 29

tstarling moved T355034: Deploy new block_target schema from In Development 💻 to Ready 🎬 on the Community-Tech (CommTech-Kanban) board.
Wed, May 29, 10:20 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Multiblocks, MediaWiki-Blocks
tstarling moved T362133: Clean up block_target migration code from Review/Feedback 💬 to Ready 🎬 on the Community-Tech (CommTech-Kanban) board.
Wed, May 29, 10:19 AM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, Community-Tech (June 17-28 2024 Bat-Eared Fox), Multiblocks, MediaWiki-Blocks
tstarling added a comment to T362133: Clean up block_target migration code.

Some usages of $wgBlockTargetMigrationStage remain in WMF-maintained extensions.

Wed, May 29, 10:19 AM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, Community-Tech (June 17-28 2024 Bat-Eared Fox), Multiblocks, MediaWiki-Blocks
tstarling closed T51504: ipb_range_start and ipb_range_end should be blank for single-IP blocks as Resolved.
Wed, May 29, 10:18 AM · Patch-For-Review, MediaWiki-Blocks, Performance Issue
tstarling closed T51504: ipb_range_start and ipb_range_end should be blank for single-IP blocks, a subtask of T346293: ipblocks schema redesign for multiblocks, as Resolved.
Wed, May 29, 10:18 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling moved T346293: ipblocks schema redesign for multiblocks from In Development 💻 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.
Wed, May 29, 10:09 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling moved T361067: Rewrite Wishlist Survey bot from In Development 💻 to Ready 🎬 on the Community-Tech (CommTech-Kanban) board.
Wed, May 29, 10:09 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), Patch-For-Review, Community Wishlist Survey

Tue, May 28

tstarling added a comment to T209892: SecurePoll is not compatible with GPG 2.1+.

@tstarling @dom_walden Is it possible to test an election on the mw-debug deployment of MW-on-K8s using XWD, or are we missing some configuration to try this in production?

Tue, May 28, 3:21 AM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Community-Tech (CommTech-Kanban), MW-on-K8s, MediaWiki-extensions-SecurePoll

Fri, May 24

tstarling claimed T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work).
Fri, May 24, 6:29 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Patch-For-Review, MediaWiki-extensions-GlobalPreferences
tstarling moved T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work) from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.
Fri, May 24, 6:29 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Patch-For-Review, MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T352499: Use extension registration (extension.json/skin.json) for preloaded i18n messages.

FWIW We need some more background on why these messages were selected in the first case.

Fri, May 24, 2:50 AM · MediaWiki-Engineering, Patch-For-Review, Web-Team-Backlog (Needs Prioritization (Tech)), I18n, MediaWiki-Internationalization, Desktop Improvements (Vector 2022)
tstarling added a comment to T365075: Lua parameter keys which are integers should be stringified if they have a magnitude > 2^53 - 1, not 2^53.

It seems to me that it should be possible to represent all powers of two up to the limit of the exponent, since the mantissa is just 1 for those numbers. So 2^53+1 is the lowest positive integer which needs to be rounded in order to fit in a double.

Fri, May 24, 2:12 AM · Patch-For-Review, Scribunto

May 16 2024

tstarling added a comment to T361067: Rewrite Wishlist Survey bot.

I suggest renaming bot.js to update-indexes.js.

May 16 2024, 5:28 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), Patch-For-Review, Community Wishlist Survey

May 14 2024

Remagoxer awarded T214998: RFC: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Love token.
May 14 2024, 10:04 AM · Web-Team-Backlog, Traffic-Icebox, MobileFrontend (Tracking), TechCom-RFC, SRE
Dreamy_Jazz awarded T214998: RFC: Remove .m. subdomain, serve mobile and desktop variants through the same URL a Like token.
May 14 2024, 8:34 AM · Web-Team-Backlog, Traffic-Icebox, MobileFrontend (Tracking), TechCom-RFC, SRE
tstarling added a comment to T361067: Rewrite Wishlist Survey bot.

Proposed implementation plan:

  • Use sqlite3 for data persistence, using the filesystem to avoid the need for an SSH tunnel to a Cloud Services database (or local MySQL-like dependency)
May 14 2024, 5:51 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), Patch-For-Review, Community Wishlist Survey
tstarling closed T364610: CI Blocker: MergeUserTest::testBasicMerge: Error 1054: Unknown column 'bt_address' in 'field list' as Resolved.

This was fixed.

May 14 2024, 5:23 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), Patch-For-Review, MediaWiki-extensions-UserMerge, ci-test-error
tstarling closed T364610: CI Blocker: MergeUserTest::testBasicMerge: Error 1054: Unknown column 'bt_address' in 'field list', a subtask of T346293: ipblocks schema redesign for multiblocks, as Resolved.
May 14 2024, 5:21 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling updated subscribers of T364644: Set $wgEnableAsyncUploads = true on all wikis.

@aaron disabled it on 2013-03-14 and re-enabled it for Commons only on 2013-03-29. But there was no UI for it on wikis other than Commons, and that remains the case.

May 14 2024, 5:20 AM · Wikimedia-Site-requests
tstarling added a comment to T354949: Tool:Panoviewer - Grid Engine web service cannot be reached..

Hallo,

https://panoviewer.toolforge.org/ does not work. Error 403 "Forbidden". Can somebody fixed it maybe?

May 14 2024, 3:23 AM · Tools
tstarling closed T363752: CodeMirror shouldn't load in the 2017 editor on RTL pages as Resolved.

Confirmed fix on ar.wikipedia.org

May 14 2024, 12:38 AM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), VisualEditor, Community-Tech (CommTech-Kanban), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

May 10 2024

tstarling added a comment to T346293: ipblocks schema redesign for multiblocks.

Looking here: https://gerrit.wikimedia.org/g/mediawiki/core/+/bc11d8072a47fdc2f9d3a60f78c09716948b626e/includes/block/DatabaseBlockStore.php#336 tables does not list block_target, but it refers to bt_* fields from that table.

The query definition a few lines below: https://gerrit.wikimedia.org/g/mediawiki/core/+/bc11d8072a47fdc2f9d3a60f78c09716948b626e/includes/block/DatabaseBlockStore.php#367 does list block_target when using fields from that table.

I'm not sure if that's a mistake, but it looks suspicious.

May 10 2024, 11:48 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling added a comment to T364221: PanoProjector -- equirectangular to rectilinear reprojection in C++.

Temporary repo with unreviewed code: https://github.com/tstarling/pano-projector

May 10 2024, 12:37 AM · Community-Tech

May 9 2024

DAlangi_WMF awarded T240307: Hook container with strong types and DI a Love token.
May 9 2024, 9:37 PM · Platform Team Workboards (Epics), Patch-For-Review, MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), MW-1.33-notes, MW-1.31-release-notes, MW-1.34-notes, Core Platform Team Initiatives (New Hook System), MediaWiki-Core-Hooks, Dependency injection, TechCom-RFC (TechCom-RFC-Closed), User-Daniel, Platform Engineering

May 7 2024

real68er awarded T33366: File description page thumbnail click versus EXIF rotation, mustRender() a Love token.
May 7 2024, 9:37 AM · Commons, Multimedia, MediaWiki-File-management
tstarling added a comment to T363891: Panoramic images tiling component.

Panellum falls back to a low resolution full size image if the results are not yet ready. The toolforge tool also renders on the fly i believe and it will 'fill in' results as they arrive based on a JS poll.

There's no Pannellum support for that, it's only in the panoviewer tool.

May 7 2024, 12:35 AM · Thumbor, MediaViewer

May 4 2024

tstarling added a parent task for T364221: PanoProjector -- equirectangular to rectilinear reprojection in C++: T363891: Panoramic images tiling component.
May 4 2024, 12:14 PM · Community-Tech
tstarling added a subtask for T363891: Panoramic images tiling component: T364221: PanoProjector -- equirectangular to rectilinear reprojection in C++.
May 4 2024, 12:14 PM · Thumbor, MediaViewer
tstarling created T364221: PanoProjector -- equirectangular to rectilinear reprojection in C++.
May 4 2024, 12:13 PM · Community-Tech

May 3 2024

tstarling added a comment to T363891: Panoramic images tiling component.

I did a rough prototype of this in C++, and I got it down to 5.9 seconds for single-threaded extraction of a single cube face. So I think this is the way to go. I'll write a custom cube face extractor, and Thumbor will run it on demand, no need for a job.

May 3 2024, 10:39 AM · Thumbor, MediaViewer

May 2 2024

tstarling triaged T348136: Error: Class 'MediaWiki\HookContainer\HookRunner' not found as Low priority.

The frequency of these errors before March 6 g1008752 reflected the frequency of Redis connection timeout errors. About 1 in every 160 errors raised by excimerFlushToArclamp() would fail with "HookRunner not found". So following Timo's patch, we can expect this to be very rare indeed. In logstash since that date, there has only been one such error. So I think it is a low priority.

May 2 2024, 12:13 PM · MW-Interfaces-Team, MediaWiki-Engineering, API Platform, MediaWiki-Core-Hooks, Wikimedia-production-error
tstarling added a comment to T363891: Panoramic images tiling component.

DENIVIP's panorama converter shows how simple it can be. It does all 6 cube faces in 67 seconds, single threaded. They messed up the interpolation somehow, the CImg library they used is weird and scary, and the dependencies are wrong (it doesn't really need xorg-dev), but it's certainly inspiring. It's basically doing the thing we need in 229 lines of code.

May 2 2024, 7:20 AM · Thumbor, MediaViewer
tstarling added a comment to T363891: Panoramic images tiling component.

By specifying bilinear interpolation I was able to reduce the time taken by PTmender to extract a cube face from 42 to 33 seconds. By default it uses a cubic polynomial on a 4x4 region of the input image, but I think that's excessive given we're only upscaling by a factor of between 1 and 2.

May 2 2024, 5:31 AM · Thumbor, MediaViewer
tstarling added a comment to T138933: Explore moving the Panoviewer gadget/Toolforge tool into production.

I made subtasks for what I see as the three main components of spherical panorama support:

May 2 2024, 2:39 AM · Patch-For-Review, Thumbor, MediaViewer, Tools, Platform Team Legacy (Watching / External), Services (watching), Multimedia
tstarling added a comment to T363891: Panoramic images tiling component.

Where would we store the results ? Make a new file storage subspace like score-render ?

May 2 2024, 2:24 AM · Thumbor, MediaViewer
tstarling added a comment to T345334: Cache thumbs in our caching infrastructure (e.g. ATS).

That'd work on overall hits, as you said "sort images by popularity". That's not the case here. Front caches absorb all of the hits and collapse the power law distribution.

May 2 2024, 1:45 AM · SRE, Thumbor, SRE-swift-storage, Traffic

May 1 2024

tstarling added a comment to T363885: Panoramic images thumbnailing component.

In my experiments so far, i've noticed that we also have a LOT of images that do NOT have GPano metadata.

May 1 2024, 11:30 PM · Community-Tech, Commons, MediaWiki-File-management, Thumbor
tstarling created T363891: Panoramic images tiling component.
May 1 2024, 5:20 AM · Thumbor, MediaViewer
tstarling added a comment to T363885: Panoramic images thumbnailing component.

It only supports TIFF output, so it's necessary to pass the resulting image through ImageMagick to convert it to a JPEG.

What input formats are supported?

May 1 2024, 1:46 AM · Community-Tech, Commons, MediaWiki-File-management, Thumbor
tstarling updated the task description for T363885: Panoramic images thumbnailing component.
May 1 2024, 1:33 AM · Community-Tech, Commons, MediaWiki-File-management, Thumbor
tstarling created T363885: Panoramic images thumbnailing component.
May 1 2024, 1:30 AM · Community-Tech, Commons, MediaWiki-File-management, Thumbor

Apr 30 2024

tstarling moved T209892: SecurePoll is not compatible with GPG 2.1+ from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.

Following the merge of https://gerrit.wikimedia.org/r/1003091 it would be good if @dom_walden could do a test election using the new OpenSSL encryption method. See my local test log comment on PS5 for information about generating keys and creating an election.

Apr 30 2024, 11:28 AM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Community-Tech (CommTech-Kanban), MW-on-K8s, MediaWiki-extensions-SecurePoll
tstarling added a project to T209892: SecurePoll is not compatible with GPG 2.1+: Community-Tech (CommTech-Kanban).
Apr 30 2024, 11:20 AM · MW-1.43-notes (1.43.0-wmf.7; 2024-05-28), Community-Tech (CommTech-Kanban), MW-on-K8s, MediaWiki-extensions-SecurePoll
tstarling merged T363810: Publish wikidiff2 to pecl into T196132: wikidiff2 binaries are not distributable due to PHP / GPL license incompatibilities.
Apr 30 2024, 10:29 AM · WMDE-TechWish-Maintenance, Software-Licensing, wikidiff2
tstarling merged task T363810: Publish wikidiff2 to pecl into T196132: wikidiff2 binaries are not distributable due to PHP / GPL license incompatibilities.
Apr 30 2024, 10:28 AM · wikidiff2
tstarling added a comment to T363810: Publish wikidiff2 to pecl.

We can't, due to T196132: wikidiff2 binaries are not distributable due to PHP / GPL license incompatibilities

Apr 30 2024, 10:28 AM · wikidiff2
tstarling added a project to T363786: MultimediaViewer Pannellum integration: Community-Tech (CommTech-Kanban).
Apr 30 2024, 2:06 AM · Community-Tech, MediaViewer
tstarling moved T362133: Clean up block_target migration code from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.
Apr 30 2024, 2:06 AM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, Community-Tech (June 17-28 2024 Bat-Eared Fox), Multiblocks, MediaWiki-Blocks
tstarling created T363786: MultimediaViewer Pannellum integration.
Apr 30 2024, 2:03 AM · Community-Tech, MediaViewer

Apr 29 2024

tstarling added a comment to T345334: Cache thumbs in our caching infrastructure (e.g. ATS).

If we do extrapolation after 10,000th hit. The Theil-Sen extrapolation becomes more useful:
So the simplest is to see is boundary problem and say it's 130 hits at zero and zero at 200M and draw a line.

Apr 29 2024, 3:40 AM · SRE, Thumbor, SRE-swift-storage, Traffic

Apr 26 2024

tstarling closed T353194: Fix support for firejail versions 0.9.72+ as Resolved.

Should be fixed in Shellbox 4.0.1 which is required by MediaWiki 1.42.

Apr 26 2024, 1:31 AM · MediaWiki-Shell
tstarling added a comment to T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal.

If there is some aspect of this that is not addressed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1010344/ , feel free to reopen.

Apr 26 2024, 12:55 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Commons, MediaWiki-File-management, Unstewarded-production-error, Structured-Data-Backlog, Structured Data Engineering, Wikimedia-production-error
tstarling merged task T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Apr 26 2024, 12:54 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MW-1.41-notes (1.41.0-wmf.3; 2023-04-03), Commons, MediaWiki-File-management, Unstewarded-production-error, Structured-Data-Backlog, Structured Data Engineering, Wikimedia-production-error
tstarling merged T228292: API uploads fatal with UploadChunkFileException: Error storing file in '/tmp' backend-fail-internal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Apr 26 2024, 12:52 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage
tstarling merged task T206252: Spike of HTTP errors from SwiftFileBackend::doStoreInternal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Apr 26 2024, 12:51 AM · MediaWiki-File-management, Multimedia, Wikimedia-production-error, Commons
tstarling merged T206252: Spike of HTTP errors from SwiftFileBackend::doStoreInternal into T358830: Uploads fail due to 401 error from swift on wednesdays.
Apr 26 2024, 12:50 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage
tstarling closed T358830: Uploads fail due to 401 error from swift on wednesdays as Resolved.
Apr 26 2024, 12:48 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MediaWiki-Engineering, Commons, MediaWiki-File-management, SRE-swift-storage
tstarling closed T285216: High frequency production warning: Couldn't find a global ID for user {user} as Resolved.

global id warning.png (240×579 px, 15 KB)

Apr 26 2024, 12:14 AM · MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), MediaWiki-extensions-CentralAuth, Community-Tech, Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-GlobalPreferences

Apr 9 2024

tstarling created T362133: Clean up block_target migration code.
Apr 9 2024, 3:06 AM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, Community-Tech (June 17-28 2024 Bat-Eared Fox), Multiblocks, MediaWiki-Blocks
tstarling reopened T346293: ipblocks schema redesign for multiblocks, a subtask of T194697: Multiblocks — Allow for multiple, simultaneous blocks with different expiration dates., as Open.
Apr 9 2024, 3:02 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), Epic, Multiblocks, Community-Wishlist-Survey-2023, MediaWiki-Blocks
tstarling reopened T346293: ipblocks schema redesign for multiblocks as "Open".

Reopening for 3rd party migration and MW core cleanup.

Apr 9 2024, 3:01 AM · MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Multiblocks, Community-Tech (CommTech-Kanban), MediaWiki-Blocks
tstarling reopened T346293: ipblocks schema redesign for multiblocks, a subtask of T349689: Admins should be able to edit an active block without needing to delete it first, as Open.
Apr 9 2024, 3:01 AM · Community-Tech (July 1-12 2024 (Corsac Fox)), Story, Multiblocks

Apr 8 2024

tstarling updated the task description for T355034: Deploy new block_target schema.
Apr 8 2024, 11:32 PM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Multiblocks, MediaWiki-Blocks
tstarling added a comment to T355034: Deploy new block_target schema.

There were a few duplicate key errors while the change was half-deployed, the last at 23:23:00.

Apr 8 2024, 11:32 PM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Multiblocks, MediaWiki-Blocks

Apr 7 2024

tstarling added a comment to T361991: Regex search doesn't work with `/` delimiter in maintenance/grep.php .

Thanks for the report @labster. I can accept a Gerrit patch along these lines. It looks like you do have an account in Gerrit already.

Apr 7 2024, 1:00 AM · MW-1.41-notes, MW-1.40-notes, MW-1.39-notes, MW-1.42-notes (1.42.0-wmf.26; 2024-04-09), Patch-For-Review, MediaWiki-Maintenance-system, MW-1.42-release, MW-1.41-release, MW-1.40-release, MW-1.39-release

Apr 5 2024

tstarling added a comment to T361419: DatabaseTest::testCriticalSectionErrorSelect fails locally, yet passes with php-xdebug enabled.

I couldn't reproduce this, with PHP 8.2.15, xdebug disabled, and excimer locally compiled from the current git master.

Apr 5 2024, 5:44 AM · Upstream, Wikimedia-Hackathon-2024, MediaWiki-libs-RequestTimeout, MW-Interfaces-Team, MediaWiki-libs-Rdbms

Apr 4 2024

tstarling added a comment to T361419: DatabaseTest::testCriticalSectionErrorSelect fails locally, yet passes with php-xdebug enabled.

CriticalSectionScope is not meant to be alive until the end of the process. That's the whole point of it, to have scope lifetime.

Apr 4 2024, 10:50 PM · Upstream, Wikimedia-Hackathon-2024, MediaWiki-libs-RequestTimeout, MW-Interfaces-Team, MediaWiki-libs-Rdbms
tstarling updated the task description for T355034: Deploy new block_target schema.
Apr 4 2024, 2:57 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Multiblocks, MediaWiki-Blocks
tstarling updated the task description for T355034: Deploy new block_target schema.
Apr 4 2024, 2:56 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Multiblocks, MediaWiki-Blocks

Apr 3 2024

tstarling added a comment to T358687: "New device" email sent if cookie has expired.

This should only happen if your IP address is in a /24 subnet (or /64 for IPv6) that hasn't been used for login in the past 80 days. Can you comment on whether that is likely to be the case?

Apr 3 2024, 10:29 PM · Community-Tech, MediaWiki-extensions-LoginNotify

Apr 2 2024

tstarling closed T285798: Stop extending core's ApiOptions as Declined.

Note that the other classes extended by GlobalPreferences (DefaultPreferencesFactory, PreferencesFormOOUI and SpecialPreferences) are also not marked stable to extend.

Apr 2 2024, 10:06 PM · Community-Tech, MediaWiki-extensions-GlobalPreferences
tstarling closed T285798: Stop extending core's ApiOptions, a subtask of T259960: Inject services into API modules and special pages, as Declined.
Apr 2 2024, 10:05 PM · MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), User-DannyS712, Dependency injection, MediaWiki-Special-pages, MediaWiki-Action-API
tstarling added a comment to T285798: Stop extending core's ApiOptions.

MaxSem refactored ApiOptions to allow GlobalPreferences to extend it. He just didn't add @stable to extend because his work predated the introduction of those annotations.

Apr 2 2024, 6:01 AM · Community-Tech, MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work).

As such, it seems to me that the apiwarn-globally-overridden warning should have been an error.

Apr 2 2024, 4:32 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Patch-For-Review, MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work).

(unless we resort to hacky string indexOf checks on the warning).

Apr 2 2024, 3:41 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Patch-For-Review, MediaWiki-extensions-GlobalPreferences
tstarling added a comment to T77151: Full Zoom Feature in Media Viewer.

Shortcuts for zoom will be provided to avoid clicking and repositioning: shift+scroll and "+" and "-" keys will increase/decrease the zoom level centering the zoom area to the current mouse position.

Apr 2 2024, 2:23 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 6), Multimedia, MediaViewer
tstarling updated subscribers of T323076: GlobalPreferences blocks API changes to preference table (mediawiki.user saveOption function doesn't work).

On T198913 we had multiple engineers arguing that users should be informed of global preference updates or overrides, so the default behaviour of action=options, where there is a non-overridden global preference and the extension has not suitably informed the user, should be to fail. As such, it seems to me that the apiwarn-globally-overridden warning should have been an error.

Apr 2 2024, 12:17 AM · Community-Tech (June 17-28 2024 Bat-Eared Fox), MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), Patch-For-Review, MediaWiki-extensions-GlobalPreferences

Mar 30 2024

tstarling added a comment to T190369: Big holes in the MediaWiki release archive.

I found 1.20.6 on a random website. I think the only one we're missing is 1.20.7.

Mar 30 2024, 4:54 AM · MediaWiki-Releasing

Mar 28 2024

tstarling updated subscribers of T190369: Big holes in the MediaWiki release archive.

It's unlikely the Internet Archive or any crawler would have files that were generated in September 2013 and reported missing in December 2013. Maybe community members would have them, but the right time to ask was December 2013.

Mar 28 2024, 3:11 AM · MediaWiki-Releasing
tstarling closed T360865: Slow query in Special:LintErrors as Resolved.
Mar 28 2024, 1:49 AM · MW-1.42-notes (1.42.0-wmf.24; 2024-03-26), MediaWiki-extensions-Linter, Wikimedia-Slow-DB-Query, Wikimedia-production-error
tstarling added a comment to T190369: Big holes in the MediaWiki release archive.

OK, well if they were already missing in 2014, I'm not going to find them in a 2018 archive.

Mar 28 2024, 1:39 AM · MediaWiki-Releasing
tstarling closed T349462: Run Lua garbage collector prior to LuaSandbox OOM as Resolved.

Anything left to do here?

Mar 28 2024, 1:31 AM · LuaSandbox
tstarling closed T349462: Run Lua garbage collector prior to LuaSandbox OOM, a subtask of T165935: "Lua error: not enough memory" on certain en.wiktionary pages, as Resolved.
Mar 28 2024, 1:31 AM · Performance Issue, Scribunto, All-and-every-Wiktionary
tstarling added a comment to T190369: Big holes in the MediaWiki release archive.

Legoktm uploaded all MediaWiki tarballs from releases.wikimedia.org to the Internet Archive in 2018. I should be able to recover the remaining missing tarballs from there.

Mar 28 2024, 12:00 AM · MediaWiki-Releasing

Mar 27 2024

tstarling added a comment to T361064: Wikimedia OCR is not responding.

I can set up a wall time limit, but it seems abusive to queue unlimited Transkribus jobs without any plans to check their responses.

Mar 27 2024, 11:54 PM · Community-Tech, Wikimedia OCR
tstarling added a comment to T190369: Big holes in the MediaWiki release archive.

I uploaded the following release tarballs from my personal archives, which mostly derive from a copy I made of the SourceForge files section in 2009. I retroactively designated the dated snapshots of 2003 as "1.0" for clarity when navigating the top-level directory. There was no other 1.0 and they immediately preceded 1.1 in the release notes. For files which already existed on releases.wikimedia.org, I confirmed that the MD5 hash was the same before removing them from the following list.

Mar 27 2024, 11:20 PM · MediaWiki-Releasing