Code Review Office Hours
ActivePublic
Actions

Hosted by • mmodell on Jan 11 2018, 8:00 PM - 9:00 PM.

Description

What's this all about

This is an initiative of Wikimedia Developer-Advocacy and Release-Engineering-Team intended to promote quality and timely code reviews on Wikimedia projects. See T128371: Set up Code Review office hours for related discussion and the overview on mediawiki.org Code_Review/Office_Hours

How does it work

If you have a patch that needs attention, please subscribe to this event and post a link to your patch in the comments, then show up on freenode IRC in the #wikimedia-codereview channel during the scheduled office hours. Developers with +2 should be on hand to review patches, provide feedback and merge any acceptable/deployable patches.

Nominated Patches

Suggested by	Task and/or Description of patch	Link to patch
@name	Tnnn	...

Other Patches "for-review"

To find other patches to review, try this maniphest query which will show you tasks with the Patch-For-Review tag.

Recurring Event
Next
Previous

Event Series: This event is an instance of E415: Code Review Office Hours, and repeats every week.

Details

Invitees

Kghbln
MarkAHershberger
Smalyshev
• bmansurov
• JGirault
TheDJ
greg
MGChecker
Danny_B
phuedx
Tgr
Catrope
Bawolff
Jdlrobson
Nikerabbit
• ksmith
• brooke
Luke081515
Florian
• mmodell

Event Timeline

MarcoAurelio subscribed.Jan 8 2018, 11:00 AM

Hi there. Please review even if I'm not around if possible. Leave comments on patch/task if any. Thank you.

Author(s)	Patch	Description	Comments
@MarcoAurelio and @matej_suchanek	https://gerrit.wikimedia.org/r/#/c/384496/	Actually mark abusefilter creations as such in the logs	+1(x2), needs review and CR+2
@MarcoAurelio	https://gerrit.wikimedia.org/r/#/c/391877/	Convert Ext:CloseWikis to use extension registration	Tested by @Mainframe98 partially.
@MarcoAurelio	https://gerrit.wikimedia.org/r/#/c/392021/	Converts AdManager to use extension registration	The extension seems to not work neither before nor after this patch. Please test and advice.
@MarcoAurelio	https://gerrit.wikimedia.org/r/#/c/392081/	Converts DeleteBatch to use extension registration	Later due to T182455 ?

MarcoAurelio added a subscriber: Mainframe98.Jan 10 2018, 2:16 PM

MarcoAurelio invited: MarcoAurelio; uninvited: • Mholloway.Jul 27 2018, 8:52 AM

MarcoAurelio uninvited: MarcoAurelio.

Code Review Office HoursActivePublicActions