Page MenuHomePhabricator
Create Task
Maniphest T149473

Edit warnings have escaped HTML
Closed, ResolvedPublic
Actions

Description

Since a02a7ff8eab9, warnings are wrapped in <div class="errorbox"></div> but the messages themselves have HTML escaped (the message should look like this).

Rozbitý-filtr.png (642×1 px, 233 KB)

This affects at least AbuseFilter and SpamBlacklist warnings.

Reports:

Details

SubjectRepoBranchLines +/-
Revert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox""mediawiki/coremaster+26 -2
Remove unused messagesmediawiki/coremaster+2 -6
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"mediawiki/coremaster+2 -22
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"mediawiki/corewmf/1.29.0-wmf.1+2 -22
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"mediawiki/coreREL1_28+2 -22
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"mediawiki/corewmf/1.28.0-wmf.23+2 -22
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Oct 29 2016, 8:35 AM
matmarex updated the task description. (Show Details)Oct 29 2016, 3:06 PM
Nirmos merged a task: T149490: AbuseFilter Messages shown as html.Oct 29 2016, 9:31 PM
Nirmos added subscribers: Dmitry89, Sunpriat, vvv, Jack_who_built_the_house.
• Urbanecm triaged this task as Unbreak Now! priority.Oct 29 2016, 9:45 PM

UBN as this breaks almost all filters at cswiki with warn. At least a revert of mentoined change.

Restricted Application added subscribers: Jay8g, Luke081515, TerraCodes. · View Herald TranscriptOct 29 2016, 9:45 PM
Paladox subscribed.Oct 29 2016, 9:49 PM

The only recent change to AbuseFilter is

rEABFb31d903900f62972b8a1e74f8c2b7dc6b80a44a5

rEABF0309113bd98b3cb68d3d996682606ea4b5927559

Did this only recently happen?

Like last week or the week before?

Paladox added a project: AbuseFilter.Oct 29 2016, 9:49 PM
gerritbot subscribed.Oct 29 2016, 9:55 PM

Change 318770 had a related patch set uploaded (by Paladox):
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"

https://gerrit.wikimedia.org/r/318770

gerritbot added a project: Patch-For-Review.Oct 29 2016, 9:55 PM
Dereckson updated the task description. (Show Details)Oct 29 2016, 9:58 PM
gerritbot added a comment.Oct 29 2016, 10:03 PM

Change 318772 had a related patch set uploaded (by Paladox):
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"

https://gerrit.wikimedia.org/r/318772

gerritbot added a comment.Oct 29 2016, 10:20 PM

Change 318772 merged by jenkins-bot:
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"

https://gerrit.wikimedia.org/r/318772

Stashbot subscribed.Oct 29 2016, 10:26 PM

Mentioned in SAL (#wikimedia-operations) [2016-10-29T22:26:43Z] <reedy@tin> Synchronized php-1.28.0-wmf.23/includes/EditPage.php: Fix for T149473 (duration: 00m 49s)

Reedy lowered the priority of this task from Unbreak Now! to High.Oct 29 2016, 10:27 PM
Peachey88 updated the task description. (Show Details)Oct 30 2016, 6:31 AM
• Nikerabbit subscribed.Oct 30 2016, 9:17 AM
• Nikerabbit added a comment.Oct 30 2016, 9:19 AM

Adding a reminder: i18n messages were not reverted, so those should be cleaned-up before this task is closed, if there won't be a fix that re-uses them.

gerritbot added a comment.Oct 31 2016, 8:35 PM

Change 318983 had a related patch set uploaded (by Thcipriani):
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"

https://gerrit.wikimedia.org/r/318983

gerritbot added a comment.Oct 31 2016, 8:53 PM

Change 318983 merged by jenkins-bot:
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"

https://gerrit.wikimedia.org/r/318983

matmarex subscribed.Nov 2 2016, 12:14 PM

I am confused by the patches here. This has been backported to 1.28 and 1.28.0-wmf.23, but not merged into master. So it will regress again this week when 1.29.0-wmf.1 is deployed? https://gerrit.wikimedia.org/r/#/q/I35a650c6ec478542351824e8ae8a8d8354ffa50f

matmarex added a subscriber: Reedy.Nov 2 2016, 12:17 PM

@Reedy It seems you deployed this to 1.28.0-wmf.23 (according to SAL). Why is it not merged in master or 1.29.0-wmf.1?

matmarex raised the priority of this task from High to Unbreak Now!.Nov 2 2016, 12:17 PM
matmarex added a parent task: T149059: MW-1.29.0-wmf.1 deployment blockers.
Reedy added a subscriber: thcipriani.Nov 2 2016, 12:19 PM
In T149473#2763121, @matmarex wrote:

@Reedy It seems you deployed this to 1.28.0-wmf.23 (according to SAL). Why is it not merged in master or 1.29.0-wmf.1?

I hoped Lego was going to get it fixed before. However, it was known it wasn't... It was discussed with @thcipriani about merging, and/or cherry picking to .1

I'm not sure what actually happened (aka I'm not running the train)

Will deal with now

gerritbot added a comment.Nov 2 2016, 12:19 PM

Change 319309 had a related patch set uploaded (by Reedy):
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"

https://gerrit.wikimedia.org/r/319309

gerritbot added a comment.Nov 2 2016, 12:28 PM

Change 319309 merged by jenkins-bot:
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"

https://gerrit.wikimedia.org/r/319309

gerritbot added a comment.Nov 2 2016, 12:30 PM

Change 318770 merged by jenkins-bot:
Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox"

https://gerrit.wikimedia.org/r/318770

Stashbot added a comment.Nov 2 2016, 12:32 PM

Mentioned in SAL (#wikimedia-operations) [2016-11-02T12:32:03Z] <reedy@tin> Synchronized php-1.29.0-wmf.1/includes/EditPage.php: Fix regression from 1.28.0-wmf.23 T149473 (duration: 00m 47s)

Reedy lowered the priority of this task from Unbreak Now! to Medium.Nov 2 2016, 12:37 PM
matej_suchanek removed a project: Patch-For-Review.Nov 2 2016, 3:12 PM
matej_suchanek merged a task: T149669: Unformatted (raw HTML) AbuseFilter error on beta cluster.
matej_suchanek added a subscriber: Yurik.
matmarex closed this task as Resolved.Nov 2 2016, 3:24 PM
matmarex assigned this task to Reedy.

Now merged and deployed everywhere that it should be.

thcipriani added a comment.Nov 2 2016, 3:25 PM
In T149473#2763136, @Reedy wrote:
In T149473#2763121, @matmarex wrote:

@Reedy It seems you deployed this to 1.28.0-wmf.23 (according to SAL). Why is it not merged in master or 1.29.0-wmf.1?

I hoped Lego was going to get it fixed before. However, it was known it wasn't... It was discussed with @thcipriani about merging, and/or cherry picking to .1

Yes. I cherry-picked this change to REL1_28, but missed cherry-picking the change to master before the 1.29.0-wmf.1 branch cut, my fault completely, sorry :(

ReleaseTaggerBot added projects: MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), MW-1.28-release-notes.Nov 2 2016, 6:01 PM
ReleaseTaggerBot added projects: MW-1.29-release-notes, MW-1.29-release (WMF-deploy-2016-11-01_(1.29.0-wmf.1)), MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Nov 2 2016, 7:01 PM
• Nikerabbit reopened this task as Open.Nov 2 2016, 7:39 PM
In T149473#2754871, @Nikerabbit wrote:

Adding a reminder: i18n messages were not reverted, so those should be cleaned-up before this task is closed, if there won't be a fix that re-uses them.

Base subscribed.Nov 3 2016, 4:01 PM
• mmodell subscribed.Nov 3 2016, 6:09 PM

I'm removing this from blocking T149059: MW-1.29.0-wmf.1 deployment blockers since the only thing remaining is cleanup which shouldn't block the train.

• mmodell removed a parent task: T149059: MW-1.29.0-wmf.1 deployment blockers.Nov 3 2016, 6:09 PM
• mmodell added a project: MediaWiki-Internationalization.
• Nikerabbit added a project: User-Nikerabbit.Nov 4 2016, 7:24 AM
gerritbot added a comment.Nov 23 2016, 4:29 PM

Change 323175 had a related patch set uploaded (by Bartosz Dziewoński):
Remove unused messages

https://gerrit.wikimedia.org/r/323175

gerritbot added a project: Patch-For-Review.Nov 23 2016, 4:29 PM
gerritbot added a comment.Nov 25 2016, 8:55 AM

Change 323175 merged by jenkins-bot:
Remove unused messages

https://gerrit.wikimedia.org/r/323175

matmarex closed this task as Resolved.Nov 25 2016, 1:58 PM
matmarex removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)).Nov 28 2016, 2:00 AM
Anomie mentioned this in T185638: Wrap Scribunto error message into class=error .Jan 26 2018, 5:05 PM
gerritbot added a comment.Jan 26 2018, 5:20 PM

Change 406309 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Revert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox""

https://gerrit.wikimedia.org/r/406309

gerritbot edited projects, added Patch-For-Review; removed MW-1.29-release (WMF-deploy-2016-11-29_(1.29.0-wmf.4)), MW-1.29-release (WMF-deploy-2016-11-08_(1.29.0-wmf.2)).Jan 26 2018, 5:20 PM
gerritbot added a comment.Jan 26 2018, 6:01 PM

Change 406309 merged by jenkins-bot:
[mediawiki/core@master] Revert and fix "Revert "EditPage: Show EditFilterMergedContent hook errors in an errorbox""

https://gerrit.wikimedia.org/r/406309

matmarex removed a project: Patch-For-Review.Jan 26 2018, 6:04 PM
Daimona mentioned this in T187072: CSS for errors turns the whole message to red.Mar 6 2018, 5:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits