Per T210704: Migrate node-based services in production to node10.
- Test proton source code against node 10
- Implement pipeline
- Profile Proton in deployment-charts
- Deploy Proton in k8s
- Switch traffic to the new deployment
Per T210704: Migrate node-based services in production to node10.
https://gerrit.wikimedia.org/r/c/mediawiki/services/chromium-render/+/489102 adds URL handling with the legacy URL API (the WHATWG one is not available on nodejs 6.11.0, although it is available on later versions of node 6). Would be nice to fix when the migration happens.
See https://phabricator.wikimedia.org/T210704, ideally this would happen in the next quarter.
@Tgr Would you mind memorializing the tricky bits about this in the description, for the benefit of whoever picks it up?
Change 524353 had a related patch set uploaded (by MSantos; owner: MSantos):
[operations/puppet@production] Pass use_nodejs10 to proton
Change 524353 merged by Alexandros Kosiaris:
[operations/puppet@production] Pass use_nodejs10 to proton
So, I think our part is done:
@MoritzMuehlenhoff and @Jdforrester-WMF what are the next steps? Does that conclude this task?
CI is running node 6; there's no testing for node 10 set up (and every time you V+2 you bypass all the testing anyway). Next step is to add the pipeline build step in CI, which I'll do now.
Change 528226 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [mediawiki/services/chromium-render] Enable pipeline testing and publishing
Change 528226 merged by jenkins-bot:
[integration/config@master] layout: [mediawiki/services/chromium-render] Enable pipeline testing and publishing
Mentioned in SAL (#wikimedia-releng) [2019-08-05T19:22:27Z] <James_F> Zuul: [mediawiki/services/chromium-render] Enable pipeline testing and publishing T217114
OK, it's now running the pipeline step for CI, but unfortunately that's failing as your pipeline file still tries to use v3 of blubber which is no longer supported; you need to bump to v4.
Change 528232 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/services/chromium-render@master] blubber: bump version to v4
Change 528232 abandoned by MSantos:
blubber: bump version to v4
Reason:
duplicate of If0f9c4d7f2732358b8ee01ed0c6a7e55f5be15fb
Does this mean we can remove the node 6 CI job and the entire mediawiki/services/chromium-render/deploy repo now?
Change 607746 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [mediawiki/services/chromium-render/deploy] Archive
Change 607747 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] jjb: Drop chromium-render-deploy-npm-node-6-docker, unused
I don't think the k8s deployment of Proton is actually serving any traffic yet, so we should wait on those until it's switched over.
Change 607746 merged by jenkins-bot:
[integration/config@master] layout: [mediawiki/services/chromium-render/deploy] Archive
Mentioned in SAL (#wikimedia-releng) [2020-07-10T10:15:42Z] <James_F> Zuul: [mediawiki/services/chromium-render/deploy] Archive T217114
Change 607747 merged by jenkins-bot:
[integration/config@master] jjb: Drop chromium-render-deploy-npm-node-6-docker, unused