Page MenuHomePhabricator
Create Task
Maniphest T221763

LinksUpdate fails during page move due to "Title does not belong to page" RevisionStore error from PageImages hook
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To
daniel
Authored By
jijiki
Apr 24 2019, 11:49 AM
Tags
Referenced Files
None
Subscribers
Aklapper
ArielGlenn
brennen
daniel
DannyS712
hgzh
jijiki
View All 11 Subscribers

Description

Error
  • Request ID: XO8cRQpAIDEAAL3eYJkAAACI
InvalidArgumentException: The given Title does not belong to page ID 8946238 but actually belongs to 8171110

#0 /srv/mediawiki/php-1.34.0-wmf.6/includes/Revision/RevisionStore.php(1826): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.34.0-wmf.6/includes/Revision/RevisionStore.php(2167): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
#2 /srv/mediawiki/php-1.34.0-wmf.6/includes/Revision/RevisionStore.php(1535): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Wikimedia\Rdbms\DBConnRef, array, integer, Title)
#3 /srv/mediawiki/php-1.34.0-wmf.6/includes/Revision.php(138): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Title, integer, integer)
#4 /srv/mediawiki/php-1.34.0-wmf.6/extensions/PageImages/includes/LinksUpdateHookHandler.php(50): Revision::newFromTitle(Title)
#5 /srv/mediawiki/php-1.34.0-wmf.6/extensions/PageImages/includes/LinksUpdateHookHandler.php(74): PageImages\Hooks\LinksUpdateHookHandler->getPageImageCandidates(LinksDeletionUpdate)
#6 /srv/mediawiki/php-1.34.0-wmf.6/extensions/PageImages/includes/LinksUpdateHookHandler.php(33): PageImages\Hooks\LinksUpdateHookHandler->doLinksUpdate(LinksDeletionUpdate)
#7 /srv/mediawiki/php-1.34.0-wmf.6/includes/Hooks.php(174): PageImages\Hooks\LinksUpdateHookHandler::onLinksUpdate(LinksDeletionUpdate)
#8 /srv/mediawiki/php-1.34.0-wmf.6/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#9 /srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/LinksUpdate.php(188): Hooks::run(string, array)
#10 /srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/DeferredUpdates.php(274): LinksUpdate->doUpdate()
#11 /srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/DeferredUpdates.php(219): DeferredUpdates::runUpdate(LinksDeletionUpdate, Wikimedia\Rdbms\LBFactoryMulti, string, integer)
#12 /srv/mediawiki/php-1.34.0-wmf.6/includes/deferred/DeferredUpdates.php(143): DeferredUpdates::execute(array, string, integer)
#13 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(907): DeferredUpdates::doUpdates(string)
#14 /srv/mediawiki/php-1.34.0-wmf.6/includes/MediaWiki.php(731): MediaWiki->restInPeace(string, boolean)
#15 [internal function]: Closure$MediaWiki::doPostOutputShutdown()
[XMAmggpAICsAAEwlrXgAAABD] /w/index.php?title=Speciaal:PaginaHernoemen&action=submit   InvalidArgumentException from line 100 of /srv/mediawiki/php-1.34.0-wmf.1/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 1284480 but actually belongs to 1280398

[XL-6RgpAAD4AAI97q5EAAADR] /w/index.php?title=Special:MovePage&action=submit   InvalidArgumentException from line 100 of /srv/mediawiki/php-1.34.0-wmf.1/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 41989195 but actually belongs to 39994396

Impact

The LinksUpdate logic is failing to complete during a rename or page move sometimes.

It is yet to be determined whether it affects a subset of pages or a subset of attempts (e.g. does it usually work after a retry).

The impact is that data in link tables (category members, file usage, WhatLinksHere etc.) and other page updates (e.g. search index etc.) might be corrupt or out of date for pages that were moved.

Notes

After a rough search, it looks like we have about ~3,850 of errors like these in the past 10 days.

Similar tasks:

Details

SubjectRepoBranchLines +/-
RevisionStore and PageUpdater: handle stale page IDmediawiki/coremaster+161 -9
FlaggedRevision: load revision from master when appropriate.mediawiki/extensions/FlaggedRevsmaster+9 -7
RevisionStoreRecord: improve reporting of mismatching titles.mediawiki/coremaster+2 -1
Use READ_LATEST during LinksUpdatemediawiki/extensions/PageImagesmaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• kchapman assigned this task to Anomie.Apr 26 2019, 3:19 PM
Krinkle moved this task from Untriaged to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.May 6 2019, 6:16 PM
hashar renamed this task from Unable to move page (Special:MovePage&action=submit) to Unable to move page (Special:MovePage&action=submit) Title does not belong to page ID X but actually belong to Y.May 22 2019, 2:06 PM
Krinkle renamed this task from Unable to move page (Special:MovePage&action=submit) Title does not belong to page ID X but actually belong to Y to Page rename (Special:MovePage) can throw InvalidArgumentException: Title does not belong to page ID X but actually belong to Y..May 30 2019, 12:24 AM
Krinkle edited projects, added PageImages; removed SRE.
Krinkle updated the task description. (Show Details)
Krinkle added a comment.May 30 2019, 12:26 AM

Looking through Logstash, it seems all matches for this exception message have a similar stack trace:

  • The request urls are submissions of Special:MovePage (Page rename).
  • The call sites are via PageImages\Hooks\LinksUpdateHookHandler::onLinksUpdate(LinksDeletionUpdate), as fired by the deferred LinksUpdate->doUpdate action.
pmiazga added a project: Web-Team-Backlog (Tracking).May 30 2019, 10:56 PM
pmiazga subscribed.
Krinkle added a comment.EditedMay 30 2019, 11:06 PM

@pmiazga Could your team take a look first to confirm (or rule out) whether PageImages is using Revision::newFromTitle correctly in this context? We can also ask Core Platform to check whether MovePage is issuing the LinksDeletionUpdate incorrectly, but given no other extensions are affected looks like it might be on the PageImages side.

From a quick glance, it is constructing a Revision object by title from a replica db, which seems like it wouldn't be a reliable way to get the wikitext for the edit that just occurred, as it can both be outdated (not yet replicated) or too new (run after other page renames, and thus be updating the wrong title, leaving the one that mattered stay outdated). I would expect LinksUpdate to provide a way to get the correct Content object for your use case, although I don't know off-hand what the right method for that is.

Krinkle mentioned this in Blog Post: Production Excellence #10: April 2019.May 31 2019, 7:21 PM
daniel added a comment.Jun 5 2019, 11:20 AM

LinksUpdate just has a ParserOutput, with no info about the revision ID or the original Content. It should probably have RenderedRevision, that would solve the problem.

daniel edited projects, added Platform Team Legacy (Watching / External); removed Platform Team Legacy (Next).Jun 5 2019, 11:21 AM
pmiazga added a comment.Jun 7 2019, 4:05 PM

sorry, I missed the ping, I'll look into it today

pmiazga added a comment.Jun 7 2019, 4:25 PM

The LinksUpdate has two methods - setRevision() and getRevision(), the PageImages/LinksUpdateHooksHandler tries to fetch the Revision object via $linksUpdate->getRevision(). If there is no revision, it fallbacks to $rev = Revision::newFromTitle( $linksUpdate->getTitle() ); which is causing this error.

The fallback method was added in T203965: PageImages Maintenance Script finds not all Images, patch rEPIMcd2115f80d78: Reenable Indexing for Images. There is no clear information why LinksUpdate::getRevision() can return null, and using LinksUpdate::getTitle() looked like a correct way to solve that problem. IMHO, the call Revision::newFromTitle( $linksUpdate->getTitle() ) looks like a valid call, we take a Title object, and we ask for revision.

But I think I can understand why it fails, this happens as Deferred action most probably the Page is already renamed (so Title points to different page id), that's why system throws that error.

/cc @daniel @Krinkle

CCicalese_WMF edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Team Legacy (Watching / External).Jul 14 2019, 3:24 PM
Nirmos added a project: MediaWiki-Core-Revision-backend.Jul 14 2019, 3:42 PM
• WDoranWMF removed Anomie as the assignee of this task.Jul 17 2019, 8:21 PM
• WDoranWMF lowered the priority of this task from High to Medium.
• WDoranWMF added a subscriber: Anomie.
tstarling subscribed.Jul 25 2019, 1:29 AM

In DeferredUpdates.log I saw the following similar error:

2019-07-25 01:21:33 [XTkEHApAIC4AACNzY80AAADA] mw1325 enwiki 1.34.0-wmf.14 DeferredUpdates ERROR: Deferred update LinksDeletionUpdate failed: The given Title does not belong to page ID 61355695 but actually belongs to 44570450 {"type":"LinksDeletionUpdate","message":"The given Title does not belong to page ID 61355695 but actually belongs to 44570450","trace":"#0 /srv/mediawiki/php-1.34.0-wmf.14/includes/Revision/RevisionStore.php(1894): MediaWiki\\Revision\\RevisionStoreRecord->__construct()

I determined that this is reproducible by moving a page over a redirect. The above DeferredUpdates.log entry occurred when I did a test move (move log entry).

tstarling added a comment.Jul 25 2019, 2:36 AM

I was able to reproduce this locally with PageImages and fake replication (MediaWiki sees two servers but both are really localhost). PageImages calls Revision::newFromTitle() with a Title that has the correct post-move information. RevisionStore fetches the revision information from the slave, retrieving the page and revision row for the redirect that was just deleted. The RevisionStoreRecord constructor does a sanity check, notices the mismatch, and throws an exception. So I think the solution is for PageImages to use the READ_LATEST flag.

gerritbot added a comment.Jul 25 2019, 4:01 AM

Change 525473 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/extensions/PageImages@master] Use READ_LATEST during LinksUpdate

https://gerrit.wikimedia.org/r/525473

gerritbot added a project: Patch-For-Review.Jul 25 2019, 4:01 AM
gerritbot added a comment.Jul 25 2019, 11:12 AM

Change 525473 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Use READ_LATEST during LinksUpdate

https://gerrit.wikimedia.org/r/525473

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.16; 2019-07-30).Jul 25 2019, 12:00 PM
Krinkle removed a project: Patch-For-Review.Jul 26 2019, 3:30 PM
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Resolved on the Wikimedia-production-error board.
• WDoranWMF moved this task from MCR to mop on the Platform Engineering board.Jul 26 2019, 6:38 PM
• WDoranWMF edited projects, added Core Platform Team Initiatives (MCR); removed Platform Engineering (MCR).
Krinkle moved this task from Untriaged to Revision on the MediaWiki-Core-Revision-backend board.Aug 1 2019, 7:56 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:07 PM
Aklapper mentioned this in T232464: Getting InvalidArgumentException when running a query on the API.Sep 10 2019, 12:10 PM
hashar subscribed.Sep 11 2019, 12:54 PM

One more I have noticed today:

enwikiRevisionStoreRecord.phpThe given Title does not belong to page ID 52943292 but actually belongs to 61713901
daniel added a comment.Sep 11 2019, 3:19 PM
In T221763#5483334, @hashar wrote:

One more I have noticed today:

enwikiRevisionStoreRecord.phpThe given Title does not belong to page ID 52943292 but actually belongs to 61713901

Can you provide a stack trace? This issue generally points towards a race condition in the context of renaming or undeletion, but it's impossible to find out what is causing it without a stack trace.

daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:57 AM
Krinkle unsubscribed.Oct 8 2019, 5:14 PM
hashar added a comment.Nov 26 2019, 2:24 PM

Sorry I have missed Daniel request for a stacktrace. It is lost now.

daniel closed this task as Invalid.Nov 26 2019, 5:35 PM

Closing invalid, since I can't find any instance of this error in Kibana. Please re-open with a stack trace if it happens again.

Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptNov 26 2019, 5:35 PM
daniel added a comment.Nov 26 2019, 5:37 PM
In T221763#5693548, @hashar wrote:

Sorry I have missed Daniel request for a stacktrace. It is lost now.

I note that there actually is a stack trace attached. Did I just miss that?

hashar reopened this task as Open.Nov 27 2019, 1:18 PM

That is definitely still happening:

[{exception_id}] {exception_url} InvalidArgumentException from line 99 of /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 54440713 but actually belongs to 62426502
	1
[{exception_id}] {exception_url} InvalidArgumentException from line 99 of /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 54441765 but actually belongs to 62426505
	1
[{exception_id}] {exception_url} InvalidArgumentException from line 99 of /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStoreRecord.php: The given Title does not belong to page ID 57535372 but actually belongs to 62426509

A trace which comes from /rpc/RunSingleJob.php

The given Title does not belong to page ID 54440713 but actually belongs to 62426502
at /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStoreRecord.php:99

#0 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php(1894): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php(1817): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php(2539): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
#3 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision/RevisionStore.php(1514): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Wikimedia\Rdbms\DBConnRef, array, integer, Title)
#4 /srv/mediawiki/php-1.35.0-wmf.5/includes/Revision.php(139): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Title, integer, integer)
#5 /srv/mediawiki/php-1.35.0-wmf.5/includes/actions/InfoAction.php(73): Revision::newFromTitle(Title, integer, integer)
#6 /srv/mediawiki/php-1.35.0-wmf.5/includes/jobqueue/jobs/RefreshLinksJob.php(191): InfoAction::invalidateCache(Title)
#7 /srv/mediawiki/php-1.35.0-wmf.5/includes/jobqueue/jobs/RefreshLinksJob.php(126): RefreshLinksJob->runForTitle(Title)
#8 /srv/mediawiki/php-1.35.0-wmf.5/extensions/EventBus/includes/JobExecutor.php(70): RefreshLinksJob->run()
#9 /srv/mediawiki/rpc/RunSingleJob.php(76): JobExecutor->execute(array)
#10 {main}
ArielGlenn added a project: User-ArielGlenn.Nov 27 2019, 1:24 PM
ArielGlenn subscribed.
daniel added a comment.Nov 27 2019, 3:36 PM
In T221763#5696888, @hashar wrote:

That is definitely still happening:

Hm, my luck with logstash seems to be poor. I was unable to find matching entries. Can you point me to a query that would work, so I can figure out what I did wrong?

daniel raised the priority of this task from Medium to High.Nov 27 2019, 3:38 PM

Bumping to high, since this prevents links update jobs to run (presumably after page moves).

ArielGlenn added a comment.Nov 27 2019, 5:46 PM

message:belong turns up a number of these for various code paths just within the last 15 minutes. https://logstash.wikimedia.org/goto/40f64ef65a75d7609c391dd00ef5d0bb as an example.

daniel claimed this task.Nov 27 2019, 6:41 PM
daniel added a comment.Nov 27 2019, 6:43 PM

Interestingly, the stack traces vary a lot. My guess is that when a page is renamed, anything in progress that relates to that page may encounter this error. I'll have to look more closely, though.

Aklapper merged a task: T240760: Cannot merge pages - InvalidArgumentException: The given Title does not belong to page ID 4673644 but actually belongs to 4506005.Dec 14 2019, 7:09 PM
Aklapper added subscribers: Wargo, DannyS712.
daniel added a comment.Jan 7 2020, 7:20 PM

The instances of this I currently see on Kibana all come from FlaggedRevs:

#0 /srv/mediawiki/php-1.35.0-wmf.11/includes/Revision/RevisionStore.php(1884): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.11/includes/Revision/RevisionStore.php(1807): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.11/includes/Revision.php(374): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
#3 /srv/mediawiki/php-1.35.0-wmf.11/extensions/FlaggedRevs/backend/FlaggedRevision.php(71): Revision->__construct(stdClass, integer, Title)
#4 /srv/mediawiki/php-1.35.0-wmf.11/extensions/FlaggedRevs/backend/FlaggedRevision.php(187): FlaggedRevision->__construct(stdClass, Title)
#5 /srv/mediawiki/php-1.35.0-wmf.11/extensions/FlaggedRevs/backend/FlaggedRevs.php(949): FlaggedRevision::newFromStable(Title, integer)
#6 /srv/mediawiki/php-1.35.0-wmf.11/extensions/FlaggedRevs/backend/FlaggedRevsHooks.php(573): FlaggedRevs::autoReviewEdit(FlaggableWikiPage, User, Revision, NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.11/includes/Hooks.php(174): FlaggedRevsHooks::maybeMakeEditReviewed(WikiPage, Revision, integer, User, array)
#8 /srv/mediawiki/php-1.35.0-wmf.11/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.11/includes/Storage/PageUpdater.php(1001): Hooks::run(string, array)
#10 /srv/mediawiki/php-1.35.0-wmf.11/includes/Storage/PageUpdater.php(757): MediaWiki\Storage\PageUpdater->doModify(CommentStoreComment, User, integer)
#11 /srv/mediawiki/php-1.35.0-wmf.11/includes/page/WikiPage.php(1929): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#12 /srv/mediawiki/php-1.35.0-wmf.11/includes/EditPage.php(2352): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer, boolean, User, string, array, integer)
#13 /srv/mediawiki/php-1.35.0-wmf.11/includes/EditPage.php(1623): EditPage->internalAttemptSave(array, boolean)
#14 /srv/mediawiki/php-1.35.0-wmf.11/includes/api/ApiEditPage.php(398): EditPage->attemptSave(array)
#15 /srv/mediawiki/php-1.35.0-wmf.11/includes/api/ApiMain.php(1603): ApiEditPage->execute()
#16 /srv/mediawiki/php-1.35.0-wmf.11/includes/api/ApiMain.php(539): ApiMain->executeAction()
#17 /srv/mediawiki/php-1.35.0-wmf.11/includes/api/ApiMain.php(510): ApiMain->executeActionWithErrorHandling()
#18 /srv/mediawiki/php-1.35.0-wmf.11/api.php(78): ApiMain->execute()
#19 /srv/mediawiki/w/api.php(3): require(string)
#20 {main}

We should probably use the same approach here as for PageImages: pass the READ_LATEST flag when appropriate. FlaggedRevs actually uses such a flag already, but doesn't pass it to Revision.

daniel moved this task from Backlog to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Jan 7 2020, 7:21 PM
gerritbot added a comment.Jan 7 2020, 7:26 PM

Change 562590 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] FlaggedRevision: load revision from master when appropriate.

https://gerrit.wikimedia.org/r/562590

gerritbot added a project: Patch-For-Review.Jan 7 2020, 7:26 PM

Change 562591 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] RevisionStoreRecord: improve reporting of mismatching titles.

https://gerrit.wikimedia.org/r/562591

daniel moved this task from Doing(WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Jan 7 2020, 7:30 PM
TerraCodes unsubscribed.Jan 8 2020, 2:32 AM
gerritbot added a comment.Jan 8 2020, 9:30 AM

Change 562591 merged by jenkins-bot:
[mediawiki/core@master] RevisionStoreRecord: improve reporting of mismatching titles.

https://gerrit.wikimedia.org/r/562591

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 8 2020, 10:00 AM
brennen added a project: User-brennen.Jan 21 2020, 10:07 PM
brennen subscribed.

Seeing a number of these from 1.35.0-wmf.15:

reqId: XidtzApAMDkAAFHdlf4AAAIF
server: ar.wikipedia.org
timestamp: 2020-01-21T21:32:04+00:00
url: /w/api.php?format=xml&rawcontinue=1&maxlag=5&action=edit

InvalidArgumentException from line 99 of /srv/mediawiki/php-1.35.0-wmf.15/includes/Revision/RevisionStoreRecord.php: The given Title (علاقات الجبل الأسود الخارجية) does not belong to page ID 7103929 but actually belongs to 7103918
#0 /srv/mediawiki/php-1.35.0-wmf.15/includes/Revision/RevisionStore.php(1885): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.15/includes/Revision/RevisionStore.php(1808): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.15/includes/Revision.php(374): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
#3 /srv/mediawiki/php-1.35.0-wmf.15/extensions/FlaggedRevs/backend/FlaggedRevision.php(71): Revision->__construct(stdClass, integer, Title)
#4 /srv/mediawiki/php-1.35.0-wmf.15/extensions/FlaggedRevs/backend/FlaggedRevision.php(187): FlaggedRevision->__construct(stdClass, Title)
#5 /srv/mediawiki/php-1.35.0-wmf.15/extensions/FlaggedRevs/backend/FlaggedRevs.php(949): FlaggedRevision::newFromStable(Title, integer)
#6 /srv/mediawiki/php-1.35.0-wmf.15/extensions/FlaggedRevs/backend/FlaggedRevsHooks.php(573): FlaggedRevs::autoReviewEdit(FlaggableWikiPage, User, Revision, NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.15/includes/Hooks.php(174): FlaggedRevsHooks::maybeMakeEditReviewed(WikiPage, Revision, integer, User, array)
#8 /srv/mediawiki/php-1.35.0-wmf.15/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.15/includes/Storage/PageUpdater.php(1001): Hooks::run(string, array)
#10 /srv/mediawiki/php-1.35.0-wmf.15/includes/Storage/PageUpdater.php(757): MediaWiki\Storage\PageUpdater->doModify(CommentStoreComment, User, integer)
#11 /srv/mediawiki/php-1.35.0-wmf.15/includes/page/WikiPage.php(1930): MediaWiki\Storage\PageUpdater->saveRevision(CommentStoreComment, integer)
#12 /srv/mediawiki/php-1.35.0-wmf.15/includes/EditPage.php(2352): WikiPage->doEditContent(WikitextContent, CommentStoreComment, integer, boolean, User, string, array, integer)
#13 /srv/mediawiki/php-1.35.0-wmf.15/includes/EditPage.php(1623): EditPage->internalAttemptSave(array, boolean)
#14 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiEditPage.php(398): EditPage->attemptSave(array)
#15 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(1603): ApiEditPage->execute()
#16 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(539): ApiMain->executeAction()
#17 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(510): ApiMain->executeActionWithErrorHandling()
#18 /srv/mediawiki/php-1.35.0-wmf.15/api.php(78): ApiMain->execute()
#19 /srv/mediawiki/w/api.php(3): require(string)
#20 {main}
brennen moved this task from Backlog to Logs/Train on the User-brennen board.Jan 21 2020, 10:07 PM
Anomie moved this task from Waiting for Review to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Feb 3 2020, 7:56 PM
Krinkle mentioned this in T246720: Unable to save edit due to "The given Title does not belong to page" error (Wikipedias with FlaggedRevs enabled).Mar 10 2020, 1:35 AM
gerritbot added a comment.Mar 17 2020, 5:11 PM

Change 562590 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] FlaggedRevision: load revision from master when appropriate.

https://gerrit.wikimedia.org/r/562590

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.25; 2020-03-24); removed MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Mar 17 2020, 6:00 PM
Aklapper mentioned this in T248175: Ruwiki article cannot be edited: The given Title does not belong to page ID abc but actually belongs to xyz.Mar 20 2020, 2:45 PM
• WDoranWMF moved this task from Doing(WIP:5) to Ready (WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Mar 24 2020, 8:41 PM
hgzh subscribed.Mar 29 2020, 3:26 PM

Some new cases today:
https://de.wikipedia.org/w/index.php?title=Wikipedia:Fragen_zur_Wikipedia&oldid=198231736#Verschiebung_funktioniert_nicht,_Seite_ist_auf_einmal_ungesichtet

[XoBXoQpAIIQAA4qalHgAAABD] 2020-03-29 08:09:06: Fataler Ausnahmefehler des Typs „InvalidArgumentException“
[XoBhfgpAMMIAAin@rCsAAACE] 2020-03-29 08:51:11: Fataler Ausnahmefehler des Typs „InvalidArgumentException“
[XoCuuApAMNUAAwjyIq8AAABB] 2020-03-29 14:20:42: Fataler Ausnahmefehler des Typs „InvalidArgumentException“

Anomie added a comment.Mar 30 2020, 7:35 PM

Most of these seem to be through RevisionStore::getKnownCurrentRevision(), perhaps RevisionStore::getDBConnectionRef() too should use master when $lb->hasOrMadeRecentMasterChanges().

For the last, my best guess is that the first exception rolled back the move, but somehow or other the deferred update (intended for the redirect left behind) still tried to run.

In T221763#6008525, @hgzh wrote:

[XoBXoQpAIIQAA4qalHgAAABD] 2020-03-29 08:09:06: Fataler Ausnahmefehler des Typs „InvalidArgumentException“

[XoBXoQpAIIQAA4qalHgAAABD] /w/index.php?title=Spezial:Verschieben&action=submit   InvalidArgumentException from line 99 of /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStoreRecord.php: The given Title (Matthias Henkel) does not belong to page ID 7457921 but actually belongs to 11223353
#0 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1907): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1830): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(3233): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title, boolean)
#3 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3733): MediaWiki\Revision\RevisionStore->getKnownCurrentRevision(Title)
#4 [internal function]: Parser::statelessFetchRevision(Title, Parser)
#5 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(391): call_user_func(array, Title, Parser)
#6 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3702): MediaWiki\Revision\RenderedRevision->MediaWiki\Revision\{closure}(Title, Parser)
#7 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/TitleLibrary.php(289): Parser->fetchCurrentRevisionOfTitle(Title)
#8 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/TitleLibrary.php(309): Scribunto_LuaTitleLibrary->getContentInternal(string)
#9 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Scribunto_LuaTitleLibrary->getContent(string)
#10 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#11 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#12 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(291): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#13 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(69): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#14 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#15 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3606): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#16 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3310): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#17 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#18 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3488): PPFrame_Hash->expand(PPNode_Hash_Tree)
#19 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPFrame_Hash)
#20 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3151): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#21 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(1485): Parser->replaceVariables(string)
#22 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(599): Parser->internalParse(string)
#23 /srv/mediawiki/php-1.35.0-wmf.25/includes/content/WikitextContent.php(368): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#24 /srv/mediawiki/php-1.35.0-wmf.25/includes/content/AbstractContent.php(565): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#25 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(267): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#26 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(236): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#27 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#28 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#29 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#30 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(198): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#31 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1301): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#32 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1655): MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#33 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1441): MediaWiki\Storage\DerivedPageDataUpdater->doParserCacheUpdate()
#34 /srv/mediawiki/php-1.35.0-wmf.25/includes/page/WikiPage.php(2047): MediaWiki\Storage\DerivedPageDataUpdater->doUpdates()
#35 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(889): WikiPage->doEditUpdates(MediaWiki\Revision\RevisionStoreRecord, User, array)
#36 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(546): MovePage->moveToInternal(User, Title, string, boolean, array)
#37 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(389): MovePage->moveUnsafe(User, string, boolean, array)
#38 /srv/mediawiki/php-1.35.0-wmf.25/includes/specials/SpecialMovepage.php(773): MovePage->moveIfAllowed(User, string, boolean)
#39 /srv/mediawiki/php-1.35.0-wmf.25/includes/specials/SpecialMovepage.php(135): MovePageForm->doSubmit()
#40 /srv/mediawiki/php-1.35.0-wmf.25/includes/specialpage/SpecialPage.php(575): MovePageForm->execute(NULL)
#41 /srv/mediawiki/php-1.35.0-wmf.25/includes/specialpage/SpecialPageFactory.php(622): SpecialPage->run(NULL)
#42 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#43 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(973): MediaWiki->performRequest()
#44 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(535): MediaWiki->main()
#45 /srv/mediawiki/php-1.35.0-wmf.25/index.php(47): MediaWiki->run()
#46 /srv/mediawiki/w/index.php(3): require(string)
#47 {main}

[XoBhfgpAMMIAAin@rCsAAACE] 2020-03-29 08:51:11: Fataler Ausnahmefehler des Typs „InvalidArgumentException“

[XoBhfgpAMMIAAin@rCsAAACE] /w/index.php?title=Spezial:Verschieben&action=submit   InvalidArgumentException from line 99 of /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStoreRecord.php: The given Title (Matthias Henkel) does not belong to page ID 7457921 but actually belongs to 11223406
#0 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1907): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1830): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(3233): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title, boolean)
#3 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3733): MediaWiki\Revision\RevisionStore->getKnownCurrentRevision(Title)
#4 [internal function]: Parser::statelessFetchRevision(Title, Parser)
#5 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(391): call_user_func(array, Title, Parser)
#6 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3702): MediaWiki\Revision\RenderedRevision->MediaWiki\Revision\{closure}(Title, Parser)
#7 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/TitleLibrary.php(289): Parser->fetchCurrentRevisionOfTitle(Title)
#8 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/TitleLibrary.php(309): Scribunto_LuaTitleLibrary->getContentInternal(string)
#9 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Scribunto_LuaTitleLibrary->getContent(string)
#10 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#11 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#12 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(291): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#13 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(69): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#14 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#15 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3606): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#16 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3310): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#17 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#18 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3488): PPFrame_Hash->expand(PPNode_Hash_Tree)
#19 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPFrame_Hash)
#20 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3151): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#21 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(1485): Parser->replaceVariables(string)
#22 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(599): Parser->internalParse(string)
#23 /srv/mediawiki/php-1.35.0-wmf.25/includes/content/WikitextContent.php(368): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#24 /srv/mediawiki/php-1.35.0-wmf.25/includes/content/AbstractContent.php(565): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#25 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(267): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#26 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(236): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#27 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#28 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#29 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#30 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(198): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#31 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1301): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#32 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1655): MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#33 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1441): MediaWiki\Storage\DerivedPageDataUpdater->doParserCacheUpdate()
#34 /srv/mediawiki/php-1.35.0-wmf.25/includes/page/WikiPage.php(2047): MediaWiki\Storage\DerivedPageDataUpdater->doUpdates()
#35 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(889): WikiPage->doEditUpdates(MediaWiki\Revision\RevisionStoreRecord, User, array)
#36 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(546): MovePage->moveToInternal(User, Title, string, boolean, array)
#37 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(389): MovePage->moveUnsafe(User, string, boolean, array)
#38 /srv/mediawiki/php-1.35.0-wmf.25/includes/specials/SpecialMovepage.php(773): MovePage->moveIfAllowed(User, string, boolean)
#39 /srv/mediawiki/php-1.35.0-wmf.25/includes/specials/SpecialMovepage.php(135): MovePageForm->doSubmit()
#40 /srv/mediawiki/php-1.35.0-wmf.25/includes/specialpage/SpecialPage.php(575): MovePageForm->execute(NULL)
#41 /srv/mediawiki/php-1.35.0-wmf.25/includes/specialpage/SpecialPageFactory.php(622): SpecialPage->run(NULL)
#42 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#43 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(973): MediaWiki->performRequest()
#44 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(535): MediaWiki->main()
#45 /srv/mediawiki/php-1.35.0-wmf.25/index.php(47): MediaWiki->run()
#46 /srv/mediawiki/w/index.php(3): require(string)
#47 {main}

[XoCuuApAMNUAAwjyIq8AAABB] 2020-03-29 14:20:42: Fataler Ausnahmefehler des Typs „InvalidArgumentException“

[XoCuuApAMNUAAwjyIq8AAABB] /w/index.php?title=Spezial:Verschieben&action=submit   InvalidArgumentException from line 99 of /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStoreRecord.php: The given Title (Merchawia) does not belong to page ID 3425839 but actually belongs to 11224061
#0 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1907): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1830): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(3233): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title, boolean)
#3 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3733): MediaWiki\Revision\RevisionStore->getKnownCurrentRevision(Title)
#4 [internal function]: Parser::statelessFetchRevision(Title, Parser)
#5 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(391): call_user_func(array, Title, Parser)
#6 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3702): MediaWiki\Revision\RenderedRevision->MediaWiki\Revision\{closure}(Title, Parser)
#7 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/TitleLibrary.php(289): Parser->fetchCurrentRevisionOfTitle(Title)
#8 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/TitleLibrary.php(309): Scribunto_LuaTitleLibrary->getContentInternal(string)
#9 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxCallback.php(26): Scribunto_LuaTitleLibrary->getContent(string)
#10 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#11 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaSandbox/LuaSandboxInterpreter.php(113): LuaSandboxFunction->call(LuaSandboxFunction)
#12 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/LuaEngine.php(291): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#13 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/engines/LuaCommon/LuaModule.php(69): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#14 /srv/mediawiki/php-1.35.0-wmf.25/extensions/Scribunto/includes/common/Hooks.php(128): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#15 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3606): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#16 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3310): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#17 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#18 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3488): PPFrame_Hash->expand(PPNode_Hash_Tree)
#19 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/PPFrame_Hash.php(253): Parser->braceSubstitution(array, PPFrame_Hash)
#20 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(3151): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#21 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(1485): Parser->replaceVariables(string)
#22 /srv/mediawiki/php-1.35.0-wmf.25/includes/parser/Parser.php(599): Parser->internalParse(string)
#23 /srv/mediawiki/php-1.35.0-wmf.25/includes/content/WikitextContent.php(368): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#24 /srv/mediawiki/php-1.35.0-wmf.25/includes/content/AbstractContent.php(565): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#25 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(267): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#26 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(236): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#27 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#28 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#29 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#30 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RenderedRevision.php(198): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#31 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1301): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#32 [internal function]: MediaWiki\Storage\DerivedPageDataUpdater->getCanonicalParserOutput()
#33 /srv/mediawiki/php-1.35.0-wmf.25/includes/edit/PreparedEdit.php(104): call_user_func(array)
#34 /srv/mediawiki/php-1.35.0-wmf.25/includes/edit/PreparedEdit.php(119): MediaWiki\Edit\PreparedEdit->getOutput()
#35 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1279): MediaWiki\Edit\PreparedEdit->__get(string)
#36 /srv/mediawiki/php-1.35.0-wmf.25/includes/Storage/DerivedPageDataUpdater.php(1478): MediaWiki\Storage\DerivedPageDataUpdater->getPreparedEdit()
#37 /srv/mediawiki/php-1.35.0-wmf.25/includes/page/WikiPage.php(2047): MediaWiki\Storage\DerivedPageDataUpdater->doUpdates()
#38 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(889): WikiPage->doEditUpdates(MediaWiki\Revision\RevisionStoreRecord, User, array)
#39 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(546): MovePage->moveToInternal(User, Title, string, boolean, array)
#40 /srv/mediawiki/php-1.35.0-wmf.25/includes/MovePage.php(389): MovePage->moveUnsafe(User, string, boolean, array)
#41 /srv/mediawiki/php-1.35.0-wmf.25/includes/specials/SpecialMovepage.php(773): MovePage->moveIfAllowed(User, string, boolean)
#42 /srv/mediawiki/php-1.35.0-wmf.25/includes/specials/SpecialMovepage.php(135): MovePageForm->doSubmit()
#43 /srv/mediawiki/php-1.35.0-wmf.25/includes/specialpage/SpecialPage.php(575): MovePageForm->execute(NULL)
#44 /srv/mediawiki/php-1.35.0-wmf.25/includes/specialpage/SpecialPageFactory.php(622): SpecialPage->run(NULL)
#45 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(299): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#46 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(973): MediaWiki->performRequest()
#47 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(535): MediaWiki->main()
#48 /srv/mediawiki/php-1.35.0-wmf.25/index.php(47): MediaWiki->run()
#49 /srv/mediawiki/w/index.php(3): require(string)
#50 {main}
[XoCuuApAMNUAAwjyIq8AAABB] /w/index.php?title=Spezial:Verschieben&action=submit   InvalidArgumentException from line 99 of /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStoreRecord.php: The given Title (Merchavia) does not belong to page ID 4642608 but actually belongs to 3425839
#0 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1907): MediaWiki\Revision\RevisionStoreRecord->__construct(Title, User, CommentStoreComment, stdClass, MediaWiki\Revision\RevisionSlots, boolean)
#1 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1830): MediaWiki\Revision\RevisionStore->newRevisionFromRowAndSlots(stdClass, MediaWiki\Revision\RevisionSlots, integer, Title, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(2536): MediaWiki\Revision\RevisionStore->newRevisionFromRow(stdClass, integer, Title)
#3 /srv/mediawiki/php-1.35.0-wmf.25/includes/Revision/RevisionStore.php(1520): MediaWiki\Revision\RevisionStore->loadRevisionFromConds(Wikimedia\Rdbms\DBConnRef, array, integer, Title)
#4 /srv/mediawiki/php-1.35.0-wmf.25/extensions/PageImages/includes/LinksUpdateHookHandler.php(59): MediaWiki\Revision\RevisionStore->getRevisionByTitle(Title, integer, integer)
#5 /srv/mediawiki/php-1.35.0-wmf.25/extensions/PageImages/includes/LinksUpdateHookHandler.php(83): PageImages\Hooks\LinksUpdateHookHandler->getPageImageCandidates(LinksDeletionUpdate)
#6 /srv/mediawiki/php-1.35.0-wmf.25/extensions/PageImages/includes/LinksUpdateHookHandler.php(35): PageImages\Hooks\LinksUpdateHookHandler->doLinksUpdate(LinksDeletionUpdate)
#7 /srv/mediawiki/php-1.35.0-wmf.25/includes/Hooks.php(174): PageImages\Hooks\LinksUpdateHookHandler::onLinksUpdate(LinksDeletionUpdate)
#8 /srv/mediawiki/php-1.35.0-wmf.25/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.25/includes/deferred/LinksUpdate.php(192): Hooks::run(string, array)
#10 /srv/mediawiki/php-1.35.0-wmf.25/includes/deferred/DeferredUpdates.php(417): LinksUpdate->doUpdate()
#11 /srv/mediawiki/php-1.35.0-wmf.25/includes/deferred/DeferredUpdates.php(296): DeferredUpdates::attemptUpdate(LinksDeletionUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#12 /srv/mediawiki/php-1.35.0-wmf.25/includes/deferred/DeferredUpdates.php(233): DeferredUpdates::run(LinksDeletionUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#13 /srv/mediawiki/php-1.35.0-wmf.25/includes/deferred/DeferredUpdates.php(150): DeferredUpdates::handleUpdateQueue(array, string, integer)
#14 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(1059): DeferredUpdates::doUpdates(string)
#15 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(839): MediaWiki->restInPeace()
#16 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(848): MediaWiki->{closure}()
#17 /srv/mediawiki/php-1.35.0-wmf.25/includes/MediaWiki.php(574): MediaWiki->doPostOutputShutdown()
#18 /srv/mediawiki/php-1.35.0-wmf.25/index.php(47): MediaWiki->run()
#19 /srv/mediawiki/w/index.php(3): require(string)
#20 {main}
DannyS712 added a project: MediaWiki-Page-rename.Apr 8 2020, 4:33 PM
daniel added a comment.Apr 9 2020, 9:12 AM

Most of these seem to be through RevisionStore::getKnownCurrentRevision(), perhaps RevisionStore::getDBConnectionRef() too should use master when $lb->hasOrMadeRecentMasterChanges().

Loading the revision row from master would not help - rev_page never changes, so it's not going to be any different on master.
However, getKnownCurrentRevision() calls Title::getArticleID(), and getLatestRevID(), both of which may return outdated information. We could pass the READ_LATEST flag here, but that forces a database query. getKnownCurrentRevision() exists to avoid database queries. So we should, at least in the common case...

hashar unsubscribed.Apr 9 2020, 9:51 AM
gerritbot added a comment.Apr 9 2020, 12:08 PM

Change 587722 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] RevisionStore and PageUpdater: handle stale page ID

https://gerrit.wikimedia.org/r/587722

daniel moved this task from Ready (WIP:5) to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.Apr 9 2020, 5:14 PM
daniel moved this task from Doing(WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.Apr 16 2020, 12:14 PM
Krinkle renamed this task from Page rename (Special:MovePage) can throw InvalidArgumentException: Title does not belong to page ID X but actually belong to Y. to Unable to move pages sometimes due to "Title does not belong to page" RevisionStore error from PageImages hook.Apr 16 2020, 3:29 PM
Krinkle renamed this task from Unable to move pages sometimes due to "Title does not belong to page" RevisionStore error from PageImages hook to LinksUpdate fails during page move due to "Title does not belong to page" RevisionStore error from PageImages hook.Apr 16 2020, 3:33 PM
Krinkle updated the task description. (Show Details)
gerritbot added a comment.Apr 27 2020, 9:16 PM

Change 587722 merged by jenkins-bot:
[mediawiki/core@master] RevisionStore and PageUpdater: handle stale page ID

https://gerrit.wikimedia.org/r/587722

• Pchelolo moved this task from Waiting for Review to Waiting for deployment on the Platform Team Workboards (Clinic Duty Team) board.Apr 28 2020, 3:14 PM
Krinkle removed a project: Wikimedia-production-error.Apr 29 2020, 7:04 PM
Jdlrobson added a project: Wikimedia-production-error.May 8 2020, 9:17 PM
• Pchelolo closed this task as Resolved.May 28 2020, 5:32 PM
• Pchelolo moved this task from Waiting for deployment to Done on the Platform Team Workboards (Clinic Duty Team) board.
• Pchelolo subscribed.

All patches here were deployed. I've done some logstash searching, and all errors have completely stopped around May 04-05 which corresponds with deployment. Resolving. Please reopen if reappears.

Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 16 2020, 6:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits