Page MenuHomePhabricator
Create Task
Maniphest T225659

Homepage: different paths to User talk depending on origin tab
Closed, ResolvedPublic
Actions

Description

IMG_7669.PNG (1×640 px, 92 KB)

IMG_7670.PNG (1×640 px, 95 KB)

Details

SubjectRepoBranchLines +/-
Only set relevant title on mobile skinmediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.15+7 -1
Only set relevant title on mobile skinmediawiki/extensions/GrowthExperimentswmf/1.34.0-wmf.16+7 -1
Only set relevant title on mobile skinmediawiki/extensions/GrowthExperimentsmaster+7 -1
Enable talk overlay on mobile homepage talk tabmediawiki/extensions/GrowthExperimentsmaster+5 -1
Use wgRelevantPageTitle when setting up talk overlaymediawiki/skins/MinervaNeuemaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 Resolved• RileychT213990 [EPIC] Growth: Newcomer homepage
 ResolvedMMiller_WMFT215983 Homepage: mobile version
 ResolvedMMiller_WMFT225676 Homepage: mobile MVP list
 ResolvedSBissonT225659 Homepage: different paths to User talk depending on origin tab
 ResolvedSBissonT225660 Homepage: recent questions links on mobile go to desktop site
 ResolvedkostajhT225661 Homepage: link to "Guidelines for user pages" leads to desktop version
 ResolvedkostajhT225663 Homepage: add sub-header text about user longevity to mobile homepage
 ResolvedSBissonT225665 Homepage: open user and user talk in reading mode from mobile
 ResolvedSBissonT225666 Homepage: mobile header style
 ResolvedEtonkovidovaT225615 Homepage mobile: the icon image=message not displayed in 'Confirm your email'
 ResolvedSBissonT225668 Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89
 OpenNoneT225669 Homepage: "ask a question" dialog and overlay issues
 ResolvedSBissonT216220 Homepage: design for indicating that the user should check back for pageviews
 ResolvedMMiller_WMFT226147 Homepage: impact clock icon issues on mobile
 DuplicateNoneT227229 Homepage: impact tooltip cut off in Arabic
 ResolvedSBissonT222836 Mobile Homepage: instrumentation
 DeclinedkostajhT226146 Homepage: minor mobile instrumentation issues
 ResolvedkostajhT226208 Homepage: do not log HomepageVisit when handling tutorial visit POST requests
 Resolvednettrom_WMFT226222 Homepage: mobile instrumentation post-deployment QA
 ResolvedkostajhT222833 Mobile Homepage: Show module details in a mobile overlay
 ResolvedBUG REPORTSBissonT225346 Mobile homepage not fully responsive in Czech
 ResolvedSBissonT223142 Homepage: mobile tab scrolling
 ResolvedJdforrester-WMFT226442 CI jobs failing for MinervaNeue (because of old pinned fibers version?)
 ResolvedkostajhT226041 Homepage and help panel: ask question dialog should be aware of back button

Event Timeline

SBisson created this task.Jun 12 2019, 6:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 12 2019, 6:57 PM
SBisson added a comment.Jun 12 2019, 6:58 PM

@kostajh could you explain how this works?

kostajh added a comment.Jun 12 2019, 7:16 PM

Sure. MinervaNeue contains code (skins/MinervaNeue/resources/skins.minerva.talk/init.js) which takes over control of the Talk tab and displays the talk overlay. That code is currently loaded when viewing the user page or an article page. We could load it on Special:Homepage, but I think we might also need to make some modifications to init.js so it supports overriding the links when added to a Special page, since AMC tabs generally are assumed to be added to content pages and not special pages.

SBisson mentioned this in T225288: [mobile] Homepage UX/UI issues.Jun 12 2019, 7:21 PM
MMiller_WMF renamed this task from Different paths to User talk page depending from which tab 'Discussion' tab is clicked to Homepage: different paths to User talk depending origin tab.Jun 12 2019, 10:07 PM
MMiller_WMF renamed this task from Homepage: different paths to User talk depending origin tab to Homepage: different paths to User talk depending on origin tab.
MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
MMiller_WMF added parent tasks: T225676: Homepage: mobile MVP list, T215983: Homepage: mobile version.
MMiller_WMF added subscribers: Catrope, Etonkovidova, • Cntlsn and 3 others.
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 12 2019, 11:31 PM
MMiller_WMF mentioned this in T225676: Homepage: mobile MVP list.Jun 13 2019, 5:53 PM
JTannerWMF moved this task from Needs triage to Triaged on the Mobile board.Jun 14 2019, 11:36 AM
SBisson added a comment.Jun 14 2019, 5:47 PM

@MMiller_WMF Which one of the two options described in the task description do we want, navigating to the talk page (1st option) or opening the talk overlay (2nd option)?

MMiller_WMF added a comment.Jun 14 2019, 7:09 PM

@SBisson -- we want it to be the 2nd option (opening the talk overlay), because we want the behavior to be consistent with what AMC is doing by default.

SBisson claimed this task.Jun 18 2019, 7:30 PM
SBisson moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jun 18 2019, 7:51 PM

Change 517730 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/skins/MinervaNeue@master] Use wgRelevantPageTitle when setting up talk overlay

https://gerrit.wikimedia.org/r/517730

gerritbot added a project: Patch-For-Review.Jun 18 2019, 7:51 PM

Change 517731 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Enable talk overlay on mobile homepage talk tab

https://gerrit.wikimedia.org/r/517731

SBisson moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 18 2019, 7:53 PM

@Catrope had the brilliant idea to use wgRelevantPageTitle for this. Let's hope it's acceptable on the Minerva side.

gerritbot added a comment.Jun 25 2019, 10:21 AM

Change 517730 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Use wgRelevantPageTitle when setting up talk overlay

https://gerrit.wikimedia.org/r/517730

gerritbot added a comment.Jun 25 2019, 12:01 PM

Change 517731 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Enable talk overlay on mobile homepage talk tab

https://gerrit.wikimedia.org/r/517731

Maintenance_bot removed a project: Patch-For-Review.Jun 25 2019, 12:10 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 25 2019, 2:00 PM
Catrope moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jun 25 2019, 9:38 PM
Etonkovidova closed this task as Resolved.Jun 26 2019, 5:08 PM

Checked in betalabs - the look for Discussion page is the same for users coming from Homepage and from User page

gerritbot added a comment.Jul 30 2019, 4:46 PM

Change 526475 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Only set relevant title on mobile skin

https://gerrit.wikimedia.org/r/526475

gerritbot added a project: Patch-For-Review.Jul 30 2019, 4:46 PM
kostajh mentioned this in T229263: Homepage: do not display tabs unrelated to the page .Jul 30 2019, 4:47 PM
gerritbot added a comment.Jul 31 2019, 1:42 AM

Change 526475 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Only set relevant title on mobile skin

https://gerrit.wikimedia.org/r/526475

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.17; 2019-08-06); removed MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jul 31 2019, 2:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 2:10 AM
gerritbot added a comment.Jul 31 2019, 7:46 AM

Change 526610 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.16] Only set relevant title on mobile skin

https://gerrit.wikimedia.org/r/526610

gerritbot added a project: Patch-For-Review.Jul 31 2019, 7:46 AM
gerritbot added a comment.Jul 31 2019, 7:49 AM

Change 526612 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.15] Only set relevant title on mobile skin

https://gerrit.wikimedia.org/r/526612

gerritbot added a comment.Jul 31 2019, 4:17 PM

Change 526610 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.16] Only set relevant title on mobile skin

https://gerrit.wikimedia.org/r/526610

gerritbot added a comment.Jul 31 2019, 4:18 PM

Change 526612 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.15] Only set relevant title on mobile skin

https://gerrit.wikimedia.org/r/526612

Stashbot added a comment.Jul 31 2019, 4:25 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-31T16:25:02Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.15/extensions/GrowthExperiments/: SWAT: [[:gerrit:526612|Only set relevant title on mobile skin]] (T229263, T225659) (duration: 00m 56s)

Stashbot added a comment.Jul 31 2019, 4:26 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-31T16:26:26Z] <urbanecm@deploy1001> Synchronized php-1.34.0-wmf.16/extensions/GrowthExperiments/: SWAT: [[:gerrit:526610|Only set relevant title on mobile skin]] (T229263, T225659) (duration: 00m 51s)

ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.15; 2019-07-23); removed MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Jul 31 2019, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2019, 5:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits