1.35.0-wmf.24 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	• mmodell
	Sep 25 2019, 10:14 PM

Details

Backup Train Conductor: • mmodell
Release Version: 1.35.0-wmf.24
Release Date: Mar 16 2020, 12:00 AM

2020 week 12 1.35-wmf.24 Changes wmf/1.35.0-wmf.24

This MediaWiki Train Deployment is scheduled for the week of Monday, March 16th:

Monday March 16th	Tuesday, March 17th	Wednesday, March 18th	Thursday, March 19th	Friday
Backports only.	Branch `wmf.24` and deploy to Group 0 Wikis.	Deploy `wmf.24` to Group 1 Wikis.	Deploy `wmf.24` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.24 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.35.0-wmf.23

Next: 1.35.0-wmf.25

	Subject	Repo	Branch	Lines +/-
	Group0 to 1.35.0-wmf.24	operations/mediawiki-config	master	+130 -130

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T233872 1.35.0-wmf.24 deployment blockers
Resolved	Release	• brennen	T233871 1.35.0-wmf.23 deployment blockers
Resolved	PRODUCTION ERROR	• brennen	T247446 CPT want the wmf.23 train blocked for group1
Resolved	PRODUCTION ERROR	Krinkle	T247562 Warning: Memcached::setMulti(): failed to set key global:segment:...
Resolved		Krinkle	T248010 Vector sidebar missing on test.wikipedia.org and weird footer
Resolved		Jdlrobson	T247566 Broken section edit links styles on Vector
Resolved		Catrope	T248049 wgNewUserMsgRevisionId (in JavaScript) is no longer set when the user has a new message
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T248090 ResourceLoaderFileModule::getFileContents: style file not found, or is not a file: "/srv/mediawiki/php-1.35.0-wmf.24/extensions/RelatedArticles/"
Resolved		aaron	T248147 Wikimedia\Rdbms\Database::normalizeUpsertKeys called with deprecated parameter style: the unique key array should be a string or array of string arrays generating 2 million warnings in 24 hours

Event Timeline

• mmodell created this task.Sep 25 2019, 10:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 25 2019, 10:14 PM

thcipriani assigned this task to hashar.Jan 16 2020, 10:14 PM

thcipriani triaged this task as Medium priority.

thcipriani updated Other Assignee, added: • mmodell.

thcipriani added a project: Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)).

thcipriani moved this task from INBOX to Deployment on the Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)) board.

• Mholloway subscribed.Mar 3 2020, 6:43 PM

Added wmf.23 as a blocker for wmf.24. If wmf.23 isn't fully deployed by the wmf.24 Tuesday train window then we should go ahead and cut the branch for wmf.24, but NOT deploy it to any wikis. This unblocks folks waiting to merge to master until after wmf.24 is cut, but spares us the confusion of 3 branches in production which I definitely want to avoid.

Mentioned in SAL (#wikimedia-operations) [2020-03-17T13:41:42Z] <hashar> Branching 1.35.0-wmf.24 # T233872

Mentioned in SAL (#wikimedia-operations) [2020-03-17T14:38:10Z] <hashar> mediawiki/core git push 68bc9300dc:wmf/1.35.0-wmf.24 to catch up with a change that got merged while branch is being cut # T233872

Mentioned in SAL (#wikimedia-operations) [2020-03-17T15:01:56Z] <hashar> scap prep 1.35.0-wmf.24 and applying security patches # T233872

Change 580349 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Group0 to 1.35.0-wmf.24

https://gerrit.wikimedia.org/r/580349

gerritbot added a project: Patch-For-Review.Mar 17 2020, 3:12 PM

The patch for the GlobalBlocking extension has been merged/released ( T229731 ). I have dropped it from our list of patches to maintain.

All other patches have been applied.

I have prepared the wikiversion update change: https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/580349 Group0 to 1.35.0-wmf.24

In T233872#5975662, @hashar wrote:

The patch for the GlobalBlocking extension has been merged/released ( T229731 ). I have dropped it from our list of patches to maintain.

All other patches have been applied.

I have prepared the wikiversion update change: https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/580349 Group0 to 1.35.0-wmf.24

The "all wikis to 1.35.0-wmf.23" patch at https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/580358/ is based on the "Group0 to 1.35.0-wmf.24" patch, and thus despite having CR+2 won't merged until you start this train... should the order be flipped?

@DannyS712 indeed, thanks to have noticed!

hashar closed subtask T233871: 1.35.0-wmf.23 deployment blockers as Resolved.Mar 18 2020, 2:46 PM

Change 580349 abandoned by Hashar:
Group0 to 1.35.0-wmf.24

https://gerrit.wikimedia.org/r/580349

Change 580349 restored by Hashar:
Group0 to 1.35.0-wmf.24

https://gerrit.wikimedia.org/r/580349

Change 580349 merged by jenkins-bot:
[operations/mediawiki-config@master] Group0 to 1.35.0-wmf.24

https://gerrit.wikimedia.org/r/580349

Mentioned in SAL (#wikimedia-operations) [2020-03-18T14:58:46Z] <hashar@deploy1001> Started scap: testwiki to 1.35.0-wmf.24 and rebuild l10n cache - T233872

I wanted to do group0 this afternoon, but forgot about the initial sync of all data which is going on right now.

I am aiming at pushing wmf.24 to group0 during my evening (~ 20-21h UTC).

Mentioned in SAL (#wikimedia-operations) [2020-03-18T16:00:09Z] <hashar@deploy1001> Finished scap: testwiki to 1.35.0-wmf.24 and rebuild l10n cache - T233872 (duration: 61m 23s)

hashar added a subtask: T248006: PHP Notice: Undefined property: Wikibase\DataModel\Term\TermList::$Ø.Mar 18 2020, 5:28 PM

Nikerabbit added a subtask: T248003: Wikimedia\\Rdbms\\DBTransactionError(code: 0): A database transaction round is pending..Mar 18 2020, 6:13 PM

Nikerabbit added a subtask: T248010: Vector sidebar missing on test.wikipedia.org and weird footer.Mar 18 2020, 6:28 PM

hashar removed a subtask: T248006: PHP Notice: Undefined property: Wikibase\DataModel\Term\TermList::$Ø.Mar 18 2020, 7:37 PM

hashar removed a subtask: T248003: Wikimedia\\Rdbms\\DBTransactionError(code: 0): A database transaction round is pending..Mar 18 2020, 9:53 PM

RhinosF1 subscribed.Mar 18 2020, 9:56 PM

Change 581133 had a related patch set uploaded (by 20after4; owner: 20after4):
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.24 refs T233872

https://gerrit.wikimedia.org/r/581133

DannyS712 added a subtask: T248040: Scap plugins in operations/mediawiki-config don't pass tox, so CI is disabled.Mar 18 2020, 11:40 PM

ssastry subscribed.Mar 18 2020, 11:49 PM

This comment was removed by ssastry.

matmarex added a subtask: T247566: Broken section edit links styles on Vector.Mar 18 2020, 11:52 PM

Jdforrester-WMF removed a subtask: T248040: Scap plugins in operations/mediawiki-config don't pass tox, so CI is disabled.Mar 19 2020, 12:15 AM

Jdforrester-WMF closed subtask T248010: Vector sidebar missing on test.wikipedia.org and weird footer as Resolved.

Change 581133 merged by 20after4:
[operations/mediawiki-config@master] group0 wikis to 1.35.0-wmf.24 refs T233872

https://gerrit.wikimedia.org/r/581133

Mentioned in SAL (#wikimedia-operations) [2020-03-19T00:39:46Z] <twentyafterfour@deploy1001> rebuilt and synchronized wikiversions files: group0 wikiws to 1.35.0-wmf.24 refs T233872

Catrope added a subtask: T248049: wgNewUserMsgRevisionId (in JavaScript) is no longer set when the user has a new message.Mar 19 2020, 3:27 AM

Ladsgroup closed subtask T247566: Broken section edit links styles on Vector as Resolved.Mar 19 2020, 10:28 AM

hashar closed subtask T248049: wgNewUserMsgRevisionId (in JavaScript) is no longer set when the user has a new message as Resolved.Mar 19 2020, 1:09 PM