Page MenuHomePhabricator
Create Task
Maniphest T234241

[regression-wmf.31] Cannot disable/enable Structured discussion beta feature
Closed, ResolvedPublic
Actions

Description

Note: Before deploying wmf.31 to group 2 (e.g. frwiki wmf.30; check List of wikis with Structured discussion feature) - enabling/disabling Structured discussion worked fine.

On any wiki with wmf.31 (or in enwiki betalabs) - try to enable/disable 'Structured Discussions on user talk' beta feature - it will have no effect on a User talk page.
✅ checked in wmf.4 - not an issue anymore- if a User talk page did not exist before - it won't be created
✅ checked in wmf.4 - not an issue anymore-- (enabling the feature) if a user page was in text format, it won't convert to Structured Discussions format
✅ checked in wmf.4 - not an issue anymore- - (disabling the feature) if a user page was in Structured Discussion format, it won't be converted to the text format.

"Restore all default settings (in all sections)" won't have any effect on an existing Structured discussion User talk page - the db won't have a record of up_property: beta-feature-flow-user-talk-page up_value: 1, but the SD page is still present.

Details

SubjectRepoBranchLines +/-
Import: Avoid unredacted trace in OptInController log warningmediawiki/extensions/Flowmaster+1 -1
Use $originalOptions in UserSaveOptions hookmediawiki/extensions/Flowmaster+3 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Sep 30 2019, 4:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 30 2019, 4:30 PM
Aklapper added a project: Regression.Mar 22 2020, 9:26 PM
Aklapper removed a subscriber: Regression.
Etonkovidova renamed this task from [testwiki wmf.24] Cannot disable Structured discussion to [testwiki wmf.31] Cannot disable/enable Structured discussion .May 6 2020, 1:23 AM
Etonkovidova updated the task description. (Show Details)
Etonkovidova renamed this task from [testwiki wmf.31] Cannot disable/enable Structured discussion to [regression-wmf.31] Cannot disable/enable Structured discussion on group1 wikis.May 6 2020, 9:43 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova renamed this task from [regression-wmf.31] Cannot disable/enable Structured discussion on group1 wikis to [regression-wmf.31] Cannot disable/enable Structured discussion beta feature.May 8 2020, 12:27 AM
Etonkovidova updated the task description. (Show Details)
MMiller_WMF mentioned this in T248309: StructuredDiscussions (Flow): Prevent users from enabling Flow on their user talk page (beta feature).May 11 2020, 5:28 PM
MMiller_WMF subscribed.May 11 2020, 5:30 PM
kostajh added a comment.May 11 2020, 5:36 PM

I suspect it is this type of error that is happening (link to log):

Flow\Import\OptInController::initiateChange failed to enable Flow on 'User talk:...' for user '.... Request to parsoid for "wikitext" to "html" conversion of content connected to title "User_talk:..." failed: 500 #0 /srv/mediawiki/php-1.35.0-wmf.30/extensions/Flow/includes/Conversion/Utils.php(66): Flow\Conversion\Utils::parsoid('wikitext', 'html', '<div style="wid...', Object(Title))
#1 /srv/mediawiki/php-1.35.0-wmf.30/extensions/Flow/includes/Import/TemplateHelper.php(76): Flow\Conversion\Utils::convert('wikitext', 'html', '<div style="wid...', Object(Title))
#2 /srv/mediawiki/php-1.35.0-wmf.30/extensions/Flow/includes/Import/OptInController.php(628): Flow\Import\TemplateHelper::extractTemplates('<div style="wid...', Object(Title))
#3 /srv/mediawiki/php-1.35.0-wmf.30/extensions/Flow/includes/Import/OptInController.php(159): Flow\Import\OptInController->extractTemplatesAboveFirstSection(Object(Title))
#4 /srv/mediawiki/php-1.35.0-wmf.30/extensions/Flow/includes/Import/OptInController.php(118): Flow\Import\OptInController->enable(Object(Title), Object(User))
#5 /srv/mediawiki/php-1.35.0-wmf.30/includes/deferred/MWCallableUpdate.php(38): Flow\Import\OptInController->Flow\Import\{closure}()
#6 /srv/mediawiki/php-1.35.0-wmf.30/includes/deferred/DeferredUpdates.php(417): MWCallableUpdate->doUpdate()
#7 /srv/mediawiki/php-1.35.0-wmf.30/includes/deferred/DeferredUpdates.php(296): DeferredUpdates::attemptUpdate(Object(MWCallableUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti))
#8 /srv/mediawiki/php-1.35.0-wmf.30/includes/deferred/DeferredUpdates.php(233): DeferredUpdates::run(Object(MWCallableUpdate), Object(Wikimedia\Rdbms\LBFactoryMulti), Object(Monolog\Logger), Object(BufferingStatsdDataFactory), 'post')
#9 /srv/mediawiki/php-1.35.0-wmf.30/includes/deferred/DeferredUpdates.php(150): DeferredUpdates::handleUpdateQueue(Array, 'run', 2)
#10 /srv/mediawiki/php-1.35.0-wmf.30/includes/MediaWiki.php(1059): DeferredUpdates::doUpdates('run')
#11 /srv/mediawiki/php-1.35.0-wmf.30/includes/MediaWiki.php(839): MediaWiki->restInPeace()
#12 /srv/mediawiki/php-1.35.0-wmf.30/includes/MediaWiki.php(848): MediaWiki->{closure}()
#13 /srv/mediawiki/php-1.35.0-wmf.30/includes/MediaWiki.php(574): MediaWiki->doPostOutputShutdown()
#14 /srv/mediawiki/php-1.35.0-wmf.30/index.php(47): MediaWiki->run()
#15 /srv/mediawiki/w/index.php(3): require('/srv/mediawiki/...')
#16 {main}
kostajh added a project: Parsoid.May 11 2020, 5:37 PM
kostajh added a project: Wikimedia-production-error.May 11 2020, 6:20 PM
ssastry subscribed.May 11 2020, 6:33 PM

The failing page reported in the log is https://zh.wikipedia.org/wiki/User_talk:Zorua_Fox

Tgr subscribed.May 11 2020, 8:03 PM
ssastry added a comment.May 11 2020, 8:37 PM

So, the page renders just fine with Parsoid.

ssastry@scandium:/srv/parsoid-testing$ curl -x scandium.eqiad.wmnet:80 http://zh.wikipedia.org/w/rest.php/zh.wikipedia.org/v3/page/html/User_talk:Zorua_Fox/59594079
<!DOCTYPE html>
...
...</html>

ssastry@scandium:/srv/parsoid-testing$ sudo -u www-data php /srv/mediawiki/multiversion/MWScript.php /srv/parsoid-testing/bin/parse.php --wiki=zhwiki --integrated --pageName 'User_talk:Zorua_Fox' < /dev/null
<!DOCTYPE html>
...
...</html>

@kostajh do you have a more specific error message? Or maybe this is a crasher in Flow code if it is trying to process this DOM in some way?

ssastry moved this task from Needs Triage to Non-Parsing-Team Tasks on the Parsoid board.May 11 2020, 8:40 PM
Tgr added a comment.May 11 2020, 8:44 PM

Looking at the code, there should be another log event with the details of the Parsoid error, but I don't see anything like that in Logstash. Maybe some log level needs to be changed?

ssastry added a comment.May 13 2020, 4:13 PM
In T234241#6125828, @kostajh wrote:

I suspect it is this type of error that is happening (link to log):

Flow\Import\OptInController::initiateChange failed to enable Flow on 'User talk:...' for user '.... Request to parsoid for "wikitext" to "html" conversion of content connected to title "User_talk:..." failed: 500 #0 /srv/mediawiki/php-1.35.0-wmf.30/extensions/Flow/includes/Conversion/Utils.php(66): Flow\Conversion\Utils::parsoid('wikitext', 'html', '<div style="wid...', Object(Title))

This could be the same as T252648: Publishing a translation fails with Error converting HTML to wikitext: docserver-http: HTTP 500: {"type":"https://mediawiki.org/wiki/HyperSwitch/errors/unknown_error. In any case as @Tgr said in the previous comment, worth fixing logging so the details aren't lost since that is what helped me quickly fix the problem. But, we should also look on the Parsoid end why this didn't get logged under the Parsoid channel.

kostajh added a comment.May 18 2020, 5:43 PM

Seems like last instance of this was on May 10: https://logstash.wikimedia.org/goto/96946a8d8b317a00ff9cbeb8c1a5caba

MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.May 18 2020, 9:54 PM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

The Growth team will consider working on this next week.

Catrope mentioned this in T253144: Homepage - old accounts do not have Mentorship module .May 19 2020, 7:06 PM
Catrope mentioned this in T253149: Regression: UserSaveOptions hook no longer exposes old preference values.May 19 2020, 7:32 PM
Catrope added a parent task: T253149: Regression: UserSaveOptions hook no longer exposes old preference values.May 19 2020, 7:35 PM
MMiller_WMF moved this task from Ready for Development to QA on the Growth-Team (Sprint 0 (Growth Team)) board.May 25 2020, 5:18 PM

Since the issue is upstream in T253149: Regression: UserSaveOptions hook no longer exposes old preference values, we will move this straight to QA for @Etonkovidova to check when the upstream issue is fixed.

thcipriani moved this task from Untriaged to May 2020 on the Wikimedia-production-error board.May 27 2020, 6:51 PM
gerritbot added a comment.May 28 2020, 4:28 PM

Change 599377 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Flow@master] Use $originalOptions in UserSaveOptions hook

https://gerrit.wikimedia.org/r/599377

gerritbot added a project: Patch-For-Review.May 28 2020, 4:28 PM
gerritbot added a comment.May 28 2020, 5:34 PM

Change 599377 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use $originalOptions in UserSaveOptions hook

https://gerrit.wikimedia.org/r/599377

Maintenance_bot removed a project: Patch-For-Review.May 28 2020, 6:11 PM
Etonkovidova added a comment.Jul 10 2020, 7:16 PM

So far, testing on testwiki and cawiki showed

  • enabling Structured Discussion is fine
  • disabling Structured discussion still not possible
MMiller_WMF added a comment.Jul 13 2020, 11:39 PM

@Etonkovidova -- so you're saying something is still wrong here?

@Catrope -- can you help us understand what's going on?

Etonkovidova added a comment.EditedJul 25 2020, 12:53 AM
In T234241#6303008, @MMiller_WMF wrote:

@Etonkovidova -- so you're saying something is still wrong here?

@Catrope -- can you help us understand what's going on?

I did some additional testing

Initial state User talk pageUser actionAfter User action switches to SDAfter User action switches to wikitext-basedResult
User - default wikitext-basedvisits wikitext-based User talk pageYesNA✅
User - wikitext-basedposts content on wikitext-based User talk pageYesNA✅
User - SDposts content on SD User talk pageNAYes❌

Here is the description of the above use cases:
Case 1 (Correct behavior) - users who never had User talk page - the User talk page is not existent.

  • a user enables SD in Beta features
  • visits the User talk page -sees SD page - not posting anything there, decides to switch back to wikitext User talk page
  • disables SD beta feature - goes to User talk page - User talk page is wikitext-based page (not SD)

Case 2 (Incorrect behavior) - users who decide to disable SD after having some content posted on it.

  • a user with wikitext-based User talk page posts some content
  • decided to switch to SD
  • the enabling SD is successful - a user posts some content
  • decided to switch back to the wkitext-based User talk
  • cannot disable SD

Taking into account that there were no complaints since switching between formats for User talk pages with content should be extremely rare, I'm moving the ticket off the Current sprint board to Revisit.

Etonkovidova moved this task from Sprint 0 (Growth Team) to Revisit on the Growth-Team board.Jul 25 2020, 12:54 AM
Etonkovidova edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).
ssastry removed a project: Parsoid.Aug 10 2020, 10:11 PM
Krinkle closed this task as Resolved.Apr 1 2021, 7:10 PM
Krinkle subscribed.

No matches for type:mediawiki AND message:"failed to enable Flow on" in the past 90 days (under any channel or mesage level).

gerritbot added a comment.Apr 1 2021, 7:16 PM

Change 676440 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/extensions/Flow@master] Import: Avoid unredacted trace in OptInController log warning

https://gerrit.wikimedia.org/r/676440

gerritbot added a project: Patch-For-Review.Apr 1 2021, 7:16 PM
Krinkle reopened this task as Open.Apr 1 2021, 7:16 PM

I was wrong. Logstash got two queried confused. The results only appeared after I submitted the next query without this search.

Stil seen a couple times a day most days.

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
gerritbot added a comment.Apr 15 2021, 10:40 PM

Change 676440 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Import: Avoid unredacted trace in OptInController log warning

https://gerrit.wikimedia.org/r/676440

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 15 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 15 2021, 11:10 PM
Krinkle updated the task description. (Show Details)Jun 11 2021, 8:40 PM
Tgr mentioned this in T265534: Flow - initiateChange failed to enable Flow on User talk page.Aug 24 2021, 3:38 AM
kostajh mentioned this in T291116: Error: Call to a member function getContent() on null.Sep 15 2021, 6:45 PM
Krinkle moved this task from May 2020 to Older on the Wikimedia-production-error board.Sep 20 2021, 9:40 PM
Trizek-WMF mentioned this in T351257: Lift off the technical blockers for actions offered in communities messaging.Nov 14 2023, 8:33 PM
Etonkovidova updated the task description. (Show Details)Nov 14 2023, 9:44 PM
Etonkovidova added a subscriber: KStoller-WMF.Nov 14 2023, 9:58 PM

@KStoller-WMF - re-checked in cawiki wmf.4 - seems to be working as expected.

The task description is updated with testing results. The major points of testing 1) a user may enable/disable the preference 2) a user won't loose the previous content of their User talk pages.

The following scenarios worked as expected:
(1) a new user enables Structured discussion beta feature, adds some content and then disables Structured discussion beta .

  • the page format will be changed accordingly; the to link the archived Flow page will be provided

(2) a user with enabled Structured discussion beta feature and some content on the page, disables Structured discussion beta

  • (the same as for the above user) the page format will be changed accordingly; to link the archived Flow page will be provided

(3) a user with the text (not Flow format) on their user talk page switches to Flow

  • the page format will be changed accordingly; the previous, plain text talk page will be referred as a red link

Screen Shot 2023-11-14 at 1.56.52 PM.png (636×2 px, 135 KB)

If a user disables Flow after seeing this, the plain text talk page content will be restored.
I think it's an acceptable behavior at this point.

KStoller-WMF closed this task as Resolved.Nov 14 2023, 10:05 PM
KStoller-WMF assigned this task to Etonkovidova.
KStoller-WMF edited projects, added Growth-Team (Sprint 3 (Growth Team)); removed Growth-Team.
KStoller-WMF moved this task from Incoming to QA on the Growth-Team (Sprint 3 (Growth Team)) board.

Thanks for testing! It sounds like we can mark this as resolved then?
Please feel free to reopen if needed.

Trizek-WMF added a parent task: T351257: Lift off the technical blockers for actions offered in communities messaging.Nov 29 2023, 3:35 PM
Trizek-WMF mentioned this in T352550: Deactivating Flow using the Beta feature makes the talk page inaccessible - Flow\Exception\InvalidDataException.Dec 1 2023, 3:29 PM
Trizek-WMF subscribed.Dec 1 2023, 6:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL