Page MenuHomePhabricator
Create Task
Maniphest T294739

remove configuration access via global variables in core
Open, MediumPublic
Actions

Description

Configuration variables should never be accessed as global variables. Ideally, configuration is injected, individually or via a ServiceOptions instance or as a Config object. Where injection is not currently possible, configuration needs to be accessed via the main Config object obtained from the global service container: MediaWikiServices::getInstance()->getMainConfig()->get( 'SomeOption' ).

Details

Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT294739 remove configuration access via global variables in core
 OpenNoneT71084 Convert things to use Config classes instead of globals
 OpenFeatureNoneT62522 Use Config class rather than explicit globals in GuidedTour
 OpenFeatureNoneT62521 Use Config class rather than explicit globals in GettingStarted
 OpenNoneT72632 Convert ApiQueryExtLinksUsage to use Config instead of globals
 OpenNoneT72637 Special:Userlogin: Use Config instead of globals
 ResolvedTgrT110277 Rewrite Special:UserLogin (and signup) and Special:UserLogout to use AuthManager
 ResolvedAnomieT91699 Create AuthManager framework and core classes
 ResolvedJoeT97675 Custom session handler corrupted by session_destroy, "Failed to initialize storage module"
 ResolvedJoeT106483 Create new HHVM package for HHVM 3.6.5 + patches
 ResolvedhasharT106699 Upgrade HHVM related packages on Trusty Jenkins slaves
 Resolvedbd808T95864 Mocking abstract objects fails on HHVM
 ResolvedAnomieT110274 Fix PHPUnit version incompatibility between AuthManager and Jenkins
 ResolvedKrinkleT99982 Upgrade PHPUnit to 4.0+
 ResolvedNoneT90303 Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches
 ResolvedJanZerebeckiT106433 replace inline perl in builder wd-mw-composer-merged-install with a proper script
 ResolvedKrinkleT112895 Support installing composer require-dev packages together with mediawiki/vendor
 ResolvedTgrT110628 Improve AuthManager documentation
 ResolvedxSavitarT72638 Special:Version: Use Config instead of globals
 OpenNoneT72673 Convert maintenance scripts to use Config instead of globals
 ResolvedTchandersT71087 Special:Block: Use Config instead of globals
 ResolvedNoneT71086 Use Config object instead of globals in GoogleLogin
 ResolvedFlorianT71188 SpecialUpload: Use Config instead of globals
 ResolvedFlorianT71187 SpecialRunJobs: Use Config instead of globals
 ResolvedNoneT71256 SpecialPageFactory: Use Config instead of globals
 OpenFeatureNoneT71338 Migrate Setup.php to use Config instead of globals
 OpenNoneT99537 Message.php should accept a Config object
 ResolvedJdforrester-WMFT344397 Use Config class rather than explicit globals in MassMessage
 OpenNoneT297797 Fix unit tests that test methods that use globals
 OpenSimetricalT305093 Move dynamic configuration defaults out of Setup.php
 OpenNoneT313840 Replace need and use of $wgInitialSessionId
 OpenNoneT313841 Replace need and use of $wgCommandLineMode

Event Timeline

daniel created this task.Nov 1 2021, 10:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2021, 10:50 AM
Mainframe98 added a subtask: T71084: Convert things to use Config classes instead of globals.Nov 2 2021, 4:38 PM
• Pchelolo assigned this task to tchin.Nov 16 2021, 7:02 PM
daniel moved this task from Todo to Doing on the MediaWiki-SettingsBuilder board.Dec 1 2021, 2:32 PM
Reedy updated the task description. (Show Details)Dec 20 2021, 1:59 PM
tchin added a comment.Jan 12 2022, 4:41 PM

Forgot to link the patch that replaces most of the easily replaceable ones. T297797 lists places where it wasn't easily removable.

daniel removed tchin as the assignee of this task.Jan 26 2022, 11:48 AM
daniel moved this task from Doing to Todo on the MediaWiki-SettingsBuilder board.
daniel added a subscriber: tchin.
daniel added a comment.Jan 26 2022, 11:55 AM

Status: Thomas' patch addressed many places where global variables were used to access configuration variables, but there are still quite a few left. Most of the remaining cases either write to the global variable, or the code is executed in a phpunit data provider, which causes any access to the MediawikiServices singleton to trigger warnings.

gerritbot added a comment.Jan 26 2022, 12:02 PM

Change 753991 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] SettingsBuilder: allow maintenance scripts to manipulate config

https://gerrit.wikimedia.org/r/753991

gerritbot added a project: Patch-For-Review.Jan 26 2022, 12:02 PM
daniel triaged this task as Medium priority.Jan 26 2022, 12:11 PM
gerritbot added a comment.Jan 26 2022, 3:20 PM

Change 753991 merged by jenkins-bot:

[mediawiki/core@master] SettingsBuilder: allow maintenance scripts to manipulate config

https://gerrit.wikimedia.org/r/753991

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2022, 4:11 PM
gerritbot added a comment.Jan 28 2022, 7:32 PM

Change 757960 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Remove access to config globals from includes/debug/logger

https://gerrit.wikimedia.org/r/757960

gerritbot added a project: Patch-For-Review.Jan 28 2022, 7:32 PM

Change 757961 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Remove access to config globals from includes/exception

https://gerrit.wikimedia.org/r/757961

gerritbot added a comment.Jan 28 2022, 7:39 PM

Change 757963 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] remove access to config globals from includes/parser

https://gerrit.wikimedia.org/r/757963

gerritbot added a comment.Jan 28 2022, 7:41 PM

Change 757965 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] remove access to config globals from Title

https://gerrit.wikimedia.org/r/757965

gerritbot added a comment.Jan 28 2022, 7:43 PM

Change 757966 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] remove access to config globals from FauxResponse

https://gerrit.wikimedia.org/r/757966

gerritbot added a comment.Jan 28 2022, 7:46 PM

Change 757967 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] remove access to config globals from more classes

https://gerrit.wikimedia.org/r/757967

matej_suchanek updated the task description. (Show Details)Jan 31 2022, 9:43 AM
gerritbot added a comment.Jan 31 2022, 4:16 PM

Change 757966 merged by jenkins-bot:

[mediawiki/core@master] remove access to config globals from FauxResponse

https://gerrit.wikimedia.org/r/757966

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 31 2022, 5:00 PM
gerritbot added a comment.Feb 1 2022, 4:27 PM

Change 757963 merged by jenkins-bot:

[mediawiki/core@master] remove access to config globals from includes/parser

https://gerrit.wikimedia.org/r/757963

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.21; 2022-02-07); removed MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Feb 1 2022, 5:00 PM
gerritbot added a comment.Feb 20 2022, 8:28 PM

Change 763956 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Pass SettingsBuilder into config callbacks.

https://gerrit.wikimedia.org/r/763956

gerritbot added a comment.Feb 21 2022, 10:47 PM

Change 764448 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] Split default variable initialization out of Setup.php

https://gerrit.wikimedia.org/r/764448

gerritbot added a comment.Feb 22 2022, 4:28 PM

Change 763956 merged by jenkins-bot:

[mediawiki/core@master] Pass SettingsBuilder into config callbacks.

https://gerrit.wikimedia.org/r/763956

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.24; 2022-02-28); removed MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 22 2022, 5:00 PM
Daimona added a subscriber: Daimona.Apr 5 2022, 3:06 PM
Mainframe98 added a subscriber: Mainframe98.Apr 10 2022, 5:57 PM
gerritbot added a comment.Apr 27 2022, 12:13 PM

Change 764448 abandoned by Simetrical:

[mediawiki/core@master] Split default variable initialization out of Setup.php

Reason:

This was landed elsewhere: I931b92357ec48db4665891c8546f86264885e881

https://gerrit.wikimedia.org/r/764448

gerritbot added a comment.Apr 28 2022, 4:22 PM

Change 787531 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/FileImporter@master] Replace MediaWikiTitleCodec with TitleParser mock

https://gerrit.wikimedia.org/r/787531

gerritbot added a comment.Apr 28 2022, 6:03 PM

Change 787531 merged by jenkins-bot:

[mediawiki/extensions/FileImporter@master] Replace MediaWikiTitleCodec with TitleParser mock

https://gerrit.wikimedia.org/r/787531

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).Apr 28 2022, 7:00 PM
gerritbot added a comment.Apr 29 2022, 11:54 AM

Change 757967 merged by jenkins-bot:

[mediawiki/core@master] Remove access to config globals from more classes

https://gerrit.wikimedia.org/r/757967

gerritbot added a comment.Apr 29 2022, 6:08 PM

Change 787798 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] config: Do not get wgInitialSessionId and wgCommandLineMode from config

https://gerrit.wikimedia.org/r/787798

gerritbot added a comment.May 16 2022, 1:47 AM

Change 757961 merged by jenkins-bot:

[mediawiki/core@master] Remove access to config globals from includes/exception

https://gerrit.wikimedia.org/r/757961

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.10; 2022-05-02).May 17 2022, 6:00 AM
gerritbot added a comment.Jun 17 2022, 4:04 PM

Change 806436 had a related patch set uploaded (by Daniel Kinzler; author: Daniel Kinzler):

[mediawiki/core@master] PHPUnit: introduce overrideConfigValues.

https://gerrit.wikimedia.org/r/806436

gerritbot added a comment.Jun 23 2022, 9:35 AM

Change 806436 merged by jenkins-bot:

[mediawiki/core@master] PHPUnit: introduce overrideConfigValues.

https://gerrit.wikimedia.org/r/806436

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.18; 2022-06-27); removed MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).Jun 23 2022, 10:00 AM
Umherirrender added a subtask: T313840: Replace need and use of $wgInitialSessionId.Jul 26 2022, 6:42 PM
Umherirrender added a subtask: T313841: Replace need and use of $wgCommandLineMode.
gerritbot added a comment.Jul 26 2022, 6:45 PM

Change 787798 abandoned by Umherirrender:

[mediawiki/core@master] config: Do not get wgInitialSessionId and wgCommandLineMode from config

Reason:

I just want to avoid the access, not the globals.

https://gerrit.wikimedia.org/r/787798

gerritbot added a comment.Jan 11 2023, 12:33 PM

Change 878198 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/MobileFrontend@master] tests: Move away from using $GLOBALS for configs

https://gerrit.wikimedia.org/r/878198

gerritbot added a comment.Jan 11 2023, 6:15 PM

Change 878198 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] tests: Move away from using $GLOBALS for configs

https://gerrit.wikimedia.org/r/878198

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL