Aside from the UI changes, we would have to:

• update the handling of the user preference where we store the user's selected topics (currently as a simple list)
• update the task search API which again takes a list of topic names
• likewise, update the SearchSuggester and TaskSetFilters
• update SearchStrategy and SearchQuery which take Topic objects
• update the various bits involved in logging topic scores (Topic, HomepageHooks, GrowthTasksApi.js etc). Or maybe just discard topic score logging, we never used it.

It's a fair amount of footwork; for the object-oriented bits we could probably introduce an IntersectionTopic class, for the API we can just use a new parameter. SearchSuggester seems the least straightforward. Maybe it should take a TaskSetFilters or similar object instead of the two arrays.

Do we intend to enable the “switch logic ANY/ALL” feature for all GE users now or in the future? Or we only want to show this option to users participating in campaigns? @RHo @MMiller_WMF

In T301825#7742056, @Sgs wrote:

Do we intend to enable the “switch logic ANY/ALL” feature for all GE users now or in the future? Or we only want to show this option to users participating in campaigns? @RHo @MMiller_WMF

Hi @Sgs for now it is a stretch goal for the campaigns, but that may change in future.

Change 767503 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: change TaskSuggester::suggest() signature to take a TaskSetFilters object

https://gerrit.wikimedia.org/r/767503

Change 767504 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Newcomer tasks: add topic match mode parameter for filtering

https://gerrit.wikimedia.org/r/767504

Change 769024 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Suggested edits: add topic match mode widget selector

https://gerrit.wikimedia.org/r/769024

Change 767503 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: change TaskSuggester::suggest() signature to take a TaskSetFilters object

https://gerrit.wikimedia.org/r/767503

Change 767504 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: add topic match mode parameter for filtering

https://gerrit.wikimedia.org/r/767504

@MShilova_WMF We might want to set a deadline for March 28, because we want all code to ride the train (well, there is trainsperiment week) to be in production before April 1.

One thing I came across and it's not clear to me is if we want to enable the "AND selector" in the on-boarding dialog. On one side it would make the experience consistent with what users will find in the filters dialog in the homepage. On the other side it might slow down the on-boarding experience by adding some more entropy to the interface. What should we do in this situation? @RHo

In T301825#7781228, @Sgs wrote:

One thing I came across and it's not clear to me is if we want to enable the "AND selector" in the on-boarding dialog. On one side it would make the experience consistent with what users will find in the filters dialog in the homepage. On the other side it might slow down the on-boarding experience by adding some more entropy to the interface. What should we do in this situation? @RHo

Hi @Sgs, thanks for raising that point about onboarding. For the purposes of having this initially for the GLAM events, I think we can leave it off since the event participants should be pre-onboarded after sign-up and not see the onboarding. @Etonkovidova please confirm if this is the case?

In T301825#7781521, @RHo wrote:

Hi @Sgs, thanks for raising that point about onboarding. For the purposes of having this initially for the GLAM events, I think we can leave it off since the event participants should be pre-onboarded after sign-up and not see the onboarding. @Etonkovidova please confirm if this is the case?

I agree it is fine behavior to leave it off for now. Not sure what you mean by pre-onboarded here, could you clarify? My understanding is that GLAM campaign account created users will still get the "start editing" step in their homepage on the desktop experience (see screenshot). The only differences with regular accounts is that the image recommendation variant is enforced and that campaign specific topics are shown.

In T301825#7781796, @Sgs wrote:

In T301825#7781521, @RHo wrote:

Hi @Sgs, thanks for raising that point about onboarding. For the purposes of having this initially for the GLAM events, I think we can leave it off since the event participants should be pre-onboarded after sign-up and not see the onboarding. @Etonkovidova please confirm if this is the case?

I agree it is fine behavior to leave it off for now. Not sure what you mean by pre-onboarded here, could you clarify? My understanding is that GLAM campaign account created users will still get the "start editing" step in their homepage on the desktop experience (see screenshot). The only differences with regular accounts is that the image recommendation variant is enforced and that campaign specific topics are shown.

Ahhh by "pre-onboarded" I meant my (incorrect) impression was that the GLAM events folks would not get the onboarding step. In that case I do think it could be worth adding here, since people might not realise this ability to toggle the selection between ANY/ALL exists if it is only in the filters. However, it is fine to leave off if this adds development work that could delay this being ready in time for the last events.

Change 769024 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] GLAM events: add topic match mode widget selector

https://gerrit.wikimedia.org/r/769024

Change 772031 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[schemas/event/secondary@master] Homepage module: add events for topic toggle match mode button

https://gerrit.wikimedia.org/r/772031

Change 772036 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: log events for topic match mode toggle button

https://gerrit.wikimedia.org/r/772036

The changes are now ready for review. The ANY/ALL toggle button will automatically appear for users creating their accounts through growth-glam-2022 campaigns. Prior campaign users will also get it. In case we want to test this in production without creating an extra account there's a "special" campaign name (test-topics-AND) that will enable it. It can be set running the following snippet in the browser Javascript console:

new mw.Api().saveOption('growthexperiments-campaign', 'test-topics-AND');

The match mode selector should appear after reloading the page.

For the analytics logging we've added:

• se-topicfilter-toggle-impression in the start editing dialog and the topics filter dialog when topics matching is enabled.
• se-topicfilter-toggle-and and se-topicfilter-toggle-or events for tracking user toggle selections.

See comment below with updated analytics implementation details.

I think the current status quo is we log the impressions of the topic selection in the start editing dialog with the event se-cta-click:

- se-cta-click: User starts the suggested edits
onboarding/activation process (by clicking on the StartEditing
module button in variant A, or the welcome notice button or info
icon in variant C).

And after the on-boarding we log impressions of showing the topic filter dialog with the event se-topicfilter-open and then topic selection actions with se-topicfilter-select-all and every topic toggling triggers a se-fetch-tasks event.

For the new interface we have added:

• se-topicmatchmode-impression in the start editing dialog and the topics filter dialog when topics matching is enabled.
• se-topicmatchmode-and and se-topicmatchmode-or events for tracking user changes in the mode selection.
• se-fetch-tasks and all events above will contain topicsMatchMode=AND or topicsMatchMode=OR inside its action_data

@nettrom_WMF could you confirm this setup suits our analytics well or if you prefer other event organization or naming?

Change 772031 merged by jenkins-bot:

[schemas/event/secondary@master] Homepage module: add events for topic toggle match mode button

https://gerrit.wikimedia.org/r/772031

Change 772870 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[operations/mediawiki-config@master] beta, testwiki: enable testing of topics match mode for GLAM events

https://gerrit.wikimedia.org/r/772870

Change 772870 merged by jenkins-bot:

[operations/mediawiki-config@master] beta, testwiki: enable testing of topics match mode for GLAM events

https://gerrit.wikimedia.org/r/772870

Mentioned in SAL (#wikimedia-operations) [2022-03-22T20:29:47Z] <urbanecm@deploy1002> Synchronized wmf-config/InitialiseSettings.php: ce18d4eeb255349e27163d5e5472fbe21c320322: testwiki: enable testing of topics match mode for GLAM events (T301825) (duration: 01m 06s)

In T301825#7793893, @Sgs wrote:

For the new interface we have added:

• se-topicmatchmode-impression in the start editing dialog and the topics filter dialog when topics matching is enabled.
• se-topicmatchmode-and and se-topicmatchmode-or events for tracking user changes in the mode selection.
• se-fetch-tasks and all events above will contain topicsMatchMode=AND or topicsMatchMode=OR inside its action_data

@nettrom_WMF could you confirm this setup suits our analytics well or if you prefer other event organization or naming?

From what I can tell, we'll be looking at usage of this feature and for that we have sufficient instrumentation to understand that. It's also good that we have this logged in se-fetch-tasks events, as one place we might want to look would be at lack of tasks for certain combinations of topics. We haven't done a lot of analysis of topics, apart from when the feature was first added in Newcomer Tasks v1.1, so I'm basing this a bit on that and a bit on what we'll generally be interested in.

In summary: looks good to me!

Change 772036 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] GLAM events: add topic match mode widget selector

Reason:

Abandon in favour of squashed version https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/769024

https://gerrit.wikimedia.org/r/772036

Change 769024 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] GLAM events: add topic match mode widget selector

https://gerrit.wikimedia.org/r/769024

In T301825#7798417, @nettrom_WMF wrote:

From what I can tell, we'll be looking at usage of this feature and for that we have sufficient instrumentation to understand that. It's also good that we have this logged in se-fetch-tasks events, as one place we might want to look would be at lack of tasks for certain combinations of topics. We haven't done a lot of analysis of topics, apart from when the feature was first added in Newcomer Tasks v1.1, so I'm basing this a bit on that and a bit on what we'll generally be interested in.

In summary: looks good to me!

Thanks for checking @nettrom_WMF. We can improve logging for topics and filters if we decide to analyze these deeper in the future.

For @RHo review - if there are no follow-up, please move to Test in Production|Watching column.
(1) The functionality is in place - checked on cswiki betalabs with ge.utils.enableCampaign(). The filters combinations that show the tasks for AND with *the *Add image** tasks: e.g., Africa+Asia, Asia+Europe. GLAM Argentina +Asia.

(2)
Desktop:

- "Choose "Match ALL"..." never fits on one line

Mobile

- The mockup has italic for "Choose "Match ALL..."		- "GLAM Argentina" never fits enough to display "+" (except on a tablet)

Thanks @Etonkovidova! I have replied to your notes below. @Sgs, I also have added a couple of minor visual design tweaks that wonder if can be done as part of this task? However, if there is a hard deadline for the campaign then I'm happy to move this to Test in Production and file a separate follow up task instead.

In T301825#7804689, @Etonkovidova wrote:

For @RHo review - if there are no follow-up, please move to Test in Production|Watching column.
(1) The functionality is in place - checked on cswiki betalabs with ge.utils.enableCampaign(). The filters combinations that show the tasks for AND with *the *Add image tasks: e.g., Africa+Asia, Asia+Europe. GLAM Argentina +Asia.
(2)
Desktop:**

- "Choose "Match ALL"..." never fits on one line

Ah yes, this is true. I did also try to google translate how this might look in Spanish and it overflows even more:

Mobile

- The mockup has italic for "Choose "Match ALL..."		- "GLAM Argentina" never fits enough to display "+" (except on a tablet)

Sorry, that is a mocko, the implementation without italics on both mobile and desktop is fine. Also fine with the "+" not being shown if the label is too long.
However, @Sgs I have the same request to reduce the size of the "Choose 'MATCH ALL..." text to be font-size 0.9em / 14.4px if that is possible?

Change 774412 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: add spanish translations for topic match mode feature

https://gerrit.wikimedia.org/r/774412

Change 774413 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: wrap description text in a new line * Make description text appear in a new line when the button group labels leave less than a 60% fo space to the text container * Adapt font-sizes per design requirements

https://gerrit.wikimedia.org/r/774413

Change 774412 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: add spanish translations for topic match mode feature

Reason:

https://gerrit.wikimedia.org/r/774412

Change 774413 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: wrap description text in a new line

https://gerrit.wikimedia.org/r/774413

Change 774405 had a related patch set uploaded (by Kosta Harlan; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.4] GLAM events: add topic match mode widget selector

https://gerrit.wikimedia.org/r/774405

Change 774405 abandoned by Kosta Harlan:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.4] GLAM events: add topic match mode widget selector

Reason:

too complicated to backport; going to let this ride the train

https://gerrit.wikimedia.org/r/774405

Change 774879 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: always align button and text to the right

https://gerrit.wikimedia.org/r/774879

This can now be tested in testwiki by enabling the GLAM campaign for the logged in user with ge.utils.enableCampaign() or by creating a new account through the GLAM campaign URL.

@RHo in case you do a second round of review, you will find another style issue in the mobile version. There's a fix but might not get in time for the first version. I'll check with Kosta see if it is worth backporting.

Mobile bug	Fixed

Change 774879 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Newcomer tasks: always align button and text to the right

https://gerrit.wikimedia.org/r/774879

In T301825#7814012, @Sgs wrote:

This can now be tested in testwiki by enabling the GLAM campaign for the logged in user with ge.utils.enableCampaign() or by creating a new account through the GLAM campaign URL.

@RHo in case you do a second round of review, you will find another style issue in the mobile version. There's a fix but might not get in time for the first version. I'll check with Kosta see if it is worth backporting.

Mobile bug	Fixed

Awesome, thanks for making the changes so briskly @Sgs!

Some suggestions after speaking to our content writer:

• Short term:
  • Simplify the introduction text. Remove the explanation under the "Choose some topics..." header
  • Refer to the the topics as "topics". At the moment the modal title is "Select interests" and inside we refer to the tags as topics/interest topics.
  • Make it clearer what the user is doing and what "we" the system is doing. The instructions should be for the user as they should "choose topics", which is why simplifying it would be to remove the part about what "we" will do.

• Long term: Reduce competition and confusion about what the user needs to do vs what it optional by using a dropdown instead of the button toggle - see example below:

Concerning wording, what about:

Matches at least one of the selected topics
Matches all selected topics

It would fit better in a dropdown, and it would be easier for translators and people less comfortable with English as the sentences are much more descriptive.

Change 775371 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.5] Newcomer tasks: always align button and text to the right

https://gerrit.wikimedia.org/r/775371

In T301825#7819249, @RHo wrote:

Some suggestions after speaking to our content writer:

• Short term:
  • Simplify the introduction text. Remove the explanation under the "Choose some topics..." header
  • Refer to the the topics as "topics". At the moment the modal title is "Select interests" and inside we refer to the tags as topics/interest topics.
  • Make it clearer what the user is doing and what "we" the system is doing. The instructions should be for the user as they should "choose topics", which is why simplifying it would be to remove the part about what "we" will do.

• Long term: Reduce competition and confusion about what the user needs to do vs what it optional by using a dropdown instead of the button toggle - see example below:

To clarify, these suggestions have been moved to a new task T305097: Newcomer tasks: Copy and UI improvements the AND selection of interest topics for future improvements (including @Trizek-WMF 's suggested text for the dropdown above), this task can go into Test in Production.

Change 775784 had a related patch set uploaded (by Sergio Gimeno; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.5] Post-edit dialog: check for presence of preferences.topicFilters

https://gerrit.wikimedia.org/r/775784

Change 775784 abandoned by Sergio Gimeno:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.5] Post-edit dialog: check for presence of preferences.topicFilters

Reason:

no need for squashed change

https://gerrit.wikimedia.org/r/775784

Change 775371 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.39.0-wmf.5] Newcomer tasks: always align button and text to the right

https://gerrit.wikimedia.org/r/775371

Mentioned in SAL (#wikimedia-operations) [2022-03-31T20:56:43Z] <thcipriani@deploy1002> Synchronized php-1.39.0-wmf.5/extensions/GrowthExperiments/modules/ext.growthExperiments.Homepage.SuggestedEdits/MatchModeSelectWidget.less: Backport: [[gerrit:775371|Newcomer tasks: always align button and text to the right (T301825)]] (duration: 00m 50s)