Page MenuHomePhabricator
Create Task
Maniphest T302027

Drop VectorLanguageInHeaderTreatmentABTest A/B test configuration flag
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

The code to support an A/B test for showing the language in the header or sidebar, should be removed. It's adding unnecessary code complexity.

TODO

  • Drop VectorLanguageInHeaderTreatmentABTest and associated code.

Details

SubjectRepoBranchLines +/-
Remove VectorLanguage A/B test code (WgVectorLanguageInHeaderTreatmentABTest)mediawiki/skins/Vectormaster+5 -26
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenovasilevaT317884 [EPIC] Vector 2022 post-deployment work
 ResolvedovasilevaT302073 [GOAL] Page Tools available on all wikis
 ResolvedsgrabarczukT302074 Page tools community prototype testing
 ResolvedovasilevaT300673 [Design spike] Consider changes to main menu
 ResolvedJdrewniakT306609 [PageTools] Set up feature flag for page tools menu
 ResolvedMabualruzT306519 [Page Tools] [SPIKE] Move page tools to menu in page toolbar
 ResolvedJdlrobsonT302027 Drop VectorLanguageInHeaderTreatmentABTest A/B test configuration flag
 ResolvedOct 10 2022ovasilevaT317897 [L] [Page Tools] Make the page tools menu pinnable
 ResolvedovasilevaT322051 [L] [Page Tools] Set default for pinnable state
 ResolvedJdlrobsonT324874 [subtask] Drop table of contents A/B test code
 ResolvedovasilevaT317898 [M] [PageTools] Restructure page tools menu contents
 ResolvedNov 7 2022ovasilevaT317899 [L] [PageTools] Convert main menu into a dropdown menu
 DuplicateBUG REPORTJdlrobsonT313611 In vector-2022 the main menu becomes full screen width under 1000px
 ResolvedMabualruzT320927 Create Dropdown and Menu Skin component classes
 ResolvedovasilevaT317900 [PageTools] Make the new main menu pinnable
 OpenNoneT318168 [Page tools] Make sections of the page tools collapsible/expandable
 ResolvedovasilevaT318169 [Page tools] Make page tools menu sticky
 OpenNoneT318435 [Spike] Review behaviour of wiki customization of Sidebar and propose next steps
 OpenNoneT329715 Make sidebar interface control through the MediaWiki:Sidebar
 DeclinedNoneT245734 Consider making the new sidebar sticky/fixed
 Invalid• alexhollender_WMFT247031 Consider making the new sidebar sticky/fixed (discussion archive)
 ResolvedOct 10 2022JdrewniakT318690 [Spike] Page tools: accessibility requirements for Page Tools
ResolvedbwangT319349 [M] [PageTools] Split up Menu.template into separate templates, remove SkinVector::decoratePortletsData from modern Vector
 ResolvedovasilevaT318434 PageTools: Move toolbox from main menu to page tools menu
 ResolvedNoneT311160 Add indicator that appears when TOC & page tools menu have been hidden
 OpenNoneT324280 [Page tools] Leave page tools uncollapsed until 720px (logged-in only)
 ResolvedovasilevaT324878 Pinned and unpinned menus should be instrumented in click tracking with different IDs
 Resolved• alexhollender_WMFT324877 Style the page tools and main menu dropdown feature
 ResolvedovasilevaT326364 All pinned menus should automatically collapse below 1000px
 ResolvedJdlrobsonT327109 Handle case where screen is resized right after pinning a menu
 ResolvedJdrewniakT327718 Increase space between groups in main menu and page tools menu
 InvalidovasilevaT327957 Main menu on Main page on single-language projects (Wikidata, Commons, etc.)
 StalledJdrewniakT328720 Decrease vertical spacing between menu items (main menu, toc, page tools, personal tools)
 ResolvedovasilevaT325020 Ensure focus returns to appropriate when pinnable elements are pinned/unpinned

Event Timeline

Jdlrobson created this task.Feb 17 2022, 8:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2022, 8:37 PM
Jdlrobson mentioned this in T287208: [GOAL, placeholder] Address feature flag technical debt by removing feature flags.Feb 17 2022, 8:37 PM
Jdlrobson added a project: Web-Team-Backlog.
Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.
Jdlrobson moved this task from Incoming to Deployment on the Desktop Improvements (Vector 2022) board.Mar 4 2022, 6:17 PM
ovasileva triaged this task as Medium priority.Mar 15 2022, 1:07 PM
ovasileva moved this task from Not ready to estimate to Current Fiscal Year on the Web-Team-Backlog board.
Jdlrobson moved this task from Needs triage to Vector 2022 (tracking) on the Vector (legacy skin) board.Apr 25 2022, 9:34 PM
Jdlrobson added a parent task: T309972: [Goal] prepare desktop improvements project for further deployment.Jun 6 2022, 10:16 PM
Jdlrobson moved this task from Current Fiscal Year to Not ready to estimate on the Web-Team-Backlog board.Jun 22 2022, 5:48 PM
ovasileva edited projects, added Web-Team-Backlog (Kanbanana-2022-23-Q1); removed Web-Team-Backlog.Sep 12 2022, 11:29 AM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 12 2022, 5:07 PM
Jdlrobson mentioned this in T309972: [Goal] prepare desktop improvements project for further deployment.Sep 12 2022, 7:21 PM
Jdlrobson added a parent task: T302073: [GOAL] Page Tools available on all wikis.Sep 15 2022, 3:49 PM
Jdlrobson updated the task description. (Show Details)Sep 15 2022, 5:13 PM
LGoto set the point value for this task to 2.Sep 15 2022, 5:14 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 21 2022, 8:28 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.Sep 21 2022, 11:15 PM
gerritbot added a comment.Sep 21 2022, 11:15 PM

Change 833862 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Remove VectorLanguage A/B test code (WgVectorLanguageInHeaderTreatmentABTest)

https://gerrit.wikimedia.org/r/833862

gerritbot added a project: Patch-For-Review.Sep 21 2022, 11:15 PM
cjming claimed this task.Sep 22 2022, 5:00 PM
gerritbot added a comment.Sep 26 2022, 11:01 PM

Change 833862 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove VectorLanguage A/B test code (WgVectorLanguageInHeaderTreatmentABTest)

https://gerrit.wikimedia.org/r/833862

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2022, 11:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 27 2022, 12:00 AM
cjming removed cjming as the assignee of this task.Sep 27 2022, 4:10 PM
cjming moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-2022-23-Q1) board.
cjming subscribed.
LGoto assigned this task to • nray.Sep 29 2022, 5:05 PM
ovasileva edited parent tasks, added: T317884: [EPIC] Vector 2022 post-deployment work; removed: T309972: [Goal] prepare desktop improvements project for further deployment.Sep 30 2022, 4:20 PM
• nray closed this task as Resolved.Oct 4 2022, 12:47 AM
• nray reassigned this task from • nray to Jdlrobson.
• nray subscribed.
Jdlrobson merged a task: T290169: [Cleanup] Drop language A/B test code.Dec 9 2022, 8:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL