Page MenuHomePhabricator

Move "Data item" link into In Other Projects section of sidebar
Open, In Progress, MediumPublic5 Estimated Story Points

Description

Problem:
When Wikidata started we added the link to the related Wikidata Item to the toolbox section of the sidebar of the article. Later the In Other Projects Sidebar was developed to show links to all the other Wikimedia projects based on Wikidata's sitelinks. However it does not include a link to Wikidata. We didn't want to duplicate the link. Since the In Other Projects Sidebar wasn't enabled everywhere we didn't want to remove it from the toolbox section either.
Now the In Other Projects Sidebar is enabled on all Wikimedia projects. We should move the Wikidata Item link to the In Other Projects section.

Screenshots:

IronMan.png (1×980 px, 203 KB)

BDD
GIVEN a Wikipedia article
WHEN it is connected to a Wikidata Item
THEN link to the Wikidata Item is added to the In Other Projects section
AND link to the Wikidata Item is not added to the Toolbox section

Technical Notes
The link should retain an id to be identifiable by gadgets and user scripts. Suggested id wb-otherproject-wikibase-item
After the switch, some caching issues may happen. If the new link doesn't appear, you can purge the cache by adding "?action=purge" at the end of the page URL.

Details

Reference
bz64315
SubjectRepoBranchLines +/-
mediawiki/skins/MinervaNeuemaster+59 -1
operations/mediawiki-configmaster+3 -0
operations/mediawiki-configmaster+0 -3
mediawiki/skins/MinervaNeuewmf/1.43.0-wmf.21+0 -8
mediawiki/skins/MinervaNeuemaster+8 -0
mediawiki/skins/MinervaNeuewmf/1.43.0-wmf.20+8 -0
mediawiki/skins/MinervaNeuewmf/1.43.0-wmf.21+8 -0
mediawiki/extensions/Wikibasemaster+80 -13
mediawiki/extensions/Wikibasemaster+46 -8
mediawiki/extensions/Wikibasemaster+138 -26
mediawiki/extensions/Wikibasemaster+9 -6
mediawiki/extensions/Wikibasemaster+59 -138
mediawiki/extensions/Wikibasemaster+59 -135
mediawiki/extensions/Wikibasemaster+3 -3
mediawiki/extensions/Wikibasemaster+3 -3
mediawiki/extensions/Wikibasemaster+2 -5
mediawiki/extensions/Wikibasewmf/1.34.0-wmf.19+59 -138
mediawiki/extensions/Wikibasewmf/1.34.0-wmf.19+5 -2
mediawiki/extensions/Wikibasemaster+5 -2
mediawiki/extensions/Wikibasemaster+3 -3
mediawiki/extensions/Wikibasemaster+3 -3
mediawiki/extensions/Wikibasemaster+135 -59
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 530373 abandoned by Addshore:

[mediawiki/extensions/Wikibase@master] Re-add accesskey and title to Data item link in Other project sidebar

Reason:

Abandoning per "we'll use t-wikibase as back/compat ID for now"

https://gerrit.wikimedia.org/r/530373

Recent discussions of this use with editors (c.f. https://en.wikipedia.org/w/index.php?title=Wikipedia:Requests_for_comment/2020_left_sidebar_update&oldid=960644483#Move_Wikidata_to_%22In_other_projects%22 ) that make use of the link, where the feedback was to keep it in tools. Moving it around sections based on external factors may be confusing.

I'm going to close the related Gerrit changes and flag this up with @Lydia_Pintscher and @Manuel

Change 532363 abandoned by Addshore:

[mediawiki/extensions/Wikibase@master] Reinstate \"Move Data item link outside of sidebar toolbox\"

Reason:

https://gerrit.wikimedia.org/r/532363

I'm going to close the related Gerrit changes and flag this up with @Lydia_Pintscher and @Manuel

Done, and we do still want this so leaving it open

Moving to Investigate to see what happened when this was tried before...

Ifeatu_Nnaobi_WMDE changed the task status from Open to In Progress.Aug 15 2024, 8:49 AM
Ifeatu_Nnaobi_WMDE subscribed.

Change #1063193 had a related patch set uploaded (by Joely Rooke WMDE; author: Joely Rooke WMDE):

[mediawiki/extensions/Wikibase@master] Move Wikibase Data item link to Other Projects sidebar

https://gerrit.wikimedia.org/r/1063193

Change #1063221 had a related patch set uploaded (by Joely Rooke WMDE; author: Joely Rooke WMDE):

[mediawiki/extensions/Wikibase@master] Move Wikibase Data item link to Other Projects sidebar

https://gerrit.wikimedia.org/r/1063221

Change #1063193 abandoned by Joely Rooke WMDE:

[mediawiki/extensions/Wikibase@master] Move Wikibase Data item link to Other Projects sidebar

Reason:

duplicate change

https://gerrit.wikimedia.org/r/1063193

Change #1063221 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move Wikibase Data item link to Other Projects sidebar

https://gerrit.wikimedia.org/r/1063221

For Tech News, it looks like this is ready to re-announce now. Please could someone confirm if this is an accurate description to include, or if it needs tweaks, additions or something different?

Later this week, the location of the "Wikidata item" menu entry within the Tools sidebar, will be moved into the "Other Projects" section. Some wikis have already made this change locally. [ 1 ]

For Tech News, it looks like this is ready to re-announce now. Please could someone confirm if this is an accurate description to include, or if it needs tweaks, additions or something different?

Later this week, the location of the "Wikidata item" menu entry within the Tools sidebar, will be moved into the "Other Projects" section. Some wikis have already made this change locally. [ 1 ]

Sorry, it's not quite ready to announce yet.
We are deploying the code (inactive) this week to the Train, but we will first activate it on a few select Wikis and monitor click-thru behaviour and usage as part of T370045 and watch for bugs.
After a period of (min.) 2 weeks, we will then look at global activation (and announcement to Tech News). I can add to Tech News myself or ping you at that point, if you prefer.

Sounds good, either way. Thanks!

Feedback from hewiki:

  • The Wikidata item from the Mobile version has disappeared (on both mobile/browser and mobile/mobile displays) after the deployment. (screenshot)
  • This can be verified by checking non-pilot wikis such as enwiki/mobile version where the Wikidata item is still visible under the 3-Dot menu (screenshot)
  • To add a little more confusion, if a user has hewiki:Gadget-WikidataTab.js enabled (via Preferences/Gadgets), then a coloured Wikidata-icon will be dispayed within the 3-Dot menu that is correctly linked to the corresponding Wikidata item, but the placement and visibility is a lot to be desired. (screenshot)

Change #1070534 had a related patch set uploaded (by Joely Rooke WMDE; author: Joely Rooke WMDE):

[mediawiki/skins/MinervaNeue@master] Fix missing wikibase link in Minerva sidebar

https://gerrit.wikimedia.org/r/1070534

Change #1070534 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix missing wikibase link in Minerva sidebar

https://gerrit.wikimedia.org/r/1070534

Change #1070878 had a related patch set uploaded (by Joely Rooke WMDE; author: Joely Rooke WMDE):

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.21] Fix missing wikibase link in Minerva sidebar

https://gerrit.wikimedia.org/r/1070878

Change #1070878 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.21] Fix missing wikibase link in Minerva sidebar

https://gerrit.wikimedia.org/r/1070878

Mentioned in SAL (#wikimedia-operations) [2024-09-05T13:39:47Z] <hashar@deploy1003> Started scap sync-world: Backport for [[gerrit:1070878|Fix missing wikibase link in Minerva sidebar (T66315)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-05T13:41:46Z] <hashar@deploy1003> hashar, joelyrookewmde: Backport for [[gerrit:1070878|Fix missing wikibase link in Minerva sidebar (T66315)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-05T13:59:08Z] <hashar@deploy1003> Finished scap sync-world: Backport for [[gerrit:1070878|Fix missing wikibase link in Minerva sidebar (T66315)]] (duration: 19m 21s)

Change #1070953 had a related patch set uploaded (by Joely Rooke WMDE; author: Joely Rooke WMDE):

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.20] Fix missing wikibase link in Minerva sidebar

https://gerrit.wikimedia.org/r/1070953

Change #1070961 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.21] Revert "Fix missing wikibase link in Minerva sidebar"

https://gerrit.wikimedia.org/r/1070961

Change #1070961 merged by Hashar:

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.21] Revert "Fix missing wikibase link in Minerva sidebar"

https://gerrit.wikimedia.org/r/1070961

Mentioned in SAL (#wikimedia-operations) [2024-09-05T14:41:00Z] <hashar@deploy1003> Started scap sync-world: Backport for [[gerrit:1070961|Revert "Fix missing wikibase link in Minerva sidebar" (T66315)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-05T14:43:02Z] <hashar@deploy1003> hashar: Backport for [[gerrit:1070961|Revert "Fix missing wikibase link in Minerva sidebar" (T66315)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Change #1070953 abandoned by Hashar:

[mediawiki/skins/MinervaNeue@wmf/1.43.0-wmf.20] Fix missing wikibase link in Minerva sidebar

Reason:

On wmf.21 that caused:

PHP Notice: Undefined index: id

The wmf.21 patch ends up being rolled back https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1070961

https://gerrit.wikimedia.org/r/1070953

Mentioned in SAL (#wikimedia-operations) [2024-09-05T14:50:28Z] <hashar@deploy1003> Finished scap sync-world: Backport for [[gerrit:1070961|Revert "Fix missing wikibase link in Minerva sidebar" (T66315)]] (duration: 09m 27s)

Change #1071207 had a related patch set uploaded (by Joely Rooke WMDE; author: Joely Rooke WMDE):

[mediawiki/skins/MinervaNeue@master] Fix missing wikibase link in Minerva sidebar

https://gerrit.wikimedia.org/r/1071207

Just to add some narrative to this ticket from a chat with @seanleong-WMDE who is looking at this while @JoelyRooke-WMDE is away.

On Thursday there was an attempt to "hotfix" an issue with the issue:

T66315#10110762

The Wikidata item from the Mobile version has disappeared (on both mobile/browser and mobile/mobile displays) after the deployment.

This was a patch in Minverva:
https://gerrit.wikimedia.org/r/1070534 actually wasn't possible to deploy on Thursday because it resulted in some logspam of the form PHP Notice: Undefined index: id so it was reverted during the backport window.

We now want to unbreak this missing link on these three pilot wikis until we do a proper, better tested fix for the issue.

To unbreak this missing link we'll just turn the feature flag off. There is a patch for this at https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1071566 . We hope to deploy this at 1500 today although there's already a lot in that backport window.

Change #1071566 had a related patch set uploaded (by Jforrester; author: Seanleong-wmde):

[operations/mediawiki-config@master] Revert "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis."

https://gerrit.wikimedia.org/r/1071566

Change #1071566 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis."

https://gerrit.wikimedia.org/r/1071566

Mentioned in SAL (#wikimedia-operations) [2024-09-09T14:05:33Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1071566|Revert "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis." (T66315)]], [[gerrit:1070948|Enable Copyupload-allowed-domains on test2wiki (T356241)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-09T14:08:18Z] <jforrester@deploy1003> seanleong-wmde, jforrester, hnowlan: Backport for [[gerrit:1071566|Revert "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis." (T66315)]], [[gerrit:1070948|Enable Copyupload-allowed-domains on test2wiki (T356241)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-09T14:17:50Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1071566|Revert "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis." (T66315)]], [[gerrit:1070948|Enable Copyupload-allowed-domains on test2wiki (T356241)]] (duration: 12m 16s)

Hi everyone, the change is now reverted after the backport deployment at 1500 today. The following patch https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1071566 was deployed. Thanks.

Tarrow renamed this task from Move "Data item" link outside of sidebar toolbox to Move "Data item" link into Other Projects section of sidebar.Thu, Sep 12, 12:43 PM

The operations config patch for registering this feature flag is here: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1067282

I think gerritbot missed it because the Bug: <ticket> needed a blank line between it and the main message

Change #1071207 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Fix missing wikibase link in Minerva sidebar

https://gerrit.wikimedia.org/r/1071207

seanleong-WMDE renamed this task from Move "Data item" link into Other Projects section of sidebar to Move "Data item" link into In Other Projects section of sidebar.Fri, Sep 13, 7:36 AM

Hi everyone, two new patches have been merged:

  1. Bug fix in patch https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1071207
  2. Additional test coverage in patch https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1073177

We hope to reactivate the feature flag for some pilot wikis at 1500 today. The patch is https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1073428. Thanks.

Change #1073428 had a related patch set uploaded (by Seanleong-wmde; author: Seanleong-wmde):

[operations/mediawiki-config@master] Revert^2 "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis."

https://gerrit.wikimedia.org/r/1073428

Change #1073428 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert^2 "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis."

https://gerrit.wikimedia.org/r/1073428

Mentioned in SAL (#wikimedia-operations) [2024-09-19T14:05:38Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:rOPUP1073428751b1|Revert^2 "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis." (T66315)]]

Mentioned in SAL (#wikimedia-operations) [2024-09-19T14:11:50Z] <lucaswerkmeister-wmde@deploy1003> seanleong-wmde, lucaswerkmeister-wmde: Backport for [[gerrit:rOPUP1073428751b1|Revert^2 "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis." (T66315)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-09-19T14:24:09Z] <lucaswerkmeister-wmde@deploy1003> Finished scap sync-world: Backport for [[gerrit:rOPUP1073428751b1|Revert^2 "Activate feature flag for moving wikibase item to Other Projects sidebar in pilot wikis." (T66315)]] (duration: 18m 31s)

JFYI, Russian Wikipedia already implements this change via https://ru.wikipedia.org/wiki/MediaWiki:Gadget-sidebarRelated.js so if you want to include us in pilot wikis so we can turn off this gadget earlier, I would endorse that.

Would like to point out the specific concerns and negative feedback mentioned at the corresponding talk page:
https://meta.wikimedia.org/wiki/Talk:Wikidata_For_Wikimedia_Projects/Projects/Move_Wikidata_item_link

Maybe, this has not been thought quite through? It is weird to ask for feedback if a decision apparently already has been made?

(I would note that most of the feedback there seems to misunderstand what this change is going to do.)

Since 4 October has passed already, can I ask on what the plan of the deployment is? I would really like to make it so Russian Wikipedia ships less JS code.