Page MenuHomePhabricator

Repackage Minerva's JavaScript code with webpack
Open, Stalled, LowPublic

Description

User Story

To aid the MobileFrontend refactor, we will want to clean up how JavaScript is organised in Minerva.

Currently our modules in Minerva are arranged by feature AND context (e.g. is tablet). We want to arrange them by page (e.g userpage, standard page, special page).

For instance if the user cannot watch a certain page we currently do not load the module skins.minerva.watchstar
After discussing this as a team we concluded that we would prefer to group these by page and move this logic into frontend code. This will mean more JS is loaded by default, but there will be less fragmentation across pages.

Acceptance Criteria

  • Add webpack to Minerva.
  • Add a new entry point to webpack - skins.minerva.page - this should load the code inside skins.minerva.scripts and any Minerva dependencies.
  • Ensure if skins.minerva.scripts is loaded the new entry point skins.minerva.page is loaded so that we do not run into any caching issues.

Sign off steps

  • The remaining work revolves around deprecating the getContextSpecificModules module. Next step would be to create a card to clean that up.

Related Objects

StatusAssignedTask
ResolvedJdlrobson
ResolvedJdlrobson
OpenNone
ResolvedJdlrobson
OpenNone
OpenNone
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedABorbaWMF
OpenJdlrobson
StalledNone
ResolvedJdlrobson
Resolvedphuedx
ResolvedJdlrobson
ResolvedJdlrobson
DuplicateNone
OpenNone
OpenNone
ResolvedJdlrobson
StalledNone
ResolvedJhernandez
ResolvedJdrewniak
Resolvedpmiazga
ResolvedJdrewniak
ResolvedJdlrobson
ResolvedJdrewniak
ResolvedJdlrobson
OpenNone
ResolvedJdlrobson
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedJdlrobson

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 26 2018, 4:37 PM

We discussed this briefly today concluded that it's blocked on a solution to avoid versioning the build artifacts (related discussion for Popups: T158980).

Jdlrobson updated the task description. (Show Details)Mar 26 2018, 6:04 PM
Jdlrobson changed the task status from Open to Stalled.Apr 11 2018, 4:13 PM

Stalled on T158980 but ready to go IMO.

Jdlrobson triaged this task as Low priority.Fri, Aug 2, 6:10 PM