Page MenuHomePhabricator
Create Task
Maniphest T213426

Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle
Closed, ResolvedPublic
Actions

Assigned To
Jdforrester-WMF
Authored By
Esanders
Jan 10 2019, 1:21 PM
Tags
Referenced Files
None
Subscribers
Aklapper
BEANS-X2
Esanders
Galobtter
gerritbot
Jdforrester-WMF
Krinkle
View All 14 Subscribers

Description

Timeline:

Details

SubjectRepoBranchLines +/-
resources: Drop jquery.throttle-debounce, deprecated since 1.33mediawiki/coremaster+1 -263
Replace use of deprecated $.throttle() with mw.util.throttle()mediawiki/extensions/Flowmaster+6 -7
Replace use of deprecated $.debounce() with mw.util.debounce()mediawiki/extensions/CentralNoticemaster+3 -3
Replace use of deprecated $.debounce() with mw.util.debounce()mediawiki/extensions/LiveChatmaster+2 -2
Replace use of deprecated $.throttle() with mw.util.throttle()mediawiki/extensions/GettingStartedmaster+3 -3
Use mw.util.debounce() in collapsibleTabs.jsmediawiki/skins/Metrolookmaster+4 -4
Convert Special:MassMessage to use OOUImediawiki/extensions/MassMessagemaster+187 -136
Remove jquery.throttle-debounce from dependenciesmediawiki/extensions/MassMessagemaster+0 -1
mw.externalguidance.special: replace use of deprecated $.debouncemediawiki/extensions/ExternalGuidancemaster+2 -1
Replace use of deprecated jQuery.debouncemediawiki/extensions/3Dmaster+3 -2
Replace deprecated jQuery.throttle/debouncemediawiki/extensions/Translatemaster+46 -5
Replace deprecated jQuery.throttle/debouncemediawiki/extensions/MultimediaViewermaster+8 -9
mediawiki.page.gallery: Replace use of deprecated $.debounce()mediawiki/coremaster+3 -3
mediawiki.util: Add throttle function, ported from OOUImediawiki/coremaster+40 -0
mediawik.util: Use same debounce implementation as OO.ui.debouncemediawiki/coremaster+99 -22
Replace jquery.debounce with OO.ui.debouncemediawiki/extensions/Graphmaster+3 -3
Replace use of deprecated $.debounce()mediawiki/extensions/InputBoxmaster+2 -2
Use ooui debounce and throttle instead of deprecated jquery onemediawiki/extensions/Wikibasemaster+2 -4
Remove usage of deprecated jquery.throttle-debounce modulemediawiki/extensions/WikidataPageBannermaster+2 -2
Use mw.util.debouncemediawiki/extensions/Kartographermaster+2 -2
Use mw.util.debouncemediawiki/extensions/RelatedArticlesmaster+2 -2
mediawiki.util: Add debounce() functionmediawiki/coremaster+48 -9
Use mw.util.debounce() in collapsibleTabs.jsmediawiki/skins/Vectormaster+4 -4
mediawiki.special.userlogin.signup: Remove unused debounce dependencymediawiki/coremaster+0 -1
mediawiki.htmlform.checker: Remove use of deprecated jquery.throttle-debouncemediawiki/coremaster+9 -4
Revert "Mark jquery.throttle-debounce as deprecated"mediawiki/coremaster+0 -4
Mark jquery.throttle-debounce as deprecatedmediawiki/coremaster+4 -0
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Ladsgroup subscribed.Feb 15 2021, 9:43 AM
gerritbot added a comment.Feb 15 2021, 9:47 AM

Change 664229 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikidataPageBanner@master] Remove usage of deprecated jquery.throttle-debounce module

https://gerrit.wikimedia.org/r/664229

Od1n added a comment.EditedFeb 15 2021, 1:21 PM

So, with https://gerrit.wikimedia.org/r/664228 the simple EventSingletonManager utility gets a dependency on the heavy and unrelated OOUI…

As more, this dependency isn't enforced, i.e. all codes that require() this module should make sure OOUI is loaded, and nothing states nor enforces this.

Ladsgroup added a comment.Feb 15 2021, 8:16 PM
In T213426#6830557, @Od1n wrote:

So, with https://gerrit.wikimedia.org/r/664228 the simple EventSingletonManager utility gets a dependency on the heavy and unrelated OOUI…

The whole RL module is depending on ooui already so it's guaranteed to be loaded before this file is executed

As more, this dependency isn't enforced, i.e. all codes that require() this module should make sure OOUI is loaded, and nothing states nor enforces this.

it gets enforced through resource loader

gerritbot added a comment.Feb 16 2021, 1:52 AM

Change 664229 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Remove usage of deprecated jquery.throttle-debounce module

https://gerrit.wikimedia.org/r/664229

Ladsgroup updated the task description. (Show Details)Feb 16 2021, 1:53 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.32; 2021-02-23).Feb 16 2021, 2:00 AM
gerritbot added a comment.Feb 16 2021, 2:07 AM

Change 664228 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use ooui debounce and throttle instead of deprecated jquery one

https://gerrit.wikimedia.org/r/664228

Od1n unsubscribed.Feb 16 2021, 2:39 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:52 PM
gerritbot added a comment.Apr 27 2021, 5:01 PM

Change 682998 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/Translate@master] Replace deprecated jQuery.throttle/debounce

https://gerrit.wikimedia.org/r/682998

Jdlrobson unsubscribed.Apr 27 2021, 5:03 PM
Seb35 updated the task description. (Show Details)Apr 27 2021, 5:03 PM
Seb35 mentioned this in T280972: Translating does not work anymore.Apr 27 2021, 5:19 PM
gerritbot added a comment.Apr 27 2021, 6:11 PM

Change 683034 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/InputBox@master] Replace deprecated jQuery.debounce

https://gerrit.wikimedia.org/r/683034

Seb35 updated the task description. (Show Details)Apr 27 2021, 6:12 PM
gerritbot added a comment.Apr 27 2021, 6:38 PM

Change 683039 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/MultimediaViewer@master] Replace deprecated jQuery.throttle/debounce

https://gerrit.wikimedia.org/r/683039

Seb35 updated the task description. (Show Details)Apr 27 2021, 6:48 PM
gerritbot added a comment.Apr 30 2021, 1:12 AM

Change 683034 merged by jenkins-bot:

[mediawiki/extensions/InputBox@master] Replace use of deprecated $.debounce()

https://gerrit.wikimedia.org/r/683034

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 30 2021, 2:00 AM
Seb35 updated the task description. (Show Details)Apr 30 2021, 4:17 PM
gerritbot added a comment.May 2 2021, 7:00 AM

Change 684059 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/core@master] Replace use of deprecated $.debounce()

https://gerrit.wikimedia.org/r/684059

Seb35 updated the task description. (Show Details)May 2 2021, 7:04 AM
Seb35 subscribed.May 2 2021, 5:19 PM

I’ve done a few patches, and I find OOUI is quite heavy if used only for the function throttle or “debounce with immediate execution” (mw.util.debounce executes after the delay, not before).

The “immediate debounce” is needed in mediawiki.page.gallery and the throttle is needed in Translate and MobileFrontend. It can be used inline versions, but I’m moderately enthusiastic about that because of code duplication -- it is always a question of balance between maintainability and performance as already said above.

Krinkle mentioned this in T286842: Proposal: merge styles for user login and signup into a single ResourceLoader module.Jul 19 2021, 6:37 PM
Addshore added a project: [DEPRECATED] wdwb-tech.Sep 21 2021, 8:42 AM
Addshore moved this task from Inbox to External Realm on the [DEPRECATED] wdwb-tech board.Sep 21 2021, 8:53 AM
AndyRussG added a project: Fundraising-Backlog.Nov 17 2021, 4:11 PM
XenoRyet moved this task from Triage to Unscheduled on the Fundraising-Backlog board.Nov 22 2021, 10:07 PM
Jdlrobson changed the status of subtask T236427: Dev: MobileFrontend should not use deprecated jquery.throttle-debounce inside ImageCarousel.js and ScrollEndEventEmitter.js from Stalled to Open.Dec 9 2021, 5:46 PM
gerritbot added a comment.Jan 22 2022, 8:11 PM

Change 756128 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/Graph@master] Replace jquery.debounce with OO.ui.debounce

https://gerrit.wikimedia.org/r/756128

gerritbot added a comment.Jan 22 2022, 8:58 PM

Change 756128 merged by jenkins-bot:

[mediawiki/extensions/Graph@master] Replace jquery.debounce with OO.ui.debounce

https://gerrit.wikimedia.org/r/756128

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 22 2022, 9:00 PM
Krinkle removed projects: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), MediaWiki-extensions-InputBox, MediaWiki-extensions-Graph.Jan 22 2022, 10:18 PM
Krinkle updated the task description. (Show Details)
Nikerabbit moved this task from Backlog to Maintenance on the MassMessage board.Jan 26 2022, 9:23 AM
Esanders added a comment.Feb 4 2022, 5:11 PM

It would've been nice to use the same function signature as OOUI, now we have

OO.ui.debounce( callback, wait [, immediate] );
//and
mw.util.debounce( wait, callback );

(ContentTranslation's utils also uses callback, wait, immedate as ported from the same source as underscore.js)

Given we know that the arguments have to be number and Function it's not too late to "fix" it with some type checks (and deprecating the old signature).

It would also be sensible to add the immediate arg, as it is generally useful (e.g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/684059/)

nb jQuery.throttle also had an immediate arg, but put it in the middle just to be difficult: delay [, at_begin ], callback

gerritbot added a comment.Feb 4 2022, 5:36 PM

Change 759748 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] mw.util.debounce: Use same implementation as OO.ui.debounce

https://gerrit.wikimedia.org/r/759748

gerritbot added a comment.Feb 6 2022, 4:38 AM

Change 759748 merged by jenkins-bot:

[mediawiki/core@master] mediawik.util: Use same debounce implementation as OO.ui.debounce

https://gerrit.wikimedia.org/r/759748

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.21; 2022-02-07); removed MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Feb 6 2022, 5:00 AM
gerritbot added a comment.Feb 7 2022, 3:45 PM

Change 760584 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/core@master] mw.util: Add throttle function, ported from OOUI

https://gerrit.wikimedia.org/r/760584

gerritbot added a comment.Feb 7 2022, 11:31 PM

Change 760584 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.util: Add throttle function, ported from OOUI

https://gerrit.wikimedia.org/r/760584

gerritbot added a comment.Feb 8 2022, 1:13 AM

Change 684059 merged by jenkins-bot:

[mediawiki/core@master] mediawiki.page.gallery: Replace use of deprecated $.debounce()

https://gerrit.wikimedia.org/r/684059

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.22; 2022-02-14); removed MW-1.38-notes (1.38.0-wmf.21; 2022-02-07).Feb 8 2022, 2:00 AM
Esanders renamed this task from Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle to Deprecate jquery.throttle-debounce in favour of (mw.util|OO.ui).debounce/throttle.Feb 8 2022, 12:53 PM
Seb35 updated the task description. (Show Details)Feb 9 2022, 11:58 PM
gerritbot added a comment.Feb 10 2022, 10:16 PM

Change 683039 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Replace deprecated jQuery.throttle/debounce

https://gerrit.wikimedia.org/r/683039

gerritbot added a comment.Feb 14 2022, 12:36 PM

Change 682998 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Replace deprecated jQuery.throttle/debounce

https://gerrit.wikimedia.org/r/682998

TheDJ updated the task description. (Show Details)Feb 14 2022, 3:40 PM
Volker_E updated the task description. (Show Details)Mar 16 2022, 4:24 PM
Jdlrobson closed subtask T236427: Dev: MobileFrontend should not use deprecated jquery.throttle-debounce inside ImageCarousel.js and ScrollEndEventEmitter.js as Resolved.Mar 16 2022, 5:59 PM
gerritbot added a comment.Mar 24 2022, 3:11 AM

Change 773381 had a related patch set uploaded (by Dylsss; author: Dylsss):

[mediawiki/extensions/3D@master] Replace use of deprecated jQuery.debounce

https://gerrit.wikimedia.org/r/773381

gerritbot added a comment.Mar 24 2022, 12:03 PM

Change 773381 merged by jenkins-bot:

[mediawiki/extensions/3D@master] Replace use of deprecated jQuery.debounce

https://gerrit.wikimedia.org/r/773381

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).Mar 24 2022, 1:00 PM
Pginer-WMF removed a project: MediaWiki-extensions-Translate.Mar 28 2022, 11:53 AM
Volker_E updated the task description. (Show Details)Mar 29 2022, 12:01 AM
gerritbot added a comment.May 22 2022, 4:14 PM

Change 795632 had a related patch set uploaded (by Ori; author: Ori):

[mediawiki/extensions/ExternalGuidance@master] mw.externalguidance.special: replace use of deprecated $.debounce

https://gerrit.wikimedia.org/r/795632

gerritbot added a comment.May 22 2022, 6:46 PM

Change 795632 merged by jenkins-bot:

[mediawiki/extensions/ExternalGuidance@master] mw.externalguidance.special: replace use of deprecated $.debounce

https://gerrit.wikimedia.org/r/795632

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.13; 2022-05-23); removed MW-1.39-notes (1.39.0-wmf.5; 2022-03-28).May 22 2022, 7:00 PM
Volker_E updated the task description. (Show Details)May 23 2022, 2:47 AM
gerritbot added a comment.Sep 3 2022, 4:09 PM

Change 829286 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MassMessage@master] Convert Special:MassMessage to use OOUI

https://gerrit.wikimedia.org/r/829286

gerritbot added a comment.Sep 6 2022, 2:49 AM

Change 829286 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Convert Special:MassMessage to use OOUI

https://gerrit.wikimedia.org/r/829286

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 6 2022, 3:00 AM
Dreamy_Jazz updated the task description. (Show Details)Sep 6 2022, 3:13 PM
gerritbot added a comment.Sep 8 2022, 8:22 PM

Change 830939 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/MassMessage@master] Remove jquery.throttle-debounce from dependencies

https://gerrit.wikimedia.org/r/830939

gerritbot added a comment.Sep 9 2022, 12:47 AM

Change 830939 merged by jenkins-bot:

[mediawiki/extensions/MassMessage@master] Remove jquery.throttle-debounce from dependencies

https://gerrit.wikimedia.org/r/830939

gerritbot added a comment.Sep 9 2022, 5:55 PM

Change 831128 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/skins/Metrolook@master] Use mw.util.debounce() in collapsibleTabs.js

https://gerrit.wikimedia.org/r/831128

gerritbot added a comment.Sep 9 2022, 6:14 PM

Change 831128 merged by jenkins-bot:

[mediawiki/skins/Metrolook@master] Use mw.util.debounce() in collapsibleTabs.js

https://gerrit.wikimedia.org/r/831128

Jdforrester-WMF updated the task description. (Show Details)Sep 9 2022, 6:19 PM
gerritbot added a comment.Sep 9 2022, 6:50 PM

Change 831135 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/GettingStarted@master] Replace use of deprecated $.throttle() with mw.util.throttle()

https://gerrit.wikimedia.org/r/831135

gerritbot added a comment.Sep 9 2022, 6:51 PM

Change 831137 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@master] Replace use of deprecated $.debounce() with mw.util.debounce()

https://gerrit.wikimedia.org/r/831137

Volker_E added a comment.Sep 9 2022, 6:52 PM

https://codesearch.wmcloud.org/search/?q=%5C%24%5C.debounce&i=nope&files=&excludeFiles=&repos= only shows MediaWiki-extensions-CentralNotice and LiveChat extension as remainders.

gerritbot added a comment.Sep 9 2022, 6:54 PM

Change 831135 merged by jenkins-bot:

[mediawiki/extensions/GettingStarted@master] Replace use of deprecated $.throttle() with mw.util.throttle()

https://gerrit.wikimedia.org/r/831135

gerritbot added a comment.Sep 9 2022, 6:54 PM

Change 831138 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/Flow@master] Replace use of deprecated $.throttle() with mw.util.throttle()

https://gerrit.wikimedia.org/r/831138

Jdforrester-WMF added a comment.Sep 9 2022, 6:57 PM
In T213426#8225521, @Volker_E wrote:

https://codesearch.wmcloud.org/search/?q=%5C%24%5C.debounce&i=nope&files=&excludeFiles=&repos= only shows MediaWiki-extensions-CentralNotice and LiveChat extension as remainders.

https://codesearch.wmcloud.org/search/?q=%5C%24%5C.(throttle%7Cdebounce)&i=nope&files=&excludeFiles=&repos= sadly has a few more hits.

Volker_E updated the task description. (Show Details)Sep 9 2022, 6:57 PM
Jdforrester-WMF updated the task description. (Show Details)Sep 9 2022, 6:58 PM
Jdforrester-WMF updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Sep 9 2022, 6:59 PM
gerritbot added a comment.Sep 9 2022, 7:01 PM

Change 831139 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/LiveChat@master] Replace use of deprecated $.debounce() with mw.util.debounce()

https://gerrit.wikimedia.org/r/831139

Jdforrester-WMF updated the task description. (Show Details)Sep 9 2022, 7:02 PM
Volker_E updated the task description. (Show Details)Sep 9 2022, 7:05 PM
gerritbot added a comment.Sep 9 2022, 7:06 PM

Change 831139 merged by jenkins-bot:

[mediawiki/extensions/LiveChat@master] Replace use of deprecated $.debounce() with mw.util.debounce()

https://gerrit.wikimedia.org/r/831139

gerritbot added a comment.Sep 9 2022, 7:06 PM

Change 831141 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] resources: Drop jquery.throttle-debounce, deprecated since 1.33

https://gerrit.wikimedia.org/r/831141

Jdforrester-WMF updated the task description. (Show Details)Sep 9 2022, 7:08 PM
Jdforrester-WMF mentioned this in rELICc4489ed98609: Replace use of deprecated $.debounce() with mw.util.debounce().Sep 9 2022, 7:45 PM
gerritbot added a comment.Sep 12 2022, 8:24 AM

Change 831137 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Replace use of deprecated $.debounce() with mw.util.debounce()

https://gerrit.wikimedia.org/r/831137

Jdforrester-WMF updated the task description. (Show Details)Sep 12 2022, 8:30 AM
gerritbot added a comment.Sep 12 2022, 9:30 AM

Change 831138 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace use of deprecated $.throttle() with mw.util.throttle()

https://gerrit.wikimedia.org/r/831138

kostajh updated the task description. (Show Details)Sep 12 2022, 9:39 AM
kostajh updated the task description. (Show Details)
kostajh removed a project: Growth-Team-Filtering.
kostajh moved this task from FY 2019-20 to Triaged on the Growth-Team board.
Jdforrester-WMF claimed this task.Sep 27 2022, 2:26 PM
gerritbot added a comment.Sep 27 2022, 8:16 PM

Change 831141 merged by jenkins-bot:

[mediawiki/core@master] resources: Drop jquery.throttle-debounce, deprecated since 1.33

https://gerrit.wikimedia.org/r/831141

Jdforrester-WMF closed this task as Resolved.Sep 27 2022, 8:17 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.4; 2022-10-03); removed MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 27 2022, 9:00 PM
happy5214 moved this task from Backlog to Closed on the WikiEditor board.Jul 31 2023, 9:54 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2023, 10:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL