Page MenuHomePhabricator
Create Task
Maniphest T248191

Can't reopen table in wikidb-unittest_ (from SpecialPageFatalTest)
Closed, ResolvedPublic
Actions

Description

This is blocking the re-enablement of the "assert no runtime errors" step in CI, which checks that mw-error.log remains empty. This was accidentally removed a few months ago (T246358).

This error ocurrs five times on every build, and seem likely to have a single or identical root cause.

mw-dberror.log (1)
Fri Mar 20 18:07:26 UTC 2020	32a44f17c9c0	wikidb-unittest_	SpecialBrokenRedirects::reallyDoQuery	localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket	1137	Can't reopen table: 'p1' (localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket)	SELECT  p1.page_namespace AS `namespace`,p1.page_title AS `title`,rd_namespace,rd_title,rd_fragment  FROM `unittest_redirect` JOIN `unittest_page` `p1` ON ((rd_from=p1.page_id)) LEFT JOIN `unittest_page` `p2` ON ((rd_namespace=p2.page_namespace) AND (rd_title=p2.page_title))   WHERE (rd_namespace >= 0) AND (rd_interwiki IS NULL OR rd_interwiki = '') AND (p2.page_namespace IS NULL)  ORDER BY rd_namespace,rd_title,rd_from LIMIT 51  
#0 /workspace/src/includes/libs/rdbms/database/Database.php(1580): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /workspace/src/includes/libs/rdbms/database/Database.php(1159): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /workspace/src/includes/libs/rdbms/database/Database.php(1819): Wikimedia\Rdbms\Database->query(string, string)
#3 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /workspace/src/includes/specialpage/QueryPage.php(459): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#6 /workspace/src/includes/specialpage/QueryPage.php(637): QueryPage->reallyDoQuery(integer, integer)
#7 /workspace/src/includes/specials/SpecialBrokenRedirects.php(173): QueryPage->execute(string)
#8 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(107): SpecialBrokenRedirects->execute(string)
#9 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(37): SpecialPageExecutor->getHTMLFromSpecialPage(SpecialBrokenRedirects, string)
#10 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php(33): SpecialPageExecutor->executeSpecialPage(SpecialBrokenRedirects, string, NULL, string, User)
#11 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1408): SpecialPageFatalTest->testSpecialPageDoesNotFatal(SpecialBrokenRedirects)
#12 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1028): PHPUnit\Framework\TestCase->runTest()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(756): PHPUnit\Framework\TestResult->run(SpecialPageFatalTest)
#15 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(418): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#17 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(200): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, boolean)
#22 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#23 /workspace/src/maintenance/doMaintenance.php(99): PHPUnitMaintClass->execute()
#24 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#25 {main}
mw-dberror.log (2)
Fri Mar 20 18:07:26 UTC 2020	32a44f17c9c0	wikidb-unittest_	SpecialDoubleRedirects::reallyDoQuery	localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket	1137	Can't reopen table: 'ra' (localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket)	SELECT  pa.page_namespace AS `namespace`,pa.page_title AS `title`,pb.page_namespace AS `b_namespace`,pb.page_title AS `b_title`,rb.rd_namespace AS `c_namespace`,rb.rd_title AS `c_title`,rb.rd_fragment AS `c_fragment`,rb.rd_interwiki AS `c_interwiki`  FROM `unittest_redirect` `ra`,`unittest_redirect` `rb`,`unittest_page` `pa`,`unittest_page` `pb`    WHERE (ra.rd_from = pa.page_id) AND (ra.rd_interwiki IS NULL OR ra.rd_interwiki = '') AND (pb.page_namespace = ra.rd_namespace) AND (pb.page_title = ra.rd_title) AND (rb.rd_from = pb.page_id)  ORDER BY ra.rd_namespace,ra.rd_title LIMIT 51  
#0 /workspace/src/includes/libs/rdbms/database/Database.php(1580): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /workspace/src/includes/libs/rdbms/database/Database.php(1159): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /workspace/src/includes/libs/rdbms/database/Database.php(1819): Wikimedia\Rdbms\Database->query(string, string)
#3 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /workspace/src/includes/specialpage/QueryPage.php(459): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#6 /workspace/src/includes/specialpage/QueryPage.php(637): QueryPage->reallyDoQuery(integer, integer)
#7 /workspace/src/includes/specials/SpecialDoubleRedirects.php(208): QueryPage->execute(string)
#8 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(107): SpecialDoubleRedirects->execute(string)
#9 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(37): SpecialPageExecutor->getHTMLFromSpecialPage(SpecialDoubleRedirects, string)
#10 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php(33): SpecialPageExecutor->executeSpecialPage(SpecialDoubleRedirects, string, NULL, string, User)
#11 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1408): SpecialPageFatalTest->testSpecialPageDoesNotFatal(SpecialDoubleRedirects)
#12 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1028): PHPUnit\Framework\TestCase->runTest()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(756): PHPUnit\Framework\TestResult->run(SpecialPageFatalTest)
#15 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(418): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#17 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(200): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, boolean)
#22 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#23 /workspace/src/maintenance/doMaintenance.php(99): PHPUnitMaintClass->execute()
#24 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#25 {main}
mw-dberror.log (3)
Fri Mar 20 18:07:27 UTC 2020	32a44f17c9c0	wikidb-unittest_	WantedFilesPage::reallyDoQuery	localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket	1137	Can't reopen table: 'img1' (localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket)	SELECT  6 AS `namespace`,il_to AS `title`,COUNT(*) AS `value`  FROM `unittest_imagelinks` LEFT JOIN `unittest_page` ON ((il_to = page_title) AND page_namespace = 6) LEFT JOIN `unittest_redirect` ON ((page_id = rd_from) AND rd_namespace = 6 AND rd_interwiki = '') LEFT JOIN `unittest_image` `img1` ON ((il_to = img1.img_name)) LEFT JOIN `unittest_image` `img2` ON ((rd_title = img2.img_name))   WHERE img1.img_name IS NULL AND img2.img_name IS NULL  GROUP BY il_to ORDER BY value DESC,namespace,title LIMIT 51  
#0 /workspace/src/includes/libs/rdbms/database/Database.php(1580): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /workspace/src/includes/libs/rdbms/database/Database.php(1159): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /workspace/src/includes/libs/rdbms/database/Database.php(1819): Wikimedia\Rdbms\Database->query(string, string)
#3 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /workspace/src/includes/specialpage/QueryPage.php(459): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#6 /workspace/src/includes/specialpage/QueryPage.php(637): QueryPage->reallyDoQuery(integer, integer)
#7 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(107): QueryPage->execute(string)
#8 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(37): SpecialPageExecutor->getHTMLFromSpecialPage(WantedFilesPage, string)
#9 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php(33): SpecialPageExecutor->executeSpecialPage(WantedFilesPage, string, NULL, string, User)
#10 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1408): SpecialPageFatalTest->testSpecialPageDoesNotFatal(WantedFilesPage)
#11 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1028): PHPUnit\Framework\TestCase->runTest()
#12 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(756): PHPUnit\Framework\TestResult->run(SpecialPageFatalTest)
#14 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(418): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#15 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#17 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(200): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, boolean)
#21 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#22 /workspace/src/maintenance/doMaintenance.php(99): PHPUnitMaintClass->execute()
#23 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#24 {main}
mw-dberror.log (4)
Fri Mar 20 18:07:27 UTC 2020	32a44f17c9c0	wikidb-unittest_	WantedPagesPage::reallyDoQuery	localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket	1137	Can't reopen table: 'pg1' (localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket)	SELECT  pl_namespace AS `namespace`,pl_title AS `title`,COUNT(*) AS `value`  FROM `unittest_pagelinks` LEFT JOIN `unittest_page` `pg1` ON ((pg1.page_namespace = pl_namespace) AND (pg1.page_title = pl_title)) LEFT JOIN `unittest_page` `pg2` ON ((pg2.page_id = pl_from))   WHERE (pg1.page_namespace IS NULL) AND (pl_namespace NOT IN (2,3)) AND (pg2.page_namespace != 8)  GROUP BY pl_namespace,pl_title HAVING (COUNT(*) > 0) AND (COUNT(*) > SUM(pg2.page_is_redirect)) ORDER BY value DESC,namespace,title LIMIT 51  
#0 /workspace/src/includes/libs/rdbms/database/Database.php(1580): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /workspace/src/includes/libs/rdbms/database/Database.php(1159): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /workspace/src/includes/libs/rdbms/database/Database.php(1819): Wikimedia\Rdbms\Database->query(string, string)
#3 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /workspace/src/includes/specialpage/QueryPage.php(459): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#6 /workspace/src/includes/specialpage/QueryPage.php(637): QueryPage->reallyDoQuery(integer, integer)
#7 /workspace/src/includes/specials/SpecialWantedpages.php(48): QueryPage->execute(string)
#8 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(107): WantedPagesPage->execute(string)
#9 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(37): SpecialPageExecutor->getHTMLFromSpecialPage(WantedPagesPage, string)
#10 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php(33): SpecialPageExecutor->executeSpecialPage(WantedPagesPage, string, NULL, string, User)
#11 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1408): SpecialPageFatalTest->testSpecialPageDoesNotFatal(WantedPagesPage)
#12 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1028): PHPUnit\Framework\TestCase->runTest()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(756): PHPUnit\Framework\TestResult->run(SpecialPageFatalTest)
#15 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(418): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#17 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(200): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, boolean)
#22 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#23 /workspace/src/maintenance/doMaintenance.php(99): PHPUnitMaintClass->execute()
#24 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#25 {main}
mw-dberror.log (5)
Fri Mar 20 18:07:27 UTC 2020	32a44f17c9c0	wikidb-unittest_	SpecialListRedirects::reallyDoQuery	localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket	1137	Can't reopen table: 'p1' (localhost:/workspace/db/quibble-mysql-fyqd_1b0/socket)	SELECT  p1.page_namespace AS `namespace`,p1.page_title AS `title`,rd_namespace,rd_title,rd_fragment,rd_interwiki,p2.page_id AS `redirid`  FROM `unittest_page` `p1` LEFT JOIN `unittest_redirect` ON ((rd_from=p1.page_id)) LEFT JOIN `unittest_page` `p2` ON ((p2.page_namespace=rd_namespace) AND (p2.page_title=rd_title))   WHERE p1.page_is_redirect = 1  ORDER BY p1.page_namespace,p1.page_title LIMIT 51  
#0 /workspace/src/includes/libs/rdbms/database/Database.php(1580): Wikimedia\Rdbms\Database->getQueryExceptionAndLog(string, integer, string, string)
#1 /workspace/src/includes/libs/rdbms/database/Database.php(1159): Wikimedia\Rdbms\Database->reportQueryError(string, integer, string, string, boolean)
#2 /workspace/src/includes/libs/rdbms/database/Database.php(1819): Wikimedia\Rdbms\Database->query(string, string)
#3 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->select(array, array, array, string, array, array)
#4 /workspace/src/includes/libs/rdbms/database/DBConnRef.php(313): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#5 /workspace/src/includes/specialpage/QueryPage.php(459): Wikimedia\Rdbms\DBConnRef->select(array, array, array, string, array, array)
#6 /workspace/src/includes/specialpage/QueryPage.php(637): QueryPage->reallyDoQuery(integer, integer)
#7 /workspace/src/includes/specials/SpecialListRedirects.php(149): QueryPage->execute(string)
#8 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(107): SpecialListRedirects->execute(string)
#9 /workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php(37): SpecialPageExecutor->getHTMLFromSpecialPage(SpecialListRedirects, string)
#10 /workspace/src/tests/phpunit/structure/SpecialPageFatalTest.php(33): SpecialPageExecutor->executeSpecialPage(SpecialListRedirects, string, NULL, string, User)
#11 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1408): SpecialPageFatalTest->testSpecialPageDoesNotFatal(SpecialListRedirects)
#12 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(1028): PHPUnit\Framework\TestCase->runTest()
#13 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestResult.php(691): PHPUnit\Framework\TestCase->runBare()
#14 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestCase.php(756): PHPUnit\Framework\TestResult->run(SpecialPageFatalTest)
#15 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php(418): PHPUnit\Framework\TestCase->run(PHPUnit\Framework\TestResult)
#16 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): MediaWikiIntegrationTestCase->run(PHPUnit\Framework\TestResult)
#17 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#18 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#19 /workspace/src/vendor/phpunit/phpunit/src/Framework/TestSuite.php(597): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#20 /workspace/src/vendor/phpunit/phpunit/src/TextUI/TestRunner.php(621): PHPUnit\Framework\TestSuite->run(PHPUnit\Framework\TestResult)
#21 /workspace/src/vendor/phpunit/phpunit/src/TextUI/Command.php(200): PHPUnit\TextUI\TestRunner->doRun(PHPUnit\Framework\TestSuite, array, boolean)
#22 /workspace/src/tests/phpunit/phpunit.php(71): PHPUnit\TextUI\Command->run(array, boolean)
#23 /workspace/src/maintenance/doMaintenance.php(99): PHPUnitMaintClass->execute()
#24 /workspace/src/tests/phpunit/phpunit.php(130): require(string)
#25 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
phpunit: Drop bypass for now-fixed dberror from SpecialPageFatalTestmediawiki/coremaster+0 -2
phpunit: Acknowledge known dberror from SpecialPageFatalTestmediawiki/coreREL1_34+7 -0
phpunit: Acknowledge known dberror from SpecialPageFatalTestmediawiki/coremaster+7 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedKrinkleT248191 Can't reopen table in wikidb-unittest_ (from SpecialPageFatalTest)
 ResolvedDzahnT245757 Upgrade MediaWiki clusters to Debian Buster (debian 10)
 ResolvedhasharT252434 Test MW code in buster as well as stretch
 ResolvedJdforrester-WMFT250514 Create buster-based images for quibble
 ResolvedLadsgroupT279068 Wikibase data-client bridge selenium failure on buster but not stretch
 ResolvedMoritzMuehlenhoffT250515 Please provide our special component/php72 in buster-wikimedia
 ResolvedjijikiT264991 Upgrade the MediaWiki servers to ICU 63
 ResolvedMoritzMuehlenhoffT253377 WMF deployed EasyTimeline extension depends on Ploticus package which is not available in Debian Buster (but available again in Debian Bullseye)
 ResolvedTrizek-WMFT267145 CommRel support for ICU 63 upgrade
 ResolvedDzahnT267248 create mwdebug1003 - ganeti VM with buster and appserver role
 Resolved• GillesT268188 Release WikimediaDebug for mwdebug1003 addition
 ResolvedDzahnT267607 upgrade mwmaint servers to buster
ResolvedRequestPapaulT275928 decommission mwmaint2001.codfw.wmnet
 ResolvedjijikiT268524 Upgrade Parsoid servers to buster
DeclinedNoneT245888 Rename wtp* servers to parse* (Parsoid PHP servers)
 ResolvedDzahnT268248 upgrade scandium to buster
 ResolvedDzahnT265963 Replace production deployment servers and update them to Buster
Unknown Object (Task)
 ResolvedPapaulT266363 (Need By: TBD) rack/setup/install deploy2002
 Resolved• CmjohnsonT265653 (Need By: TBD) setup/install deploy1002
 ResolvedRequest• CmjohnsonT275831 decommission deploy1001.eqiad.wmnet
 ResolvedRequestPapaulT275832 decommission deploy2001.codfw.wmnet
 ResolvedAndrewT269004 Upgrade labweb servers to buster
 ResolvedArielGlennT269377 Upgrade snapshot hosts to Buster
 ResolvedDzahnT270517 Investigate opcache hit rate on Buster appserver
 ResolvedLegoktmT273312 Investigate possible performance degradation on mediawiki servers after Debian Buster upgrade
 ResolvedPapaulT273803 mw2220 - broken IPMI / mgmt
ResolvedDzahnT274023 Convert mwdebug VMs to debian buster
 Declined• GillesT274026 Add 3 new canaries to WikimediaDebug
 ResolvedVolansT274689 sre.hosts.decomission -> generate_dns_snippets - > Cumin execution failed
 ResolvedDzahnT274403 mw1379 - down after reboot attempt and DRAC can't powercycle
 ResolvedLegoktmT275752 Jobrunner timeouts on cross-DC file uploads because of HTTP/2

Event Timeline

Krinkle created this task.Mar 20 2020, 6:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 20 2020, 6:31 PM
Krinkle mentioned this in T246358: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty.Mar 20 2020, 7:09 PM
Anomie moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Mar 20 2020, 9:52 PM
Anomie subscribed.

The "underlying cause" is MySQL bug 10327: for some reason it's incapable of "opening" a temporary table multiple times in one query. Interestingly, it looks like MariaDB may have fixed that bug in 10.2 or 10.3, as I can't reproduce it locally or on db1107 but can on the other DBs that are still on 10.1.

I don't see how this ever didn't produce these log messages. The test in question appears to have existed since rMWb50c8848e6e8: Introduce SpecialPageFatalTest (merged July 2018). The query in SpecialBrokenRedirects triggering that MySQL bug appears to have been in place in various forms since rSVN9199: * links and brokenlinks tables merged to pagelinks; this will reduce pain. At a quick search, I don't see that either has ever had any code skipping the test for MySQL.

Umherirrender subscribed.Mar 21 2020, 1:42 PM

See https://gerrit.wikimedia.org/g/mediawiki/core/+/226fa9578b863a069cccd2790557f85e9d06a216/tests/phpunit/includes/specials/QueryAllSpecialPagesTest.php#34 for the blacklist on the unit tests

Anomie added a comment.Mar 23 2020, 6:06 PM
In T248191#5988942, @Umherirrender wrote:

See https://gerrit.wikimedia.org/g/mediawiki/core/+/226fa9578b863a069cccd2790557f85e9d06a216/tests/phpunit/includes/specials/QueryAllSpecialPagesTest.php#34 for the blacklist on the unit tests

I don't see where SpecialPageFatalTest uses or has ever used that?

• CCicalese_WMF edited projects, added Platform Engineering (Icebox); removed Platform Engineering.Mar 24 2020, 8:14 PM
• CCicalese_WMF subscribed.

This will be fixed when we upgrade to MariaDB version 10.3 (possibly 10.2) in CI.

Jdforrester-WMF subscribed.May 11 2020, 5:51 PM
In T248191#5996263, @CCicalese_WMF wrote:

This will be fixed when we upgrade to MariaDB version 10.3 (possibly 10.2) in CI.

That means we're going to be waiting a very long time. :-(

For CI to run 10.4 instead of 10.1, we'll have to move quibble from stretch to buster; we wouldn't drop strech CI running until all of production has moved over.

Have created T252432 to mark as blocking this, per your comment.

Jdforrester-WMF added a subtask: T252432: Drop MediaWiki testing in stretch and instead test only in buster.May 11 2020, 5:51 PM
gerritbot added a comment.May 18 2020, 9:42 PM

Change 597167 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] phpunit: Acknowledge known dberror from SpecialPageFatalTest

https://gerrit.wikimedia.org/r/597167

gerritbot added a project: Patch-For-Review.May 18 2020, 9:42 PM
gerritbot added a comment.May 19 2020, 9:29 AM

Change 597167 merged by jenkins-bot:
[mediawiki/core@master] phpunit: Acknowledge known dberror from SpecialPageFatalTest

https://gerrit.wikimedia.org/r/597167

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.34; 2020-05-26).May 19 2020, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 19 2020, 10:10 AM
Krinkle removed a parent task: T246358: Jenkins no longer fails build if mw-error.log or mw-dberror.log are non-empty.May 19 2020, 7:56 PM
Krinkle mentioned this in T256006: Test fails with "Can't reopen table" error..Jun 22 2020, 3:48 PM
gerritbot added a comment.Jul 29 2020, 6:52 PM

Change 617145 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@REL1_34] phpunit: Acknowledge known dberror from SpecialPageFatalTest

https://gerrit.wikimedia.org/r/617145

gerritbot added a project: Patch-For-Review.Jul 29 2020, 6:52 PM

Change 617145 merged by Krinkle:
[mediawiki/core@REL1_34] phpunit: Acknowledge known dberror from SpecialPageFatalTest

https://gerrit.wikimedia.org/r/617145

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 7:10 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:01 PM
Umherirrender unsubscribed.Feb 27 2021, 9:27 PM
Jdforrester-WMF closed subtask T252432: Drop MediaWiki testing in stretch and instead test only in buster as Resolved.Apr 16 2021, 10:38 PM
Izno edited subtasks, added: T245757: Upgrade MediaWiki clusters to Debian Buster (debian 10); removed: T252432: Drop MediaWiki testing in stretch and instead test only in buster.Jun 1 2021, 11:15 PM
Dzahn changed the status of subtask T245757: Upgrade MediaWiki clusters to Debian Buster (debian 10) from Open to Stalled.Aug 5 2021, 1:37 PM
Dzahn changed the status of subtask T245757: Upgrade MediaWiki clusters to Debian Buster (debian 10) from Stalled to In Progress.Sep 16 2021, 2:38 PM
Dzahn closed subtask T245757: Upgrade MediaWiki clusters to Debian Buster (debian 10) as Resolved.Sep 16 2021, 3:22 PM
gerritbot added a comment.Sep 16 2021, 4:03 PM

Change 721569 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] phpunit: Drop bypass for now-fixed dberror from SpecialPageFatalTest

https://gerrit.wikimedia.org/r/721569

gerritbot added a project: Patch-For-Review.Sep 16 2021, 4:03 PM
fgiunchedi reopened subtask T245757: Upgrade MediaWiki clusters to Debian Buster (debian 10) as Open.Sep 24 2021, 8:33 AM
gerritbot added a comment.Oct 7 2021, 8:29 PM

Change 721569 merged by jenkins-bot:

[mediawiki/core@master] phpunit: Drop bypass for now-fixed dberror from SpecialPageFatalTest

https://gerrit.wikimedia.org/r/721569

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 7 2021, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 7 2021, 9:11 PM
Legoktm closed subtask T245757: Upgrade MediaWiki clusters to Debian Buster (debian 10) as Resolved.Nov 4 2021, 7:10 PM
Krinkle removed projects: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12), MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Wikimedia-database-issue.Apr 9 2022, 6:52 PM
Krinkle closed this task as Resolved.Apr 9 2022, 6:55 PM
Krinkle claimed this task.

I confirmed that on core commits, these three jobs all end with Asserting empty files: mw-dberror.log mw-error.log:

  • wmf-quibble-core-vendor-mysql-php72-docker
  • wmf-quibble-selenium-php72-docker
  • mediawiki-quibble-vendor-mysql-php72-docker
Krinkle edited projects, added Performance-Team, Developer Productivity, Continuous-Integration-Config; removed Platform Engineering (Icebox).Apr 9 2022, 6:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits