Page MenuHomePhabricator
Create Task
Maniphest T340160

WikiLambda: Track function-creation attempts
Closed, ResolvedPublic
Actions

Description

Description

Create Metrics Platform instruments that log events for:

  • User loads function definition page (Special:CreateZObject?zid=Z8)
  • User publishes function definition
  • User cancels function definition editing

Desired behavior/Acceptance criteria

Completion checklist

Details

SubjectRepoBranchLines +/-
Add event logging for the 3 view initializationsmediawiki/extensions/WikiLambdamaster+19 -0
WikiLambda metrics: Allow false custom data values to get throughmediawiki/extensions/WikiLambdamaster+9 -9
Metrics custom data: pass undefined as null & update 2 namesmediawiki/extensions/WikiLambdamaster+24 -24
Add metrics instrument for loading function-editing pagemediawiki/extensions/WikiLambdamaster+10 -7
Add instrument to produce zobject publish eventmediawiki/extensions/WikiLambdamaster+13 -1
Change existing event names to verb-object conventionmediawiki/extensions/WikiLambdamaster+3 -3
Add custom data "isnewzobject" to "wf.ui.newView.mounted" eventmediawiki/extensions/WikiLambdamaster+1 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenBUG REPORTNoneT344206 Special:MathStatus exception error on Wikifunctions
 OpenNoneT342865 Post-creation work for wikifunctionswiki
 ResolvedBTullisT289316 Prepare and check storage layer for Wikifunctions.org (new public content wiki)
 ResolvedJdforrester-WMFT275945 Create Wikifunctions.org
 ResolvedDVrandecicT289321 Pre-launch performance review of Wikifunctions
 ResolvedcmassaroT313226 Get all SRE-type things ready for launching Wikifunctions
 ResolvedClement_GoubertT313227 Get new edge & internal HTTPS certificates expanded to add wikifunctions.org and *.wikifunctions.org
 ResolvedJdforrester-WMFT307723 Ensure the runbooks for function-* services are good enough
 ResolvedcmassaroT297314 New Service Request: function-orchestrator and function-evaluator (for Wikifunctions launch)
 ResolvedoriT295698 Create helm charts for Wikifunctions services
 ResolvedsbassettT289322 Pre-launch security review of Wikifunctions
 ResolvedakosiarisT340041 Setup kubernetes namespaces for wikifunctions
 ResolvedJdforrester-WMFT340141 Add a variant of WikiLambda's ReloadBuiltinData maintenance script that will insert new pre-defined ZObjects from function-schemata
 ResolvedRequest• CCoxwell-WMFT339936 Please add Abstract Wiki team members to `deployment` prod SRE group
 ResolvedRequestgenghT340614 Requesting access to deployment for gengh
 ResolvedRequestArnoldokothT340890 Requesting access to deployment for cec
 ResolvedcmassaroT326785 Kubernetes Wikifunctions security and control measures
 ResolvedQuiddityT337866 Prepare Main Page content for Wikifunctions ahead of launch
 ResolvedJdforrester-WMFT327459 Set up an interwiki prefix to Wikifunctions
 ResolvedJdforrester-WMFT291594 Have discussion tools enabled on Wikifunctions on launch by default
 ResolvedJdforrester-WMFT291595 Determine initial launch configuration for Wikifunctions
 ResolvedJdforrester-WMFT340775 Launch-blocking bugs
 ResolvedBUG REPORTgenghT337457 DefaultView page-wide: When validateZObject returns false, the UI doesn't reflect the error state
 ResolvedBUG REPORTgenghT340627 Display cancel dialog (after edits) on browser interactions
 ResolvedgenghT336877 Provide a "Cancel" control in edit mode for ZObjects
 ResolvedBUG REPORTJdforrester-WMFT340732 User functionmaintainer and functioneer cannot edit a non-attached implementation
 ResolvedBUG REPORTJdforrester-WMFT340748 User should not be able to create or edit Programming Language objects
 ResolvedBUG REPORTDVrandecicT338020 router.js state module: Fix Special:EvaluateFunctionCall navigation
 ResolvedBUG REPORTcmassaroT338315 Calling a Function Returns Undefined with Degenerate Implementation
 ResolvedBUG REPORTJdforrester-WMFT340022 Persistent no js warning after load
 ResolvedBUG REPORTAAlhazwani-WMFT337987 Make various fixes for RTL support in WikiLambda UX
 DuplicateBUG REPORTNoneT337989 Function view: Content isn't flipped and so displays in the wrong order on dir=rtl context
 ResolvedBUG REPORTJdforrester-WMFT342212 Adapt wikilambda-zobject-title better for RTL user interface
 ResolvedBUG REPORTDVrandecicT337070 When adding a tester, literal arguments can not be immediately added
 ResolvedgenghT336562 DefaultView page-wide behavior: Make sure that all used and referred Zids and keys are fetched
 ResolvedBUG REPORTcmassaroT336719 Cannot call "is BCE" (function which takes a type that references itself)
 ResolvedBUG REPORTgenghT336984 Raw key ids are shown instead of labels in argument references
 ResolvedgenghT287514 Handle old (non-current) ZObject pages, or at least warn the user that they're looking at the current version despite their request
 ResolvedJdforrester-WMFT299176 Phase Theta – Root task
 ResolvedJdforrester-WMFT314485 We are ready for the last three phases, especially the next, ι (Iota)
 Resolved• CCoxwell-WMFT290522 Object model: Add short description to Z2/Persistent Objects, Z2K5
 Resolved• CCoxwell-WMFT335360 Provide short description (Z2K5) view/editing in function views, not just default views
 ResolvedAAlhazwani-WMFT303229 Create a design for having short descriptions on function pages
 ResolvedLadsgroupT341102 addWiki.php fails with CannotReplaceActiveServiceException
 ResolvedJdforrester-WMFT338164 Restrict Type creation to functionmaintainers
 ResolvedJdforrester-WMFT323399 Add Wikifunctions as a sibling project to the Portals once it launches
 ResolvedcmassaroT342820 Migrate wikifunctions.org from locked-down to limited mode, letting users edit wikitext pages and some
 ResolvedJdforrester-WMFT268678 Make Wikifunctions a true multi-lingual wiki, exposing content in each language to readers and search engines with parity
 ResolvedDVrandecicT338190 Performance review of Wikifunctions multingual setup and caching
 ResolvedgenghT341500 Implement UX to select natural language one reads and edits Wikifunctions
 ResolvedBUG REPORTJdforrester-WMFT342891 Under `view/lang/zid` routes, Edit pages are rendered with "viewmode=true" even if `?action=edit` is present
 ResolvedDMartin-WMFT297511 Instrumentation of UI and logging of events for analysis
 ResolvedDMartin-WMFT340160 WikiLambda: Track function-creation attempts
 ResolvedQuiddityT271271 Ensure essential pages will be available on Wikifunctions
 ResolvedQuiddityT300515 Docs: create "Extension:WikiLambda/Evaluate function call" help page
 ResolvedQuiddityT300517 Docs: create "Extension:WikiLambda/Creating ZObjects" help page
 ResolvedDVrandecicT300519 Docs: create "Extension:WikiLambda/Objects by type" help page
 ResolvedDVrandecicT300516 Docs: create "Extension:WikiLambda/Duplicate Object labels" help page
 ResolvedQuiddityT309199 Documentation: create wiki page about function review process and update link to it in FunctionViewerDetails.vue

Event Timeline

DMartin-WMF claimed this task.Jun 22 2023, 7:54 PM
DMartin-WMF created this task.
DMartin-WMF added a parent task: T297511: Instrumentation of UI and logging of events for analysis.Jun 22 2023, 8:01 PM
DMartin-WMF updated the task description. (Show Details)Jun 22 2023, 8:17 PM
DMartin-WMF added a comment.Jun 23 2023, 12:46 AM
  • User loads function definition page: indicated by event name wf.ui.newView.mounted, with custom data viewname = function-editor. Use custom data field isnewzobject to distinguish CUJ2 (function creation) from CUJ3 (editing an existing function).
gerritbot added a comment.Jun 23 2023, 12:54 AM

Change 932350 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Add custom data "isnewzobject" to "wf.ui.newView.mounted" event

https://gerrit.wikimedia.org/r/932350

gerritbot added a project: Patch-For-Review.Jun 23 2023, 12:54 AM
gerritbot added a comment.Jun 23 2023, 10:49 AM

Change 932350 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add custom data "isnewzobject" to "wf.ui.newView.mounted" event

https://gerrit.wikimedia.org/r/932350

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 23 2023, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 23 2023, 11:10 AM
DMartin-WMF added a comment.Jun 24 2023, 2:01 AM
Jdforrester-WMF moved this task from To triage to Phase λ – Launch on the Abstract Wikipedia team board.Jun 26 2023, 3:57 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to In progress on the Abstract Wikipedia team (Phase λ – Launch) board.Jun 26 2023, 4:15 PM
gerritbot added a comment.Jun 27 2023, 4:57 PM

Change 933495 had a related patch set uploaded (by Jforrester; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Change existing event names to verb-object convention

https://gerrit.wikimedia.org/r/933495

gerritbot added a project: Patch-For-Review.Jun 27 2023, 4:57 PM
gerritbot added a comment.Jun 27 2023, 5:38 PM

Change 933495 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Change existing event names to verb-object convention

https://gerrit.wikimedia.org/r/933495

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.16; 2023-07-04); removed MW-1.41-notes (1.41.0-wmf.15; 2023-06-27).Jun 27 2023, 6:00 PM
gerritbot added a comment.Jun 27 2023, 6:07 PM

Change 933602 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Add instrument to produce zobject publish event

https://gerrit.wikimedia.org/r/933602

gerritbot added a comment.Jun 27 2023, 6:32 PM

Change 933609 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Add event logging for the 3 view initializations

https://gerrit.wikimedia.org/r/933609

gerritbot added a comment.Jun 29 2023, 1:18 PM

Change 933602 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add instrument to produce zobject publish event

https://gerrit.wikimedia.org/r/933602

DMartin-WMF updated the task description. (Show Details)Jun 29 2023, 6:12 PM
mpopov added subscribers: ATsay-WMF, EMagallanes, mpopov.Jun 29 2023, 6:47 PM

Hi @DMartin-WMF @ATsay-WMF As part of this instrumentation work can you please submit documentation (of the data you're collecting) for Legal's review & approval through the L3SC (if you haven't already)?

We're here to make sure no oversight happens with regards to privacy or security or any other legal issues. And if you have a timeline you're working towards, please let us know in the L3SC request form so we can work with you to meet it.

(Heads-up @EMagallanes)

EMagallanes added a comment.Jun 29 2023, 7:24 PM

Thanks for the heads up! I'll look out for the ticket in Asana. :)

gerritbot added a comment.Jun 30 2023, 2:24 AM

Change 934429 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Add metrics instrument for loading function-editing page

https://gerrit.wikimedia.org/r/934429

gerritbot added a comment.Jun 30 2023, 12:38 PM

Change 934429 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add metrics instrument for loading function-editing page

https://gerrit.wikimedia.org/r/934429

gerritbot added a comment.Jul 12 2023, 1:37 AM

Change 937204 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Metrics custom data: pass undefined as null & update 2 names

https://gerrit.wikimedia.org/r/937204

DMartin-WMF updated the task description. (Show Details)Jul 12 2023, 1:42 AM
DMartin-WMF added a comment.EditedJul 12 2023, 2:19 AM

Loading the function definition page to create a new function will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.load'
  • Custom data 'isnewzobject' = true

Publishing a new function will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.publish'
  • Custom data 'isnewzobject' = true

Canceling new function creation will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.cancel'
  • Custom data 'isnewzobject' = true
gerritbot added a comment.Jul 12 2023, 1:19 PM

Change 937204 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Metrics custom data: pass undefined as null & update 2 names

https://gerrit.wikimedia.org/r/937204

gerritbot added a comment.Jul 17 2023, 8:48 PM

Change 938928 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] WikiLambda metrics: Allow false custom data values to get through

https://gerrit.wikimedia.org/r/938928

gerritbot added a comment.Jul 17 2023, 10:54 PM

Change 938928 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] WikiLambda metrics: Allow false custom data values to get through

https://gerrit.wikimedia.org/r/938928

DMartin-WMF updated the task description. (Show Details)Jul 20 2023, 2:22 AM
Jdforrester-WMF moved this task from In progress to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 24 2023, 8:47 PM
DVrandecic closed this task as Resolved.Jul 25 2023, 1:56 AM
DMartin-WMF mentioned this in T355638: WikiLambda metrics: collect type info for function create/edit activities in the UI.Jan 23 2024, 6:12 AM
gerritbot added a comment.Jan 26 2024, 3:34 AM

Change 933609 abandoned by David Martin:

[mediawiki/extensions/WikiLambda@master] Add event logging for the 3 view initializations

Reason:

Not likely to ever be needed, based on recent analysis of Wikifunctions metrics needs

https://gerrit.wikimedia.org/r/933609

Maintenance_bot removed a project: Patch-For-Review.Jan 26 2024, 4:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL