Flow's VE toolbar v2
Open, NormalPublic

Description

Placeholder, for notes about the second iteration of the VE toolbar.

Things like:


See also:

Quiddity created this task.Mar 19 2015, 6:52 PM
Quiddity updated the task description. (Show Details)
Quiddity raised the priority of this task from to Normal.
Quiddity added a subscriber: Quiddity.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2015, 6:52 PM
Elitre added a subscriber: Elitre.Mar 30 2015, 12:36 PM
Quiddity updated the task description. (Show Details)Aug 3 2015, 6:47 PM
Quiddity set Security to None.

The formatting menu only has 2 options (bold, italic). If that's gonna stay that way, please just add the 2 buttons directly to the toolbar.

Trizek-WMF added subscribers: Mooeypoo, Catrope.EditedMay 25 2016, 12:04 AM

Summary of discussions I had during the collaboration team's offsite and my thoughts.

Add features to VE's toolbar on Flow is not complicated. The question is what should we add and why.

What are the current VE toolbar options for editing pages, and are they relevant on Flow:

  • Paragraph : yes
    • titles, yes for <h3>, <h4>, <h5> & <h6> in order to keep consistency (h1 is used for page title, h2 for Topic title).
  • Formatting options : yes, all
  • Links, already in
  • Cite: no real reason to have it, and Flow is not design to support footnotes
  • Lists options: yes, all
  • Insert: yes, all which work, especially Template and Media (highly required)
  • Special characters, yes

At the moment, there is on Flow toolbar:

  • Formatting options
  • Link
  • Mention

The goal is to keep it simple. A possible grouping option would be the following:

  • Formatting:
    • Bold
    • Italics
    • Titles (in "view more")
    • Other formatting options (in "view more")
  • Links
  • Mention
  • Insert:
    • Template
    • Media
    • Lists
    • Special characters
    • Other options (in "view more")

Add options will raise needs from people who want to have customized buttons (pre-formatted messages, smileys...). (See T136152: Allow people to add customized buttons to OOUI/VE toolbar in an easy way)

Add a toolbar to wikitext editor would be postponed until T104479: Provide a modern wikitext editor is more advanced.

Feldo added a subscriber: Feldo.May 26 2016, 1:17 AM

@Catrope told me that some elements can't be on the same group (titles and formatting - block vs inline elements).
A possible grouping option would be the following:

A possible new grouping option would be the following:

  • Formatting:
    • Bold
    • Italics
    • Other formatting options (in "view more")
  • Titles (maybe optional?)
  • Lists
  • Links
  • Mention
  • Insert:
    • Template
    • Media
    • Table
    • Special characters (if possible)
    • Other options (in "view more")
Trizek-WMF added a comment.EditedMay 26 2016, 7:15 PM

And, at least, a shortcut to the shortcuts panel (the one reached by Ctrl + /).

Change 291364 had a related patch set uploaded (by Catrope):
Use the standard VE toolbar in Flow as much as possible

https://gerrit.wikimedia.org/r/291364

Deployment scheduled for week 23.

@Catrope, can you add that toolbar on a test wiki? Thanks.

@Catrope, can you add that toolbar on a test wiki? Thanks.

I'll ask someone to merge it today after the cut, that'll make it appear in beta labs.

Change 291364 merged by jenkins-bot:
Use the standard VE toolbar in Flow as much as possible

https://gerrit.wikimedia.org/r/291364

JamesF said during a meeting that we should provide an option for h1 and h2 titles (even hidden on a sub-menu), because people can do that on wikitext.

How it will look:

How it will look:

I'd propose to try to make the toolbar a bit more compact in this context. Some ideas:

  • Move the special character action inside the "insert" menu.
  • Move the list creation actions inside the "insert" menu, and remove the list indentation control (the use of tabs should be enough in this context).
  • Remove undo/redo actions since keyboard shortcuts should be enough in this context.
  • Rename "Paragraph" to "Normal" since in a conversation context, compared to a document context, it may not be obvious you are writing a paragraph.

I'd propose to try to make the toolbar a bit more compact in this context. Some ideas:

  • Move the special character action inside the "insert" menu.

@Trizek-WMF initially asked for that, and I tried, but it doesn't want to go there.

  • Move the list creation actions inside the "insert" menu, and remove the list indentation control (the use of tabs should be enough in this context).

Something similar to this was initially requested as well, but it may or may not make sense conceptually. The tools in the list dropdown aren't really insertion tools, but communicate state and can change state. However, @Pginer-WMF suggests using lines to separate sections of the dropdown, which could work. Dropping the indent/outdent tools is easy.

  • Remove undo/redo actions since keyboard shortcuts should be enough in this context.

We could remove these easily enough. @Trizek-WMF wanted to include them for consistency with the normal VE toolbar.

  • Rename "Paragraph" to "Normal" since in a conversation context, compared to a document context, it may not be obvious you are writing a paragraph.

That may be trickier. I understand the rationale, but if we do this should we also change it in VE?

At a higher level, what should we do with this change? It was rushed (my apologies) and will be deployed in its current form on Tuesday unless we do something. Should we revert this until we've figured out what we need?

I'd propose to try to make the toolbar a bit more compact in this context. Some ideas:

  • Move the special character action inside the "insert" menu.

@Trizek-WMF initially asked for that, and I tried, but it doesn't want to go there.

If the issue is related to the special characters becoming a panel, we may want to open a separate ticket, if there is none already ( I think @Esanders was considering some work around that).

  • Move the list creation actions inside the "insert" menu, and remove the list indentation control (the use of tabs should be enough in this context).

Something similar to this was initially requested as well, but it may or may not make sense conceptually. The tools in the list dropdown aren't really insertion tools, but communicate state and can change state. However, @Pginer-WMF suggests using lines to separate sections of the dropdown, which could work. Dropping the indent/outdent tools is easy.

Another way to solve for this would be to make the insert bucket to be more generic. Making it become "More" and use it as an entry point of the tools that do not fit in the default toolbar.

  • Remove undo/redo actions since keyboard shortcuts should be enough in this context.

We could remove these easily enough. @Trizek-WMF wanted to include them for consistency with the normal VE toolbar.

I understand that, but the more options we add the less chances (and more effort is required) for users to find and use the specific tools that are useful in this context (e.g., mentioning people).

  • Rename "Paragraph" to "Normal" since in a conversation context, compared to a document context, it may not be obvious you are writing a paragraph.

That may be trickier. I understand the rationale, but if we do this should we also change it in VE?

In the context of VE it may also make sense since the menu there are options such as "preformatted" which also result in a paragraph (at least from the perspective of those not talking about HTML tags).

At a higher level, what should we do with this change? It was rushed (my apologies) and will be deployed in its current form on Tuesday unless we do something. Should we revert this until we've figured out what we need?

I'd go with adding the "insert" menu for now, and then figure out where we want to go from there.

I illustrated how some of the ideas above would look in context:

Initial state.

Text format and styling:

Adding new elements:

Qgil moved this task from Backlog to Team radar on the Community-Liaisons board.

Special character is a separate tool because it is a toggle button for the panel, mostly because we couldn't find a place for a hide button in the special character panel.

Change 292912 had a related patch set uploaded (by Catrope):
Revert "Use the standard VE toolbar in Flow as much as possible"

https://gerrit.wikimedia.org/r/292912

Change 292912 merged by jenkins-bot:
Revert "Use the standard VE toolbar in Flow as much as possible"

https://gerrit.wikimedia.org/r/292912


We may need to shorten that toolbar width on page description' edit field.

What about just expanding sideways, so a [>] button that reveals the extra toolbar groups?

Possible.

So, is it possible to group things like Pau suggested on T93243#2350530?

An user is asking for that new toolbar.

Qgil moved this task from Backlog to Team radar on the Community-Liaisons board.
Feldo added a comment.Aug 29 2016, 4:33 PM

Any release date for this new toolbar?

No. There is still some design issues and the priority is not on having major changes on Flow at the moment.

(The 2 things I miss the most in Flow so far are "Remove formatting" and a button to add curly brackets.)

Would it be imaginable to have that toolbar as an option? @Quiddity sugests that IPs and beginners have the current toolbar, but an option in parameters give access to a complete toolbar.

Jdforrester-WMF removed Catrope as the assignee of this task.Mar 28 2017, 4:25 PM