Page MenuHomePhabricator
Create Task
Maniphest T340779

WikiLambda: Track (already existing) function-editing attempts
Closed, ResolvedPublic
Actions

Description

Description

Create Metrics Platform instruments that log events for:

  • User starts editing an existing function definition
  • User publishes the updated function definition
  • User cancels function definition editing

Desired behavior/Acceptance criteria

Completion checklist

Details

SubjectRepoBranchLines +/-
WikiLambda metrics: Allow false custom data values to get throughmediawiki/extensions/WikiLambdamaster+9 -9
Metrics custom data: pass undefined as null & update 2 namesmediawiki/extensions/WikiLambdamaster+24 -24
Add metrics instrument for loading function-editing pagemediawiki/extensions/WikiLambdamaster+10 -7
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenBUG REPORTNoneT344206 Special:MathStatus exception error on Wikifunctions
 ResolvedJdforrester-WMFT342865 Post-creation work for wikifunctionswiki
 ResolvedBTullisT289316 Prepare and check storage layer for Wikifunctions.org (new public content wiki)
 ResolvedJdforrester-WMFT275945 Create Wikifunctions.org
 ResolvedDVrandecicT289321 Pre-launch performance review of Wikifunctions
 ResolvedcmassaroT313226 Get all SRE-type things ready for launching Wikifunctions
 ResolvedClement_GoubertT313227 Get new edge & internal HTTPS certificates expanded to add wikifunctions.org and *.wikifunctions.org
 ResolvedJdforrester-WMFT307723 Ensure the runbooks for function-* services are good enough
 ResolvedcmassaroT297314 New Service Request: function-orchestrator and function-evaluator (for Wikifunctions launch)
 ResolvedoriT295698 Create helm charts for Wikifunctions services
 ResolvedsbassettT289322 Pre-launch security review of Wikifunctions
 ResolvedakosiarisT340041 Setup kubernetes namespaces for wikifunctions
 ResolvedJdforrester-WMFT340141 Add a variant of WikiLambda's ReloadBuiltinData maintenance script that will insert new pre-defined ZObjects from function-schemata
 ResolvedRequest• CCoxwell-WMFT339936 Please add Abstract Wiki team members to `deployment` prod SRE group
 ResolvedRequestgenghT340614 Requesting access to deployment for gengh
 ResolvedRequestArnoldokothT340890 Requesting access to deployment for cec
 ResolvedcmassaroT326785 Kubernetes Wikifunctions security and control measures
 ResolvedQuiddityT337866 Prepare Main Page content for Wikifunctions ahead of launch
 ResolvedJdforrester-WMFT327459 Set up an interwiki prefix to Wikifunctions
 ResolvedJdforrester-WMFT291594 Have discussion tools enabled on Wikifunctions on launch by default
 ResolvedJdforrester-WMFT291595 Determine initial launch configuration for Wikifunctions
 ResolvedJdforrester-WMFT340775 Launch-blocking bugs
 ResolvedBUG REPORTgenghT337457 DefaultView page-wide: When validateZObject returns false, the UI doesn't reflect the error state
 ResolvedBUG REPORTgenghT340627 Display cancel dialog (after edits) on browser interactions
 ResolvedgenghT336877 Provide a "Cancel" control in edit mode for ZObjects
 ResolvedBUG REPORTJdforrester-WMFT340732 User functionmaintainer and functioneer cannot edit a non-attached implementation
 ResolvedBUG REPORTJdforrester-WMFT340748 User should not be able to create or edit Programming Language objects
 ResolvedBUG REPORTDVrandecicT338020 router.js state module: Fix Special:EvaluateFunctionCall navigation
 ResolvedBUG REPORTcmassaroT338315 Calling a Function Returns Undefined with Degenerate Implementation
 ResolvedBUG REPORTJdforrester-WMFT340022 Persistent no js warning after load
 ResolvedBUG REPORTAAlhazwani-WMFT337987 Make various fixes for RTL support in WikiLambda UX
 DuplicateBUG REPORTNoneT337989 Function view: Content isn't flipped and so displays in the wrong order on dir=rtl context
 ResolvedBUG REPORTJdforrester-WMFT342212 Adapt wikilambda-zobject-title better for RTL user interface
 ResolvedBUG REPORTDVrandecicT337070 When adding a tester, literal arguments can not be immediately added
 ResolvedgenghT336562 DefaultView page-wide behavior: Make sure that all used and referred Zids and keys are fetched
 ResolvedBUG REPORTcmassaroT336719 Cannot call "is BCE" (function which takes a type that references itself)
 ResolvedBUG REPORTgenghT336984 Raw key ids are shown instead of labels in argument references
 ResolvedgenghT287514 Handle old (non-current) ZObject pages, or at least warn the user that they're looking at the current version despite their request
 ResolvedJdforrester-WMFT299176 Phase Theta – Root task
 ResolvedJdforrester-WMFT314485 We are ready for the last three phases, especially the next, ι (Iota)
 Resolved• CCoxwell-WMFT290522 Object model: Add short description to Z2/Persistent Objects, Z2K5
 Resolved• CCoxwell-WMFT335360 Provide short description (Z2K5) view/editing in function views, not just default views
 ResolvedAAlhazwani-WMFT303229 Create a design for having short descriptions on function pages
 ResolvedLadsgroupT341102 addWiki.php fails with CannotReplaceActiveServiceException
 ResolvedJdforrester-WMFT338164 Restrict Type creation to functionmaintainers
 ResolvedJdforrester-WMFT323399 Add Wikifunctions as a sibling project to the Portals once it launches
 ResolvedcmassaroT342820 Migrate wikifunctions.org from locked-down to limited mode, letting users edit wikitext pages and some
 ResolvedJdforrester-WMFT268678 Make Wikifunctions a true multi-lingual wiki, exposing content in each language to readers and search engines with parity
 ResolvedDVrandecicT338190 Performance review of Wikifunctions multingual setup and caching
 ResolvedgenghT341500 Implement UX to select natural language one reads and edits Wikifunctions
 ResolvedBUG REPORTJdforrester-WMFT342891 Under `view/lang/zid` routes, Edit pages are rendered with "viewmode=true" even if `?action=edit` is present
 ResolvedDMartin-WMFT297511 Instrumentation of UI and logging of events for analysis
 ResolvedDMartin-WMFT340779 WikiLambda: Track (already existing) function-editing attempts
ResolvedQuiddityT271271 Ensure essential pages will be available on Wikifunctions
 ResolvedQuiddityT300515 Docs: create "Extension:WikiLambda/Evaluate function call" help page
 ResolvedQuiddityT300517 Docs: create "Extension:WikiLambda/Creating ZObjects" help page
 ResolvedDVrandecicT300519 Docs: create "Extension:WikiLambda/Objects by type" help page
 ResolvedDVrandecicT300516 Docs: create "Extension:WikiLambda/Duplicate Object labels" help page
 ResolvedQuiddityT309199 Documentation: create wiki page about function review process and update link to it in FunctionViewerDetails.vue

Event Timeline

DMartin-WMF created this task.Jun 29 2023, 6:23 PM
DMartin-WMF claimed this task.Jun 29 2023, 6:38 PM
DMartin-WMF added a parent task: T297511: Instrumentation of UI and logging of events for analysis.
gerritbot added a comment.Jun 30 2023, 2:24 AM

Change 934429 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Add metrics instrument for loading function-editing page

https://gerrit.wikimedia.org/r/934429

gerritbot added a project: Patch-For-Review.Jun 30 2023, 2:24 AM
gerritbot added a comment.Jun 30 2023, 12:38 PM

Change 934429 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add metrics instrument for loading function-editing page

https://gerrit.wikimedia.org/r/934429

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jun 30 2023, 1:01 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 30 2023, 1:10 PM
gerritbot added a comment.Jul 12 2023, 1:37 AM

Change 937204 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] Metrics custom data: pass undefined as null & update 2 names

https://gerrit.wikimedia.org/r/937204

gerritbot added a project: Patch-For-Review.Jul 12 2023, 1:37 AM
gerritbot added a comment.Jul 12 2023, 1:19 PM

Change 937204 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Metrics custom data: pass undefined as null & update 2 names

https://gerrit.wikimedia.org/r/937204

Maintenance_bot removed a project: Patch-For-Review.Jul 12 2023, 1:30 PM
Jdforrester-WMF moved this task from To triage to Phase λ – Launch on the Abstract Wikipedia team board.Jul 13 2023, 4:35 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase λ – Launch); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to QA needed on the Abstract Wikipedia team (Phase λ – Launch) board.Jul 13 2023, 4:51 PM
gerritbot added a comment.Jul 17 2023, 8:48 PM

Change 938928 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] WikiLambda metrics: Allow false custom data values to get through

https://gerrit.wikimedia.org/r/938928

gerritbot added a project: Patch-For-Review.Jul 17 2023, 8:48 PM
gerritbot added a comment.Jul 17 2023, 10:54 PM

Change 938928 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] WikiLambda metrics: Allow false custom data values to get through

https://gerrit.wikimedia.org/r/938928

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2023, 11:11 PM
DVrandecic closed this task as Resolved.Jul 19 2023, 3:59 AM
DMartin-WMF added a comment.Jul 20 2023, 2:26 AM

Loading the function definition page to edit an existing function will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.load'
  • Custom data 'isnewzobject' = false

Publishing an updated function will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.publish'
  • Custom data 'isnewzobject' = false

Canceling function editing will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.cancel'
  • Custom data 'isnewzobject' = false
DMartin-WMF updated the task description. (Show Details)Jul 20 2023, 2:30 AM
Etonkovidova subscribed.Jul 25 2023, 12:34 AM

Confirmed on https://stream-beta.wmflabs.org/v2/ui/#/?streams=wikifunctions.ui:

In T340779#9030221, @DMartin-WMF wrote:

Loading the function definition page to edit an existing function will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.load'
  • Custom data 'isnewzobject' = false
"$schema": "/analytics/mediawiki/client/metrics_event/1.2.0",
"dt": "2023-07-25T00:24:26.679Z",
"name": "wf.ui.editFunction.load",
"custom_data": {
"isnewzobject": {
"data_type": "boolean",
"value": "false"

Publishing an updated function will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.publish'
  • Custom data 'isnewzobject' = false
"$schema":
"/analytics/mediawiki/client/metrics_event/1.2.0",
"dt": "2023-07-25T00:27:25.388Z",
"name": "wf.ui.editFunction.publish",
"custom_data": {
"isnewzobject": {
"data_type": "boolean",
"value": "false"

Canceling function editing will be indicated by all MP events like this:

  • Event name: 'wf.ui.editFunction.cancel'
  • Custom data 'isnewzobject' = false
"$schema": "/analytics/mediawiki/client/metrics_event/1.2.0",
"dt": "2023-07-25T00:30:26.337Z",
"name": "wf.ui.editFunction.cancel",
"custom_data": {
"isnewzobject": {
"data_type": "boolean",
"value": "false"
DMartin-WMF mentioned this in T355638: WikiLambda metrics: track types usage for inputs/outputs of functions.Jan 23 2024, 6:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits