Page MenuHomePhabricator
Create Task
Maniphest T357620

Hard deprecate the CheckUserInsertForRecentChange hook
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The CheckUserInsertForRecentChange hook was soft deprecated in 1.40 as part of T324907: Create separate tables for log events in CheckUser. The hook now needs to be hard deprecated to comply with the Deprecation process and allow it's removal in the next release.

One remaining usages exists in the StructuredDiscussions extension which will need to be replaced before the hook is hard deprecated.

Details

SubjectRepoBranchLines +/-
Mark CheckUserInsertForRecentChange as hard deprecatedmediawiki/extensions/CheckUsermaster+5 -0
Replace deprecated CheckUserInsertForRecentChange hook handlermediawiki/extensions/Flowmaster+113 -6
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedFeatureDreamy_JazzT311375 Instead of not showing any results on too many results show the results to the truncation point with a pager that allows generation of more results
 ResolvedFeatureDreamy_JazzT313446 Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder
 OpenNoneT364943 InvestigateBlock does not allow many custom options
Restricted Task
Restricted Task
 ResolvedSecurityDreamy_JazzT268147 CVE-2024-40611: Special:CheckUser shows deleted edits to non-admins
 ResolvedSecurityZabeT311337 CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension
 ResolvedSecurityDreamy_JazzT316414 CVE-2022-39193: Special:Investigate can expose supressed information in check results
 ResolvedSecurityDreamy_JazzT318166 CVE-2022-39193: CheckUser API can expose the suppressed performer
 ResolvedSecurityDreamy_JazzT316360 Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it
Restricted Task
 ResolvedBUG REPORTDreamy_JazzT326866 CVE-2024-40596: Special:Investigate can expose suppressed information for log events
 ResolvedBUG REPORTDreamy_JazzT326867 CVE-2024-40598: CheckUser API can expose suppressed information for log events
 ResolvedBUG REPORTDreamy_JazzT326865 CVE-2024-40597: Special:CheckUser can expose suppressed information for log events
 ResolvedDreamy_JazzT253796 Make CheckUser record the log_id of logged actions
 OpenNoneT139810 RFC: Overhaul the CheckUser extension
 ResolvedDreamy_JazzT132892 CheckUser UI revamp
 ResolvedDreamy_JazzT69811 CheckUsers "Get users" design needs improvements
 ResolvedFeatureDreamy_JazzT24120 Enhance Blocking and tagging from checkuser interface: add dropdowns
 DuplicateNoneT145340 Split CheckUser mass-block interface to separate special page
 ResolvedFeatureDreamy_JazzT316441 Enforce minimum length of the tag on the client side for the checkuser block form
 ResolvedFeatureDreamy_JazzT321427 Allow HTMLForm text based elements to specify a minimum length
 ResolvedFeatureDreamy_JazzT321439 Allow TextInputWidget to specify the "minlength" attribute
 ResolvedFeatureDreamy_JazzT316444 The CheckUser block form should explain why users were not blocked or tagged
 ResolvedFeatureDreamy_JazzT314700 Restore the bottom paging links on 'Get users'
 ResolvedBUG REPORTDreamy_JazzT314217 Checkuserblock form is broken when paging links are shown on 'Get users'
 DeclinedFeatureNoneT313451 Separate out when the blocks are made for IPs and users in Special:CheckUser 'get users' mode
 ResolvedFeatureDreamy_JazzT18306 Allow user to specify block settings from CU form
 ResolvedGlaisherT41213 Block interface after "Get users" check should allow talk page/send email blocking
 ResolvedFeatureDreamy_JazzT329493 Replace Special:CheckUser's 'get users' block form with a usage of Special:InvestigateBlock
 ResolvedDreamy_JazzT339914 Remove CheckUserEnableSpecialInvestigate config
 ResolvedFeatureDreamy_JazzT318458 Add dropdown options for the reason in Special:InvestigateBlock (like Special:Block has)
 ResolvedDreamy_JazzT362569 Test SpecialInvestigateBlock
 ResolvedDreamy_JazzT366265 Limit the number of blocks that can be performed in a single use of Special:InvestigateBlock to wgCheckUserMaxBlocks
 DeclinedNoneT27053 Replace user / talk pages feature of "Get users" creates a user/talk page if it doesnt exist
 ResolvedFeatureDreamy_JazzT318459 Make a clearer visual distinction between the UA and IP list in 'get users'
 ResolvedGlaisherT49505 CheckUser results (userlinks) cannot be customized
 ResolvedNiharikaT24119 Enhance Blocking and tagging from checkuser interface: add new page
 ResolvedNoneT14808 Blocking and tagging from checkuser interface
 ResolvedFeatureDreamy_JazzT16699 More versatile searching in CheckUser log
 DeclinedNoneT15789 Restore the global CheckUser log
 ResolvedFeatureDreamy_JazzT309924 Add check links for both the target and performer in Special:CheckUserLog
 ResolvedFeatureDreamy_JazzT309925 Implement User:Amalthea/culoghelper.js into the CheckUser extension
 DuplicateNoneT140345 Userlinks in CheckUser should be customizable
 ResolvedDreamy_JazzT21964 Provide a link to the user on account creation
 DuplicateNoneT144099 Make CheckUser unit-testable
 ResolvedDreamy_JazzT309815 Use OOUI in Special:CheckUser
 ResolvedDreamy_JazzT310019 The Special:CheckUser block form should use OOUI
 ResolvedDreamy_JazzT266586 Use OOUI in SpecialCheckUserLog
Restricted Task
 OpenFeatureNoneT26231 Allow CheckUsers to filter checks for account creations only
 ResolvedDreamy_JazzT139809 Bad output of AbuseFilter blocks in CU get edits
 ResolvedBUG REPORTDreamy_JazzT41013 Incomplete i18n for log entries in CheckUser
 ResolvedBUG REPORTDreamy_JazzT268156 Partial blocks from namespaces are displayed odd
 OpenNoneT311354 Make CheckUser results easier to parse by userscripts
 OpenFeatureNoneT311380 Make certain types of edits in 'Get edits' highlightable for ease of parsing the results
 DeclinedFeatureNoneT54849 Checkuser option "get users" should point out when user password is changed
 OpenFeatureNoneT315488 Show failed login attempts in the results list for the user
Restricted Task
 ResolvedDreamy_JazzT145265 Store check user data action text in structured format
 ResolvedkostajhT257893 [EPIC] Support User-Agent Client Hints header in CheckUser
 OpenNoneT341094 Create client hint mapping rows for CheckUser-worthy events
 ResolvedNoneT248926 Performance review of checkuser database queries [NOT READY]
 ResolvedtstarlingT342613 CompareService::getTotalEditsFromIp queries exceeding TransactionProfiler limits
 OpenNoneT301992 Insert CheckUser row events during certain 2FA actions
 ResolvedTchandersT326393 IP Address Reveal on Log page
 DeclinedBUG REPORTNoneT28843 CheckUser results do not appear cleanly for AbuseFilter modifications
 OpenNoneT366719 Update AccountInfo InfoLookup::getUserInfo to read data from cu_log_event and cu_private_event
 OpenNoneT366739 Update ArticleFeedbackv5 rebuildCheckUser.php maintenance script for CheckUser extension database changes
 ResolvedDreamy_JazzT371099 No longer use removed cuc_actiontext column in analytics/refinery
 ResolvedFeatureDreamy_JazzT324907 Create separate tables for log events in CheckUser
 ResolvedDreamy_JazzT366507 Remove 'CheckUserInsertForRecentChange' hook
 ResolvedDreamy_JazzT357620 Hard deprecate the CheckUserInsertForRecentChange hook

Event Timeline

Dreamy_Jazz created this task.Feb 15 2024, 11:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2024, 11:34 AM
Dreamy_Jazz claimed this task.Feb 15 2024, 11:34 AM
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.
Dreamy_Jazz set the point value for this task to 1.
gerritbot added a comment.Feb 15 2024, 11:44 AM

Change 1003615 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Mark CheckUserInsertForRecentChange as hard deprecated

https://gerrit.wikimedia.org/r/1003615

gerritbot added a project: Patch-For-Review.Feb 15 2024, 11:44 AM
gerritbot added a comment.Feb 15 2024, 12:54 PM

Change 1003746 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/Flow@master] Replace deprecated CheckUserInsertForRecentChange hook handler

https://gerrit.wikimedia.org/r/1003746

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.Feb 15 2024, 1:05 PM
Dreamy_Jazz added a project: StructuredDiscussions.Feb 15 2024, 1:08 PM
Dreamy_Jazz updated the task description. (Show Details)
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 15 2024, 1:08 PM
Dreamy_Jazz added a parent task: T324907: Create separate tables for log events in CheckUser.Feb 16 2024, 11:05 AM
Urbanecm_WMF moved this task from Inbox to Triaged on the Growth-Team board.Feb 19 2024, 8:09 AM
Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)); removed Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).Feb 20 2024, 12:07 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.
gerritbot added a comment.Feb 21 2024, 1:08 PM

Change 1003746 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace deprecated CheckUserInsertForRecentChange hook handler

https://gerrit.wikimedia.org/r/1003746

Tchanders moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 21 2024, 1:15 PM
gerritbot added a comment.Feb 21 2024, 1:32 PM

Change 1003615 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Mark CheckUserInsertForRecentChange as hard deprecated

https://gerrit.wikimedia.org/r/1003615

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2024, 2:30 PM
dom_walden moved this task from Needs QA to Done on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 21 2024, 4:07 PM
dom_walden subscribed.

I see after creating a new StructuredDiscussion post, the respective entry in Special:CheckUser appears to be correct (it has the correct comment).

Test environment: Local docker CheckUser 2.5 (5485886) 07:35, 21 February 2024.

Dreamy_Jazz closed this task as Resolved.Feb 21 2024, 7:38 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 22 2024, 12:02 PM
Dreamy_Jazz edited parent tasks, added: T366507: Remove 'CheckUserInsertForRecentChange' hook; removed: T324907: Create separate tables for log events in CheckUser.Jun 5 2024, 4:44 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits