Hard deprecate the CheckUserInsertForRecentChange hook
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The CheckUserInsertForRecentChange hook was soft deprecated in 1.40 as part of T324907: Create separate tables for log events in CheckUser. The hook now needs to be hard deprecated to comply with the Deprecation process and allow it's removal in the next release.

One remaining usages exists in the StructuredDiscussions extension which will need to be replaced before the hook is hard deprecated.

Details

	Subject	Repo	Branch	Lines +/-
	Mark CheckUserInsertForRecentChange as hard deprecated	mediawiki/extensions/CheckUser	master	+5 -0
	Replace deprecated CheckUserInsertForRecentChange hook handler	mediawiki/extensions/Flow	master	+113 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Feature	Dreamy_Jazz	T311375 Instead of not showing any results on too many results show the results to the truncation point with a pager that allows generation of more results
Open	Feature	Dreamy_Jazz	T313446 Make non-CUs linking users and IPs when CUs use block forms in CheckUser harder
			Restricted Task
			Restricted Task
			Restricted Task
Resolved	Security	Zabe	T311337 CVE-2022-39193: Edits with the performer suppressed still show the performer in results from the CheckUser extension
Resolved	Security	Dreamy_Jazz	T316414 CVE-2022-39193: Special:Investigate can expose supressed information in check results
Resolved	Security	Dreamy_Jazz	T318166 CVE-2022-39193: CheckUser API can expose the suppressed performer
Resolved	Security	Dreamy_Jazz	T316360 Oversighted action text is shown in Special:CheckUser when the checkuser does not have the right to see it
			Restricted Task
Open	BUG REPORT	None	T326866 Special:Investigate can expose suppressed information for log events
Resolved	BUG REPORT	Dreamy_Jazz	T326867 CheckUser API can expose suppressed information for log events
Resolved	BUG REPORT	Dreamy_Jazz	T326865 Special:CheckUser can expose suppressed information for log events
Resolved		Dreamy_Jazz	T253796 Make CheckUser record the log_id of logged actions
Open		None	T139810 RFC: Overhaul the CheckUser extension
Open		None	T132892 CheckUser UI revamp
Open		None	T69811 CheckUsers "Get users" design needs improvements
Open	Feature	Dreamy_Jazz	T24120 Enhance Blocking and tagging from checkuser interface: add dropdowns
Duplicate		None	T145340 Split CheckUser mass-block interface to separate special page
Open	Feature	None	T324709 Allow the HTMLForm Select and other field to have a minimum length set
Resolved	Feature	Dreamy_Jazz	T316441 Enforce minimum length of the tag on the client side for the checkuser block form
Resolved	Feature	Dreamy_Jazz	T321427 Allow HTMLForm text based elements to specify a minimum length
Resolved	Feature	Dreamy_Jazz	T321439 Allow TextInputWidget to specify the "minlength" attribute
Open	Feature	None	T316444 The CheckUser block form should explain why users were not blocked or tagged
Open	Feature	None	T314700 Restore the bottom paging links on 'Get users'
Resolved	BUG REPORT	Dreamy_Jazz	T314217 Checkuserblock form is broken when paging links are shown on 'Get users'
Declined	Feature	None	T313451 Separate out when the blocks are made for IPs and users in Special:CheckUser 'get users' mode
Open	Feature	None	T18306 Allow user to specify block settings from CU form
Resolved		Glaisher	T41213 Block interface after "Get users" check should allow talk page/send email blocking
Open	Feature	None	T329493 Replace Special:CheckUser's 'get users' block form with a usage of Special:InvestigateBlock
Resolved		Dreamy_Jazz	T339914 Remove CheckUserEnableSpecialInvestigate config
Resolved	Feature	Dreamy_Jazz	T318458 Add dropdown options for the reason in Special:InvestigateBlock (like Special:Block has)
Resolved		Dreamy_Jazz	T362569 Test SpecialInvestigateBlock
Open		None	T27053 Replace user / talk pages feature of "Get users" creates a user/talk page if it doesnt exist
Resolved	Feature	Dreamy_Jazz	T318459 Make a clearer visual distinction between the UA and IP list in 'get users'
Resolved		Glaisher	T49505 CheckUser results (userlinks) cannot be customized
Resolved		Niharika	T24119 Enhance Blocking and tagging from checkuser interface: add new page
Resolved		None	T14808 Blocking and tagging from checkuser interface
Resolved	Feature	Dreamy_Jazz	T16699 More versatile searching in CheckUser log
Declined		None	T15789 Restore the global CheckUser log
Resolved	Feature	Dreamy_Jazz	T309924 Add check links for both the target and performer in Special:CheckUserLog
Resolved	Feature	Dreamy_Jazz	T309925 Implement User:Amalthea/culoghelper.js into the CheckUser extension
Duplicate		None	T140345 Userlinks in CheckUser should be customizable
Open		None	T21964 Provide a link to the user on account creation
Duplicate		None	T144099 Make CheckUser unit-testable
Resolved		Dreamy_Jazz	T309815 Use OOUI in Special:CheckUser
Resolved		Dreamy_Jazz	T310019 The Special:CheckUser block form should use OOUI
Resolved		Dreamy_Jazz	T266586 Use OOUI in SpecialCheckUserLog
			Restricted Task
Open	Feature	None	T26231 Allow CheckUsers to filter checks for account creations only
Resolved		Dreamy_Jazz	T139809 Bad output of AbuseFilter blocks in CU get edits
Resolved	BUG REPORT	Dreamy_Jazz	T41013 Incomplete i18n for log entries in CheckUser
Resolved	BUG REPORT	Dreamy_Jazz	T268156 Partial blocks from namespaces are displayed odd
Open		None	T311354 Make CheckUser results easier to parse by userscripts
Open	Feature	None	T311380 Make certain types of edits in 'Get edits' highlightable for ease of parsing the results
Declined	Feature	None	T54849 Checkuser option "get users" should point out when user password is changed
Open	Feature	None	T315488 Show failed login attempts in the results list for the user
			Restricted Task
Resolved		Dreamy_Jazz	T145265 Store check user data action text in structured format
Resolved		kostajh	T257893 [EPIC] Support User-Agent Client Hints header in CheckUser
Open		None	T341094 Create client hint mapping rows for CheckUser-worthy events
Open		None	T248926 Performance review of checkuser database queries [NOT READY]
Resolved		tstarling	T342613 CompareService::getTotalEditsFromIp queries exceeding TransactionProfiler limits
Open		None	T301992 Insert CheckUser row events during certain 2FA actions
Resolved		Tchanders	T326393 IP Address Reveal on Log page
Open	BUG REPORT	None	T28843 CheckUser results do not appear cleanly for AbuseFilter modifications
Open	Feature	Dreamy_Jazz	T324907 Create separate tables for log events in CheckUser
Resolved		Dreamy_Jazz	T357620 Hard deprecate the CheckUserInsertForRecentChange hook

Event Timeline

Dreamy_Jazz created this task.Feb 15 2024, 11:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 15 2024, 11:34 AM

Dreamy_Jazz claimed this task.Feb 15 2024, 11:34 AM

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.

Dreamy_Jazz set the point value for this task to 1.

Change 1003615 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Mark CheckUserInsertForRecentChange as hard deprecated

https://gerrit.wikimedia.org/r/1003615

gerritbot added a project: Patch-For-Review.Feb 15 2024, 11:44 AM

Change 1003746 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/Flow@master] Replace deprecated CheckUserInsertForRecentChange hook handler

https://gerrit.wikimedia.org/r/1003746

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.Feb 15 2024, 1:05 PM

Dreamy_Jazz added a project: StructuredDiscussions.Feb 15 2024, 1:08 PM

Dreamy_Jazz updated the task description. (Show Details)

Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 15 2024, 1:08 PM

Dreamy_Jazz added a parent task: T324907: Create separate tables for log events in CheckUser.Feb 16 2024, 11:05 AM

Urbanecm_WMF moved this task from Inbox to Triaged on the Growth-Team board.Feb 19 2024, 8:09 AM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)); removed Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).Feb 20 2024, 12:07 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.

Change 1003746 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Replace deprecated CheckUserInsertForRecentChange hook handler

https://gerrit.wikimedia.org/r/1003746

Tchanders moved this task from Needs review to Needs QA on the Trust and Safety Product Sprint (Sprint Piano (Feb 19th - 1st March)) board.Feb 21 2024, 1:15 PM

Change 1003615 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Mark CheckUserInsertForRecentChange as hard deprecated

https://gerrit.wikimedia.org/r/1003615

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2024, 2:30 PM

I see after creating a new StructuredDiscussion post, the respective entry in Special:CheckUser appears to be correct (it has the correct comment).

Test environment: Local docker CheckUser 2.5 (5485886) 07:35, 21 February 2024.

Dreamy_Jazz closed this task as Resolved.Feb 21 2024, 7:38 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 22 2024, 12:02 PM

Hard deprecate the CheckUserInsertForRecentChange hookClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Hard deprecate the CheckUserInsertForRecentChange hook
Closed, ResolvedPublic1 Estimated Story Points
Actions

Related Objects
Search...