Page MenuHomePhabricator

Create client functionality for getting human readable wikitext from Wikibase statements
Closed, ResolvedPublic

Description

The current access methods for getting statement values for display in wikitext (Lua: mw.wikibase.entity:formatPropertyValues, wikitext: {{#property:…}}) are being heavily used and the output formats are being exploited in various places. For example many consumers assume that external ids are returned as plain strings, not as linked wikitext.

In order to not break with existing consumers, we decided to implement new functions that will output the format which is best for human consumption.

Related Objects

StatusSubtypeAssignedTask
Resolvedthiemowmde
Resolvedthiemowmde
Resolvedhoo
Resolvedhoo
Resolvedhoo
OpenNone
DuplicateNone
DeclinedNone
Resolvedhoo
Resolvedhoo
Resolvedhoo
DuplicateNone
DeclinedNone
ResolvedLucie
ResolvedLucie
InvalidLucie
OpenNone
ResolvedLucie
ResolvedLucie
ResolvedLucie
OpenNone
OpenNone
Resolvedhoo
ResolvedLucie
Resolvedoschposch
Resolvedhoo
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
OpenNone
DeclinedNone
OpenNone
ResolvedLucie
ResolvedLucie
DuplicateLucie
ResolvedLucie
DuplicateLucie
ResolvedLucie
OpenNone
ResolvedLucie
ResolvedLucie
ResolvedLucie
Resolvedhoo
ResolvedTobi_WMDE_SW
Resolveddaniel
Resolveddaniel
Resolveddaniel
Resolveddaniel
Resolveddaniel
Resolveddaniel
Resolveddaniel
Resolvedaude
Resolveddaniel
Resolveddaniel
ResolvedLucie
ResolvedLucie
ResolvedLucie
OpenNone
Resolvedthiemowmde
Resolvedlucamauri
ResolvedLucie
OpenNone
ResolvedLucie
ResolvedLucie
ResolvedLucie
Resolved Jonas
OpenNone
ResolvedLucie
ResolvedLucie
ResolvedLucie
ResolvedLucie
ResolvedLucie
ResolvedLucie
ResolvedLucie
ResolvedLucie
ResolvedJanZerebecki
ResolvedJanZerebecki
DeclinedNone
DuplicateLucie
ResolvedLucie
ResolvedLucie
ResolvedLucie
Resolvedhoo
ResolvedLucie
ResolvedLucie
Resolved Jonas
ResolvedAklapper
DeclinedDereckson
Resolvedcsteipp
ResolvedJanZerebecki
DuplicateNone
Resolvedhoo
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedLucie
ResolvedNone
ResolvedLucie
OpenNone
InvalidLucie
DeclinedLucie
ResolvedLucie
InvalidLucie
ResolvedLucie
DuplicateNone
Resolvedhoo
Resolvedhoo
ResolvedLydia_Pintscher
Resolvedthiemowmde
InvalidNone
Resolveddaniel
Resolvedthiemowmde
Resolvedaude

Event Timeline

@Lydia_Pintscher I couldn't find anything regarding that in our arguments doc and also can't remember what name we came up with back then.

I chose to go with statement here, as it's a short name (easy to remember, hard to misremember, which might happen with a name that is property-something). Also it's the right term for what it does, while property is not (you can argue that it stands for renderstatementbyproperty or so, but I think that's not what people have in mind).

@Lucie Do you remember it?
@daniel Do you have a good idea for a name?

I have sadly no notes either. I vaguely remember something including "property" but honestly would prefer "statement" since it's more descriptive about the functionality and I think that weights for me more than making clear with the name how it is connected to {{#property:…}}

@Lydia_Pintscher Are you fine with the proposed Lua function name (mw.wikibase.entity:formatStatementValues)?

Updated the names for the new functionality listed in the sub-tickets according to a discussion we just had.

thiemowmde triaged this task as Medium priority.Sep 1 2016, 2:58 PM
thiemowmde added a subscriber: thiemowmde.
Jonas raised the priority of this task from Medium to High.Oct 12 2016, 9:02 AM

Change 315682 had a related patch set uploaded (by Hoo man):
Introduce DataAccessSnakFormatterFactory::newRichWikitextSnakFormatter

https://gerrit.wikimedia.org/r/315682

Change 315682 merged by jenkins-bot:
Introduce DataAccessSnakFormatterFactory::newRichWikitextSnakFormatter

https://gerrit.wikimedia.org/r/315682

Change 317840 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Enable Wikibase #statements parser function on all test wikis

https://gerrit.wikimedia.org/r/317840

Change 318071 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Enable Wikibase #statements parser function on beta

https://gerrit.wikimedia.org/r/318071

Change 318071 merged by jenkins-bot:
Enable Wikibase #statements parser function on beta

https://gerrit.wikimedia.org/r/318071

thiemowmde claimed this task.

Change 317840 merged by jenkins-bot:
Enable Wikibase #statements parser function on all test wikis

https://gerrit.wikimedia.org/r/317840