Page MenuHomePhabricator
Create Task
Maniphest T142940

Create client functionality for getting human readable wikitext from Wikibase statements
Closed, ResolvedPublic
Actions

Description

The current access methods for getting statement values for display in wikitext (Lua: mw.wikibase.entity:formatPropertyValues, wikitext: {{#property:…}}) are being heavily used and the output formats are being exploited in various places. For example many consumers assume that external ids are returned as plain strings, not as linked wikitext.

In order to not break with existing consumers, we decided to implement new functions that will output the format which is best for human consumption.

Details

SubjectRepoBranchLines +/-
Enable Wikibase #statements parser function on all test wikisoperations/mediawiki-configmaster+2 -0
Enable Wikibase #statements parser function on betaoperations/mediawiki-configmaster+2 -0
Introduce DataAccessSnakFormatterFactory::newRichWikitextSnakFormattermediawiki/extensions/Wikibasemaster+107 -11
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedthiemowmdeT142940 Create client functionality for getting human readable wikitext from Wikibase statements
 ResolvedthiemowmdeT142941 Create a {{#statements:…}} parser function for human readable access to statements
 ResolvedhooT147568 Create regression tests for the output of client data access functionality
 ResolvedhooT147580 Use SnakFormatter::FORMAT_PLAIN for the current output of client data access functionality
 ResolvedhooT142942 [Task] Create mw.wikibase.entity:formatStatements for human readable access to statements
 OpenNoneT109324 [Story] Provide lua module for handling Wikibase time values
 DuplicateNoneT143841 Implement a hook for linking wikibase-item values that don't have local sitelink
 DeclinedNoneT143842 Choose a color for linking article placeholders in place of redlinks
 ResolvedhooT147307 [RfC] Decide whether values outputted by new human readable access functionality should be wrapped in spans.
 ResolvedhooT147591 Look at FORMAT_WIKI usages in the wbformatvalue API
 ResolvedhooT58763 Rendering URL datatype as wikitext should generate an external link instead of a bare URL
 DuplicateNoneT147651 Wikitext output of external ids on Client should be a link, not just the plain identifier string
 DeclinedNoneT99897 {{#property}} parser function should output EntityIdValues as local wiki links, once we have article placeholders
 ResolvedLucieT99895 [Epic] Article placeholder based on data from Wikidata
 ResolvedLucieT109436 [Story] Discover Article Placeholders
 InvalidLucieT109437 [RFC] Get to article placeholder from red link/404 article
 OpenNoneT123021 Implement connection between nonexistent pages (red links) and Wikidata items
 ResolvedLucieT109438 [Story] Get to Article Placeholder via search
 ResolvedLucieT109440 [Story] Get to the Article Placholder via the SpecialPage url
 ResolvedLucieT117693 [Story] ArticlePlaceholder pages should show up in search engines
 OpenNoneT144591 Create a special page that lists all indexable placeholders
 OpenNoneT145200 [RfC] Find a name for the special page that lists all placeholders considered "notable" enough to be indexed
 ResolvedhooT144592 Search index a limited number of article placeholders on cywiki for testing and evaluation purposes
 ResolvedLucieT144589 Evaluate placeholder structure
 ResolvedoschposchT144590 Introduce a setting for allowing article placeholders to be indexed by search engines
 ResolvedhooT109458 [Story] CDN cache article placeholders
 ResolvedLydia_PintscherT148831 [RfC] What do we want to find out after indexing placeholders?
 ResolvedLydia_PintscherT156832 [RfC] Decide whether to index not-notable placeholders
 OpenNoneT158506 Add a sitemap with all indexable placeholders on cywiki (Welsh Wikipedia)
 DeclinedNoneT158507 Consider translations and tweak the "notability" requirement for placeholders to be indexable
 OpenNoneT167872 Correctly set lang HTML attribute for each article placeholder string
 ResolvedLucieT109445 [Story] Display the Article Placeholder
 ResolvedLucieT109447 [Story] default display for article placeholder
 DuplicateLucieT109833 [Story] link for all items with a link to the local wiki
 ResolvedLucieT113936 [Story] initial default display of article placeholder
 DuplicateLucieT113952 [Story] Sorting properties
 ResolvedLucieT113958 [Story] Localisation of the default display
 OpenNoneT117557 [Story] Link to other placeholder
 ResolvedLucieT118382 [Story] Blacklist "imported from $1 Wikipedia" as reference
ResolvedLucieT118693 [Story] Put identifiers into separate section in the article placeholder
 ResolvedLucieT118694 [Story] Handling of identifier in the article placeholder
 ResolvedhooT95682 [Task] Add a new datatype for identifiers
 ResolvedTobi_WMDE_SWT88451 [Epic] Provide a mechanism for registering new data types.
 ResolveddanielT104329 [Task] Create central registry for datatypes
 ResolveddanielT110212 Manage ValueParsers based on central DataType registry
 ResolveddanielT110213 Manage ValueFormatters based on central DataType registry
 ResolveddanielT110214 [Task] Manage RDF mapping of data values based on central DataType registry
 ResolveddanielT112083 [Task] Allow RDF bindings for different data types to be registered dynamically.
 ResolveddanielT118499 [Task] Define RDF mappings per value type
 ResolveddanielT118497 [Task] Allow central datatype registry to also manage callbacks per value type.
 ResolvedaudeT120643 Adjust WikibaseQuality external validation for changes in data type registration
 ResolveddanielT118500 [Task] Split RDF mapping code into separate classes per type
 ResolveddanielT110215 Manage ValueValidators based on central DataType registry
 ResolvedLucieT119312 [Task] Refactor EntityRenderer.lua
 ResolvedLucieT119505 [RfC] What to do with sitelinks to other projects?
 ResolvedLucieT120521 [Task] Remove the word "Description:" from the generated page
 OpenNoneT120376 Labels and entity ids shown should have their respective descriptions as html title
 ResolvedthiemowmdeT113955 [Story] Show links to local wiki articles in statements in ArticlePlaceholder
 ResolvedlucamauriT124191 [Task] Mention that a page is ArticlePlaceholder generated
 ResolvedLucieT109578 [Story] extended display for article placeholder
 OpenNoneT125434 Research on right to left languages layout in ArticlePlaceholder
 ResolvedLucieT109451 [Story] Creation of article from Article Placeholder
 ResolvedLucieT109452 [Story] Create article from scratch from Article Placeholder
 ResolvedLucieT109453 [Story] Create and translate article
Resolved• JonasT151858 rework translation/article creation UI
 OpenNoneT141769 Start from a non-blank page when creating an article
 ResolvedLucieT117965 Review and deploy of the ArticlePlaceholder extension
 ResolvedLucieT117683 [Tracking] Finish minimal loveable product as beta feature
 ResolvedLucieT117007 [Story] Don't load a placeholder, if item doesn't exist
 ResolvedLucieT115051 [Task] Use EntityLookup for article placeholder
 ResolvedLucieT115020 [Task] Rename Special:FancyUnicorn to Special:AboutTopic
 ResolvedLucieT113957 [Story] Set the image Property id in configurations
 ResolvedLucieT113959 [Story] [Article Placeholder] Write tests
 ResolvedLucieT117685 [Task] Tests for SearchHookHandler
 ResolvedJanZerebeckiT113049 [Task] add CI to extension ArticlePlaceholder
 ResolvedJanZerebeckiT112572 [Task] make Wikibase work in WM CI without special config
 DeclinedNoneT112638 [Story] beta feature status for initial article placeholder rollout
 DuplicateLucieT117539 [Story] First layout Article Placeholder
 ResolvedLucieT109454 [Story] Create mockup for the article placeholder
 ResolvedLucieT117684 [Task] Add comment to Template and Module
 ResolvedLucieT119834 [Task] Move references to the bottom of the page
 ResolvedhooT123970 [ArticlePlaceholder] Fill composer.json and add to packagist
 ResolvedLucieT109442 [Story] show article if it exists instead of placeholder
 ResolvedLucieT120373 Prefix Lua module names
 Resolved• JonasT124036 [Task] Add button to translate article
 ResolvedAklapperT133774 Echo phpunit tests fail together with other extensions
 DeclinedDerecksonT125913 Capitalize property headings in the Special:AboutTopic view
 Resolved• csteippT118268 Security Review of Article Placeholder
 ResolvedJanZerebeckiT125901 Enable ArticlePlaceholder on test.wikipedia, test2.wikipedia and testwikidata
 DuplicateNoneT132219 Configure ArticlePlaceholder for htwiki
 ResolvedhooT134273 Deploy ArticlePlaceholder to eowiki, htwiki, orwiki and napwiki
 ResolvedNoneT132162 [Tracking] Requirements for initial Wikipedia deployments
 ResolvedNoneT131985 Multiple images not handled properly
 ResolvedNoneT131598 [Task] Document Module:AboutTopic
 ResolvedLucieT125980 [Task] Avoid id="coordinates" in HTML ArticlePlaceholder output
 ResolvedNoneT125196 Style article placeholders on mobile web (MobileFrontend)
 ResolvedLucieT113954 [Story] Only show notable items as search result
 OpenNoneT122996 Limit the resources ArticlePlaceholders can use further (compared to normal pages)
 InvalidLucieT121536 [Bug] No error message displayed when Property id entered
 DeclinedLucieT117556 Limit number of statements
 ResolvedLucieT117680 [Story] Ordering of statement groups for ArticlePlaceholder
 InvalidLucieT117681 [RfC] Ordering of statement groups in ArticlePlaceholder
 ResolvedLucieT120945 [Task] Add a parser for the property page
 DuplicateNoneT134638 [Task] Document Wikibase's statement sorting
 ResolvedhooT134639 [Task] Implement statement order fetching from other Wikis
 ResolvedhooT148025 [Task] Allow formatting of external identifiers as wiki links when using rich wikitext output
 ResolvedLydia_PintscherT148026 [RfC] Decide what to do with commonsMedia Snaks in new wikitext output format.
 ResolvedthiemowmdeT148626 [Task] EntityIdValues should be formatted as local wiki links in Wikitext output
 InvalidNoneT149005 time values should be formatted in Wikitext output (and not just use the ISO-like representation)
 ResolveddanielT150018 [RfC] Decide what link text to use for rich wikitext formatted URLs
 ResolvedthiemowmdeT150240 [RfC] Find a name for mw.wikibase.renderSnak(s) alternative with richt wikitext output
 ResolvedaudeT152780 deploy new statement parser function and Lua function

Event Timeline

hoo created this task.Aug 14 2016, 5:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 14 2016, 5:17 PM
hoo created subtask T142941: Create a {{#statements:…}} parser function for human readable access to statements.Aug 14 2016, 5:20 PM
hoo created subtask T142942: [Task] Create mw.wikibase.entity:formatStatements for human readable access to statements.
Lydia_Pintscher added a comment.Aug 15 2016, 9:27 AM
hoo added a comment.Aug 15 2016, 10:13 AM

@Lydia_Pintscher I couldn't find anything regarding that in our arguments doc and also can't remember what name we came up with back then.

I chose to go with statement here, as it's a short name (easy to remember, hard to misremember, which might happen with a name that is property-something). Also it's the right term for what it does, while property is not (you can argue that it stands for renderstatementbyproperty or so, but I think that's not what people have in mind).

Lydia_Pintscher added a subscriber: Lucie.Aug 15 2016, 12:29 PM

@Lucie Do you remember it?
@daniel Do you have a good idea for a name?

Lucie added a comment.Aug 17 2016, 4:20 PM

I have sadly no notes either. I vaguely remember something including "property" but honestly would prefer "statement" since it's more descriptive about the functionality and I think that weights for me more than making clear with the name how it is connected to {{#property:…}}

hoo added a comment.Aug 17 2016, 6:06 PM

@Lydia_Pintscher Are you fine with the proposed Lua function name (mw.wikibase.entity:formatStatementValues)?

hoo added a comment.Aug 24 2016, 7:14 PM

Updated the names for the new functionality listed in the sub-tickets according to a discussion we just had.

hoo created subtask T143841: Implement a hook for linking wikibase-item values that don't have local sitelink.Aug 24 2016, 11:37 PM
Lucie awarded a token.Sep 1 2016, 12:59 PM
thiemowmde triaged this task as Medium priority.Sep 1 2016, 2:58 PM
thiemowmde subscribed.
thiemowmde mentioned this in T142941: Create a {{#statements:…}} parser function for human readable access to statements.Sep 5 2016, 3:19 PM
hoo created subtask T147307: [RfC] Decide whether values outputted by new human readable access functionality should be wrapped in spans..Oct 4 2016, 1:21 PM
hoo created subtask T147580: Use SnakFormatter::FORMAT_PLAIN for the current output of client data access functionality.Oct 6 2016, 5:28 PM
hoo created subtask T147591: Look at FORMAT_WIKI usages in the wbformatvalue API.Oct 6 2016, 8:22 PM
hoo closed subtask T147591: Look at FORMAT_WIKI usages in the wbformatvalue API as Resolved.Oct 6 2016, 8:28 PM
hoo closed subtask T147580: Use SnakFormatter::FORMAT_PLAIN for the current output of client data access functionality as Resolved.Oct 7 2016, 3:08 PM
hoo added a subtask: T58763: Rendering URL datatype as wikitext should generate an external link instead of a bare URL.Oct 7 2016, 3:12 PM
hoo created subtask T147651: Wikitext output of external ids on Client should be a link, not just the plain identifier string.Oct 7 2016, 3:52 PM
hoo added a subtask: T99897: {{#property}} parser function should output EntityIdValues as local wiki links, once we have article placeholders.Oct 7 2016, 6:27 PM
• Jonas raised the priority of this task from Medium to High.Oct 12 2016, 9:02 AM
• Jonas added a project: Wikidata-Sprint-2016-10-12.
thiemowmde moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-10-12 board.Oct 12 2016, 12:23 PM
thiemowmde mentioned this in T99897: {{#property}} parser function should output EntityIdValues as local wiki links, once we have article placeholders.Oct 12 2016, 2:36 PM
thiemowmde closed subtask T99897: {{#property}} parser function should output EntityIdValues as local wiki links, once we have article placeholders as Declined.
thiemowmde added a comment.EditedOct 12 2016, 2:44 PM

Name discussion moved to T142941#2728378.

hoo created subtask T148025: [Task] Allow formatting of external identifiers as wiki links when using rich wikitext output.Oct 13 2016, 11:41 AM
hoo created subtask T148026: [RfC] Decide what to do with commonsMedia Snaks in new wikitext output format..Oct 13 2016, 11:47 AM
gerritbot subscribed.Oct 13 2016, 2:47 PM

Change 315682 had a related patch set uploaded (by Hoo man):
Introduce DataAccessSnakFormatterFactory::newRichWikitextSnakFormatter

https://gerrit.wikimedia.org/r/315682

gerritbot added a project: Patch-For-Review.Oct 13 2016, 2:47 PM
thiemowmde moved this task from Backlog to Review on the Wikidata-Sprint-2016-10-12 board.Oct 14 2016, 10:42 AM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Oct 17 2016, 2:57 PM
gerritbot added a comment.Oct 18 2016, 4:43 PM

Change 315682 merged by jenkins-bot:
Introduce DataAccessSnakFormatterFactory::newRichWikitextSnakFormatter

https://gerrit.wikimedia.org/r/315682

thiemowmde added a subtask: T148626: [Task] EntityIdValues should be formatted as local wiki links in Wikitext output.Oct 19 2016, 10:44 AM
thiemowmde closed subtask T147307: [RfC] Decide whether values outputted by new human readable access functionality should be wrapped in spans. as Resolved.
thiemowmde closed subtask T148025: [Task] Allow formatting of external identifiers as wiki links when using rich wikitext output as Resolved.Oct 20 2016, 7:28 AM
thiemowmde closed subtask T58763: Rendering URL datatype as wikitext should generate an external link instead of a bare URL as Resolved.Oct 20 2016, 10:29 AM
hoo reopened subtask T147307: [RfC] Decide whether values outputted by new human readable access functionality should be wrapped in spans. as Open.Oct 20 2016, 7:02 PM
thiemowmde closed subtask T142941: Create a {{#statements:…}} parser function for human readable access to statements as Resolved.Oct 24 2016, 2:44 PM
hoo created subtask T149005: time values should be formatted in Wikitext output (and not just use the ISO-like representation).Oct 24 2016, 8:14 PM
gerritbot added a comment.Oct 25 2016, 3:31 PM

Change 317840 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Enable Wikibase #statements parser function on all test wikis

https://gerrit.wikimedia.org/r/317840

gerritbot added a comment.Oct 26 2016, 9:53 AM

Change 318071 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Enable Wikibase #statements parser function on beta

https://gerrit.wikimedia.org/r/318071

gerritbot added a comment.Oct 26 2016, 6:46 PM

Change 318071 merged by jenkins-bot:
Enable Wikibase #statements parser function on beta

https://gerrit.wikimedia.org/r/318071

hoo added a comment.Oct 26 2016, 7:18 PM

Can now be seen in action on beta: https://de.wikipedia.beta.wmflabs.org/wiki/Statements

thiemowmde closed subtask T148026: [RfC] Decide what to do with commonsMedia Snaks in new wikitext output format. as Resolved.Oct 27 2016, 1:04 PM
thiemowmde closed subtask T142942: [Task] Create mw.wikibase.entity:formatStatements for human readable access to statements as Resolved.Oct 28 2016, 1:32 PM
thiemowmde closed subtask T148626: [Task] EntityIdValues should be formatted as local wiki links in Wikitext output as Resolved.
TomT0m subscribed.Oct 31 2016, 2:09 PM
hoo created subtask T150018: [RfC] Decide what link text to use for rich wikitext formatted URLs.Nov 4 2016, 2:49 PM
hoo closed subtask T149005: time values should be formatted in Wikitext output (and not just use the ISO-like representation) as Invalid.Nov 8 2016, 9:53 AM
hoo created subtask T150240: [RfC] Find a name for mw.wikibase.renderSnak(s) alternative with richt wikitext output.Nov 8 2016, 10:17 AM
thiemowmde added a project: Wikidata-Sprint-2016-11-08.Nov 8 2016, 1:49 PM
thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-11-08 board.Nov 8 2016, 2:00 PM
daniel closed subtask T150018: [RfC] Decide what link text to use for rich wikitext formatted URLs as Resolved.Nov 11 2016, 11:04 PM
thiemowmde added a project: Wikidata-Former-Sprint-Board.Nov 17 2016, 10:41 AM
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Nov 17 2016, 10:44 AM
• Jonas moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.Nov 23 2016, 1:59 PM
Lea_Lacroix_WMDE subscribed.Nov 29 2016, 1:23 PM
hoo closed subtask T150240: [RfC] Find a name for mw.wikibase.renderSnak(s) alternative with richt wikitext output as Resolved.Dec 6 2016, 12:32 PM
thiemowmde closed subtask T147307: [RfC] Decide whether values outputted by new human readable access functionality should be wrapped in spans. as Resolved.Dec 6 2016, 1:28 PM
thiemowmde closed this task as Resolved.Dec 6 2016, 1:31 PM
thiemowmde claimed this task.
gerritbot added a comment.Dec 7 2016, 2:24 PM

Change 317840 merged by jenkins-bot:
Enable Wikibase #statements parser function on all test wikis

https://gerrit.wikimedia.org/r/317840

Lydia_Pintscher added a subtask: T152780: deploy new statement parser function and Lua function.Dec 9 2016, 2:58 PM
aude closed subtask T152780: deploy new statement parser function and Lua function as Resolved.Dec 12 2016, 1:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL