Page MenuHomePhabricator
Create Task
Maniphest T203239

Create Debian packages for Node.js 10 upgrade
Closed, ResolvedPublic
Actions

Description

Initially to be used by the Zotero replacement (which doesn't work with node 6). Later on other node-based apps can migrate.

This is complex to build/package and node 10 packages will only be provided for stretch-wikimedia.

Details

SubjectRepoBranchLines +/-
Create node-10-docker job template and use for Fresnelintegration/configmaster+24 -3
Add 'control' files for node10 imagesintegration/configmaster+3 -0
Add component/node10 for stretch-wikimediaoperations/puppetproduction+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 StalledNoneT302086 Set scap minimum python version to 3.7
 ResolvedNoneT247045 Migrate all of production metal and VMs to Buster or later
 ResolvedakosiarisT249724 Track and remove jessie based container images from production
 ResolvedJdforrester-WMFT224908 Drop jessie testing support
 ResolvedJdforrester-WMFT224907 Drop php55 testing support
 ResolvedReedyT205039 Release MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205041 Tracking bug for 1.27.6/1.30.2/1.31.2/1.32.2 security release
 ResolvedBawolffT197279 Direct POST to Special:ChangeEmail will bypass reauth check
 ResolvedAnomieT204729 Potential enwiki DOS due to slow WatchedItemStore::countVisitingWatchersMultiple
 ResolvedBawolffT207603 CVE-2019-12471: Loading JS from user space where the username is not a registered account is dangerous and should be banned
 ResolvedBawolffT208881 CSS using var() to create exponential sized calc() on wiki page will crash visitor's browser
 ResolvedLegoktmT199540 Forbid blocking IP ranges as big as /1 and /2, as done on ruwikiquote using the API
 ResolvedLucas_Werkmeister_WMDET212118 API responses for unpatrolled or (not) autopatrolled recent changes require privileges but may be cached publicly
 ResolvedBawolffT209794 Need to make a limit of count of attempts to change email address
 ResolvedsbassettT222036 Exposed suppressed username or log in Special:EditTags
 ResolvedsbassettT222038 Exposed suppressed log in RevisionDelete page
 ResolvedJdforrester-WMFT221739 Patch jQuery due to CVE-2019-11358
 ResolvedsbassettT25227 Use token when logging out
 ResolvedsbassettT221868 Send out wikitech-l post for T25227 ("Use token when logging out")
 ResolvedReedyT205042 Write and send release announcements for 1.27.6/1.30.2/1.31.2/1.32.2 security releases
 ResolvedReedyT205043 Write and send pre-release Announcements for MediaWiki 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedJdforrester-WMFT205044 Update onwiki release notes for 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205046 Update HISTORY in master after 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT205047 Tag MW 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedReedyT224499 RELEASE-NOTES for 1.27.6/1.30.2/1.31.2/1.32.2
 ResolvedJdforrester-WMFT224912 Update MediaWiki.org links and versions
 ResolvedJdforrester-WMFT224913 EOL REL1_27 and REL1_30 onwiki
 ResolvedReedyT225201 Formally announce EOL of MW 1.27 and 1.30
 ResolvedReedyT225149 Update CVEs and publish them
 ResolvedReedyT205048 Obtain CVEs for 1.27.6/1.30.2/1.31.2/1.32.2 security releases
 ResolvedJdforrester-WMFT224906 Drop php56 testing support
 ResolvedhasharT223348 Run wikimedia/fundraising/crm CI jobs on PHP7x, not PHP5x
 ResolvedhasharT210287 Migrate wikimedia-fundraising-civicrm to a Docker container
 ResolvedJdforrester-WMFT224905 Move wikiba.se tests from php56 to php72
 ResolvedhasharT224591 Migrate contint* hosts to Buster
 DeclinedMoritzMuehlenhoffT226236 Upload docker-ce 18.06.3 upstream package for Stretch
 InvalidthciprianiT239880 Replacement hardware for buster/stretch upgrade of contint1001 and contint2001
 Resolved• mmodellT215458 Convert zuul to use scap
 ResolvedhasharT240551 Remove Zuul Debian package from WMCS instances
 ResolvedJoeT249110 Build and publish a python2 based container to build wheels
 ResolvedJMeybohmT249812 Rebuild helm/helm-diff for buster-wikimedia
 ResolvedJMeybohmT250479 Rebuild helmfile for buster-wikimedia
 DuplicateDzahnT210008 upgrade krypton (webserver_misc_apps) to stretch
 DeclinedDzahnT224194 switch webserver_misc_apps to PHP 7.2 (7.1)
 ResolvedJdforrester-WMFT211784 Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects
 ResolvedMoritzMuehlenhoffT203239 Create Debian packages for Node.js 10 upgrade

Event Timeline

MoritzMuehlenhoff created this task.Aug 31 2018, 11:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2018, 11:05 AM
MoritzMuehlenhoff claimed this task.Aug 31 2018, 11:25 AM
MoritzMuehlenhoff triaged this task as Medium priority.
MoritzMuehlenhoff added a comment.Aug 31 2018, 2:58 PM

One notable change which is to be expected from moving to 10:
Some node modules ship binary blobs in their modules and the official node packages are build against OpenSSL 1.0.2. nodejs 10 only supports OpenSSL 1.1 (which has a different ABI/API) and then those modules fail to load or throw runtime errors
Upstream discussion is at https://github.com/nodejs/node/issues/21897, but there's no real solution

All node binary packages will need to be built for our environment and not fetched from npm (which is the clean approach anyway), so packages moved to node 10 will need to be reviewed if any of the deps is affected by this.

• Pchelolo edited projects, added Services (watching); removed Services.Sep 5 2018, 5:39 PM
• Pchelolo subscribed.

All node binary packages will need to be built for our environment and not fetched from npm (which is the clean approach anyway)

For most of node services we actually build binary dependencies ourselves already with a docker build script, so this shouldn't be an issue. We even switch off node-pre-gyp in some cases to explicitly avoid fetching pre-built binaries.

Legoktm subscribed.Sep 7 2018, 6:33 AM

This is complex to build/package and node 10 packages will only be provided for stretch-wikimedia.

Will nodejs 10 packages be in a separate component for stretch-wikimedia, or will they replace the nodejs 6 packages currently in stretch-wikimedia's main?

MoritzMuehlenhoff added a comment.Sep 7 2018, 8:43 AM

nodejs 10 packages will be in a separate repository component, allowing applications to gradually move over. We'll continue to support nodejs 6 with security updates until all applications are migrated to 10.

Krinkle renamed this task from Create nodejs 10 packages to Create Debian packages for Node.js 10 upgrade.Sep 9 2018, 10:55 PM
Krinkle awarded a token.
Paladox subscribed.Sep 9 2018, 10:56 PM
• Mholloway subscribed.Sep 10 2018, 11:36 AM
Jdlrobson added a project: Web-Team-Backlog (Tracking).Sep 12 2018, 10:42 PM
• Niedzielski subscribed.Sep 12 2018, 10:43 PM
gerritbot subscribed.Sep 17 2018, 6:55 AM

Change 460787 had a related patch set uploaded (by Muehlenhoff; owner: Muehlenhoff):
[operations/puppet@production] Add component/node10 for stretch-wikimedia

https://gerrit.wikimedia.org/r/460787

gerritbot added a project: Patch-For-Review.Sep 17 2018, 6:55 AM

Change 460787 merged by Muehlenhoff:
[operations/puppet@production] Add component/node10 for stretch-wikimedia

https://gerrit.wikimedia.org/r/460787

MoritzMuehlenhoff added a comment.Sep 17 2018, 9:53 AM

nodejs 10 packages for stretch-wikimedia are now available in the repository component "component/node10" for testing. I'm keeping this bug open to track possible further additions (addons etc.)

• mobrovac edited projects, added Platform Team Legacy (Watching / External); removed Patch-For-Review.Oct 15 2018, 4:43 PM
MoritzMuehlenhoff mentioned this in T210704: Migrate node-based services in production to node10.Nov 29 2018, 9:12 AM
gerritbot added a comment.Jan 5 2019, 12:43 AM

Change 482392 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[integration/config@master] Create node10 image

https://gerrit.wikimedia.org/r/482392

gerritbot added a project: Patch-For-Review.Jan 5 2019, 12:43 AM
gerritbot added a comment.Jan 7 2019, 12:41 AM

Change 482572 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[integration/config@master] Create node-10-docker job template and use for Fresnel

https://gerrit.wikimedia.org/r/482572

gerritbot added a comment.Jan 7 2019, 12:53 AM

Change 482573 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[integration/config@master] Add 'control' files for node10 images

https://gerrit.wikimedia.org/r/482573

gerritbot added a comment.Jan 7 2019, 7:04 PM

Change 482573 merged by jenkins-bot:
[integration/config@master] Add 'control' files for node10 images

https://gerrit.wikimedia.org/r/482573

gerritbot added a comment.Jan 7 2019, 7:55 PM

Change 482572 merged by jenkins-bot:
[integration/config@master] Create node-10-docker job template and use for Fresnel

https://gerrit.wikimedia.org/r/482572

Krinkle mentioned this in T195103: Add Support for Node.js 10 LTS to Toolforge.Jan 10 2019, 11:51 PM
gerritbot added a comment.Jan 10 2019, 11:52 PM

Change 482755 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[integration/config@master] Create generic npm-test job for Node 10 (and use for jsdoc/wmf-theme)

https://gerrit.wikimedia.org/r/482755

Krinkle added a parent task: T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.Jan 11 2019, 12:00 AM
Krinkle mentioned this in T211784: Upgrade all CI jobs from node6/npm3 to node10/npm6 across all projects.
Krinkle closed this task as Resolved.Jan 11 2019, 2:33 AM
Krinkle removed a project: Patch-For-Review.
• Mholloway unsubscribed.Jan 11 2019, 3:19 AM
MSantos mentioned this in T216521: Create Debian packages for Node.js 8 upgrade for Maps.Feb 19 2019, 4:19 PM
Krinkle mentioned this in T267891: Create Debian packages for Node.js 14 upgrade.Nov 16 2020, 6:33 AM
Krinkle mentioned this in T284343: Create WMF CI image for Node.js 12.Jun 9 2021, 8:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL