Page MenuHomePhabricator

Send a notification when someone else edits your userpage
Closed, ResolvedPublic

Description

Before merging, this should have a $wgEchoUserPageEditNotification variable to enable it, defaulted false (like $wgEchoMentionStatusNotifications). This lets us control when it goes to production.

Also, fill out the form at https://phabricator.wikimedia.org/T168385#3439975 , and let product review, before merge.


I _have_ implemented this feature; it comes as a (positive) side-effect within the ENotif version see T2454 (pls. add you e-mail address to the CC of T2454, if you want to receive news about this.

The flag is shown, as long as not-yet-seen changes on both the user_talk or user page are pending. This is currently implemented as configurable feature depending on value of $wgShowNewtalkForUserOrUserTalkPage (true, false).

Tom (Wikinaut).

See also:

Revisions and Commits

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 371738 had a related patch set uploaded (by JoHammer; owner: JoHammer):
[mediawiki/extensions/Echo@master] send a notification if someone else edits your userpage

https://gerrit.wikimedia.org/r/371738

Aklapper added a subscriber: JoHammer.

@JoHammer: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action...Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!

Legoktm added a subscriber: Legoktm.

This was #2 on the 2022 survey: https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2022/Anti-harassment/Notifications_for_user_page_edits and adding a new notification is actually pretty straightforward, so I'll give this a shot.

A few people asked for subpages too, I think we should start with the root user page only and see what people think (if you think user subpages would be useful, please speak up). The notification will be bundled, like talk pages, so if 2 people edit it quickly, the notification will say "2 people edited your user page" rather than getting 2 notifications. And we can keep the same logic as talk page notifications, if a bot edits it as minor, then it'll be ignored.

I'd prefer subpages be included, but if it's only the root page for now that's still a solid addition IMO.

I'd prefer subpages be included as well. If someone edits one of my user subpages, whether intentionally (spam, harassment, etc.) or accidentally (such as leaving a talk page message in the wrong place), I'd like to know about it so I can clean things up (remove the spam or move the message to my talk page).

I'm okay with it just being root pages, but I'd prefer it include subpages. Would it be possible to make it an option? (No notification/ notification for root pages/ notification for root and subpages)

Subpages included will be great if it is possible to let user exclude some pages, as some subpages are designed to be edited by others (so we have template unlocked userpage). For a page with this template, user should not be notified if someone edit their pages.

This was #2 on the 2022 survey: https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2022/Anti-harassment/Notifications_for_user_page_edits and adding a new notification is actually pretty straightforward, so I'll give this a shot.

Thanks for taking this on!

A few people asked for subpages too, I think we should start with the root user page only and see what people think (if you think user subpages would be useful, please speak up). The notification will be bundled, like talk pages, so if 2 people edit it quickly, the notification will say "2 people edited your user page" rather than getting 2 notifications. And we can keep the same logic as talk page notifications, if a bot edits it as minor, then it'll be ignored.

I personally agree and think we should start with just the base userpages. Many people construct drafts and collaborate on subpages, and they'll probably want a way to turn that off but still keep notifications for the base userpage.

Community-Tech will be around to help with code review, user coordination, etc., as needed :)

Community-Tech will be around to help with code review, user coordination, etc., as needed :)

Could Community-Tech please answer the questions in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/371738 ? Thanks in advance!

Could Community-Tech please answer the questions in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/371738 ? Thanks in advance!

That patch is from 2017. It's probably best to abandon it at this point as I'm sure so much has changed in that time. My understanding from T3876#7723340 was that @Legoktm was going to re-implement this from scratch.

Sorry about the lack of updates, I both underestimated how much was needed to do this and overestimated my free time. I think I have about 75% done locally, I'll push whatever I have by midweek.

Change 866550 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/Echo@master] T3876 WIP

https://gerrit.wikimedia.org/r/866550

What's the update with Legoktm's patch?

Change 866550 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/Echo@master] T3876 WIP

https://gerrit.wikimedia.org/r/866550

What's the update with Legoktm's patch?

@Legoktm do you intend to keep working on the WIP patch, or is that available as a basis for someone to pick up and work on?

Change 866550 had a related patch set uploaded (by TheDJ; author: Legoktm):

[mediawiki/extensions/Echo@master] Add notification type for user page edits

https://gerrit.wikimedia.org/r/866550

Change 904755 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Echo@master] Don't send watchlist notice if edit-user-page or edit-user-talk are enabled

https://gerrit.wikimedia.org/r/904755

kostajh raised the priority of this task from Lowest to Medium.Mar 31 2023, 9:23 AM
kostajh added a project: User-notice.

User notice wording:

You can now receive notifications when another user edits your user page. See the "Edit to my user page" option on Special:Preferences#mw-prefsection-echo

Change 866550 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Add notification type for user page edits

https://gerrit.wikimedia.org/r/866550

Re: Tech News - thanks for the draft wording, 'tis appreciated!
I'm going to put this in the following week's edition, partially because then editors will be able to actually see the preference immediately (versus waiting 1–3 days), and partially because this week's edition is already longer than usual. Cheers.

Moved the comment to T334124 (thx, @Tacsipacsi for the comment below!)

@Etonkovidova You tested the wrong feature. Edit to my user talk page has been around for ages; the new feature is Edit to my user page, further down (cut off on your screenshot).

@Etonkovidova You tested the wrong feature. Edit to my user talk page has been around for ages; the new feature is Edit to my user page, further down (cut off on your screenshot).

Thanks, @Tacsipacsi! Sorry, I realized that the above comment should've been another task - T334124.
Checked edit-user-page notifications on testwiki wmf.3 - works as expected:

User page is created by another user and an edit is made
Screen Shot 2023-04-05 at 10.22.01 AM.png (500×1 px, 70 KB)
User preference for user page notification
Screen Shot 2023-04-05 at 10.23.36 AM.png (576×1 px, 72 KB)
Bundled user page notifications
Screen Shot 2023-04-05 at 10.25.23 AM.png (494×1 px, 52 KB)

The page has not been updated yet.

Someone on Enwiki suggests changing the ordering of this new preference, moving it to the 2nd-from-top, so that the 2 related types are next to each other. I.e.

  • Edit to my user talk page
  • Edit to my user page
  • ...

[I'm not sure if this needs a new sub-task, or can be easily done as part of wrapping up this one!]

@KStoller-WMF - should we follow up on this suggestion?

Someone on Enwiki suggests changing the ordering of this new preference, moving it to the 2nd-from-top, so that the 2 related types are next to each other. I.e.

  • Edit to my user talk page
  • Edit to my user page
  • ...

[I'm not sure if this needs a new sub-task, or can be easily done as part of wrapping up this one!]

Change 904755 abandoned by Kosta Harlan:

[mediawiki/extensions/Echo@master] EchoWatchlistNotifications: Don't create events if edit-user-page or edit-user-talk are enabled

Reason:

https://gerrit.wikimedia.org/r/904755