In T223408#5198738, @Gilles wrote:

Ian Marlier participated in the site maps project as his own personal initiative, but it has always been out of scope for the Performance Team. And his knowledge of that project left with him, so we're not better equipped than anyone else to do something about this.

Per T209377#5197164 and T209377#5200890.

• Delete PageSplitTester and PageSplitTesterTest from Wikibase (this will move to Core in T209319)
• Delete PageRandomLookup and PageRandomLookupTest
• Delete related configuration variables from Wikibase

How frequently is live updates enabled?

@MNeisler: As discussed: I'll take How frequently to users change the limit and days parameters?

AIUI this isn't High priority but a nice to have. Is that correct, @bearND?

Ping @Jdlrobson (the extension's author IIRC).

Setting up a development environment could be as trivial as adding the following to MobileFrontendHooks::onOutputPageParserOutput:

This LGTM.

🎉🎉🎉

Increase in JS bundlesizes should be consistent with the removal of the size of ResourceLoader's mobile.startup module. Change in bytes shipped to client should be recorded.

There are a few nitpicks (their words) from Timo Tijhof on @Jdrewniak's change: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/RelatedArticles/+/502529/3/resources/ext.relatedArticles.cards/CardView.js

I feel comfortable signing this off in @ovasileva's absence.

In T220627#5125187, @Nuria wrote:

Moving to radar as further steps of code chnages to Quicksurveys to fix loading issues with JS should be done by (i think) @phuedx team?

💪

Document the oversampling behaviour for AMC on the schema's talk page so Tilman can understand it

Update the schema revision number in MobileFrontend and move to Minerva codebase
Sampling rate should be 100% if the user is AMC, otherwise use the configurable sampling rate
Log whether the user is in AMC mode using the new schema revision ID

Update the schema to have an AMC flag

Thanks to @Krinkle both for discussing this issue and for the prompt review and merge.

2. Add an annotation to https://grafana.wikimedia.org/d/000000566/overview?panelId=15&fullscreen&orgId=1 at the time when the change is deploying

AIUI this task has been blocked on a request for privileges on some (all?) of the Wikipedias. The request has stalled, insofar as it hasn't been rejected nor has it been resolved, since giving a test account such privileges on production wikis will be viewed with suspicion by the community and may result in unintended outcomes.

I feel comfortable signing this off in @ovasileva's absence.

Per T220751#5137468, above.

I'd meant to follow up on this:

In the interest of fixing the discrepancy (at the expense of punting the more general problem, captured in T65459: Allow configuration of the Minerva menu), can we update [[ https://gerrit.wikimedia.org/g/mediawiki/skins/MinervaNeue/+/8086325cd25af356149dbd65f58b780caff4a67b/includes/menu/Definitions.php#191 | MediaWiki\Minerva\Menu\Definitions::insertRandomItem ]] to use

I'll follow up with Kate Zimmerman and Megan Neisler about how the ReadingDepth instrumentation fits in with their priorities.

In T214715#5134590, @pmiazga wrote:

Editors can update URIs of menu items e.g. On Commons, Special:Random can be replaced with Special:Random/file (see T188697)

• override the Definitions::insertRandomItem() to use the message cache. Instead of hardcoding Special:Random, we can load the title from Mediawiki:Random-url

I'm comfortable signing this off. Although one AC isn't satisfied, there's at least one task covering the community request. I'll follow up on that task with a simple suggestion that could get it unstuck.

Editors can update URIs of menu items e.g. On Commons, Special:Random can be replaced with Special:Random/file (see T188697)

A menu can be converted to a JSON of template properties so that it can be rendered by JavaScript via Mustache

A menu itself be made of multiple menus e.g. left hamburger navigation has 4 menus right now in stable
A menu uses a [Mustache] template for rendering so that it can also be used on the client.
Menus should work without JS

A menu can have completely different contents in a given mode e.g. contributions might be in left menu on stable but in a new user menu that shows on hover in AMC mode

It should be possible for an extension to register a menu item in a certain menu without any knowledge of how the menu is rendered.

Also! Thanks, everyone!

I've been noodling on proposing that @Stashbot and/or scap create annotations in Grafana. I think such annotations would've been useful here.

There's a spike in VirtualPageview events today (see https://grafana.wikimedia.org/d/000000018/eventlogging-schema?orgId=1&from=1555459200000&to=1555516800000&var-schema=VirtualPageView) which appears to correspond to today's updates to the cluster. Further confirmation?

From the SAL:

In T382#5108028, @Milimetric wrote:

Thanks @Tgr, that's a big pivot from what I was expecting, but hey, let's do it!

In T218627#5110077, @Edtadros wrote:

In the likely event I'm doing it wrong, after I click on the hamburger menu, I right click on Random and open that in a new window. <snip />

In T220627#5107552, @Isaac wrote:

And when do events for QuickSurveyInitiation and QuickSurveysResponses trigger?

• We are supposed to get a QuickSurveyInitiation every time the extension shows someone a survey: https://github.com/wikimedia/mediawiki-extensions-QuickSurveys/blob/c40f824c79b4e98993dafe7416a60fd6ad9cce45/resources/ext.quicksurveys.views/QuickSurvey.js#L100

@ovasileva: This might benefit from some investigation on our side too.

Do consider that this change might be useful for setting up automated browser tests targetting AMC mode available/unavailable, since the Node.js stack doesn't support a local LocalSettings.php file.

Additional notes that I raised during today's Backlog Grooming meeting:

In T219841#5096041, @Jdlrobson wrote:

cc analytics and RelEng as there's potential for a lot of traffic to EventLogging (I've seen 80k a minute) to the WebClientError schema

@Tgr: When can this work be scheduled?

One alternative would be to launch the child Chromium process using firejail, which we're confident (?) does this kind of management.

In T217724#5044953, @pmiazga wrote:

@akosiaris - yes, there is some logic that tries to kill the browser instances if browser.close() promise doesn't succeed. Looks like this code requires some tuning, and most probably it should try to kill the browser instance after some time without waiting for promise resolution/failure.

@Tgr: We'd talked about the deployment of this code having stalled out. Does this need a security review or at least an OK from Security prior to being deployed?

Work out how to deal with the frustration of non-deduplication. The feedback we got from people who have used EventLogging is that having the stack traces allowed them to fix the common bugs, but the other ones were harder to track down. We have no idea of the spread of our errors - all of them could be different, or many of them could be duplicates. We should think about what queries we can use to de-duplicate errors (And work out how many people they impact) and how our stack trace can be structured to help facilitate that.

Add stack traces to WebClientError events. Right now we're not including them in the current implementation because of the URL length. These will be essential. See T202026 for more information.

After thinking about this a little, it'd be useful for extensions/skins to be able to register a module that'll act as an error handler. AIUI the Sentry extension will suffer from the same issue as there's no guarantee that it'll be executed before the things that it intends to monitor will.

In T219212#5070027, @Tbayer wrote:

Yes, great point! I'm still slightly wondering about compatibility/comparability though - is it correct to interpret the documentation as saying that in cases where the unload event fires correctly, it should coincide with the pagehide event (with terminated state)?