Thanks @SNowick_WMF! This task can be repurposed for engineers to implement the GPay instrumentation above.

thanks @Tsevener. Adding pt-br translations, and addressing popover sizing bug are now in separate tasks, here T364157: [Sub Epic] Clean up tasks for Image Recs V2

woo, thank you @Tsevener ! This will be tested in the main Data validation task T362723

Hi @SNowick_WMF , could you please plan to validate that Watchlist Toggle instrumentation change as well in this task? https://github.com/wikimedia/wikipedia-ios/pull/4840
Thanks!

• It would be nice to also add the translations for Portuguese Brazil. Portuguese speakers in the Americas most likely have their phone set to Portuguese (Brazil), but this can be done after release.
• The translation files were missing the strings for the Edit summary chips: "Added image" and "Added image and caption", so we do not have those at this point.

thank you @SNowick_WMF !
@Tsevener would you be able to add these instrumentation changes tomorrow?

I opened the App with VoiceOver on and did not see the explore feed card, or the announcement.

hi @SNowick_WMF. This requires your signoff before release to ensure the new additions are instrumented. Could you please take a look at these changes and let us know if any instrumentation changes are needed?

Looks great!

1. I notice sometimes I see a "Sync is enabled on your account" modal that pops up after the app logs the user in. The system rejects new modals presenting from the Explore feed if it's already presenting a modal. I think we should keep this so we avoid any double-modal situation.

Agree! I was closing the Sync dialog each time so that must be why it was not showing on initial launch. After closing the dialog and navigating away and back to explore feed, I see the announcement.

2. Sometimes it takes time for the suggested edits card to appear in the Explore feed. This is because behind-the-scenes we are checking their edit count, blocked status, and if their primary app language wiki has image recommendations. These calls can take several seconds, so at the time of Explore feed appearance we aren't sure yet whether the user qualifies to see the feature. I could try to present it when the card is inserted, but I wasn't sure if we wanted to potentially interrupt what they were doing in the Explore feed if it's been a while.

I agree we don't want to interrupt.

3. I am not attempting to present the modal upon foregrounding. I should be able to easily add this one.

(That's what that is called, now I'll know the difference open vs foreground, close vs background!) That would be nice to add if there's capacity, for folks that never fully close apps. I am assuming this would present the modal once to people on first foregrounding it after the feature has been added, or first opening the app after it was closed but never both.

@Tsevener the minor edit link is leading to : https://meta.wikimedia.org/wiki/Help:Minor_edit, which displays as a CTA to redirect
to this page: https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Minor_edit
Could we swap to the Mediawiki page?

Woo! I love the pre-suggested edit summaries

Neither of these are blockers, noting:

Note for future selves that we did not implement the Nice-to-haves in this task, we'll revisit with Alt text experiment.

Good point @ABorbaWMF, I think it's ok to keep "Suggested Edits" for now as the card has that title in the explore feed so it matches other logic, and we will soon hopefully be adding the experimental Alt Text suggested edit.

Text behind the sheet is scrollable. Text inside the sheet is scrollable.

I ran into an issue with scrolling when there was a REALLY large description. Filed a bug report here: T363929