Once the next release of Codex is out, there may be very small updates that are needed on the skin side (changes to some filenames, etc). We can help you all with this.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Yesterday
I have a question about the desired UX for row selection.
Tue, Apr 23
Mon, Apr 22
Wed, Apr 17
Fri, Apr 12
Tue, Apr 9
Mon, Apr 8
In T349569#9698664, @sbassett wrote:In T349569#9647538, @egardner wrote:In T349569#9646835, @sbassett wrote:It'd probably be best to follow their security policy first: https://github.com/floating-ui/floating-ui/security. And hope they are responsive.
Oh, good catch. I can reach out to the developer at the email address provided and let him know about the Vite issue. I can report back here if he responds.
Hey @egardner - any update on this? I'm hesitant to make this task public if we haven't yet filed an upstream security issue for this, since we're discussing it here. Thanks.
Fri, Mar 29
Mar 22 2024
I should note that if we choose to do this, implementation would require re-organizing our tokens somewhat (designating one of the decision tokens as the primary source for the "progressive" color, another for the "destructive" color, another for base font size perhaps, etc). Then we'll need to implement a custom version of StyleDictionary's outputReferences feature that can understand the distinction between option tokens and decision tokens.
In T358031#9652635, @Catrope wrote:Moving this out of code review because all the associated patches are merged.
@egardner is this task done or is there more work to do here?
I've filed https://phabricator.wikimedia.org/T360802 in Up Next to represent the broader topic about token consolidation / interdependence. Right now the task is about discussing what we want and documenting it.
In T360346#9652347, @CCiufo-WMF wrote:@egardner some of these things feel more important than others. The changes you propose in https://gerrit.wikimedia.org/r/1012761 seem more like nice-to-have consolidation, while things like:
Component tokens should reference decision tokens, not option tokens
seem essential to make night mode work smoothly. Maybe we can start with those? Or should this actually be multiple tasks?
Mar 21 2024
Setting this to "blocked" pending some discussions with designers about how independent (or inter-dependent) decision tokens should be. CC @Sarai-WMDE.
In T358031#9650695, @Lofhi wrote:
Mar 20 2024
In T349569#9646835, @sbassett wrote:It'd probably be best to follow their security policy first: https://github.com/floating-ui/floating-ui/security. And hope they are responsive.
If we're concerned about a vulnerability in Floating UI, would it be worthwhile to try and open a PR in that project that upgrades Vite from 5.0.2 to 5.0.12?