Page MenuHomePhabricator
Create Task
Maniphest T260141

New translation: Support search to translate a section
Closed, ResolvedPublic
Actions

Assigned To
ngkountas
Authored By
Pginer-WMF
Aug 11 2020, 2:19 PM
Tags
Referenced Files
F34457483: image.png
May 17 2021, 12:58 PM
F34453848: image.png
May 14 2021, 11:34 AM
F34453852: image.png
May 14 2021, 11:34 AM
F34133647: New translation - Search.png
Mar 3 2021, 9:22 AM
F34133649: New translation - Search Dimensions.png
Mar 3 2021, 9:22 AM
F34131232: New translation - Navigation.png
Mar 2 2021, 7:40 AM
F31835435: New translation - Navigation.png
Aug 11 2020, 2:19 PM
F31835461: New translation - Search.png
Aug 11 2020, 2:19 PM
View All 9 Files
Subscribers
Aklapper
• Jpita
ngkountas
Pginer-WMF
• santhosh

Description

As part of the "new translation" entry point (T241590) from the Translation Dashboard, users can start a translation of a section for an article of their choice.

This ticket focuses on supporting the step to search for an article.

New translation - Navigation.png (768×1 px, 209 KB)

New translation - Search.png (768×1 px, 229 KB)
New translation - Search Dimensions.png (768×1 px, 112 KB)

More details in the parent task: T241590: Section Translation: "New translation" entry point

Details

SubjectRepoBranchLines +/-
SXArticleSearch: add search for articles functionalitymediawiki/extensions/ContentTranslationmaster+141 -0
SX mediawiki/page api client: search pages by title prefixmediawiki/extensions/ContentTranslationmaster+46 -10
SXArticleSearch: add nearby search suggestionsmediawiki/extensions/ContentTranslationmaster+356 -8
SX vuex store: add mediawiki/fetchNearbyPages actionmediawiki/extensions/ContentTranslationmaster+97 -5
SXArticleSearch: Add recently edited search suggestionsmediawiki/extensions/ContentTranslationmaster+251 -6
SXArticleSearch: add language selection button groupmediawiki/extensions/ContentTranslationmaster+60 -4
SXArticleSearch: add top search barmediawiki/extensions/ContentTranslationmaster+33 -5
SXArticleSearch: Introduce search for an article viewmediawiki/extensions/ContentTranslationmaster+58 -3
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT243495 [Epic] Support for Section Translation
 OpenNoneT286641 Entry points to improve discoverability of Section Translation
 OpenNoneT279064 Observations from first research study for Section Translation on Bengali Wikipedia
 OpenNoneT241590 Section Translation: "New translation" entry point
 ResolvedngkountasT260141 New translation: Support search to translate a section
 OpenNoneT260142 New translation: Adaptations to support Desktop and larger screens
 ResolvedngkountasT260143 New translation: Direct access to translate a specific section
 ResolvedngkountasT260144 New translation: Start a new article by translating the lead section on mobile
 ResolvedBUG REPORTngkountasT287082 Back navigation from the translation editor needs adjustment
 ResolvedngkountasT276221 New translation: Confirm translation
 ResolvedngkountasT276435 New translation: adapt the confirmation step depending on the sections available
 Resolved• santhoshT282417 Search input should get the input focus automatically
 ResolvedngkountasT282426 Article images are not shown when searching
 Resolved• santhoshT282428 Search input border needs adjustments
 OpenNoneT282430 Surface recently edited topics in the initial state for search
 ResolvedngkountasT282439 Adjust empty states for search
 ResolvedngkountasT282441 Add "New translation" header to the search step
 ResolvedngkountasT282442 Support linking to the search step
 Resolved• santhoshT282444 Language switch support when searching
 ResolvedngkountasT282455 Loading indicator for search results
 ResolvedPginer-WMFT283002 search to translate a section doesn't support copy paste
 OpenNoneT283004 search to translate a section doesn't support arrow keys to select option
 ResolvedBUG REPORTngkountasT283077 Uncaught type error on source language change
 Resolved• santhoshT283573 Search is not showing exact matches
 DeclinedNoneT283510 ERROR: Target article does not exist for en:National Health and Medical Research Council in bn language
 ResolvedPginer-WMFT284291 Languages without a Wikipedia are shown as options to search when starting a new translation
 ResolvedngkountasT284722 Open actions in the Confirm step need adjustment
 OpenNoneT284741 New translation: Responsive adaptations for larger screens
 OpenNoneT284422 New translation: Get mobile friendly image
 ResolvedngkountasT285564 Back navigation broken when linking to the search step directly
 ResolvedBUG REPORTngkountasT287835 error message saying "no pages found" that shouldn't appear until we complete the search
 ResolvedngkountasT290455 Adjust back navigation at the confirmation step when coming from search
 ResolvedngkountasT290457 Adjust search loading indicator to avoid jumps
 ResolvedWangombeT293387 Language not available for a new translation when used as target for suggestions
 OpenNoneT301874 Avoid transition from dashboard when accessing directly the confirmation step
 ResolvedngkountasT306643 Section Translation picking the wrong section when creating a new article
 ResolvedngkountasT328936 Adjust confirmation step to redirect to the platform-specific translation editor
 ResolvedngkountasT337915 Enable the Unified Content Translation Dashboard on a test wiki
 ResolvedWangombeT337917 Improve platform detection to avoid Section Translation to become unusable on wide windows
 ResolvedBUG REPORTPginer-WMFT330729 Show confirmation step (and suggestions) after a missing language is selected when searching in the language selector
 In ProgressngkountasT345332 SX: Confirmation step should be displayed when continuing in-progress page translations
 OpenNoneT345427 Accept Wikidata Q-IDs in url parameters to identify the topic to translate when loading and publishing
 OpenNoneT351728 Avoid "New translation" button to stretch
 ResolvedngkountasT355398 Readability regression when a section is selected through the url

Event Timeline

Pginer-WMF triaged this task as Medium priority.Aug 11 2020, 2:19 PM
Pginer-WMF created this task.
Pginer-WMF moved this task from Backlog to Entry points on the SectionTranslation board.Sep 3 2020, 8:30 AM
Pginer-WMF edited projects, added Language-Team (Language-2020-October-December); removed Language-Team (Language-2020-July-September).Oct 2 2020, 9:26 AM
Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2020-October-December) board.Nov 30 2020, 11:28 AM
Pginer-WMF raised the priority of this task from Medium to High.Dec 16 2020, 12:39 PM
Pginer-WMF lowered the priority of this task from High to Medium.Dec 22 2020, 9:24 AM
Pginer-WMF mentioned this in T270691: Hide dashboard views not supported on mobile.Dec 22 2020, 9:26 AM
Pginer-WMF edited projects, added Language-Team (Language-2021-January-March); removed Language-Team (Language-2020-October-December).Jan 4 2021, 10:17 AM
Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2021-January-March) board.
Pginer-WMF updated the task description. (Show Details)Mar 2 2021, 7:40 AM
Pginer-WMF raised the priority of this task from Medium to High.Mar 2 2021, 3:57 PM
Pginer-WMF updated the task description. (Show Details)Mar 3 2021, 9:22 AM
Pginer-WMF mentioned this in T241590: Section Translation: "New translation" entry point.Mar 3 2021, 9:24 AM
ngkountas claimed this task.Mar 18 2021, 1:18 PM
ngkountas moved this task from Priority Backlog to In Progress on the Language-Team (Language-2021-January-March) board.
Pginer-WMF edited projects, added Language-Team (Language-2021-April-June); removed Language-Team (Language-2021-January-March).Apr 1 2021, 11:21 AM
Pginer-WMF moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-April-June) board.
Pginer-WMF added a parent task: T279064: Observations from first research study for Section Translation on Bengali Wikipedia.Apr 1 2021, 2:51 PM
gerritbot added a comment.Apr 7 2021, 11:27 AM

Change 677527 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXArticleSearcher: Introduce search for an article view

https://gerrit.wikimedia.org/r/677527

gerritbot added a project: Patch-For-Review.Apr 7 2021, 11:27 AM

Change 677530 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXArticleSearcher: add top search bar

https://gerrit.wikimedia.org/r/677530

gerritbot added a comment.Apr 7 2021, 11:27 AM

Change 677531 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXArticleSearcher: add language selection button group

https://gerrit.wikimedia.org/r/677531

gerritbot added a comment.Apr 7 2021, 11:27 AM

Change 677532 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXArticleSearcher: Add recently edited search suggestions

https://gerrit.wikimedia.org/r/677532

gerritbot added a comment.Apr 7 2021, 11:27 AM

Change 677535 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXArticleSearcher: add nearby search suggestions

https://gerrit.wikimedia.org/r/677535

gerritbot added a comment.Apr 7 2021, 11:27 AM

Change 677538 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SXArticleSearcher: add search for articles functionality

https://gerrit.wikimedia.org/r/677538

ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2021-April-June) board.Apr 15 2021, 10:41 AM
gerritbot added a comment.Apr 26 2021, 10:11 AM

Change 677534 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX vuex store: add mediawiki/fetchNearbyPages action

https://gerrit.wikimedia.org/r/677534

gerritbot added a comment.Apr 26 2021, 10:30 AM

Change 677536 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX mediawiki/page api client: add search pages by title action

https://gerrit.wikimedia.org/r/677536

gerritbot added a comment.Apr 28 2021, 5:37 AM

Change 677527 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXArticleSearch: Introduce search for an article view

https://gerrit.wikimedia.org/r/677527

gerritbot added a comment.Apr 28 2021, 5:37 AM

Change 677530 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXArticleSearch: add top search bar

https://gerrit.wikimedia.org/r/677530

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 28 2021, 6:00 AM
gerritbot added a comment.Apr 28 2021, 6:04 AM

Change 677531 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXArticleSearch: add language selection button group

https://gerrit.wikimedia.org/r/677531

gerritbot added a comment.Apr 28 2021, 6:10 AM

Change 677532 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXArticleSearch: Add recently edited search suggestions

https://gerrit.wikimedia.org/r/677532

gerritbot added a comment.Apr 28 2021, 6:10 AM

Change 677534 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX vuex store: add mediawiki/fetchNearbyPages action

https://gerrit.wikimedia.org/r/677534

gerritbot added a comment.Apr 28 2021, 9:42 AM

Change 677535 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXArticleSearch: add nearby search suggestions

https://gerrit.wikimedia.org/r/677535

gerritbot added a comment.Apr 28 2021, 9:44 AM

Change 677536 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX mediawiki/page api client: search pages by title prefix

https://gerrit.wikimedia.org/r/677536

gerritbot added a comment.Apr 28 2021, 12:17 PM

Change 677538 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SXArticleSearch: add search for articles functionality

https://gerrit.wikimedia.org/r/677538

Maintenance_bot removed a project: Patch-For-Review.Apr 28 2021, 1:10 PM
ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2021-April-June) board.May 10 2021, 7:54 AM
Pginer-WMF added a comment.EditedMay 10 2021, 11:59 AM

It's great to see the progress on this front. This is already useful to search for specific articles to translate.
There are some aspects I found that may require polishing as follow-up tasks:

• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2021-April-June) board.EditedMay 14 2021, 11:10 AM
• Jpita subscribed.

when I paste a string, it is not recognised as a search even if I press enter.
I need then to press a character key or delete a character to start the search.
Should I create a new ticket @Pginer-WMF ?

• Jpita added a comment.May 14 2021, 11:12 AM

IMPROVEMENT IDEA: when using the arrow keys up and down we should go change the focus to the results so we can then chose an article with the Enter key

Pginer-WMF added a comment.May 14 2021, 11:32 AM
In T260141#7087762, @Jpita wrote:

when I paste a string, it is not recognised as a search even if I press enter.
I need then to press a character key or delete a character to start the search.
Should I create a new ticket @Pginer-WMF ?

Good catch. Yes, please create a ticket.

In T260141#7087785, @Jpita wrote:

IMPROVEMENT IDEA: when using the arrow keys up and down we should go change the focus to the results so we can then chose an article with the Enter key

This is also worth creating a ticket for. In addition, highlighting the first result would allow to just press enter to select it, which could speed the workflow further.

Also more generally the accessibility support may need a review. currently some interactive elements are not reachable when pressing the tab key. Although our current focus is on mobile support, the product should be usable in a keyboard-only. This would make it work better on desktop but also on accessibility-focused browsers.

• Jpita added a comment.May 14 2021, 11:34 AM

@ngkountas found this issue when selecting different languages.

image.png (298×588 px, 30 KB)

image.png (746×1 px, 209 KB)

is this supposed to be fixed in a different task?

• Jpita mentioned this in T283002: search to translate a section doesn't support copy paste.May 17 2021, 10:19 AM
• Jpita mentioned this in T283004: search to translate a section doesn't support arrow keys to select option.May 17 2021, 10:28 AM

created T283002 and T283004

• Jpita moved this task from Pending input for QA to Priority Backlog on the Language-Team (Language-2021-April-June) board.May 17 2021, 10:38 AM
• Jpita added a comment.EditedMay 17 2021, 12:58 PM

update:
once we see the error from T260141#7087858 then the suggestions stop showing up when we go back to the dashboard

image.png (1×2 px, 455 KB)

• Jpita mentioned this in T279066: Make basic suggestions with more relevant sections.May 17 2021, 1:12 PM
ngkountas added a comment.May 18 2021, 1:40 PM

@Jpita I have created T283077 to track this issue. If everything else belonging to this ticket has been resolved, feel free to move it to done.

ngkountas moved this task from Priority Backlog to Needs QA on the Language-Team (Language-2021-April-June) board.May 18 2021, 1:41 PM
• Jpita moved this task from Needs QA to Done on the Language-Team (Language-2021-April-June) board.May 19 2021, 3:13 PM
Pginer-WMF closed this task as Resolved.May 27 2021, 1:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL