Page MenuHomePhabricator
Create Task
Maniphest T150639

Redirect toasts should replace underscores with spaces
Closed, ResolvedPublic
Actions

Description

Visit Black and White House and notice the underscores that appear:

2016-11-11 12.38.38.png (1×1 px, 222 KB)

Expected: There should be no underscores

Details

SubjectRepoBranchLines +/-
Remove underscores from redirect toast messagemediawiki/extensions/MobileFrontendmaster+22 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedJdlrobsonT147641 [EPIC] Improve top of the article user experience - mobile
 ResolvedJdlrobsonT143535 [EPIC] Improve article notes
ResolvedovasilevaT146596 Make redirect into a toast message
 ResolvedphuedxT150639 Redirect toasts should replace underscores with spaces
 DuplicateNoneT157895 Section-templates don't show on mobile
 ResolvedovasilevaT159262 [EPIC] Improve page issues
 ResolvedJdlrobsonT183246 {{Orphan}} template is quasi-visible on mobile web even when it's not visible on desktop
 InvalidNoneT184421 Page issues {{Expand}} template produces empty items on mobile
 ResolvedCKoerner_WMFT186058 Community Liaison support for page issues on mobile
 ResolvedCKoerner_WMFT209405 Announce page issues improvement
InvalidNoneT191305 Mobile page issues - use hide when compact where available
 ResolvedovasilevaT191528 Mobile page issues - allow page issues to display different severity levels
 Resolved• alexhollender_WMFT191303 Mobile page issues - visual styling changes
 Duplicate• alexhollender_WMFT191529 Mobile page issues - visual changes for multiple issues
 Resolved• alexhollender_WMFT191671 [Research] Perform user testing for Page Issues on mobile web
 ResolvedovasilevaT197728 Sistersiteboxs are wired up to page issues when they shouldn't be
 Resolved• alexhollender_WMFT197932 Display section issues modal
 ResolvedRyasmeenT197931 Truncate page issues
 ResolvedRyasmeenT198115 Links should not be clickable in mobile page issue element
 Resolved• NiedzielskiT201634 [EPIC] Post A-B test technical debt cleanup
 ResolvedovasilevaT206177 Page issues: Simplify class selectors we support to provide more sustainable support for severity parsing
 ResolvedNoneT206178 Feature branch: Remove pageIssues A-B test code
 ResolvedovasilevaT202349 When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes.
 ResolvedABorbaWMFT208514 Merge PageIssues Feature Branch to Master
 Resolved• alexhollender_WMFT210553 Deploy page issues to all wikipedias (except enwiki)
 DuplicateNoneT201975 Make page issue and hatnote classes names configurable so we are not English-Wikipedia centric
 Resolved• NiedzielskiT211257 Split pageIssues.js into smaller functions
 ResolvedovasilevaT210554 Deploy page issues to enwiki and all remaining projects
 ResolvedovasilevaT200794 Analyze results of page issues A/B test
 ResolvedphuedxT200793 Disable page issues A/B test
 Resolved• TbayerT200792 [EPIC] Run A/B test on page issues (Farsi, Japanese, Russian, English)
 ResolvedovasilevaT191532 Mobile page issues - instrument page issues
 Resolved• NiedzielskiT201124 Provide standard/reproducible way to access a PageToken
 Resolved• TbayerT202098 Log sectionNumbers in PageIssues schema
 Resolved• TbayerT202651 Section number in issues is reported incorrectly.
 Resolved• TbayerT202940 [subtask] Various page issues events sending NaN for sectionNumbers in old treatment
 Resolved• TbayerT203050 sectionNumbers and issuesSeverity should always be consistent in length
 ResolvedovasilevaT202786 [subtask] Edits via the main edit icon are not triggering Schema:Edit or Schema:PageIssues events
 Resolved• TbayerT203725 Icon correct but issuesSeverity in instrumentation is wrong
 ResolvedphuedxT193584 Prepare feature flagging gateway for mobile issues work
 ResolvedovasilevaT198113 QA mobile page issues modal
 ResolvedJdlrobsonT203802 Latvian Wikipedia amboxes should be compatible with Minerva's
 ResolvedJdlrobsonT204144 ReadingDepth sometimes initialises before PageIssues leading to incorrect or missing ReadingDepth events
 Resolved• TbayerT204143 ReadingDepth events are not being sent in browsers where navigator.sendBeacon should be supported but in practice isn't
 Resolved• TbayerT204609 Turn on page issues A/B test for Latvian Wikipedia, and conduct data checks
 Resolved• NiedzielskiT205355 A/B config flag should be subject to ResourceLoader caching rules not HTML caching rules
 DeclinedNoneT204613 Turn A/B test for page issues on for test projects at low rates to validate instrumentation
 ResolvedovasilevaT204090 QA page issues feature
 ResolvedNoneT214653 Page issues broken on english wikivoyage
 ResolvedJdlrobsonT173600 Improve treatment of hatnotes

Event Timeline

Jdlrobson created this task.Nov 14 2016, 9:06 AM
Jdlrobson removed Nicholas.tsg as the assignee of this task.Nov 14 2016, 10:12 AM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-85-💩 board.
• jhobs renamed this task from [Subtask] Underscores in some redirect messages to Redirect toasts should replace underscores with spaces.Nov 14 2016, 5:01 PM
• jhobs added a project: Unplanned-Sprint-Work.Nov 14 2016, 5:03 PM

Elevating out of subtask.

ovasileva moved this task from Incoming to 2016-17 Q2 on the Web-Team-Backlog board.Nov 14 2016, 6:10 PM
gerritbot added a comment.Nov 15 2016, 10:43 AM

Change 321626 had a related patch set uploaded (by Phuedx):
Remove underscores from redirect toast message

https://gerrit.wikimedia.org/r/321626

gerritbot added a project: Patch-For-Review.Nov 15 2016, 10:43 AM
phuedx claimed this task.Nov 15 2016, 10:44 AM
phuedx moved this task from To Do to Code Review on the Reading-Web-Sprint-85-💩 board.
gerritbot added a comment.Nov 15 2016, 11:24 AM

Change 321626 merged by jenkins-bot:
Remove underscores from redirect toast message

https://gerrit.wikimedia.org/r/321626

Florian closed this task as Resolved.Nov 15 2016, 11:28 AM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-85-💩 board.Nov 15 2016, 11:59 AM
ReleaseTaggerBot added a project: MW-1.29-release (WMF-deploy-2016-11-15_(1.29.0-wmf.3)).Nov 15 2016, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL