Stalled per T278590
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 4 2021
Change 570196 abandoned by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Make CategoryAddOverlay use Overlay.make
Reason:
This will be redundant with the approach outlined in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/ /683441
In T279388#7059219, @Jdlrobson wrote:Which if anything has been a bit of a regression where it's been implemented, as generally it's better to keep content styles consistent between all pages, whether they're parser output or special pages or whatever.
Agreed, but that's a regression that predates this change, and this change allows us to keep content styles consistent across skins by making mw-body-content a first class citizen provided by core rather than a class that skins must remember to add.
Change 684491 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate FileBackendGroup::singleton() and ::destroySingletons()
Change 673976 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Expose first JSON validation error to the user
Change 685039 merged by jenkins-bot:
[wikimedia/discovery/analytics@master] Bump glent to 0.2.4
Something I noticed testing a different patch on patchdemo (without this redesign, but with action blocks enabled):
In T279388#7059217, @Jdlrobson wrote:Well, based on a very brief look at https://codesearch.wmcloud.org/search/?q=%5C.mw-body-content&i=nope&files=&excludeFiles=&repos= it looks like all of the following will likely be impacted...
These are not impacted. While they use the class, they will not be impacted by the change here as they have no styling rules that will be broken. Skins that are using the class will continue to use that class and the styling rules in each of them will also apply.
Which if anything has been a bit of a regression where it's been implemented, as generally it's better to keep content styles consistent between all pages, whether they're parser output or special pages or whatever.
Well, based on a very brief look at https://codesearch.wmcloud.org/search/?q=%5C.mw-body-content&i=nope&files=&excludeFiles=&repos= it looks like all of the following will likely be impacted...
No problem. I will just wait a couple of days and retry.
Change 685097 had a related patch set uploaded (by Isarra; author: Isarra):
[mediawiki/skins/Timeless@master] Prevent overflowing non-content images from exploding all over the place
Change 685095 had a related patch set uploaded (by Isarra; author: Isarra):
[mediawiki/core@master] Remove mw-body-content class from BaseTemplate::getIndicators
In T247143#7051429, @DannyS712 wrote:Okay, we're getting close! Current status:
First couple patches, removing the hooks that use Revision objects and starting to remove deprecated support for Revision in other places, has already merged and will go out with the train.
Next batch is ready to go, but I'm waiting until after the train to split them up a bit. Once https://gerrit.wikimedia.org/r/c/mediawiki/core/+/683964 merges, the only remaining use of Revision in core will be in the Revision class itself, and in its tests. At that point
- update extensions that, like core, supported deprecated Revision object parameters: Wikibase (repo), EntitySchema, and Parsoid
- Wait for a new version of Parsoid to be tagged and deployed to vendor
- Wait at least a week since the rest of the changes to remove the uses of the Revision class in core
Then we can merge the actual removal (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/684071)
Change 683964 merged by jenkins-bot:
[mediawiki/core@master] Remove remaining non-test uses of Revision objects
Change 683093 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Handle invalid MassMessageListContent on "show changes"
@wiki_willy @Bstorm host is out of warranty expired Jun 1, 2020. We do not have any 6tb hard drives how would you like to proceed.
Change 684962 merged by jenkins-bot:
[mediawiki/services/image-suggestion-api@master] Redirect traffic to config URL
@arturo, please lmk if there's an issue here, otherwise feel free to close this.
Change 685092 had a related patch set uploaded (by Zabe; author: Zabe):
[mediawiki/extensions/MergeArticles@master] Avoid using RepoGroup::singleton()
I actually see all of those set as forward records in Horizon, so I'm not sure there's an actual bug here.
Change 685090 had a related patch set uploaded (by Herron; author: Herron):
[operations/puppet@production] logstash101[012]: prep for reimaging
Change 685090 had a related patch set uploaded (by Herron; author: Herron):
[operations/puppet@production] logstash101[012]: prep for reimaging
- Risky Patch! 🚂🔥