Remove classic edit toolbar from core
Open, NormalPublic

Tokens
"Dislike" token, awarded by AS."Like" token, awarded by stjn."Love" token, awarded by MichaelSchoenitzer."Heartbreak" token, awarded by Liuxinyu970226."Heartbreak" token, awarded by NickK."Heartbreak" token, awarded by Kghbln."Heartbreak" token, awarded by Nemo_bis."Dislike" token, awarded by Thibaut120094."Y So Serious" token, awarded by matej_suchanek."Piece of Eight" token, awarded by RandomDSdevel."Like" token, awarded by waldyrious."Like" token, awarded by Ricordisamoa."Like" token, awarded by He7d3r.
Assigned To
Authored By
Krinkle, May 6 2011

Description

Move the 'classic' editor (<div id=toolbar> on EditPage and mediawiki.toolbar JS) out of MediaWiki core (potentially into an extension), leaving just a plain <textarea> in MediaWiki itself.

Details

Reference
bz28856

Related Objects

There are a very large number of changes, so older changes are hidden. Show Older Changes

259 users on frwiki (the query took about 20 minutes), out of 23284 "active" (the query took about 5 minutes).

(Note that on frwiki, those users will be able to get the old toolbar back by simply enabling the confusingly named "MonobookToolbarStandard" gadget.)

259 users on frwiki (the query took about 20 minutes), out of 23284 "active" (the query took about 5 minutes).

@matmarex Thanks a lot!

@Arkanosis : James and I have just agreed to postpone this for another month, until T162849 is completed. The plan is the same as discussed above at T30856#3341485, except at the end of August instead of at the end of July. If you are not available in late August, then we can wait for you.

@Arkanosis : James and I have just agreed to postpone this for another month, until T162849 is completed. The plan is the same as discussed above at T30856#3341485, except at the end of August instead of at the end of July. If you are not available in late August, then we can wait for you.

End of August should be fine for me. Thanks!

NickK added a subscriber: NickK.Jun 29 2017, 11:11 PM

I am rather disappointed to see this happen.

Personally my main reason for using this old toolbar is slower insertion of page links and files in the new toolbar. It is much faster for me to click on a button adding [[]] or [[File:]] directly than to fill in a form in a new toolbar. I suppose one of the reasons why this is really faster is that I am most active in Ukrainian Wikipedia, and Ukrainian keyboard layout does not have square brackets on the keyboard. For me the three options are:

  • old toolbar: click on a button, type page name (one click)
  • new toolbar: click on a button, type page name, click on another button in another part of the screen (two clicks and one mouse move)
  • no toolbar: switch to English, type [[]], switch back to Ukrainian and type a page name (eight key strokes)

I wouldn't mind switching to a new toolbar if there was a way to have exactly the same set of buttons without dialog boxes: I am not that attached to the blue colour, but I do not want to see that dialog box each time I need to add a link. Is there a solution for that?

[...] For me the three options are:

  • old toolbar: click on a button, type page name (one click)
  • new toolbar: click on a button, type page name, click on another button in another part of the screen (two clicks and one mouse move) I wouldn't mind switching to a new toolbar if there was a way to have exactly the same set of buttons without dialog boxes: I am not that attached to the blue colour, but I do not want to see that dialog box each time I need to add a link. Is there a solution for that?

With the new toolbar, in the dialog box, once you've typed the link text you can just tap the [return/enter] key on your keyboard to place the [[link text]]. You do not need to use the mouse to click on the "Insert link" ("Вставити посилання") button. Hopefully that works for you, and saves you a mouse-move and click. :-)

Whatamidoing-WMF added a comment.EditedJun 30 2017, 5:50 AM

Personally my main reason for using this old toolbar is slower insertion of page links and files in the new toolbar. It is much faster for me to click on a button adding [[]] or [[File:]] directly than to fill in a form in a new toolbar.

Thank you for this message, and especially for the information about how your keyboard works.

Would you try clicking *under* the edit window for this, and let us know if that works for you? The Ukrainian Wikipedia has a large list of "buttons" in between the edit window and the edit summary box, and it looks like the buttons for adding [[]] and [[File:]] (and a lot of other things) are in that list.

Liuxinyu970226 added a comment.EditedJun 30 2017, 8:52 AM

Personally my main reason for using this old toolbar is slower insertion of page links and files in the new toolbar. It is much faster for me to click on a button adding [[]] or [[File:]] directly than to fill in a form in a new toolbar.

Thank you for this message, and especially for the information about how your keyboard works.

Would you try clicking *under* the edit window for this, and let us know if that works for you? The Ukrainian Wikipedia has a large list of "buttons" in between the edit window and the edit summary box, and it looks like the buttons for adding [[]] and [[File:]] (and a lot of other things) are in that list.

But this really isn't available on MobileFrontend:


(from my Huawei M3, and btw where are buttons that under edit interface?)


Also according to https://zh.wikipedia.org/wiki/Wikipedia:互助客栈/技术/存档/2017年6月#Tech_News:_2017-23 (from @Dabao qian), it looks like that only the pre-2006 toolboxes are available on MF

Liuxinyu970226 rescinded a token.
Liuxinyu970226 rescinded a token.
Liuxinyu970226 awarded a token.
TheDJ added a comment.Jun 30 2017, 9:14 AM

@Liuxinyu970226 This ticket isn't about MobileFrontend. Let's not start bringing that into this.

NickK added a comment.Jun 30 2017, 4:07 PM

With the new toolbar, in the dialog box, once you've typed the link text you can just tap the [return/enter] key on your keyboard to place the [[link text]]. You do not need to use the mouse to click on the "Insert link" ("Вставити посилання") button. Hopefully that works for you, and saves you a mouse-move and click. :-)

Would you try clicking *under* the edit window for this, and let us know if that works for you? The Ukrainian Wikipedia has a large list of "buttons" in between the edit window and the edit summary box, and it looks like the buttons for adding [[]] and [[File:]] (and a lot of other things) are in that list.

That does not sound promising. You state in the statement yourself that editors affected are high-volume editors (source: https://www.mediawiki.org/wiki/Contributors/Projects/Removal_of_the_2006_wikitext_editor ), and you basically recognise that you offer a less efficient solution.

Yes, in theory it is possible to click Enter each time I want to insert a link, and yes, I can rely on a good toolbar in Ukrainian Wikipedia, although I cannot do it in Ukrainian Wikivoyage where this toolbar is not available (yes, I use this toolbar in all wikis).

Being one of those high-volume editors is tricky: I do understand it is way simpler for developers not to maintain this toolbar, but I would really appreciate having an alternative solution that would allow me to add [[]] in one click in all wikis

@NickK, if a volunteer turns it into a script, then you could use [[User:NickK/global.js]] to run it at all wikis.

NickK added a comment.Jul 6 2017, 10:10 PM

@NickK, if a volunteer turns it into a script, then you could use [[User:NickK/global.js]] to run it at all wikis.

Then please do not remove it until this is done. Doing it in the opposite order (it was removed, but a volunteer can do something in order to restore this functionality) is, in my view, not a good idea.

@Arkanosis and others: We are tentatively re-scheduling this for the very end of August. That means:

  • Removed from the Beta Cluster (so you can start testing replacement scripts) on Tuesday, 22 August
  • Removed from the test wikis the following Tuesday (late)
  • Removed from the non-Wikipedias on Wednesday, 30 August
  • Removed from the Wikipedias on Thursday, 31 August

As before, if there is another delay, I will post that information here.

Tnegrin added a subscriber: Tnegrin.Aug 6 2017, 3:39 PM

Can we please rerun the usage numbers across all of the wikis using Matmarex's technique above. I don't really feel like we have consistent usage numbers.

Krinkle removed a subscriber: Krinkle.

@Whatamidoing-WMF Hello, any progress here?

gh87 added a subscriber: gh87.Sep 20 2017, 8:35 AM

Just in case, there is an old discussion of this year about the old toolbar, where some editors still use it. Well, I learned about the discussion after starting this one. Why not stall this task and ask the communities whether it should be removed completely from all projects or some of them?

Why not stall this task and ask the communities whether it should be removed completely from all projects or some of them?

Do you volunteer to become the maintainer for the code of the classic edit toolbar for the next years? :)

gh87 added a comment.Sep 20 2017, 11:07 PM

@Malyacko Oh... Um... I'm not a developer or a code programmer. Sorry. :(

Hi @Iniquity: It's stalled on T166601 at the moment. The team doesn't want the removal to break anything else. I hate to leave everyone hanging on tenterhooks, because once it's ready, we need to move promptly, but I doubt that anyone's going to disagree with that decision. 😉 Given the state of their other work, my guess is "not very soon".

@Whatamidoing-WMF thanks for your answer :) I hope you will be able to do it this year.

Legoktm updated the task description. (Show Details)Sep 23 2017, 8:21 PM

The title of this task is "Remove classic edit toolbar from core". Is that still accurate, or should this be "Remove classic edit toolbar from Wikimedia sites" (most of the discussion so far).

I think there is value in turning this into an extension to force us to build a reasonably pluggable toolbar system (WikiEditor vs ClassicToolbar). The code for the classic edit toolbar is pretty deeply entrenched into MediaWiki - it's built into our language support. Should we create a separate task for doing so?

Mostly I'd like to disentangle the discussion of "lets move this out of core" (something I fully support and can make progress on) and "lets stop using it on Wikimedia sites" (I have no opinion).

Hi @Iniquity: It's stalled on T166601 at the moment.

Fixed now. :)

Krinkle rescinded a token.Oct 1 2017, 8:33 PM
Krinkle added a subscriber: Krinkle.
Krinkle removed a subscriber: Krinkle.

Fixed now. :)

Thanks! :)

This work on removing the 2006 wikitext editor is currently blocked by T177098: Fix CodeMirror to not unconditionally try to use the 2006 toolbar (as that's being deleted). I have no information about how soon it could be resolved.

This is blocked by T88976: mw.toolbar.insertTags should be independent from mediawiki.toolbar module as (mw.toolbar is removed and) mw.toolbar.insertTags is used for the bottom edit tools (mw-editTools; which should not be removed!?).

OK I see now, not blocked, because subtask T166601 is already done.

James, is this ready to go? Are you ready to talk about testing schedules with @Arkanosis and any other interested volunteers?

stjn awarded a token.Apr 22 2018, 1:13 PM
demon moved this task from Backlog to Core on the MW-1.31-release board.Apr 26 2018, 8:56 PM

Removing MW-1.31-release, this just didn't happen in time :(

Jdforrester-WMF removed a project: MW-1.31-release.

Still waiting on Danny's decision. Re-assigning to make this clear.

DannyH removed DannyH as the assignee of this task.Jun 8 2018, 12:11 AM
DannyH added a subscriber: DannyH.

I give my blessing to remove the toolbar.

AS awarded a token.Wed, Jul 25, 6:53 PM
AS added a subscriber: AS.EditedWed, Jul 25, 7:36 PM

For users who use custom toolbar html is there an option not to render NewToolbar? I can see that it's only about +5kb of gzipped content, but it's still a big part of whole page.

is there an option not to render NewToolbar?

Yes. Switch to the 2003 wikitext editor, which contains no toolbar at all (or turn off Javascript). You can do this by disabling both "Show edit toolbar" and "Enable enhanced editing toolbar" Special:Preferences.

If you want a toolbar, then there is a reasonably complete list of options at https://www.mediawiki.org/wiki/Editor

TheDJ added a comment.Mon, Jul 30, 9:34 PM

I've rewritten the charinsert gadget to use it's own insertTags using jquery.textSelection, instead of mw.toolbar.insertTags

gh87 added a comment.EditedMon, Jul 30, 10:57 PM

@TheDJ Can charinsert gadgets in other projects like Wikimedia Commons be also modified, or have they been already done?

TheDJ added a comment.Tue, Jul 31, 8:33 AM

@TheDJ Can charinsert gadgets in other projects like Wikimedia Commons be also modified, or have they been already done?

I don't have global interface permissions, so other projects can copy if they want to, i just can't do it for them.

I don't have global interface permissions

@TheDJ, this sounds like a problem report. Do you want that to change?

@Arkanosis (and others), I think we're ready to talk about re-re-re-scheduling this. Do you have a preferred month (any time this calendar year)?

@Arkanosis (and others), I think we're ready to talk about re-re-re-scheduling this. Do you have a preferred month (any time this calendar year)?

@Whatamidoing-WMF : (just talking for myself) as long as there's a week or more to make sure we can get everything working, I think it should be fine. Anytime after the 8th of October would be even easier for me.