Remove classic edit toolbar from core
Open, NormalPublic

Description

Move the 'classic' editor (<div id=toolbar> on EditPage and mediawiki.toolbar JS) out of MediaWiki core (potentially into an extension), leaving just a plain <textarea> in MediaWiki itself.

Details

Reference
bz28856
bzimport raised the priority of this task from to Normal.
bzimport set Reference to bz28856.
bzimport added a subscriber: Unknown Object (MLST).
Krinkle created this task.May 6 2011, 6:13 PM
brion added a comment.May 6 2011, 8:48 PM

That'd specifically be the classic edit _toolbar_, along with its infrastructure for core & custom buttons?

demon added a comment.May 29 2011, 6:49 PM

I'd rather see it stay in core, and have WikiEditor move into core with it ;-)

olivier.beaton wrote:

how about we move FCKEditor in there too...

I'm with Krinkle here (news flash), the ability to insert css and js to have an editor is great, but I'd love to see it be something you can pick to install or have users pick using a dropdown menu even. Definitely ship with at least one, just extension please!

Adding a few keywords since I had difficulty finding this bug again.

(In reply to Chad H. from comment #2)

I'd rather see it stay in core, and have WikiEditor move into core with it
;-)

Maybe the two editors could be merged together if there aren't any differences between them? That brings up the question of what the differences *are*, however, if any…(sigh;) maybe I should just look this up, though?

RandomDSdevel rescinded a token.
He7d3r updated the task description. (Show Details)Mar 10 2015, 6:59 PM
He7d3r set Security to None.

What would the edit bar be replaced with once the old bar is moved into its own extensions.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2015, 7:57 PM

Oh but what about a built in toolbar that would mean that there would be no tool bar if the old bar was too move out into its own extensions.

Oh but what about a built in toolbar that would mean that there would be no tool bar if the old bar was too move out into its own extensions.

I guess having no built-in edit toolbars is the goal of this task...

Elitre added a subscriber: Elitre.May 26 2016, 5:10 PM
Tpt added a subscriber: Tpt.May 26 2016, 8:12 PM
Danny_B moved this task from Unsorted to Move on the Technical-Debt board.Jun 1 2016, 3:23 AM
Krinkle renamed this task from Move classic (old) edit toolbar (from module mediawiki.action.edit) into an extension to Move classic edit toolbar into an extension.Jun 2 2016, 9:58 PM
Krinkle updated the task description. (Show Details)

Change 343785 had a related patch set uploaded (by Jforrester):
[mediawiki/core] mediawiki.toolbar: Emit deprecation warnings

https://gerrit.wikimedia.org/r/343785

Izno added a subscriber: Izno.Apr 1 2017, 2:06 PM
Jdforrester-WMF renamed this task from Move classic edit toolbar into an extension to Remove classic edit toolbar from core.Apr 26 2017, 6:24 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF updated the task description. (Show Details)

Change 343785 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.toolbar: Emit deprecation warnings

https://gerrit.wikimedia.org/r/343785

Update as of 26 April: This will be deprecated from MediaWiki 1.29 onwards; users will get a message Use of "toolbar" is deprecated. in their console (along with several others from other bits of code). The toolbar will be removed in MediaWiki 1.30, probably.

For Wikimedia users, we'll put another notice in Tech/News about it going away, and merge the commit removing the toolbar thereafter.

Change 350644 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@REL1_29] mediawiki.toolbar: Emit deprecation warnings

https://gerrit.wikimedia.org/r/350644

Johan added a subscriber: Johan.Apr 27 2017, 8:22 PM

@Jdforrester-WMF When do you want that notice in Tech News (if you know)?

@Jdforrester-WMF When do you want that notice in Tech News (if you know)?

Initial notice, probably in late May. @Whatamidoing-WMF will have a better idea, certainly.

Change 350644 merged by jenkins-bot:
[mediawiki/core@REL1_29] mediawiki.toolbar: Emit deprecation warnings

https://gerrit.wikimedia.org/r/350644

Krinkle removed a subscriber: Krinkle.Fri, May 12, 10:34 PM
Nirmos added a subscriber: Nirmos.Tue, May 23, 5:53 PM

I'm confused. This task and the code changes in Gerrit only seem to mention the toolbar, that is, the stuff at the top of the edit window. However, when I click on edittools, the stuff below the edit window, I get "Use of "toolbar" is deprecated." in the browser console. So, my question is, is mw.toolbar.insertTags deprecated, or is the warning I see an unintended side-effect from deprecating the toolbar at the top of the edit window?