Page MenuHomePhabricator
Create Task
Maniphest T257865

Merge feat/search to master for Vue.js search deployment
Closed, DeclinedPublic1 Estimated Story Points
Actions

Description

Search development is constrained to a feature branch, feat/search. This task tracks merging it back to master for the release.

Blocks on

  • Security reviews (T257579, T257734)
  • If it's ready to deploy to beta cluster (requires config change), it's ready to merge
  • All subtasks are resolved

Acceptance criteria

  • feat/search is merged to master

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
 OpenNoneT100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
 OpenNoneT85394 Use OOUI suggestions/autocompletion components only (instead of jquery.suggestions, jquery.ui.autocomplete)
 OpenNoneT125725 [epic] Update autocomplete search box with metadata and remove and delete the old searchSuggest system
 ResolvedovasilevaT244392 [GOAL] Deploy the new Vue.js search experience
 ResolvedVolker_ET249299 [Epic] Build the new Vue.js search experience
 ResolvedphuedxT244287 Build the Vue.js search component network client
 Resolved• eprodromouT245672 Search endpoint enhancement
 ResolvedEvanProdromouT245673 Reader gets page thumbnail with search results
 ResolvedPeter.ovchynT250139 Create generic technical approach to Augment search result
ResolvedPeter.ovchynT250144 Implement search result fields augmentation approach in SearchHandler
ResolvedPeter.ovchynT250207 Implement getting the thumbnails in the PageImages extension
 Resolved• eprodromouT245674 Reader gets page description in search results
 ResolvedPeter.ovchynT250217 Implement getting the page description in Wikibase/client extension
 ResolveddanielT245675 Reader gets cacheable search results
 ResolveddanielT245676 Client Developer specifies maximum number of search results in result set
 ResolveddanielT246387 Reader searches for a title prefix
 Resolved• holger.knustT258736 Core REST API search results are different from Action API results
 Resolved• holger.knustT232176 Enable cross-origin resource sharing (CORS) for requests in Core REST API
 Resolved• holger.knustT262425 Enable $wgAllowCrossOrigin on all Wikimedia wikis
 OpenNoneT259545 What's the reason for the `excerpt` property in the search/title endpoint?
 OpenNoneT259547 Include display titles in MW REST API responses
 OpenNoneT259837 Omit fields instead of making the value null
 ResolvedSpikeovasilevaT249366 [Spike] What should we instrument in the new Vue.js search experience?
 ResolvedphuedxT250851 Allow skins to override mediawiki.page.ready initialisation to enable search JavaScript to be swapped
 ResolvedJdrewniakT254695 Build a pre-library loading indicator for Vue.js search
 Resolved• alexhollender_WMFT255603 Design spec for new Vue.js search experience
 ResolvedovasilevaT255902 [Epic] Build the component primitives for Vue.js search
 ResolvedJdlrobsonT256042 Build the wvui-typeahead-suggestion component for Vue.js search
 ResolvedJdrewniakT256043 Build the wvui-typeahead-search component for Vue.js search
 ResolvedJdrewniakT256041 Build the wvui-search-form component for Vue.js search
 Resolved• NiedzielskiT256038 Build the wvui-button component for Vue.js search
 ResolvedMNeislerT259766 Data request for search button
 ResolvedMNeislerT260243 Search terms data request
 ResolvedovasilevaT261515 Basic user testing for new search experience
 ResolvedphuedxT260065 Pass server-rendered search form state to client on initial render of Vue.js search
 ResolvedovasilevaT269959 Shift search box to the left
 ResolvedovasilevaT270202 Design fixes for new Vue.js search experience
 Resolved• nrayT272160 Increase font size for page titles and descriptions in search results list
 OpenNoneT272873 Update OOUI to match new Vue search UI & UX
 ResolvedovasilevaT273093 Design improvements for Search loading state
 ResolvedVolker_ET279015 [Visual bug] search icon increases in size when Vue loads
 ResolvedAnneTT286851 [Search] Lighten color of search thumbnail placeholder icon
 ResolvedStevenSunT286922 Add message for no results in TypeaheadSearch
 ResolvedovasilevaT275200 Analyze results of A/B test for new search widget
 ResolvedovasilevaT249297 Deploy the new Vue.js search experience
 ResolvedEdtadrosT259798 Deploy the new Vue.js search experience to the Beta-Cluster and Test Wikipedia
 DeclinedNoneT257865 Merge feat/search to master for Vue.js search deployment
 DeclinedNoneT261984 Folder structure for assets built by Webpack should be separated from standard ResourceLoader assets
 ResolvedJdrewniakT264355 Integrate wvui-search-form into Vector
 ResolvedJdrewniakT268229 Make WVUI export compatible with ResourceLoader
 Resolved• nnikkhouiT268363 Fix WVUI release scripts
 Resolved• nnikkhouiT269762 Use npm version 6.x in WVUI images
 ResolvedJdlrobsonT265333 End A/B test for search location
 DuplicateovasilevaT261648 Perform A/B test for search location change
 ResolvedMNeislerT259250 A/B test setup for search changes
 ResolvedVolker_ET256040 Build the wvui-input component for Vue.js search
 ResolvedphuedxT251544 Add user journey performance tests for Vector's Legacy and Vue.js search
 ResolvedovasilevaT260167 Make new search widget configurable per project
 ResolvedovasilevaT263657 Style search widget results based on project configuration
 DeclinedNoneT262566 Enable DWIM support for Vue.js search

Event Timeline

• Niedzielski created this task.Jul 13 2020, 5:50 PM
• Niedzielski moved this task from Backlog to Analysis on the Design-Systems-team-20200324-20220422 (Vue.js Search Experience (Vector modern)) board.Jul 14 2020, 2:06 AM
• Niedzielski added a parent task: T259798: Deploy the new Vue.js search experience to the Beta-Cluster and Test Wikipedia.Aug 6 2020, 1:58 PM
ovasileva triaged this task as High priority.Sep 10 2020, 5:36 PM
ovasileva added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).
Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Sep 17 2020, 7:31 PM
• Niedzielski updated the task description. (Show Details)Sep 23 2020, 4:51 PM
ovasileva set the point value for this task to 1.Oct 7 2020, 4:50 PM
Volker_E added a project: Performance-Team.Oct 7 2020, 10:35 PM
• Gilles moved this task from Inbox, needs triage to Radar on the Performance-Team board.Oct 13 2020, 6:53 PM
• Gilles edited projects, added Performance-Team (Radar); removed Performance-Team.
• Gilles subscribed.
ovasileva moved this task from Blocked on Others to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Oct 28 2020, 5:15 PM
Jdlrobson added a subtask: T261984: Folder structure for assets built by Webpack should be separated from standard ResourceLoader assets.Oct 30 2020, 5:42 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subtasks: T264355: Integrate wvui-search-form into Vector, T265333: End A/B test for search location.
Jdlrobson added subtasks: T256040: Build the wvui-input component for Vue.js search, T251544: Add user journey performance tests for Vector's Legacy and Vue.js search, T260167: Make new search widget configurable per project, T263657: Style search widget results based on project configuration.Oct 30 2020, 5:45 PM
ovasileva closed subtask T265333: End A/B test for search location as Resolved.Nov 5 2020, 4:03 PM
Volker_E closed subtask T256040: Build the wvui-input component for Vue.js search as Resolved.Nov 6 2020, 9:01 PM
sbassett updated the task description. (Show Details)Nov 17 2020, 10:08 PM
sbassett updated the task description. (Show Details)
Jdlrobson moved this task from Upcoming to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Nov 18 2020, 10:51 PM
Jdlrobson closed this task as Declined.Nov 24 2020, 6:24 PM
Jdlrobson closed subtask T261984: Folder structure for assets built by Webpack should be separated from standard ResourceLoader assets as Declined.
Jdlrobson subscribed.

The current recommendation of the working group that met last week is to not use a build step in Vector so this task is not necessary anymore. We will be deleting the search feature branch and writing a new patch on top of Vector's master branch.

ovasileva closed subtask T263657: Style search widget results based on project configuration as Resolved.Dec 15 2020, 11:45 AM
ovasileva closed subtask T260167: Make new search widget configurable per project as Resolved.
• nray closed subtask T264355: Integrate wvui-search-form into Vector as Resolved.Jan 19 2021, 5:39 PM
phuedx closed subtask T251544: Add user journey performance tests for Vector's Legacy and Vue.js search as Resolved.Mar 18 2021, 1:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits