Change 565021 merged by jenkins-bot:
[mediawiki/tools/codesniffer@master] Fix sniff destroying comments mentioning other variables
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 25 2020
I have an account to rename there as well. I hope that SUL can resolve this.
Change 567213 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] Fix UnboundLocalError in ProofreadPage._ocr_callback
Change 567213 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] Fix UnboundLocalError in ProofreadPage._ocr_callback
Thank you @Dwu1011!
Thank you! @Crutishnyk !
Change 567212 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/services/parsoid@master] Require PHPUnit 8 like MW core
Change 567211 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[css-sanitizer@master] Require PHPUnit 8 like MW core
Change 567210 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[wikimedia/textcat@master] Require PHPUnit 8 like MW core
Change 567209 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[utfnormal@master] Require PHPUnit 8 like MW core
Change 567208 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[testing-access-wrapper@master] Require PHPUnit 8 like MW core
Change 567207 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[purtle@master] Require PHPUnit 8 like MW core
Change 567206 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[php-session-serializer@master] Require PHPUnit 8 like MW core
Change 567205 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/libs/Zest@master] Require PHPUnit 8 like MW core
Change 567204 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/libs/LangConv@master] Require PHPUnit 8 like MW core
Change 567203 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/libs/alea@master] Require PHPUnit 8 like MW core
In T219139#5701986, @Umherirrender wrote:The last question is, if this should be done also for unset()
I would say yes, because it makes the code easier when doing one thing in one line and not combine multi unsets in one line.
Is there an easy way to skip the first parameter in a method call, no matter how complicated the code is?
Urgent response required
In T243600#5830919, @Jdforrester-WMF wrote:Might want to do some of T243647: Upgrade all MediaWiki libraries to use PHPUnit 8.5+ in their tests, like MediaWiki core first. ;-)
Looks like the source of this bug is the code changed here: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/458490/8/src/dm/ve.dm.SourceConverter.js#82
Change 567202 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Sudo@master] Pass a user to LogPage::addEntry
Change 567201 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SpecialNamespaces@master] Pass a user to LogPage::addEntry
Change 567200 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/RevisionCommentSupplement@master] Pass a user to LogPage::addEntry
Change 567194 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Replace deprecated IP class with IPUtils
Deployed to .15 and .16
I watched the logs, everything should be good now. Sorry about that!
Not just the QR code... We list the secret on the page in clear text
Jan 25 04:54:21 codesearch6 docker[2002]: fatal: unable to access 'https://gerrit-replica.wikimedia.org/r/mediawiki/extensions/CentralAuth.git/': The requested URL returned error: 503
Looking
@Samwalton9 So for example if a hashtag with result data span for say 2 years is viewed in daily mode, then will not it become messy. Like
.I can reproduce the same issue in Chromium, so this isn't Firefox specific. The highlight can be fixed by disabling CodeMirror and enabling it again, so it must be something weird that only happens during insertion.
@Aklapper {{ping}} its been over a week since I posted my request - is there a standard time frame for this?
@Hexmode @MarkAHershberger would you mind looking at https://github.com/hexmode/mediawiki-UserSnoop/pull/3 and https://github.com/MWStake/mediawiki-extensions-UserLoginLog/pull/5 please?
So to summarize:
- When you're posting a reply, we allow you to type in a signature (or multiple) manually with ~~~~, in which case we don't add another one at the end of the comment. This is a bit silly to do, but there is not really any reason to try to disallow it. A more practical use case is adding a second signature to a comment in the upcoming comment-editing workflow (e.g. if you're making a significant correction to your previous comment and want to note when it was corrected).
- When the page already contains a comment with multiple signatures (within a single paragraph or list item), there will be only one "Reply" button added, at the end of the line.
Thanks for reporting this bug. Fortunately this has already been fixed in T238364. I could not reproduce this bug on the beta cluster because if is running on the latest version of Mediawiki. I think enwiki is still running on a older version of Mediawiki. This bug will not bug you anymore after the new version gets deployed.
Change 328462 abandoned by Thiemo Kreuz (WMDE):
Make CentralAuthGroupMembershipProxy implement UserGroupMember
Agreed with what @Volans said, I've been working on tox-wikimedia (https://pypi.org/project/tox-wikimedia/) which will hopefully be able to contain and be the the authoritative way to set up whichever code formatter we end up using. My POC patch (since black is being used in cloud services repos) is https://gerrit.wikimedia.org/r/c/integration/tox-wikimedia/+/566407
Done.
Change 567197 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/VipsScaler@master] Update extension.json to manifest version 2
Change 567196 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/RegexBlock@master] Update extension.json to manifes version 2
Change 567195 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/BounceHandler@master] Update extension.json to manifest version 2
Change 567194 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/WikimediaMaintenance@master] Bump required version to MW 1.35.0
I am okay to proceed further.
In T241359#5830750, @Jclark-ctr wrote:I see that the racking recomendation is both in 10g and 1g racks @Marostegui and A1 is a network rack
would these racks work for you?
es1020.eqiad.wmnet A3
es1021.eqiad.wmnet B3
es1022.eqiad.wmnet C5
es1023.eqiad.wmnet D6
es1024.eqiad.wmnet A5
es1025.eqiad.wmnet B5
Change 567193 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[operations/mediawiki-config@master] Replace deprecated IP class with IPUtils
Change 567192 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[operations/puppet@production] toolforge: Run clush helpers with Python 3
Here's a threaddump I managed to grab before restarting: https://fastthread.io/my-thread-report.jsp?p=c2hhcmVkLzIwMjAvMDEvMjUvLS1hcGktOTY2ZjljZTItOGFkZC00NjdiLTg1ZDQtZjQ2MTIyNjNkNzYyODliNjM4MjctOTVjMS00YTlkLWIyZDMtOGMwMWQ5MTU0YTg0LnR4dC0t&