Page MenuHomePhabricator

Differentiate between events emitted from the Reply Tool and the New Discussion Tool
Open, Needs TriagePublic

Description

This task is about implementing a way for Editing Engineering and Product Analytics to differentiate between events that are emitted from the Reply Tool and events that are emitted from the New Discussion Tool.

Background

Currently, EditAttemptStep contains one integration value for DiscussionTool features. This value is called discussiontools.

To date, we've been able to assume all integration-discussiontools events are emitted from the Reply Tool.

Trouble is, once the New Discussion Tool is deployed, it will no longer be clear what editor integration – the Reply Tool or the New Discussion Tool – is responsible for the integration-discussiontools events we will be seeing.

Done

  • The necessary changes are made for us (Editing and Product Analytics) to differentiate between events emitted from the Reply Tool and events emitted from the New Discussion Tool.

Event Timeline

ppelberg created this task.Oct 9 2020, 12:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 9 2020, 12:06 AM
JTannerWMF assigned this task to DLynch.Oct 14 2020, 4:39 PM

One option would be to use the existing init_type field, which is currently being sent as page but could be sent as section for this case. Advantage there is that it's just one event to change, and doesn't require any schema change. Disadvantage is that querying "event X in a session whose init was of type Y" is a more complicated query. It's consistent with how we currently log this sort of difference in VE/wikieditor though.

The other option is option is to make a new integration value, discussiontools-newtopic or whatever. Advantage: easier queries. Disadvantage: needs a schema change, becomes a (slightly) more complex query for things which you want to ask about that're common between comment replies and new topics.

JTannerWMF added a subscriber: JTannerWMF.

@MNeisler , David needs you to weigh in on an approach

Thanks @DLynch for outlining the options and @JTannerWMF .for the ping

I'm leaning towards the option of using the existing init_type field. While it might be a slightly more complicated query, I think being consistent with how these events are currently stored in the schema will avoid confusion.

Can you confirm if the following is correct to make sure I understand how the two types of events will be logged?

  • Reply Events: All events in sessions where event.action = 'init', event.integration = 'discussiontools', event.init_type = 'page'
  • Discussion Tool Events: All events in sessions where event.action = 'init', event.integration = 'discussiontools', event.init_type = 'section'
MNeisler moved this task from Triage to Tracking on the Product-Analytics board.Oct 23 2020, 10:28 PM
DLynch added a comment.Wed, Nov 4, 6:26 PM

If by "Discussion Tool Events" you mean "New discussion section events", then yes.

If by "Discussion Tool Events" you mean "New discussion section events", then yes.

Yes, sorry I meant "New discussion section events". Thanks for confirming. Based on that, I think we should go ahead and use the existing init_type field for differentiating between the two event types.