Regression: Minerva bell icon is black not gray
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Msz2001
	Feb 17 2024, 10:49 AM

Description

NOTE: QA only task. Fixed by new Codex release.

Steps to replicate the issue (include links if applicable):

Navigate to a mobile version of a wiki, eg. https://en.m.wikipedia.org/wiki/Main_Page
Ensure you're logged in
Ensure that you have "Advanced mode" turned on in settings (not necessary, but turning AMC on will show other icons for easy comparison)

What happens?:
The bell icon is significantly darker than other icons

What should have happened instead?:
All icons should be of the same brightness

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Microsoft Edge 121 (desktop and Android), Firefox 122 (desktop)

The bell icon uses SVG embedded in data URL, where fill is specified as a CSS variable instead of proper color, which seems to be the cause.

This issue is present for about two weeks now, perhaps side effect of some other change.

QA Results - Beta

AC	Status	Details
1	✅	T357845#9574201

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		ovasileva	T341631 [EPIC] Q1 Main hypothesis: Typographical and palette customizations
Resolved		ovasileva	T341632 [EPIC] Palette customizations and dark mode
Resolved		ovasileva	T354835 [epic] Release night mode as a beta feature on desktop and mobile
Resolved		Jdlrobson	T354836 [goal] Allow desktop and mobile page chrome to appear in night mode ahead of beta release
Resolved		ovasileva	T354837 [Night mode] Page background appears in night mode on desktop
Resolved		ovasileva	T354838 [Night mode] Page background appears in night mode on mobile
Resolved		JScherer-WMF	T356825 Implement the new night mode color palette in Minerva
Resolved		ovasileva	T357759 Deploy night mode on the minerva skin on test wiki
Resolved	Spike	SToyofuku-WMF	T357077 [Spike] Explore different options for code sharing of page-specific configuration between Minerva and Vector
Resolved		ovasileva	T354842 [Night mode] All global navigation open by default appear in night mode on desktop
Resolved		ovasileva	T354843 [Night mode] Make all open-by-default global navigation appear in night mode on mobile
Resolved		Jdlrobson	T356074 Implement the dark mode color palette and switch LESS variables in Minerva to use it, degrade support for browsers that do not support CSS custom properties
Resolved		ovasileva	T356900 Regression: Issues with color-subtle (Codex .cdx-mixin-css-icon mixin doesn't work with CSS variables)
Resolved	BUG REPORT	Jdlrobson	T356928 Regression: Visited links on mobile appearing as black
Resolved	BUG REPORT	JScherer-WMF	T357381 Regression: Active link color is broken on mobile
Resolved		Jdlrobson	T356344 [Night mode] Templates can be fixed by editors when necessary for night mode
Duplicate	Feature	None	T353887 Support prefers-color-scheme in css-sanitizer
Resolved	Spike	Jdlrobson	T356432 [spike] Audit broken experiences in templates night mode
Resolved		Jdlrobson	T357453 WCAG Color Contrast Violations in Infobox on Minerva Skin Night Mode
Resolved		ovasileva	T359658 [QA task] WCAG Color Contrast Violations in Infobox on Minerva Skin Night Mode
Resolved	Feature	Jdlrobson	T241946 Support @media (prefers-color-scheme: ...) rule in css-sanitizer
Duplicate		None	T357585 WCAG Color Contrast Violations in Tables with Inline Style Attributes on Minerva Night Mode
Resolved		Jdlrobson	T357717 Color Contrast Issue on Wikipedia Portal: Current Events
Resolved		ovasileva	T357721 Hatnote Color Contrast Issues Across Wikipedia Pages on Minerva Night Mode
Duplicate		Jdlrobson	T358007 [French Wikipedia] Minerva Night Mode Color Contrast Issue - links in .bandeau-container .bandeau-section.bandeau-niveau-information
Resolved		Jdlrobson	T357730 Template:Track listing has color contrast issues with Minerva Night Mode
Duplicate		None	T357733 Color Contrast Issue in ambox
Resolved		Jdlrobson	T357735 Color contrast issues with Template:Quote_box in Minerva Night Mode
Resolved	BUG REPORT	ovasileva	T358608 Phonos is not night mode friendly
Resolved		ovasileva	T357998 Address color contrast issues in .wikitable
Invalid		None	T358000 Color Contrast Error - [style] Styling in .reference > a Element in Minerva Night Mode
Invalid		Jdlrobson	T358004 Color Contrast Issue in Minerva Night Mode - table.sidebar Template
Duplicate		None	T358005 Minerva Night Mode Color Contrast Issue - current-events-sidebar (Portal Pages)
Duplicate		None	T358010 Main Page Template Color Contrast Issue in Minerva Night Mode
Duplicate		None	T358013 Citation Reference Color Contrast Issue - Minerva Night Mode
Duplicate		None	T358014 Color Contrast Issue in Minerva Night Mode - .colonnes.liste-simple
Resolved		ovasileva	T358015 Color Contrast Issue in Minerva Night Mode - a.mw-redirect
Resolved		Jdlrobson	T358387 [EPIC] Ensure all template text is readable in night mode: Fix all templates using background without color
Resolved		Jdlrobson	T358164 Set color/background to inherit or #333 on common templates/use of HTML4 bgcolor
Resolved		Jdlrobson	T358012 Navbox Related Color Contrast Issue in Minerva Night Mode
Resolved		Jdlrobson	T357726 Color contrast issue with Template:Side_box in Minerva Night Mode
Duplicate		Jdlrobson	T358016 Other Projects Template Color Contrast Issue - Minerva Night Mode
Resolved		Jdlrobson	T358385 Address issues with usage of [bgcolor]
Resolved		Jdlrobson	T356899 [Spike] Explore automatic night mode fixes with content transform team
Declined		Jdlrobson	T358239 Automatic Correction of Template and Inline Styles
Resolved		SToyofuku-WMF	T358240 [Spike 4hours] Performance Impact Assessment for Night Mode Style Correction
Resolved		Jdlrobson	T358388 Tag problematic pages with tracking category
Resolved		KSarabia-WMF	T358003 [3hr] [FRENCH WIKIPEDIA] Color Contrast Issue in Minerva Night Mode - .alternance
Resolved		None	T359488 Make MediaWiki:Minerva.css render blocking to allow editors to ship styles that fix issues with night mode
Open		None	T248416 [EPIC] Drop MediaWiki:Mobile.css and MediaWiki:Mobile.js in favor of TemplateStyles and MediaWiki:Minerva.css
Resolved		ovasileva	T359644 Apply night mode fixes to French infoboxes
Resolved		Jdlrobson	T360683 How should Template:Color work in night mode?
Resolved	BUG REPORT	Jdlrobson	T360844 Links in elements with background color should become black so they are accessible
Duplicate	BUG REPORT	None	T365318 Dark/night mode shouldn't reset .metadata styles
Resolved	BUG REPORT	ovasileva	T357179 Page issues as rendered in article is not compatible with night mode
Open		ovasileva	T358192 [Bug] Page issues icon disappearing on click
Resolved	BUG REPORT	ovasileva	T356822 Minerva/MobileFrontend icons not using embedded data URI rules should be compatible with night mode
Resolved	BUG REPORT	abi_	T356821 Make <languages> compatible with night mode by using Codex design tokens
Resolved	BUG REPORT	Nikerabbit	T358381 Make Translate outdated translations text compatible with night mode
Resolved	BUG REPORT	ovasileva	T359081 [Bug] Page previews currently does not work in night mode.
Resolved		Jdlrobson	T360877 [Bug] Page previews gradient not working in night mode
Resolved	BUG REPORT	Jdlrobson	T358822 Translate extension needs to import mediawiki.skin.variables to get night mode
Resolved		ovasileva	T356341 [Night Mode] I want to opt into or out of night mode on mobile
Resolved		ovasileva	T355065 Set up feature flag and menu for night mode on desktop
Resolved		ovasileva	T357707 Re-order Vector preferences - night mode should be above limited width
Resolved		ovasileva	T355118 Set up feature flag for night mode on mobile
Resolved		ovasileva	T355705 Allow pages to not appear in night mode
Resolved	Feature	None	T328850 Minerva/Vector: Dark mode toggle needs to be tri state
Open		None	T362923 Dark mode toggle needs to be tri state in Extension:DarkMode
Resolved		ovasileva	T356653 Show a toast notification on page load for night mode when the setting doesn't take effect in Minerva
Resolved		ovasileva	T358811 Set Minerva default to day mode
Resolved		ovasileva	T361047 Minerva Night Mode launch notifications
Resolved		ovasileva	T356434 [Night Mode] All pages and overlays that can be accessed within 2 clicks by a logged in user (AMC disabled) appear in night mode on mobile
Resolved		ovasileva	T359152 Deploy initial version of night mode to pilot wikis on the mobile website for testing
Resolved		ovasileva	T359183 Exclude non-functional pages from night mode
Resolved	BUG REPORT	ovasileva	T359958 Exclude list is not working for special page names
Resolved		Jdlrobson	T358238 Implement Linting Rule for Template Style Fixes
Resolved		Jdlrobson	T359205 Deployment Ticket - Linting Rule for Template Style Fixes
Resolved		None	T358241 Document new night mode linting rules
Resolved		Jdrewniak	T358059 Use Codex experimental build in Minerva to allow codex components to appear in night mode
Resolved		ovasileva	T357722 Main pages should work in night mode
Resolved	BUG REPORT	ovasileva	T358528 Mobile editor inconsistently renders both night mode and light mode elements
Resolved		ovasileva	T358797 Autocorrect content which uses inline styles using background without color
Resolved		ovasileva	T359571 Add note specifying night mode release is experimental
Resolved		Jdlrobson	T360132 QA: Night mode linting rule
Resolved		Jdlrobson	T359983 Rename the skin night mode classes to something more sensible before they become widely used
Resolved		ovasileva	T363814 Release dark mode as a beta feature on desktop (May 15th)
Resolved		Jdrewniak	T354889 Vector 2022 should get night theme
Resolved		JScherer-WMF	T354891 [Design] Implement the dark mode color palette and switch LESS variables in Vector to use it
Resolved		ovasileva	T361157 Change "Night" to "Dark" in Appearance settings
Resolved		ovasileva	T362726 [config] Enable night mode styles on Vector 2022 skin
Resolved	BUG REPORT	ovasileva	T363779 [Bug] Echo not compatible with desktop night theme
Resolved	BUG REPORT	ovasileva	T363861 Visual Editor overlays do not work in night theme
Resolved		Jdlrobson	T363920 Migrate ResourceLoader Icons in Vector to use Codex
Resolved		ovasileva	T367150 Deploy dark mode to logged-out users in tier 1 and 2 wikis on the Vector2022 and Minerva skin
Resolved		DTorsani-WMF	T355147 [EPIC] Dark Mode
Resolved		egardner	T356537 Release experimental styles and CSS variable set of Codex design tokens for use in MediaWiki
Resolved		Volker_E	T334790 tokens: Implement new static layout background-color tokens
Open		None	T366760 [EPIC] Dark mode for Growth team maintained features
Resolved	BUG REPORT	Jdlrobson	T357699 Prepare Special:Homepage for night mode
Resolved		AnneT	T356540 Make CSS-only icons compatible with CSS variables
Resolved	BUG REPORT	Jdlrobson	T357845 Regression: Minerva bell icon is black not gray

Event Timeline

Msz2001 created this task.Feb 17 2024, 10:49 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 17 2024, 10:49 AM

Known issue, we're waiting on T357699. Hopefully will be fixed soon.

Fixed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1005171

Jdlrobson renamed this task from Minerva bell icon is black not gray to Regression: Minerva bell icon is black not gray.Feb 21 2024, 12:18 AM

Jdlrobson assigned this task to Edtadros.

Jdlrobson triaged this task as Medium priority.

Jdlrobson moved this task from Incoming to Code Review on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 3) board.

Jdlrobson updated the task description. (Show Details)

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Navigate to a mobile version of a wiki, eg. https://en.m.wikipedia.org/wiki/Main_Page
Ensure you're logged in
Ensure that you have "Advanced mode" turned on in settings (not necessary, but turning AMC on will show other icons for easy comparison)
✅ All icons should be of the same brightness
Day mode

Night mode, I believe this is not in the scope of this task, however there is an issue with the notification icon.

Edtadros updated the task description. (Show Details)Feb 24 2024, 3:36 AM

Jdlrobson closed this task as Resolved.Feb 26 2024, 5:53 PM

Jdlrobson claimed this task.

	F42076592: screenshot 588.png
	Feb 24 2024, 3:32 AM

	F42076590: screenshot 587.png
	Feb 24 2024, 3:32 AM

Regression: Minerva bell icon is black not grayClosed, ResolvedPublic0 Estimated Story PointsBUG REPORTActions