Page MenuHomePhabricator
Create Task
Maniphest T104955

Dashboard header overlaps with page selector
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

  1. Go to Special:CX
  2. Start a new article
  3. Resize the window so that it is not much taller than the dialog (or scroll down later)
  4. Click to change the target language

Observe how ULS language selection opens and scrolls down the page enough that the start new translation header starts to float and overlap with the dialog.

pasted_file (838×1 px, 107 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Prevent page scroll when overlay is shownmediawiki/extensions/ContentTranslationmaster+46 -29
Fix dashboard header overlapping page selectormediawiki/extensions/ContentTranslationmaster+7 -2
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 In ProgressNoneT378958 Custom translation suggestions: Community-defined Collections [EPIC]
 OpenNoneT76456 Language Engineering tracker of trackers (tracking)
 DeclinedNoneT76448 [Epic] ContentTranslation - Entry Points
 OpenNoneT87867 Experiment ways to get more users to translate articles (tracking)
 OpenNoneT89709 Guided tour after enabling the beta feature to introduce entry points
 DeclinedNoneT96134 Entry Point: Show an entry point to ContentTranslation at an empty page in action=view
 DuplicateNoneT90224 Allow anonymous users to translate
 DuplicateNoneT90186 Entry point: change target language from gray links panel
 DeclinedNoneT90185 Entry point: Change source language from gray link panel
 ResolvedAmire80T90172 Suggest interlanguage translation opportunity based on browser Accept-Language
 ResolvedSBissonT90162 Entry point: New translation from Wikidata
 InvalidNoneT76457 [Epic] ContentTranslation - Translation Dashboard
 ResolvedNikerabbitT87439 [Tracking] Suggest articles to translate from the dashboard
 ResolvedsanthoshT92987 decide how to store and load the list of suggested articles to translate
 DeclinedleilaT96636 Missing article recommendation from enwiki to eswiki
 ResolvedsanthoshT88344 Polish the CX Dashboard
 ResolvedsanthoshT104955 Dashboard header overlaps with page selector
 ResolvedNikerabbitT109556 ApiQueryContentTranslation not respecting the limit parameter
 ResolvedsanthoshT111026 Keep suggestions for later (star suggestions)
 ResolvedsanthoshT111027 Discard ContentTranslation suggestions
 ResolvedsanthoshT111028 Integrate the personalised algorithm for translation suggestions
 ResolvedsanthoshT117649 ApiQueryContentTranslation does not respect from and to params if sourcetitle param not present
 OpenNoneT111034 Anticipate useful article details to pick a translation suggestion
 ResolvedsanthoshT111036 Access original article from suggestions list
 ResolvedPginer-WMFT111037 Load more article suggestions
 OpenNoneT113257 Custom translation suggestions: Find opportunities to translate in topic areas selected by the user
 ResolvedPginer-WMFT229242 Explore ways to restrict suggestions to a given knowledge area
 ResolvedPginer-WMFT235186 Design a way to control the criteria for suggestions
 ResolvedFeature• PWaigi-WMFT317056 Content Translation- suggest top 10 most viewed articles to content translation
 DeclinedNoneT317057 Create a campaign for most viewed articles
 OpenNoneT367873 Technical exploration to support topic-based suggestions with the current Recommendation API
 ResolvedsanthoshT373961 Support basic topic & community-defined translation collections with the current Recommendation API
 ResolvedSBissonT377124 Explore search parameters to increase diversity in topic-based suggestions
 ResolvedSBissonT368422 Custom translation suggestions: Basic topic selection
 ResolvedngkountasT370746 CX Unified Dashboard: Support suggestions based on previous edits
 ResolvedSBissonT368713 Community-defined translation collections: Technical Exploration
 ResolvedngkountasT369012 Custom translation suggestions: Direct access to filtered suggestions
 DeclinedNoneT384089 Improve how editors directly get access to filtered suggestions
 OpenNoneT369268 Custom translation suggestions: Multiple selection
 ResolvedsanthoshT369484 Modernize recommendation API
 ResolvedkevinbaziraT371465 Deploy Modernized Recommendation API to LiftWing
 ResolvedngkountasT369595 Custom translation suggestions: Search
 ResolvedKCVelaga_WMFT369631 Custom translation suggestions: Instrumentation
 ResolvedeamedinaT376691 CX event instrumentation: basic topic selection
 ResolvedeamedinaT381270 CX instrumentation: suggestions filters menu close
 ResolvedKCVelaga_WMFT381391 Visualize use of suggestions over time for mobile translations
 ResolvedKCVelaga_WMFT369696 Analyze how people are interacting with current suggestions
 ResolvedngkountasT368718 Community-defined Translation Collections: Single selection mode UI
 ResolvedngkountasT374597 Community-defined Translation Collections: Default/Vital Articles
 OpenNoneT378955 Community-defined Translation Collections: Multiple selection mode UI
 ResolvedSGautam_WMFT372130 Useability testing for basic topic selection & community defined translation collections on UL platform
 OpenNoneT379273 Community-defined Translation Collections: Collection View
 OpenSGautam_WMFT383762 Collection View: "Show All Articles" expansion feature
 OpenNoneT383761 Collection View: Additional Action Buttons
 ResolvedeamedinaT380702 Consider length of Collection names on different views
 ResolvedSBissonT378172 Incomplete URLs for Custom translation suggestions do not fail gracefully
ResolvedSBissonT380368 Basic topic selection: Adjust visual style for active filter tags
 ResolvedSBissonT380372 Basic topic selection: Dialog header adjustment when adjusting suggestions
 ResolvedSBissonT380379 Basic topic selection: Dialog responsivenes when adjusting suggestions
 ResolvedSBissonT380380 Basic topic selection: Use standard transitions
 ResolvedngkountasT382476 Custom Translation Suggestions: Empty & Error states for Article and Section-level suggestions
OpenNoneT395307 Surface recently selected filters
 ResolvedsanthoshT115008 Paginate suggestions with an option to refresh them
 ResolvedsanthoshT111143 Update suggestion items in database so that we dont show titles that already exist in target language
 ResolvedKartikMistryT111901 Enable CX Suggestions in ptwiki
 ResolvedsanthoshT106405 Provide basic suggestions based on featured articles
 ResolvedKartikMistryT112498 Enable CX Suggestions in testwiki
 ResolvedArrbeeT112612 Prepare announcement for ptwiki about article suggestion enablement
 ResolvedsanthoshT112051 Support language selection for suggestions
 DuplicateNoneT112775 Clicking on suggestion in ContentTranslation should skip the form "From:" and go directly to "To:"
 ResolvedsanthoshT112822 Tab "Suggestions" as default in Content Translation when coming from a campaign
 ResolvedAmire80T113332 When opening the dialog from a suggestion, the focus should be in the target title field
 DuplicatesanthoshT113333 Layout glitches when the dashboard header becomes sticky
 DuplicateNoneT113334 Open the suggestions view by default if there are no in-progress translations
 OpenNoneT113586 Notify inactive translators that new suggestions are available
 ResolvedKartikMistryT112848 CX Suggestions: Fill suggestions about featured article missing for more language pairs
 ResolvedsanthoshT113722 Spanish cannot be selected as a source language for translation suggestions in pt.wikipedia.org
 ResolvedsanthoshT113704 The French Wikipedia shows suggestions for translating TO English when selecting the Suggestions tab
 OpenNoneT93717 Analyse and visualize the entry point effectiveness data collected using eventlogging
 ResolvedsanthoshT114888 Wrong languages (and no suggestions) when switching to the suggestions view
 ResolvedSBissonT114745 Suggest a campaign for users to join
 ResolvedsanthoshT115006 Surface some manually curated campaigns for users to translate
 ResolvedKartikMistryT123814 Create a backend loaded campaign for Category:RTT between English and more languages
 ResolvedKartikMistryT126973 Create a backend loaded campaign for the Catalan culture challenge
 InvalidNoneT128174 Integrate "for later" as a personal translation list
 ResolvedAmire80T112720 Link http://recommend.wmflabs.org from CX Suggestions as fallback
 ResolvedNikerabbitT115973 Tab "Suggestions" as default in Content Translation when language variables are not set
 ResolvedPginer-WMFT117604 CX's suggestion with long description overflows
 DuplicateEtonkovidovaT117605 Double starring of Content Translation's suggestions
 ResolvedSBissonT117850 Provide access to all existing translation lists from the suggestions view
 Resolved• Petar.petkovicT111094 Improve the New Translation dialog to easily find articles to translate
 OpenFeatureNoneT119188 Surface the number of views for suggested and completed translations
 Resolved• Petar.petkovicT119507 When the in-progress view is empty a "More suggestions" label is shown
 ResolvedsanthoshT119939 Notify translators about new personalised suggestions being available based on their recently published translation
 ResolvedNikerabbitT120063 Sticky headers for expanded campaigns
 ResolvedPginer-WMFT120064 Review current design status of suggestions
 DuplicateEtonkovidovaT120670 ContentTranslation Suggestions Favorite: Multiple issues
 ResolvedNikerabbitT120067 Adjust ContentTranslation suggestion discard workflow
 ResolvedPginer-WMFT120930 Adjust the visual hierarchy of suggestion items
 ResolvedPginer-WMFT121218 Show a loading indicator for ContentTranslation suggestions
 Resolved• Petar.petkovicT121219 Make dashboard views linkable and resistant to refresh
 ResolvedNikerabbitT121222 Refreshing suggestions should always show different suggestions
 ResolvedPginer-WMFT121223 Make refresh suggestion action more prominent
 DeclinedNoneT121224 Show a smaller but constant number of suggestions at a time
 ResolvedPginer-WMFT121225 Prevent users from selecting the same source and target language for suggestions
 ResolvedNikerabbitT121226 Switching the suggestions languages while loading results in an inconsistent list
 ResolvedsanthoshT121227 Featured-based suggestions should be a fallback of personalised suggestions
 InvalidNoneT121230 Adjust ContentTranslation suggestion refresh transition
 OpenNoneT125379 Feedback when a suggestion (or list of suggestions) is kept for later
 DuplicateNoneT129341 Filter out suggestions when there is already an in-progress translation for them
 ResolvedNikerabbitT155583 Suggest articles to translate based on previous regular edits (when there are no previous translations)

Event Timeline

Nikerabbit created this task.Jul 7 2015, 8:56 AM
Nikerabbit raised the priority of this task from to Needs Triage.
Nikerabbit updated the task description. (Show Details)
Nikerabbit added a project: ContentTranslation.
Nikerabbit subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 7 2015, 8:56 AM
Amire80 triaged this task as Low priority.Jul 7 2015, 9:10 AM
Amire80 added a parent task: T88344: Polish the CX Dashboard.
Amire80 added a project: ContentTranslation-Release6.
Amire80 set Security to None.
Amire80 moved this task from Needs Triage to CX6 on the ContentTranslation board.
Amire80 moved this task from Backlog to Bugs on the ContentTranslation-Release6 board.Jul 7 2015, 8:26 PM
Pginer-WMF moved this task from CX6 to CX7 on the ContentTranslation board.Jul 21 2015, 4:12 PM
Pginer-WMF removed a project: ContentTranslation-Release6.
gerritbot subscribed.Sep 29 2015, 4:25 AM

Change 242058 had a related patch set uploaded (by Jarrettmunton):
Fix dashboard header overlapping page selector

https://gerrit.wikimedia.org/r/242058

gerritbot added a project: Patch-For-Review.Sep 29 2015, 4:25 AM
gerritbot added a comment.Sep 29 2015, 6:58 AM

Change 242058 merged by jenkins-bot:
Fix dashboard header overlapping page selector

https://gerrit.wikimedia.org/r/242058

Diffusion mentioned this in rMEXTccacdeb7b028: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 29 2015, 6:58 AM
Jarrettmunton mentioned this in rECTXdcbcaf92cf99: Fix dashboard header overlapping page selector.Sep 29 2015, 6:58 AM
santhosh added subscribers: Jarrettmunton, santhosh.Sep 29 2015, 9:22 AM

Thanks @Jarrettmunton

The ideal fix for this is to prevent the The ideal fix for this is to prevent the scrolling when overlay is shown. That is done in https://gerrit.wikimedia.org/r/242094

gerritbot added a comment.Sep 29 2015, 9:23 AM

Change 242094 had a related patch set uploaded (by Santhosh):
Prevent page scroll when overlay is shown

https://gerrit.wikimedia.org/r/242094

santhosh claimed this task.Sep 29 2015, 9:23 AM
santhosh added a project: LE-CX6-Sprint break.
santhosh moved this task from Backlog to In Review on the LE-CX6-Sprint break board.
santhosh added a subscriber: LE-CX6-Sprint break.
santhosh removed a subscriber: LE-CX6-Sprint break.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 29 2015, 10:16 PM
Jdforrester-WMF edited projects, added MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 12:49 AM
gerritbot added a comment.Sep 30 2015, 9:20 AM

Change 242094 merged by jenkins-bot:
Prevent page scroll when overlay is shown

https://gerrit.wikimedia.org/r/242094

santhosh mentioned this in rMEXT4feaf74e3383: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Sep 30 2015, 9:21 AM
Nikerabbit mentioned this in rECTX3629932645e3: Prevent page scroll when overlay is shown.Sep 30 2015, 9:21 AM
Nikerabbit moved this task from In Review to QA on the LE-CX6-Sprint break board.Sep 30 2015, 9:25 AM
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 10:01 AM
Arrbee subscribed.Sep 30 2015, 11:01 AM

ULS dialog scrolls to show the language list well.

Arrbee moved this task from QA to Done on the LE-CX6-Sprint break board.Sep 30 2015, 11:01 AM
santhosh closed this task as Resolved.Oct 9 2015, 6:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits