In T252463#6159156, @CCicalese_WMF wrote:

In T252463#6156889, @thcipriani wrote:

There are a few options that I'm aware of:

1. Use gerrit for development and gerrit can mirror to github automatically
2. Development stays on github and every so often a human/group of humans (with the forge committer permisison) reviews changes and manually pushes them to a gerrit upstream
3. Development stays on github and code is automatically mirrored to gerrit.

From a maintenance perspective (from the releng side anyway) option 1 is the best -- no special permissions, no mirroring to monitor.

There may be other considerations here that make option 2 a better one; i.e., it may be that a person needs to manually ensure compatibility between Chameleon's composer dependencies and the dependencies in mediawiki/vendor, for example (something @Jdforrester-WMF mentioned in IRC as a consideration).

I've discussed option 1 with the Chameleon maintainer, and it is a non-starter. Either 2 or 3 seem reasonable. Note that I was recently added as a contributor to the Chameleon and Bootstrap github repos.

Testflight binary size: 33.1MB

We can handle the deployment ordering problem, just make sure they are both merged within the same train window.

Baseline measurements for 6.6.0

Change 598120 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.32] filerepo: use makeGlobalKey() in ForiegnDBViaLBRepo::getSharedCacheKey()

Change 598122 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.31] filerepo: use makeGlobalKey() in ForiegnDBViaLBRepo::getSharedCacheKey()

Change 598127 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Add URL template to the return data of mw.util.parseImageUrl

Change 598126 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/Echo@master] Add push notifier

Info: I renamed File:Fioan Fiedler.jpg to File:Fiona Fiedler.jpg (typo fix). And I had noticed before that in :de:Fiona Fiedler a message box appeared on top informing about unflagged changes of a file or template. I did the flagging then – it was the file. By default unflagged changes are not visible to readers in dewiki.

In T251983#6159622, @Arlolra wrote:

On last piece of the puzzle, "span.reference" changed to "span.mw-ref",
https://github.com/wikimedia/parsoid/commit/361c7e7b722c26a18f2828b4e21041d52a29b9be#diff-145dd2c3c665462c7ad4ff10c6e60b75L408

when we started loading from "ext.cite.style.css",
https://github.com/wikimedia/parsoid/commit/361c7e7b722c26a18f2828b4e21041d52a29b9be#diff-f92dbd08070410e3a1503b08a869afaeR348

In T244434#6024492, @RHo wrote:

However, @kostajh I did have a couple of minor design tweaks (hopefully!):

@RHo - below I added screenshots to illustrate the incorporated tweaks - they all seem to be in place.

1. Background-color should be rgba(234, 243, 255, 0.5) (Accent90 color @ 50% opacity), but is currently rgba(234, 243, 255, 1)
2. 4px spacing expected between task title and additional description
3. There should be 16px spacing between the task title and additional description text block and the icon
4. There should be 16px bottom padding in suggested-edits-mobile-peek-content

desktop	mobile

5. If the task type text goes over 1 line, the drawer should increase in height to maintain the padding:16px around suggested-edits-mobile-peek-content .

Will file a separate phab task for that.

On last piece of the puzzle, "span.reference" changed to "span.mw-ref",
https://github.com/wikimedia/parsoid/commit/361c7e7b722c26a18f2828b4e21041d52a29b9be#diff-145dd2c3c665462c7ad4ff10c6e60b75L408

In T251983#6159603, @cscott wrote:

Re c: or at least rename ext.cite.style.css to parsoid.ext.cite.styles.css (which we can do w/o or before merging the styles) to make this less confusing to review!

Change 598067 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Integrated Jade on the MW rollback page

Change 596248 abandoned by Subramanya Sastry:
Fix RTL directionality issue with refs

Change 598125 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/extensions/Cite@master] Sync unicode-bidi property for <sup> tags between Parsoid & core impls

Change 598122 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@wmf/1.35.0-wmf.31] filerepo: use makeGlobalKey() in ForiegnDBViaLBRepo::getSharedCacheKey()

Updates: 22-May

• Deployment plan draft is ready for team discussion: https://office.wikimedia.org/wiki/Community_Relations_Specialists/Audiences/DiscussionTools#Reply_tool:_new_test_wiki_playbook

Change 598120 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@wmf/1.35.0-wmf.32] filerepo: use makeGlobalKey() in ForiegnDBViaLBRepo::getSharedCacheKey()

Re c: or at least rename ext.cite.style.css to parsoid.ext.cite.styles.css (which we can do w/o or before merging the styles) to make this less confusing to review!

Can't merge anything in Translate repo.

Sure, will do.

@Tgr @RHo @Amire80 -- I just did some editing and verifying, and I think this is the situation:

The tool was historically useful to the editing communities of several wikis and it was even nominated for improvement in the 2015 Community Wishlist survey (T120767). I am not excited to see it die.

It looks good to me. Thank you! There have been 60 suggested edits so far.

Change 598118 merged by jenkins-bot:
[mediawiki/core@master] filerepo: use makeGlobalKey() in ForiegnDBViaLBRepo::getSharedCacheKey()

In T252258#6152098, @Esanders wrote:

Requirements

• AFAIK all there would be no real issues on any wikis with adding new content on talk pages in visual mode. Even group 7 wikis have VE as an opt-in feature.

Configurations

• These are things that can will become noticeable to the community after deployment. We should make them aware of these limitations and how to work around them.

I think there is nothing in the above that blocks us from deploying to any wiki.

Moving to PM review - no issues found.

This turned out to be a bit of a small rabbit hole.

Change 592751 abandoned by Umherirrender:
Set ignoreSpacingBeforeAssignments to false for OperatorSpacing

In T253405#6159451, @CDanis wrote:

AIUI, @aaron suspects that (newly-added?) WANObjectCache memcache key coalescing support might be at fault here.

Baseline measurements for 6.6.0

Change 597385 merged by jenkins-bot:
[mediawiki/extensions/BlogPage@master] Don't try to suppress categories

Mentioned in SAL (#wikimedia-cloud) [2020-05-22T21:21:59Z] <Jayprakash12345> Migrate wikifile-transfer to new toolforge URL (T253404)

Change 598118 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] filerepo: use makeGlobalKey() in ForiegnDBViaLBRepo::getSharedCacheKey()

I strongly support this RFC. It will serve not only to document best practices for the use of composer for MediaWiki extensions and skins, but will also replace T467 with a policy that better reflects the current recommended state of the practice. I'll repeat my comment from T249573 below for the record.

Change 598117 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] NamespaceInfo: Throw specifically if called on a non-int namespace

Change 598115 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Add mw.util.parseImageUrl

Baseline measurements for 6.6.0