Link preview offline error message is shown for missing pages that return a 404 HTTP status
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	• Niedzielski
	Mar 21 2017, 4:51 PM

Description

Steps to reproduce

Change the app language to Bislama (BI)
Go to the matematikis page
Tap the Lojik link in the second paragraph

Expected results

~~Link preview prompts the user to create the page~~
Link preview advises user that this page does not exist (since it is not currently possible to create a page within the Android app)

Actual results

Link preview says the device is offline

screenshot-2017-03-21-10-48-22-744198429.png (800×480 px, 38 KB)

Environments observed

App version: 49d4bb7
Android OS versions: API 25
Device model: AOSP Nexus S emulator
Device language: English

Details

Subject	Repo	Branch	Lines +/-
Fix: Update error handling to handle new cache responses	apps/android/wikipedia	master	+12 -8
Prevent navigating to page from link previews w/ errors (except offline)	apps/android/wikipedia	master	+4 -0
Show an accurate message in the link preview when a page doesn't exist	apps/android/wikipedia	master	+261 -75

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Feature	None	T40891 MediaWiki API 2.0 (tracking)
Resolved		Jdlrobson	T95741 API: Inconsistent response for empty collections
Resolved		• Mholloway	T161008 Link preview offline error message is shown for missing pages that return a 404 HTTP status
Resolved		None	T119266 Red links displayed as regular links when Restbase enabled.
Resolved		Arlolra	T39902 RFC: Implement rendering of redlinks in Parsoid HTML as post-processor
Resolved		Esanders	T64803 VisualEditor: Extract red link API code from VE and put into Parsoid
Resolved		Catrope	T39901 VisualEditor: Links are not shown as redlinks when their target is blank (or as 'stub-alternate-colour' if appropriate)
Declined		None	T101046 [EPIC] Use MCS as parser for main content in mobile web
Declined		None	T78734 Support for mobile's section use cases in Parsoid HTML
Resolved		ssastry	T114072 <section> tags for MediaWiki sections
Resolved		• bearND	T178705 Prepare MCS for Parsoid section tags
Resolved		• bearND	T178706 Improve section parsing in mobile-sections endpoint
Resolved		• bearND	T178707 Create script to compare old and new sectioning code
Resolved		• bearND	T178708 Update Wiktionary definition parsing to account for new (possibly nested) section tags
Open		None	T114194 MediaWiki should be able to support multiple parser engines
Resolved		• Jhernandez	T114279 Parsoid API responses contain unnecessary meta data bloating HTML response
Open		None	T78676 Store & load data-mw separately
Resolved		• marcoil	T88290 Update data-mw encoding for <ref> tags to point to the HTML content in the <references /> output rather than duplicating it
Resolved		Catrope	T88650 Support data-mw.body.id for reference contents
Resolved		• marcoil	T88660 Parsoid Cite: Render missing reflists
Resolved		Arlolra	T76518 Errors in Parsoid v2 entry point
Resolved		Arlolra	T54936 Move data-parsoid and possibly data-mw out of the DOM, add uids
Resolved		• GWicke	T50483 Expose a parsoid public web API end point in the MediaWiki API
Resolved		• GWicke	T89481 RESTBase beta release (revision storage / content API)
Resolved		• GWicke	T1228 RESTbase deployment
Resolved		fgiunchedi	T76986 RESTBase production hardware
Resolved		fgiunchedi	T88805 rack and setup restbase production cluster in eqiad
Resolved		• Cmjohnson	T83551 Split memcached in eqiad across multiple racks/rows
Resolved		• Cmjohnson	T82259 mc1016 mgmt not working
Resolved		Joe	T89345 Missing memcached logs
Resolved		fgiunchedi	T89639 restbase1006 faulty disk controller
Resolved		• GWicke	T75955 RESTBase / Parsoid integration - waiting for parsoid deploy
Resolved		• Jdouglas	T88456 On-demand generation of HTML and data-parsoid
Resolved		• GWicke	T88457 html2wt conversion support
Resolved		• GWicke	T88588 Formalize the RESTBase v1 specification
Resolved		Arlolra	T89411 Parsoid v2 API selser might not be working correctly
Resolved		• GWicke	T76370 RESTBase performance testing
Resolved		• mobrovac	T76165 Handle revision deletion and suppression in RESTBase
Resolved		• mobrovac	T87520 Set up update jobs for RESTBase: code done and deployed, to be configured
Resolved		• mobrovac	T88652 Integrate revisions into /page structure. Was: Create a /page/revision/{revision} entry point
Resolved		• mobrovac	T87392 Add property & index on namespace in page_revisions
Duplicate		• Jdouglas	T78214 Documentation location and deployment process
Resolved		Andrew	T88850 Import Cassandra packages for Jessie
Resolved		• GWicke	T89461 trebuchet puppet provider broken on systems without upstart
Resolved		fgiunchedi	T89636 setup internal LVS for restbase eqiad servers
Resolved		fgiunchedi	T78514 Detailed cassandra monitoring: metrics and dashboards done, need to set up alerts
Resolved		fgiunchedi	T93886 Cassandra/CQL query interface monitoring
Resolved		Eevans	T93884 graphs for Cassandra metrics
Resolved		fgiunchedi	T97024 some cassandra metrics sent with invalid values
Resolved		• GWicke	T78194 Public entry point for RESTBase
Resolved		• GWicke	T89567 Load test production cluster
Resolved		fgiunchedi	T89366 Access to restbase / cassandra cluster
Resolved		• mobrovac	T91102 Update / maintain Beta Cluster restbase cluster: Up & working with VE
Resolved		• GWicke	T91188 Need to change data model for >~300 wikis in single cassandra cluster
Resolved		• GWicke	T128231 All known clients of Parsoid HTML (either directly hitting Parsoid or via RESTBase) should provide Accept: headers in their requests
Resolved		• AlexMonk-WMF	T128233 VisualEditor: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365
Resolved		• santhosh	T128235 CX Server: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365
Resolved		ssastry	T128236 Flow: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365
Resolved		• Mholloway	T128237 Mobile Content Service: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365
Resolved		Jackmcbarn	T128238 EPH Gadget: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365
Resolved		Renxiaoyi	T128239 Google: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365
Resolved		cscott	T130685 OCG: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365
Resolved		Kelson	T130686 Kiwix: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365
Open		None	T114413 Support various conversions in Parsoid's pb2pb endpoint
Open		None	T130639 All known clients of Parsoid HTML that require data-mw should fetch data-mw separately (if using RESTBase) or process the data-mw blob in Parsoid's pagebundle API response (if using Parsoid directly)
Open		None	T88623 On Parsoid HTML read pages, VisualEditor should be able to load data-mw from a separate API call and zip it into the DOM
Resolved		Arlolra	T130638 Add data-mw as a separate JSON blob in the pagebundle output of Parsoid's API
Resolved		Arlolra	T91700 Store and unpack data-* attributes when serializing/parsing document fragments throughout the pipeline
Open		None	T130643 Content Translation should load data-mw from a separate API call alongside the body content
Declined		None	T130687 OCG should load data-mw from a separate API call alongside the body content
Open		None	T130689 Google's services should load data-mw from a separate API call to RESTBase
Open		None	T124837 Update Flow for Parsoid changes re data-mw
Declined		None	T125885 Switch Flow storage to store a page bundle blob instead of HTML
Declined		None	T125886 Run migration script (HTML => wikitext => page bundle) in production
Declined		None	T125888 Write migration script (HTML => wikitext => page bundle) in production
Open		None	T125889 Update code (extractors, converters) that uses data-mw to deal with separate components
Open		None	T125890 Figure out how to get page bundle from Flow VE
Invalid		None	T194980 Triage
Invalid		None	T130641 Allocate a storage bucket for Parsoid's data-mw attribute
Duplicate		None	T114282 Red links via Parsoid
Duplicate		None	T114286 Resolving styling inconsistencies between HTML returned by Parsoid and HTML returned by PHP parser
Resolved		• Jhernandez	T113769 Spike: Scope the first version of JavaScript-based prototype on existing Parsoid service
Resolved		Jdlrobson	T113649 Demonstrate impact of loading just lead sections of a group of static pages
Duplicate		Peter	T114216 Support CSV output from the WPT wrapper script
Resolved		• bmansurov	T115073 [6 hours] Test a subset of pages with only a lead section [take 2]
Declined		None	T145219 [EPIC] Cleanup MobileFormatter and MobileViewAPI where they overlap
Duplicate		None	T109461 [EPIC]: Improvements to mobileview API
Resolved		• nray	T86210 MobileFrontend throws away warnings and other data from action=parse
Resolved		phuedx	T69054 API mobileview "protection" sometimes returns object, sometimes returns empty array in JSON output
Resolved		Anomie	T12887 API JSON formatter returns [] as an empty return value - inconsistent with {} for non-empty values
Resolved		Anomie	T76728 Clean up ApiResult and ApiFormatXml, create new formatversion
Resolved		Anomie	T85236 Better unit testing for ApiFormat*
Resolved		EBernhardson	T90745 Flow ApiFlowModerateTopicTest::testModerateTopic() assumes ApiResult will pass through arbitrary objects
Resolved		Anomie	T98083 add checkbox to ApiSandbox to use formatversion=2
Resolved		Anomie	T98086 improve RELEASE-NOTES-1.25 for formatversion=2 change
Open		None	T212069 API action=wbgetentities does not handle formatversion=2
Duplicate		None	T78479 API error messages should be localised
Resolved		None	T98528 mobileview "thumbwidth" parameter doesn't always result in return of desired image url for SVG files
Resolved		phuedx	T156408 Create interface between Skin and MobileFormatter
Declined		None	T146396 Improve performance of mobile references API
Resolved		• Pchelolo	T133221 Support red links updates in change-propagation
Resolved		Arlolra	T169975 Missing images render as broken img tags, not redlinks
Resolved		• Mholloway	T161415 Prevent saving nonexistent pages to a reading list
Open	Feature	None	T155192 Improve handling of nonexistent pages in Android app

Event Timeline

• Niedzielski created this task.Mar 21 2017, 4:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 21 2017, 4:51 PM

• NHarateh_WMF moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.Mar 22 2017, 4:21 PM

• NHarateh_WMF edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴); removed Wikipedia-Android-App-Backlog.

@RHo/@Dbrant, I should have asked yesterday during grooming and triage, but does this need design? Will a generic exclamation point icon and an appropriate message suffice?

RHo updated the task description. (Show Details)Mar 23 2017, 4:23 PM

Looking at this in more detail (/with more attention) it seems the root cause is that this is a dead link but not being shown as a red link, as is already captured on task T119266.

Per that ticket, suggest the following preference for resolution:
1. Red links for dead links – It's been a while since T119266 so not sure if the RestBase issue has been resolved but this seems ideal, so that users have a greater visual hint that the page does not exist (per existing style on web). If the user taps on that red link, a link preview appears with a message advising 'This page does not exist' after the exclamation error icon.
2. Hide dead links – this was the interim solution proposed in T119266.
3. Just show the message from preference 1 without the dead link shown in red.

RHo added a subtask: T119266: Red links displayed as regular links when Restbase enabled..Mar 23 2017, 4:35 PM

RHo added a subtask: T155192: Improve handling of nonexistent pages in Android app.Mar 23 2017, 4:38 PM

RHo updated the task description. (Show Details)

T119266 remains unresolved. Yesterday I updated an old content service patch I'd made to address it. The older version(s) of the patch (last updated a little over a year ago) caused problems when deployed to production, and so had to be reverted, but I'm hopeful that the new version will fare better if merged.

The new patch just marks links to missing pages rather than actually stripping them out of the HTML served to the app, as the old one did. This approach matches what happens in HTML served by the MediaWiki API and allows clients to choose how to deal with the missing links, so we could either show them in red, or continue removing them on the client side as we currently do with mobileview HTML.

Actually, T119266 is a downstream issue and my MCS patch is really just a workaround. T39902: RFC: Implement rendering of redlinks in Parsoid HTML as post-processor is the fundamental task that needs resolving for this.

If we update to show red links, we should do it for both HTML sources. @Dbrant, what's your opinion on this? Cross-platform consistency is appealing, but on the other hand, the point of red links is to invite users to create the pages linked, and if the app doesn't provide that capability, then there's little point in giving the user a link to click on at all.

• Mholloway claimed this task.Mar 24 2017, 4:36 PM

• Mholloway moved this task from To Do to Doing on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.

Agreed that the app should not show red links at all, since it doesn't lead to any actionable experience.

Change 344687 had a related patch set uploaded (by Mholloway):
[apps/android/wikipedia@master] Show an accurate message in the link preview when a page doesn't exist

https://gerrit.wikimedia.org/r/344687

gerritbot added a project: Patch-For-Review.Mar 24 2017, 8:47 PM

• Mholloway moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Mar 24 2017, 9:13 PM

Do we want to disable navigating to the article from the link preview when offline?

Yes, since this would just link to an error does not exist page anyway.

In T161008#3135138, @RHo wrote:

Yes, since this would just link to an error does not exist page anyway.

Does this hold when the user's truly offline (and would get an accurate offline message from the link preview and page error views) as well?

Change 344687 merged by jenkins-bot:
[apps/android/wikipedia@master] Show an accurate message in the link preview when a page doesn't exist

https://gerrit.wikimedia.org/r/344687

Change 346781 had a related patch set uploaded (by Mholloway):
[apps/android/wikipedia@master] Prevent navigating to page from link previews w/ errors (except offline)

https://gerrit.wikimedia.org/r/346781

Change 346781 merged by jenkins-bot:
[apps/android/wikipedia@master] Prevent navigating to page from link previews w/ errors (except offline)

https://gerrit.wikimedia.org/r/346781

• Mholloway moved this task from Code Review to Blocked/Waiting on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Apr 7 2017, 7:07 PM

• Mholloway moved this task from Blocked/Waiting to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Apr 10 2017, 2:18 PM

Hi @Mholloway – just want to clarify that expected when a user encounters a non-existent page link in an article (ie., what shows up as a red link on Web):

A. User is online and taps on a link to a non-existent page

EXPECTED:
Link preview card/Page opens with a error icon and a message that 'This page does not exist'.
ACTUAL:
Only a generic 'An error occurred' message is shown.

main-MainActivity-04172017181544.png (1×1 px, 171 KB)

main-MainActivity-04172017181720.png (1×1 px, 79 KB)

B. User is offline and taps on a link to a non-existent page

At the moment since there is no way to hide links to non-existent page...
EXPECTED
The standard 'article cannot be loaded' message will appear, and allows the user to save the non-existent page to a reading list.
ACTUAL
As expected.

main-MainActivity-04172017181658.png (1×1 px, 341 KB)

main-MainActivity-04172017181645.png (1×1 px, 173 KB)

TESTED ON

Device = Nexus 5 (Android 6.0.1)
Version = 2.5.192-alpha-2017-04-12)

Change 348866 had a related patch set uploaded (by Mholloway):
[apps/android/wikipedia@master] Fix: Update error handling to handle new cache responses

https://gerrit.wikimedia.org/r/348866

• Mholloway moved this task from Design Signoff to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Apr 18 2017, 10:35 PM

Change 348866 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Update error handling to handle new cache responses

https://gerrit.wikimedia.org/r/348866

• Mholloway moved this task from Code Review to QA Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.Apr 20 2017, 4:07 PM

Tested on Nexus 4 Android 5.1 and Pixel Android 7.1.1 both running 2.5.195-alpha-2017-04-24

Appears to be fixed. Tested online and offline.

Dbrant moved this task from Ready for Signoff to Done on the Wikipedia-Android-App-Backlog (Android-app-release-v2.6.19x-Bermuda🌴) board.May 1 2017, 3:24 PM

Dbrant closed this task as Resolved.May 1 2017, 3:25 PM

• Mholloway closed subtask T119266: Red links displayed as regular links when Restbase enabled. as Resolved.Jul 6 2017, 7:26 PM

	F7595158: main-MainActivity-04172017181544.png
	Apr 17 2017, 4:21 PM

	F7595167: main-MainActivity-04172017181658.png
	Apr 17 2017, 4:21 PM

	F7595164: main-MainActivity-04172017181645.png
	Apr 17 2017, 4:21 PM

	F7595161: main-MainActivity-04172017181720.png
	Apr 17 2017, 4:21 PM

	F6822155: screenshot-2017-03-21-10-48-22-744198429.png
	Mar 21 2017, 4:51 PM

Link preview offline error message is shown for missing pages that return a 404 HTTP statusClosed, ResolvedPublic1 Estimated Story PointsActions