@KartikMistry how can I know when this is going to be deployed?
the tag on the tag (wmf11) doesn't have the latest code
Feed All Stories
Jan 14 2020
Jan 14 2020
• Jpita moved T242350: Empty state for Search and Article Change language page from QA to Product sign off on the Inuka-Team (Kanban) board.
• Jpita updated subscribers of T237607: Invite for translation when creating a new article not showing for new users.
Mpaa added a comment to T241413: A lot of wikisource urls are redirected to the "mul" site.
To understand the wanted behaviour, what is the wanted Site for a redirected 'code'?
Site('aa', 'wikisource') = ?
E.g. APISite("mul", "wikisource")?
leila added a comment to T235309: Assess the possibility of data release from a public health related research conducted by WMF and formal collaborators.
@JFishback_WMF thank you very much for your thorough analysis.
MMiller_WMF updated the task description for T242418: Newcomer tasks: add article counter to footer of start editing dialog.
MMiller_WMF added a comment to T242418: Newcomer tasks: add article counter to footer of start editing dialog.
@kostajh -- thanks for these questions. My answers are below and also added to the task description:
sbassett moved T227454: Allow $wgSFSIPListLocation to be a url and have proxy support from Backlog to In Progress on the user-sbassett board.
sbassett added a project to T227454: Allow $wgSFSIPListLocation to be a url and have proxy support: user-sbassett.
MusikAnimal added a comment to T242760: Move WSExport to VPS.
I nearly finished this before noticing there's INI file that had the memory limit set to 256MB. I've increased this to 512. Let's see if that helps first.
README: pedantic wording change
mforns added a comment to T241375: The guava error still persists in data quality bundles.
Maven tree shows 4 different versions of guava:
- 11.0.2 Used by json-schema-core.jackson-coreutils and CDH5.hadoop-common
- 12.0 Used by reflection
- 16.0.1 Used by hadoop-common.hadoop-auth.apache-curator and uri-template
- 18.0 Specified in refinery-core's pom.xml
From all those versions, the only one that does not have the method com.google.common.base.Stopwatch.<init>() implemented is 18.0.
If I understand it correctly, the version compiled and included in the jar is 18.0 ([INFO] +- com.google.guava:guava:jar:18.0:compile).
MMiller_WMF added a comment to T238611: Newcomer tasks: topic filter button.
This passes my substitute design review, and I'll leave it in this column for @RHo.
Dzahn added projects to T242805: Access to view #WMF-NDA tasks on Phabricator for jwang: SRE, Phabricator.
MMiller_WMF renamed T242744: Newcomer tasks: adjust alignment of button labels from Adjust alignment of button labels to Newcomer tasks: adjust alignment of button labels.
Dzahn added a comment to T240882: (Need by: TBD) rack/setup/install logstash202[6-9].codfw.wmnet.
ready for OS install
• JHedden closed T240871: CloudVPS: nova messing with instance disks, a subtask of T240851: CloudVPS: stretch base images fails to boot, as Resolved.
Cleaned up all the stale entries with virsh undefine <domain id>
cmadeo added a comment to T240888: Better article loading experience.
@hueitan I'm not sure what ticket these would belong on but here are the loading states you requested:
| Loading language list | Loading page preview |
|---|---|
 |  |
| https://zpl.io/aR7rkzvn | https://zpl.io/VQ7m3Qm |
DannyS712 added a comment to T241683: Remove "Create a book" link from sidebar on English Wikipedia.
libraryupgrader <tools.libraryupgrader@tools.wmflabs.org> committed rEGRA22b46b2b4296: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0.
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Multichill added a comment to T239474: [M] Units support for quantity datatype.
@matthiasmullie what am I doing wrong at /w/api.php?action=wbeditentity&format=json&id=M51867633&token=123445678903dd2%2B%5C&data=%7B%22claims%22%3A%5B%7B%22mainsnak%22%3A%7B%22snaktype%22%3A%22value%22%2C%22property%22%3A%22P7787%22%2C%22datavalue%22%3A%7B%22value%22%3A%20%7B%22amount%22%20%3A%20%22%2B67%22%2C%20%22unit%22%20%3A%20%22http%3A%2F%2Fwww.wikidata.org%2Fentity%2FQ28390%22%7D%2C%22type%22%3A%22quantity%22%7D%7D%2C%22type%22%3A%22statement%22%2C%22rank%22%3A%22normal%22%7D%5D%7D ?
cmadeo added a comment to T236301: Article footer and read more.
@hueitan would it be possible to have the legal footer presented as a separate section at the bottom of each article (eg not attached to any other section) but also hide it in the TOC, then it would either appear under the Suggested articles or after the References section if there are no Suggested articles? It might be helpful to connect with someone on the apps teams to know more about how this is handled.
Anomie removed a project from T34675: API: Allow listing of logevents per pageid: Platform Engineering.
Etonkovidova added a comment to T238612: Newcomer tasks: topic filters.
The only exception is that whereas the intro overlay updated the article count based on the default difficulty level settings for user initiating suggested edits, this filter dialog should update the article count based on whichever task types the user has selected at the time they are interacting with the filter.
As I'm looking at this, cognitively, I find it weird that the counter shows 200 articles even when all topics are deselected. The 200 count is correct because it queries by the task types I have selected, but we might want to think about hiding the article counter until the user selects some topics.
Anomie removed a project from T21195: Make user IDs more readily available with the API: Platform Engineering.
Anomie removed a project from T154774: Add userid versions of `rvuser` and `rvexcludeuser`: Platform Engineering.
Anomie moved T21195: Make user IDs more readily available with the API from Needs Code to Needs Review on the MediaWiki-Action-API board.
Restricted Application added a project to T34675: API: Allow listing of logevents per pageid: Platform Engineering.
The userid part is being done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/434718.
Anomie added a comment to T69203: Inconsistent behavior of User::isIP between IPv4 and IPv6 ranges.
Merging into T239527. Even though this is older, that has much more discussion.
Anomie renamed T239527: Inconsistent behavior of User::isIP between IPv4 and IPv6 ranges from list=blocks does not support IPv4 ranges to Inconsistent behavior of User::isIP between IPv4 and IPv6 ranges.
Anomie added a comment to T239527: Inconsistent behavior of User::isIP between IPv4 and IPv6 ranges.
jgleeson moved T242275: Add recurring parameters to send to hosted checkout page from Doing to Review on the Fundraising Sprint Autocorrect Astrology Ascendant board.
Jan 14 2020, 10:20 PM · Fundraising Sprint Evil Twins For Everyone, Fundraising Sprint Dampness, Fundraising Sprint CAPS LOCK CULTS, Fundraising-Backlog, FR-Adyen, Recurring-Donations, Fundraising Sprint Autocorrect Astrology Ascendant, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Fundraising Sprint Byzantine Empire Strikes Back
Peter.ovchyn added a comment to T226833: Introduce LanguageConverterFactory service.
- I left mutual dependency for now as I have to make sure about the goal. Therefore LanguageConverterFactory::createFromCode
has got weird signature:
valhallasw added a comment to T242802: RTB errors with "Fatal Python error: Py_Initialize: Unable to get the locale encoding".
Sorry, that's an old venv that should be removed.
SNowick_WMF closed T242794: Request for iOS app Editing data for the quarterly review deck. as Resolved.
Quiddity added a comment to T242772: Remove $wgVectorResponsive from legacy mode.
I believe this configuration is used in 3rd party wikis. Perhaps Izno can provide specific examples or further details?
Aklapper awarded T230729: Evaluate Cypress as a WebdriverIO replacement for our browser automation framework a Orange Medal token.
jgleeson added a comment to T242673: Update QueueConsumer to handle recurring adyen tokens.
Yep, it looks like there's no changes needed to the queue consumer side of things which is great! I tested with a new Adyen recurring donation and it was saved to CiviCRM as expected with entries in the associated civicrm.civicrm_contribution_recur and civicrm.civicrm_payment_token tables.
Jdforrester-WMF updated subscribers of T242802: RTB errors with "Fatal Python error: Py_Initialize: Unable to get the locale encoding".
Sorry @valhallasw to leave this part-done. Logging into Phab gets me into @Forrestbot and not @ReleaseTaggerBot, too. :-(
mforns added a project to T241375: The guava error still persists in data quality bundles: Analytics-Kanban.
Jdforrester-WMF closed T204909: Reduce length of Phabricator milestone names for wmf-branches as Resolved.
I'm declaring this Good Enough™.
MBeat33 updated the task description for T242801: Civi: EoY recurring summary email - exclude canceled recurrings w/only 1 donation (audit file?).
kaldari added a comment to T234192: Automatic upload comments by Upload Wizard are unhelpful, make them more informative.
If it makes any difference, I endorse this change (as one of the original authors of UploadWizard). Note that no one really owns UploadWizard currently (as we don't actually have a multimedia team at the moment), so it's basically just in maintenance mode, i.e. bug fixes. If you want to get a feature change like this done, you'll either need to convince one of the people who is familiar with the extension to work on this in their spare time or have a volunteer developer work on it. I imagine the WMF will re-convene a multimedia team at some point, so worst case scenario would be to wait until then.
jwang updated the task description for T242496: Onboarding Checklist for Jennifer Wang.
• brion added a comment to T228339: VideoJS needs to be lazy-loaded on click before we can release it by default.
Latest rev of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/TimedMediaHandler/+/553442 includes a quick-fix for that: an inline transform property is added which adds the playsinline attribute and a mw-tmh-inline class which has the on-load transforms set up video.js for that player instead of turning it into a popup player trigger. This is then forced on for the embedded-iframe view.
Framawiki added a comment to T242355: Trivial Quarry XSS: Tabular data CSV / TSV are not escaped and sent as text/html.
I don't think too that it's used by someone else, and code was not designated to such usage. Thus I don't think that there is a need to request cve.
matmarex added a comment to T239550: Copying multiple categories from the bottom of Wikipedia articles and pasting them into source editor (while logged in) breaks all pasting until you switch editors.
Actual results:
Nothing is pasted, and pasting is now broken. You can copy anything at all and it won't be able to be pasted into that source editor.
You can fix this by switching to visual editor and switching back again.
Naseweis520 awarded T242797: Universally allowed qualifiers a Like token.
Milimetric moved T236757: Upgrade service-runner on AQS to unblock rsyslog logging from Ready to Deploy to Done on the Analytics-Kanban board.
SNowick_WMF updated the task description for T242794: Request for iOS app Editing data for the quarterly review deck. .
SNowick_WMF added a comment to T242794: Request for iOS app Editing data for the quarterly review deck. .
[Resolved] Essentially, looking to see if the release of the new History feature had any impact on editing numbers, (shows editor history of article)
did anyone use the feature? No way to correlate if History gave lift to editing as it's not a flow/funnel to edit.
Arlolra added a comment to T239642: We need to run tests on the PHP code in the deploy repo.
diff --git a/composer.json b/composer.json index 3faae9a20..df6195d45 100644 --- a/composer.json +++ b/composer.json @@ -29,6 +29,7 @@ "wikimedia/scoped-callback": "3.0.0", "wikimedia/wikipeg": "2.0.3", "wikimedia/zest-css": "1.1.2", + "monolog/monolog": "~1.25.2", "ext-dom": "*", "ext-json": "*" }, @@ -36,7 +37,6 @@ "jakub-onderka/php-parallel-lint": "1.0.0", "jakub-onderka/php-console-highlighter": "0.4.0", "jakub-onderka/php-console-color": "0.2", - "monolog/monolog": "~1.25.2", "mediawiki/mediawiki-codesniffer": "28.0.0", "mediawiki/mediawiki-phan-config": "0.9.0", "mediawiki/minus-x": "0.3.2", @@ -49,14 +49,14 @@ }, "autoload": { "psr-4": { - "Parsoid\\": ["src/placeholder", "src"] + "Parsoid\\": ["src/placeholder", "src"], + "Parsoid\\Tools\\": "tools/", + "Parsoid\\Tests\\": "tests/mocks/" } }, "autoload-dev": { "psr-4": { - "Parsoid\\Tests\\": "tests/mocks/", "Parsoid\\Tests\\ParserTests\\": "tests/ParserTests", - "Parsoid\\Tools\\": "tools/", "Test\\": "tests/phpunit/" } },
SNowick_WMF updated the task description for T242794: Request for iOS app Editing data for the quarterly review deck. .
• JFishback_WMF added a comment to T235309: Assess the possibility of data release from a public health related research conducted by WMF and formal collaborators.
I completed the Privacy Risk Assessment with the following results:
OK, this is now done. Delete away!
Aklapper added a comment to T242785: Allow a user to be blocked from sending thanks.
thiemowmde committed rEMEM3db45303683c: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 29.0.0
Sistemx added a comment to T241683: Remove "Create a book" link from sidebar on English Wikipedia.
Noooooo, I'll miss this :(
Jdforrester-WMF added a project to T242782: Stop running Parsoid-JS tests in CI: Continuous-Integration-Config.
Papaul updated the task description for T242265: rack/setup/install frlog2001.frack.codfw.wmnet.
Papaul added a comment to T242265: rack/setup/install frlog2001.frack.codfw.wmnet.
papaul@fasw-c-codfw# show | compare
[edit interfaces interface-range disabled]
- member ge-0/0/21;
- member ge-1/0/21;
[edit interfaces interface-range vlan-administration]
member "ge-[0-1]/0/16" { ... }
+ member "ge-[0-1]/0/21";
[edit interfaces]
+ ge-0/0/21 {
+ description frlog2001:eth0;
+ }
+ ge-1/0/21 {
+ description frlog2001:eth1;
+ }papaul@fasw-c-codfw# run show interfaces ge-[0-1]/0/21 descriptions Interface Admin Link Description ge-0/0/21 up up frlog2001:eth0 ge-1/0/21 up up frlog2001:eth1
MusikAnimal renamed T242793: Add support for private wikis to pageviews API from Add support for private wikis to Pageviews to Add support for private wikis to pageviews API.
gerritbot added a comment to T242782: Stop running Parsoid-JS tests in CI.
Change 564790 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[integration/config@master] layout: [parsoid and parsoid/deploy] Stop running JS tests
Ejegg moved T242161: decide where the recurring logic is going to live from Review to Deployed on the Fundraising Sprint Autocorrect Astrology Ascendant board.
MusikAnimal added projects to T242793: Add support for private wikis to pageviews API: Analytics, Pageviews-API.
I was thinking this wouldn't be for Tool-Pageviews, not just because it's private data, but also because that tool is hard-wired to use the public APIs, as opposed to fetching data through some other connection.
Etonkovidova moved T238611: Newcomer tasks: topic filter button from QA to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Re-checked in regards of recent patches - ready for Design Review.